Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* Re: i386.record.floating.point.patch : with more testing and assurity
@ 2009-07-03 18:55 paawan oza
  2009-07-03 21:52 ` Michael Snyder
  0 siblings, 1 reply; 40+ messages in thread
From: paawan oza @ 2009-07-03 18:55 UTC (permalink / raw)
  To: Mark Kettenis; +Cc: pedro, msnyder, teawater, gdb-patches


Hi,

In My understanding the point was like below.
in the patch there were following register extended in enumeration in 
i386-tdep.h

I386_FSTAT,
I386_FTAG,       
I386_FISEG,
I386_FIOFF,
I386_FOSEG,
I386_FOOFF,
I386_FOP


According to Hui in some of his previous mails...his idea was
> FCTRL, FOP and so on are the fp reg of amd64.  For now, prec is still
> not support amd64 And amd64's support are in amd64-tedp.... files.  >Change i386_regnum is not a good idea. I suggest you divide fp patch to 2 >parts. One is for i386, the other for amd64. For now, just send i386 patch >for review.  And send amd64 patch when prec support amd64"


while, my idea/understanding is:
FCTRL, FOP registers are not only a part of amd64, but also part of i386 (x87 FPU unit) also.
so according to me these registers are part of i386 also and it needed to be also in i386-tdep.h.

Regards,
Oza.





--- On Wed, 7/1/09, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:

> From: Mark Kettenis <mark.kettenis@xs4all.nl>
> Subject: Re: i386.record.floating.point.patch : with more testing and assurity
> To: paawan1982@yahoo.com
> Cc: pedro@codesourcery.com, msnyder@vmware.com, teawater@gmail.com, gdb-patches@sourceware.org
> Date: Wednesday, July 1, 2009, 9:42 PM
> > Date: Wed, 1 Jul 2009 09:02:17
> -0700 (PDT)
> > From: paawan oza <paawan1982@yahoo.com>
> > 
> > Can somebody please help with this open point ?
> 
> Sorry, I don't understand what point.
> 
> > --- On Wed, 7/1/09, paawan oza <paawan1982@yahoo.com>
> wrote:
> > 
> > > From: paawan oza <paawan1982@yahoo.com>
> > > Subject: Re: i386.record.floating.point.patch :
> with more testing and assurity
> > > To: "Pedro Alves" <pedro@codesourcery.com>,
> "Mark Kettenis" <mark.kettenis@xs4all.nl>,
> "Michael Snyder" <msnyder@vmware.com>,
> "Hui Zhu" <teawater@gmail.com>
> > > Cc: gdb-patches@sourceware.org
> > > Date: Wednesday, July 1, 2009, 9:30 PM
> > > Hi Hui,
> > > 
> > > As I clarified earlier, 
> > > these registers are already supported and
> extended by gdb
> > > much before this patch.
> > > all floating point registers are already
> supported by gdb 
> > > (info floats/info all-registers command gives
> it)
> > > 
> > > My aim is : only to make sure that whenever any
> floating
> > > point insn gets executed, we record the registers
> 
> > > (no matter whether it is %st(n) or FCTRL or FTAG
> or
> > > FSTATUS)
> > > there are insns
> > > e.g. 'ffree' changes FTAG register, so we must
> record it.
> > > 
> > > Do you mean to say that we should remove it from
> just
> > > enumaration ?
> > > but anyway we need to record those registers.
> > > 
> > > Regards,
> > > Oza.
> > > 
> > > --- On Wed, 7/1/09, Hui Zhu <teawater@gmail.com>
> > > wrote:
> > > 
> > > > From: Hui Zhu <teawater@gmail.com>
> > > > Subject: Re:
> i386.record.floating.point.patch : with
> > > more testing and assurity
> > > > To: "paawan oza" <paawan1982@yahoo.com>,
> > > "Pedro Alves" <pedro@codesourcery.com>,
> > > "Mark Kettenis" <mark.kettenis@xs4all.nl>,
> > > "Michael Snyder" <msnyder@vmware.com>
> > > > Cc: gdb-patches@sourceware.org
> > > > Date: Wednesday, July 1, 2009, 11:23 AM
> > > > About this patch, I say my idea
> > > > again, I told in
> > > > http://sourceware.org/ml/gdb-patches/2009-06/msg00014.html
> > > > @@ -145,7 +145,22 @@
> > > >    I386_ES_REGNUM,   
> > > >     /* %es */
> > > >    I386_FS_REGNUM,   
> > > >     /* %fs */
> > > >    I386_GS_REGNUM,   
> > > >     /* %gs */
> > > > -  I386_ST0_REGNUM   
> > > >     /* %st(0) */
> > > > +  I386_ST0_REGNUM,   
> > > >     /* %st(0) */
> > > > +  I386_ST1_REGNUM,   
> > > >     /* %st(1) */
> > > > +  I386_ST2_REGNUM,   
> > > >     /* %st(2) */
> > > > +  I386_ST3_REGNUM,   
> > > >     /* %st(3) */
> > > > +  I386_ST4_REGNUM,   
> > > >     /* %st(4) */
> > > > +  I386_ST5_REGNUM,   
> > > >     /* %st(5) */
> > > > +  I386_ST6_REGNUM,   
> > > >     /* %st(6) */
> > > > +  I386_ST7_REGNUM,   
> > > >     /* %st(7) */
> > > > +  I386_FCTRL,       
> > > >     /* floating point env regs :
> FCTRL-FOP
> > > > */    
> > > > +  I386_FSTAT,
> > > > +  I386_FTAG,       
> > > >     
> > > > +  I386_FISEG,
> > > > +  I386_FIOFF,
> > > > +  I386_FOSEG,
> > > > +  I386_FOOFF,
> > > > +  I386_FOP
> > > >  };
> > > > 
> > > > You are working on make prec x86 support fp
> insn, not
> > > to
> > > > extend the fp
> > > > function of i386 (If you want, you can make
> a special
> > > patch
> > > > for it).
> > > > 
> > > > Hui
> > > > 
> > > > On Tue, Jun 30, 2009 at 23:05, paawan
> oza<paawan1982@yahoo.com>
> > > > wrote:
> > > > >
> > > > > Hi,
> > > > > As I am submitting the patch for the
> first time,
> > > I am
> > > > not much aware of gdb test suite.
> > > > > would you please guide me about how I
> can put
> > > the
> > > > things in the testsuite ?
> > > > > is it the testsuite which comes along
> with the
> > > gdb
> > > > source ?
> > > > > gdb\testsuite\gdb.base ??
> > > > > Regards,
> > > > > Oza.
> > > > >
> > > > > --- On Tue, 6/30/09, Pedro Alves <pedro@codesourcery.com>
> > > > wrote:
> > > > >
> > > > >> From: Pedro Alves <pedro@codesourcery.com>
> > > > >> Subject: Re:
> i386.record.floating.point.patch
> > > :
> > > > with more testing and assurity
> > > > >> To: gdb-patches@sourceware.org
> > > > >> Cc: "paawan oza" <paawan1982@yahoo.com>,
> > > > teawater@gmail.com
> > > > >> Date: Tuesday, June 30, 2009, 7:09
> PM
> > > > >> On Tuesday 30 June 2009 14:23:30,
> > > > >> paawan oza wrote:
> > > > >> >
> > > > >> > > As suggested by Hui,
> > > > >> > > I have come up with more
> detailed
> > > and
> > > > granular
> > > > >> test case
> > > > >> > > for the patch which I had
> submitted
> > > last
> > > > week.
> > > > >>
> > > > >> Could you please consider migrating
> that test
> > > into
> > > > the
> > > > >> testsuite?
> > > > >> You've gone through the trouble of
> writing
> > > tests
> > > > to make
> > > > >> sure
> > > > >> the features work now --- putting
> it in the
> > > > testsuite means
> > > > >> we
> > > > >> have an automatic-ish means to
> check that it
> > > > doesn't get
> > > > >> inadvertently broken in the
> future.  The way
> > > it
> > > > is,
> > > > >> when your
> > > > >> code gets in, the test will
> probably end up
> > > lost
> > > > in the
> > > > >> archives.
> > > > >> We wouldn't want that, would we? 
> :-) 
> > > Having
> > > > >> auto-tests, also helps
> > > > >> the person doing the review in
> confirming
> > > things
> > > > work as
> > > > >> expected (without much effort).
> > > > >>
> > > > >> --
> > > > >> Pedro Alves
> > > > >>
> > > > >
> > > > >
> > > > >
> > > > >
> > > > 
> > > 
> > > 
> > > 
> > > 
> > 
> > 
> >       
> > 
> 




^ permalink raw reply	[flat|nested] 40+ messages in thread
[parent not found: <992589.56162.qm@web112513.mail.gq1.yahoo.com>]
* Re: i386.record.floating.point.patch : with more testing and assurity
@ 2009-07-26 14:27 paawan oza
  2009-07-26 22:51 ` Michael Snyder
                   ` (2 more replies)
  0 siblings, 3 replies; 40+ messages in thread
From: paawan oza @ 2009-07-26 14:27 UTC (permalink / raw)
  To: Michael Snyder; +Cc: Hui Zhu, Mark Kettenis, pedro, gdb-patches

[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]

Hi All,

I have worked on formatting part of the patch as per Michael and Hui's comments.


there is one problem I have been observing.
when I edit with emac and make everything correct....
still the command 'diff -bwEurN' gives some unaligned formatting at some lines.

but now things are much improved as far as far as formatting is concerned.

please find the files attached.

1) i386-tdep.c : this looks perfectly okay as per comments and formatting as per open source standard.
2) i386-tdep.orig.c : original file.
3) patch : when you edit this patch it has still some formatting problem
, but when you apply on linux, the resulting file looks okay.

please extract the attached package, you will find above contents

when I take the patch on windows and try to mail,
again format changes....and I have no clue (I tried to remove tabs, dos2unix etc....)
but still it is the same....

please help. 
(please try take difference with attached files and see the 'diff' result, it is strange, if you take the patch on windows it gets even more worse with formatting)

please let me know where and how can I take the difference between new and original file (attached with mail)....

Regards,
Oza.


      

[-- Attachment #2: package.rar --]
[-- Type: application/octet-stream, Size: 60747 bytes --]

^ permalink raw reply	[flat|nested] 40+ messages in thread
* Re: i386.record.floating.point.patch : with more testing and assurity
@ 2009-07-06 19:09 paawan oza
  0 siblings, 0 replies; 40+ messages in thread
From: paawan oza @ 2009-07-06 19:09 UTC (permalink / raw)
  To: Hui Zhu; +Cc: Michael Snyder, Mark Kettenis, pedro, gdb-patches


Hi,

I am not sure why the text looks little unformatted in the mail. 
(but it is not)
but when I copy the patch and patch it on Linux, the code looks perfectly formatted.

Regards,
Oza.

--- On Tue, 7/7/09, paawan oza <paawan1982@yahoo.com> wrote:

> From: paawan oza <paawan1982@yahoo.com>
> Subject: Re: i386.record.floating.point.patch : with more testing and assurity
> To: "Hui Zhu" <teawater@gmail.com>
> Cc: "Michael Snyder" <msnyder@vmware.com>, "Mark Kettenis" <mark.kettenis@xs4all.nl>, "pedro@codesourcery.com" <pedro@codesourcery.com>, "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> Date: Tuesday, July 7, 2009, 12:34 AM
> Hi,
> 
> please find the latest patch and ChangeLog as follows.
> 
> ********************
> ChangeLog
> ********************
> Current: gdb-6.8.50.20090706
> 2009-07-06  Oza  <paawan1982@yahoo.com>
> 
>         * i386-tdep.c: Support for
> floating point recording.
> 
> 
> ***************************
> i386.records.floats.patch
> ***************************
> 
> 
> diff -urN ./gdb.orig/i386-tdep.c gdb.new/i386-tdep.c
> --- ./gdb.orig/i386-tdep.c    2009-07-02
> 13:25:54.000000000 -0400
> +++ gdb.new/i386-tdep.c    2009-07-06
> 23:44:07.000000000 -0400
> @@ -3056,6 +3056,66 @@
>    return 0;
>  }
>  
> +
> +/* Defines contents to record.  */
> +#define I386_SAVE_FPU_REGS       
>       0xfffd
> +#define I386_SAVE_FPU_ENV       
>        0xfffe
> +#define I386_SAVE_FPU_ENV_REG_STACK 
>    0xffff
> +
> +/* Record the value of floating point registers which will
> be changed by the
> +   Current instruction to
> "record_arch_list".  
> +   Return -1 if something is wrong. 
> */  
> +
> +static int i386_record_floats(struct gdbarch *gdbarch, 
> +               
>               struct
> i386_record_s *ir, 
> +               
>               uint32_t
> iregnum)
> +{
> +  struct gdbarch_tdep *tdep = gdbarch_tdep
> (gdbarch);
> +  int i;
> +
> +  /* Oza : because of floating point insn push/pop of
> fpu stack 
> +  Is going to happen. currently we store st0-st7
> registers, 
> +  But we need not store all registers all the time,
> In future 
> +  We use ftag register and record only those who are
> not marked as an empty.  
> +  */
> +  if (I386_SAVE_FPU_REGS == iregnum)
> +    {
> +      for (i = I387_ST0_REGNUM (tdep);i
> <= I387_ST0_REGNUM (tdep) + 7;i++)
> +        {
> +          if
> (record_arch_list_add_reg (ir->regcache,i))
> +            return -1;
> +        }
> +    }
> +  else if (I386_SAVE_FPU_ENV == iregnum)
> +    {
> +      for (i = I387_FCTRL_REGNUM(tdep);i
> <= I387_FOP_REGNUM(tdep);i++)
> +      {
> +        if (record_arch_list_add_reg
> (ir->regcache,i))
> +          return -1;
> +      }
> +    }
> +  else if (I386_SAVE_FPU_ENV_REG_STACK == iregnum)
> +    {
> +      for (i = I387_ST0_REGNUM (tdep);i
> <= I387_FOP_REGNUM(tdep);i++)
> +      {
> +        if (record_arch_list_add_reg
> (ir->regcache,i))
> +          return -1;   
> 
> +      }
> +    }
> +  else if ((iregnum >= I387_ST0_REGNUM (tdep))
> && 
> +           (iregnum
> <= I387_FOP_REGNUM(tdep)))
> +    {
> +      if (record_arch_list_add_reg
> (ir->regcache,iregnum))
> +        return -1;
> +    }
> +  else
> +    {
> +      /* Parameter error.  */
> +      return -1;
> +    } 
> +  return 0;
> +}
> +
>  /* Parse the current instruction and record the values of
> the registers and
>     memory that will be changed in current
> instruction to "record_arch_list".
>     Return -1 if something wrong. */
> @@ -3070,6 +3130,7 @@
>    uint32_t tmpu32;
>    uint32_t opcode;
>    struct i386_record_s ir;
> +  struct gdbarch_tdep *tdep = gdbarch_tdep
> (gdbarch);
>  
>    memset (&ir, 0, sizeof (struct
> i386_record_s));
>    ir.regcache = regcache;
> @@ -4105,8 +4166,7 @@
>      }
>        break;
>  
> -      /* floats */
> -      /* It just record the memory change
> of instrcution. */
> +      /* Floats.  */
>      case 0xd8:
>      case 0xd9:
>      case 0xda:
> @@ -4120,46 +4180,57 @@
>        ir.reg |= ((opcode & 7)
> << 3);
>        if (ir.mod != 3)
>      {
> -      /* memory */
> +      /* Memory.  */
>        uint32_t addr;
>  
>        if (i386_record_lea_modrm_addr
> (&ir, &addr))
>          return -1;
>        switch (ir.reg)
>          {
> -        case 0x00:
> -        case 0x01:
>          case 0x02:
> -        case 0x03:
> +        case 0x12:
> +        case 0x22:
> +        case 0x32:
> +          /* For fcom, ficom
> nothing to do.  */
> +              break;
> +            case 0x03:
> +        case 0x13:
> +        case 0x23:
> +        case 0x33:
> +            /* For
> fcomp, ficomp pop FPU stack, store all.  */
> +          if
> (i386_record_floats(gdbarch, &ir, I386_SAVE_FPU_REGS))
> +               
> return -1;
> +              break;
> +        case 0x00:
> +              case
> 0x01:
>          case 0x04:
>          case 0x05:
>          case 0x06:
>          case 0x07:
>          case 0x10:
> -        case 0x11:
> -        case 0x12:
> -        case 0x13:
> +              case
> 0x11:
>          case 0x14:
>          case 0x15:
>          case 0x16:
>          case 0x17:
>          case 0x20:
>          case 0x21:
> -        case 0x22:
> -        case 0x23:
>          case 0x24:
>          case 0x25:
>          case 0x26:
>          case 0x27:
>          case 0x30:
>          case 0x31:
> -        case 0x32:
> -        case 0x33:
>          case 0x34:
>          case 0x35:
>          case 0x36:
>          case 0x37:
> -          break;
> +          /* For fadd, fmul,
> fsub, fsubr, fdiv, fdivr, fiadd, fimul, 
> +             
>    fisub, fisubr, fidiv, fidivr, modR/M.reg
> is an extension of code, 
> +             
>    Always affects st(0) register.  */
> +          if
> (i386_record_floats(gdbarch, &ir, I387_ST0_REGNUM
> (tdep)))
> +               
> return -1;
> +             
> break;       
>           
>         
>          case 0x08:
>          case 0x0a:
>          case 0x0b:
> @@ -4167,6 +4238,7 @@
>          case 0x19:
>          case 0x1a:
>          case 0x1b:
> +        case 0x1d: 
>          case 0x28:
>          case 0x29:
>          case 0x2a:
> @@ -4174,11 +4246,16 @@
>          case 0x38:
>          case 0x39:
>          case 0x3a:
> -        case 0x3b:
> +        case
> 0x3b:       
> +        case 0x3c: 
> +        case 0x3d: 
>            switch (ir.reg
> & 7)
>          {
>          case 0:
> -          break;
> +          /* Handling
> fld, fild.  */
> +              if
> (i386_record_floats(gdbarch, &ir, I386_SAVE_FPU_REGS))
> +               
>     return -1;    
> +               
>   break;
>          case 1:
>            switch
> (ir.reg >> 4)
>              {
> @@ -4191,6 +4268,7 @@
>             
> return -1;
>               
> break;
>              case
> 3:
> +             
> break;
>             
> default:
>               
> if (record_arch_list_add_mem (addr, 2))
>             
> return -1;
> @@ -4201,15 +4279,48 @@
>            switch
> (ir.reg >> 4)
>              {
>              case
> 0:
> +             
> if (record_arch_list_add_mem (addr, 4))
> +           
> return -1;
> +             
> if (3 == (ir.reg & 7))
> +               
>         {
> +               
>         /* For fstp m32fp */
> +             
>   if (i386_record_floats(gdbarch, &ir,  \
> +               
>                
>            
>    I386_SAVE_FPU_REGS))
> +             
>     return -1;         
>               
> +               
>         } 
> +               
>       break;
>              case
> 1:
>               
> if (record_arch_list_add_mem (addr, 4))
>             
> return -1;
> +             
> if ((3 == (ir.reg & 7))  \
> +               
>          || (5 == (ir.reg
> & 7))  \
> +               
>          || (7 == (ir.reg
> & 7)))
> +               
>         {
> +               
>         /* For fstp insn */
> +             
>   if (i386_record_floats(gdbarch, &ir,  \
> +               
>                
>            
>    I386_SAVE_FPU_REGS))
> +             
>     return -1;         
>               
> +               
>         } 
>               
> break;
>              case
> 2:
>               
> if (record_arch_list_add_mem (addr, 8))
>             
> return -1;
> +             
> if (3 == (ir.reg & 7))
> +               
>         {
> +               
>         /* For fstp m64fp */
> +             
>   if (i386_record_floats(gdbarch, &ir,  \
> +               
>                
>            
>    I386_SAVE_FPU_REGS))
> +             
>     return -1;         
>               
> +               
>         } 
>               
> break;
>              case
> 3:
> +             
> if ((3 <= (ir.reg & 7)) && (6 <= (ir.reg
> & 7)))
> +               
>         {
> +               
>         /* For fistp, fbld, fild,
> fbstp.  */
> +             
>   if (i386_record_floats(gdbarch, &ir,  \
> +               
>                
>            
>    I386_SAVE_FPU_REGS))
> +             
>     return -1;         
>               
> +               
>         }       
>                 
>             
> default:
>               
> if (record_arch_list_add_mem (addr, 2))
>             
> return -1;
> @@ -4218,54 +4329,74 @@
>            break;
>          }
>            break;
> -        case 0x0c:
> -        case 0x0d:
> -        case 0x1d:
> -        case 0x2c:
> -        case 0x3c:
> -        case 0x3d:
> -          break;
> -        case 0x0e:
> +           case
> 0x0c:
> +          /* Insn
> fldenv.  */
> +          if
> (i386_record_floats(gdbarch, &ir,  \
> +               
>                
>      I386_SAVE_FPU_ENV_REG_STACK))
> +            return
> -1;  
> +              break;
> +        case 0x0d: 
> +              /* Insn
> fldcw.  */
> +          if
> (i386_record_floats(gdbarch, &ir, I387_FCTRL_REGNUM
> (tdep)))
> +            return
> -1;  
> +              break;
> +        case 0x2c: 
> +              /* Insn
> frstor.  */
> +          if
> (i386_record_floats(gdbarch, &ir,  \
> +               
>                
>      I386_SAVE_FPU_ENV_REG_STACK))
> +            return
> -1;  
> +          break; 
> +        case 0x0e: 
>            if (ir.dflag)
>          {
> -          if
> (record_arch_list_add_mem (addr, 28))
> -            return
> -1;
> +        if
> (record_arch_list_add_mem (addr, 28))
> +          return -1;
>          }
>            else
>          {
> -          if
> (record_arch_list_add_mem (addr, 14))
> -            return
> -1;
> +        if
> (record_arch_list_add_mem (addr, 14))
> +          return -1;
>          }
>            break;
> -        case 0x0f:
> -        case 0x2f:
> +        case 0x0f:  
> +        case 0x2f:  
>            if
> (record_arch_list_add_mem (addr, 2))
>          return -1;
>            break;
> -        case 0x1f:
> -        case 0x3e:
> +        case 0x1f:  
> +        case 0x3e:  
>            if
> (record_arch_list_add_mem (addr, 10))
>          return -1;
> +              /* Insn
> fstp, fbstp.  */
> +              if
> (i386_record_floats(gdbarch, &ir, I386_SAVE_FPU_REGS))
> +            return
> -1;               
>                
>   
>            break;
> -        case 0x2e:
> +        case 0x2e: 
>            if (ir.dflag)
>          {
> -          if
> (record_arch_list_add_mem (addr, 28))
> -            return
> -1;
> -          addr += 28;
> +        if
> (record_arch_list_add_mem (addr, 28))
> +          return -1;
> +        addr += 28;
>          }
>            else
>          {
> -          if
> (record_arch_list_add_mem (addr, 14))
> -            return
> -1;
> -          addr += 14;
> +        if
> (record_arch_list_add_mem (addr, 14))
> +          return -1;
> +        addr += 14;
>          }
>            if
> (record_arch_list_add_mem (addr, 80))
>          return -1;
> +              /* Insn
> fsave.  */
> +          if
> (i386_record_floats(gdbarch, &ir,  \
> +           
>      
>    I386_SAVE_FPU_ENV_REG_STACK))
> +            return
> -1;   
>            break;
> -        case 0x3f:
> +        case 0x3f: 
>            if
> (record_arch_list_add_mem (addr, 8))
>          return -1;
> +        /* Ins fistp. 
> */
> +              if
> (i386_record_floats(gdbarch, &ir, I386_SAVE_FPU_REGS))
> +            return
> -1;   
>            break;
>          default:
>            ir.addr -= 2;
> @@ -4273,9 +4404,198 @@
>            goto no_support;
>            break;
>          }
> -    }
> +    }   
> +        /* Opcode is an extension of
> modR/M byte.  */     
> +    else
> +    { 
> +          switch (opcode)
> +            {
> +            case 0xd8:
> +              if
> (i386_record_floats(gdbarch, &ir, I387_ST0_REGNUM
> (tdep)))
> +               
> return -1;    
> +              break;
> +            case 0xd9: 
>   
> +              if (0x0c
> == (ir.modrm >> 4))
> +                {
> +               
>   if ((ir.modrm & 0x0f) <= 7)
> +               
>     {
> +               
>     if (i386_record_floats(gdbarch, &ir,
> I386_SAVE_FPU_REGS))
> +               
>       return -1;    
> +               
>     }
> +               
>   else
> +               
>     {
> +               
>     if (i386_record_floats(gdbarch, &ir, 
> \
> +               
>                
>        
>    I387_ST0_REGNUM (tdep)))
> +               
>       return -1;    
> +               
>     /* If only st(0) is changing, then we have
> already recorded */
> +               
>     if ((ir.modrm & 0x0f) - 0x08)
> +               
>       {
> +               
>       if (i386_record_floats(gdbarch,
> &ir,  \
> +               
>         I387_ST0_REGNUM (tdep) +
> ((ir.modrm & 0x0f) - 0x08)))
> +               
>         return -1;   
>                
>       
> +               
>       } 
> +               
>     }  
> +                }
> +              else
> +                {
> +               
> switch(ir.modrm)
> +               
>   {
> +               
>   case 0xe0:
> +               
>   case 0xe1:
> +               
>   case 0xf0:
> +               
>   case 0xf5:
> +               
>   case 0xf8:
> +               
>   case 0xfa:
> +               
>   case 0xfc:
> +               
>   case 0xfe:
> +               
>   case 0xff:
> +               
>     if (i386_record_floats(gdbarch, &ir, 
> \
> +               
>                
>        
>    I387_ST0_REGNUM (tdep)))
> +               
>       return -1;
> +               
>     break;       
>    
> +               
>   case 0xf1:  
> +               
>   case 0xf2:  
> +               
>   case 0xf3:  
> +               
>   case 0xf4:
> +          case 0xf6: 
> +               
>   case 0xf7:    
> +               
>   case 0xe8:  
> +               
>   case 0xe9:  
> +               
>   case 0xea:  
> +               
>   case 0xeb:
> +               
>   case 0xec:        
> +               
>   case 0xed:    
> +               
>   case 0xee:   
> +               
>   case 0xf9:     
> +               
>   case 0xfb:
> +               
>     if (i386_record_floats(gdbarch, &ir,
> I386_SAVE_FPU_REGS))
> +               
>       return -1;    
> +               
>     break;
> +               
>   case 0xfd: 
> +               
>     if (i386_record_floats(gdbarch, &ir, 
> \
> +               
>                
>        
>    I387_ST0_REGNUM (tdep)))
> +               
>       return -1;
> +               
>     if (i386_record_floats(gdbarch, &ir, 
> \
> +               
>                
>        
>    I387_ST0_REGNUM (tdep) + 1))
> +               
>       return -1;
> +               
>     break;
> +               
>   } 
> +              }
> +              break;
> +            case 0xda:
> +              if (0xe9
> == ir.modrm)
> +                {
> +        if
> (i386_record_floats(gdbarch, &ir, I386_SAVE_FPU_REGS))
> +               
>   return -1;           
>         
> +                }
> +              else if
> ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >>
> 4))
> +                {
> +                if
> (i386_record_floats(gdbarch, &ir, I387_ST0_REGNUM
> (tdep)))
> +               
>   return -1;         
>           
> +                if
> (((ir.modrm & 0x0f) > 0) && ((ir.modrm &
> 0x0f) <= 7))
> +               
>   {
> +               
>   if (i386_record_floats(gdbarch, &ir,  \
> +               
>      I387_ST0_REGNUM (tdep) + (ir.modrm
> & 0x0f)))
> +               
>     return -1;       
>                
>   
> +               
>   }
> +               
> else if ((ir.modrm & 0x0f) - 0x08)
> +               
>   {
> +          if
> (i386_record_floats(gdbarch, &ir,  \
> +               
>      I387_ST0_REGNUM (tdep) + ((ir.modrm
> & 0x0f) - 0x08)))
> +               
>     return -1;
> +               
>   }
> +               
> }  
> +              break; 
> +            case 0xdb:
> +              if (0xe3
> == ir.modrm)
> +                {
> +        if
> (i386_record_floats(gdbarch, &ir, I386_SAVE_FPU_ENV))
> +               
>   return -1;           
>         
> +                }
> +              else if
> ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >>
> 4))
> +                {
> +                if
> (i386_record_floats(gdbarch, &ir, I387_ST0_REGNUM
> (tdep)))
> +               
>   return -1;         
>           
> +                if
> (((ir.modrm & 0x0f) > 0) && ((ir.modrm &
> 0x0f) <= 7))
> +               
>   {
> +               
>   if (i386_record_floats(gdbarch, &ir,  \
> +               
>      I387_ST0_REGNUM (tdep) + (ir.modrm
> & 0x0f)))
> +               
>     return -1;       
>                
>   
> +               
>   }
> +               
> else if ((ir.modrm & 0x0f) - 0x08)
> +               
>   {
> +          if
> (i386_record_floats(gdbarch, &ir,  \
> +               
>       I387_ST0_REGNUM (tdep) + ((ir.modrm
> & 0x0f) - 0x08)))
> +               
>     return -1;
> +               
>   }
> +               
> }  
> +              break;
> +            case 0xdc:
> +              if
> (  (0x0c == ir.modrm >> 4)  \
> +             
>    || (0x0d == ir.modrm >> 4)  \
> +             
>    || (0x0f == ir.modrm >> 4))
> +                {
> +                if
> ((ir.modrm & 0x0f) <= 7)
> +               
>   {
> +               
>   if (i386_record_floats(gdbarch, &ir,  \
> +               
>       I387_ST0_REGNUM (tdep) + (ir.modrm
> & 0x0f)))
> +               
>     return -1;       
>                
>   
> +               
>   }
> +               
> else
> +               
>   {
> +          if
> (i386_record_floats(gdbarch, &ir,  \
> +               
>      I387_ST0_REGNUM (tdep) + ((ir.modrm
> & 0x0f) - 0x08)))
> +               
>     return -1;
> +               
>   }
> +               
> }  
> +           
>    break;
> +            case 0xdd: 
>            
> +              if (0x0c
> == ir.modrm >> 4)
> +                {
> +               
>   if (i386_record_floats(gdbarch, &ir,  \
> +               
>                
>          I387_FTAG_REGNUM
> (tdep)))
> +               
>     return -1;
> +                }
> +              else if
> ((0x0d == ir.modrm >> 4) || (0x0e == ir.modrm >>
> 4))
> +                {
> 
> +               
>   if ((ir.modrm & 0x0f) <= 7)
> +               
>     {
> +               
>       if (i386_record_floats(gdbarch,
> &ir,  \
> +               
>           I387_ST0_REGNUM (tdep) +
> (ir.modrm & 0x0f)))
> +               
>         return
> -1;     
> +               
>     }
> +               
>   else
> +               
>     {
> +               
>       if (i386_record_floats(gdbarch,
> &ir, I386_SAVE_FPU_REGS))
> +               
>         return -1;
> +               
>     }
> +               
> }            
> +              break;
> +            case 0xde:
> +              if ((0x0c
> == ir.modrm >> 4)  \
> +             
>    || (0x0e == ir.modrm >> 4)  \
> +             
>    || (0x0f == ir.modrm >> 4)  \
> +             
>    || (0xd9 == ir.modrm))
> +               
> {               
>    
> +               
>   if (i386_record_floats(gdbarch, &ir,
> I386_SAVE_FPU_REGS))
> +               
>     return -1;     
> +               
> }   
> +              break;
> +            case 0xdf:
> +          if (0xe0 ==
> ir.modrm)
> +                {
> +               
>   if (record_arch_list_add_reg (ir.regcache,
> I386_EAX_REGNUM))
> +          
>     return -1;
> +                }
> +              else if
> ((0x0f == ir.modrm >> 4) || (0x0e == ir.modrm >>
> 4))
> +                {
> 
> +               
>   if (i386_record_floats(gdbarch, &ir,
> I386_SAVE_FPU_REGS))
> +               
>     return -1;
> +                }
> 
> +              break;
> +            }
>       
> +        }     
>    
>        break;
> -
>        /* string ops */
>        /* movsS */
>      case 0xa4:
> @@ -4694,10 +5014,17 @@
>        /* fwait */
>        /* XXX */
>      case 0x9b:
> -      printf_unfiltered (_("Process record
> doesn't support instruction "
> -           
>    "fwait.\n"));
> -      ir.addr -= 1;
> -      goto no_support;
> +      if (target_read_memory (ir.addr,
> &tmpu8, 1))
> +    {
> +      if (record_debug)
> +        printf_unfiltered
> (_("Process record: error reading memory at "
> +           
>      "addr 0x%s len = 1.\n"),
> +           
>        paddress (gdbarch,
> ir.addr));
> +      return -1;
> +    }
> +      opcode = (uint32_t) tmpu8;
> +      ir.addr++;
> +      goto reswitch; 
>    
>        break;
>  
>        /* int3 */
> 
> 
> 
> 
> 
> 
> --- On Sun, 7/5/09, Hui Zhu <teawater@gmail.com>
> wrote:
> 
> > From: Hui Zhu <teawater@gmail.com>
> > Subject: Re: i386.record.floating.point.patch : with
> more testing and assurity
> > To: "paawan oza" <paawan1982@yahoo.com>
> > Cc: "Michael Snyder" <msnyder@vmware.com>,
> "Mark Kettenis" <mark.kettenis@xs4all.nl>,
> "pedro@codesourcery.com"
> <pedro@codesourcery.com>,
> "gdb-patches@sourceware.org"
> <gdb-patches@sourceware.org>
> > Date: Sunday, July 5, 2009, 3:45 PM
> > Hi Paawan,
> > 
> > 1.  gcc -g -O2   -I. -I../../src/gdb
> > -I../../src/gdb/common
> > -I../../src/gdb/config
> > -DLOCALEDIR="\"/usr/local/share/locale\""
> > -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode
> > -I../../src/gdb/../readline/.. -I../bfd
> > -I../../src/gdb/../bfd
> > -I../../src/gdb/../include -I../libdecnumber
> > -I../../src/gdb/../libdecnumber 
> > -I../../src/gdb/gnulib -Ignulib
> > -DMI_OUT=1 -DTUI=1  -Wall
> > -Wdeclaration-after-statement
> > -Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign
> > -Wno-unused
> > -Wno-switch -Wno-char-subscripts -Werror -c -o
> i386-tdep.o
> > -MT
> > i386-tdep.o -MMD -MP -MF .deps/i386-tdep.Tpo
> > ../../src/gdb/i386-tdep.c
> > cc1: warnings being treated as errors
> > ../../src/gdb/i386-tdep.c: In function
> > 'i386_process_record':
> > ../../src/gdb/i386-tdep.c:4985: warning: implicit
> > declaration of
> > function 'paddr_nz'
> > ../../src/gdb/i386-tdep.c:4985: warning: format '%s'
> > expects type
> > 'char *', but argument 2 has type 'int'
> > make[2]: *** [i386-tdep.o] Error 1
> > make[2]: Leaving directory `/media/disk/gdb/bgdb/gdb'
> > make[1]: *** [all-gdb] Error 2
> > make[1]: Leaving directory `/media/disk/gdb/bgdb'
> > make: *** [all] Error 2
> > 
> > paddr_nz was removed.  Please update your patch
> follow
> > cvs-head.
> > 
> > 2. +#define I386_SAVE_FPU_REGS   
> >     0xFFFD
> > +#define I386_SAVE_FPU_ENV   
> >     0xFFFE
> > +#define I386_SAVE_FPU_ENV_REG_STACK   
> > 0xFFFF
> > 
> > They just used in prec right?  Maybe you can move
> them
> > close to record
> > code in i386-tedp.c.
> > 
> > 3. +static int i386_record_floats(struct i386_record_s
> *ir,
> > uint32_t iregnum)
> > +{
> > +  int i;
> > +
> > +  /* Oza : push/pop of fpu stack is going to happen
> > +     currently we store st0-st7
> > registers, but we need not store all
> > registers all the time.
> > +     using fstatus, we use 11-13 bits
> > which gives us stack top and
> > hence we optimize our storage.
> > +     alternatively we can use ftag
> > register too */
> > +  if (I386_SAVE_FPU_REGS == iregnum)
> > +    {
> > +      for
> > (i=I386_ST0_REGNUM;i<=I386_ST0_REGNUM+7;i++)
> > +        {
> > +          if
> > (record_arch_list_add_reg (ir->regcache,i))
> > +            return -1;
> > +        }
> > +    }
> > About the number of fp regs.  Please use the code:
> > #define I387_ST0_REGNUM(tdep) ((tdep)->st0_regnum)
> > #define I387_NUM_XMM_REGS(tdep)
> ((tdep)->num_xmm_regs)
> > #define I387_MM0_REGNUM(tdep) ((tdep)->mm0_regnum)
> > 
> > #define I387_FCTRL_REGNUM(tdep) (I387_ST0_REGNUM
> (tdep) +
> > 8)
> > #define I387_FSTAT_REGNUM(tdep) (I387_FCTRL_REGNUM
> (tdep) +
> > 1)
> > #define I387_FTAG_REGNUM(tdep) (I387_FCTRL_REGNUM
> (tdep) +
> > 2)
> > #define I387_FISEG_REGNUM(tdep) (I387_FCTRL_REGNUM
> (tdep) +
> > 3)
> > #define I387_FIOFF_REGNUM(tdep) (I387_FCTRL_REGNUM
> (tdep) +
> > 4)
> > #define I387_FOSEG_REGNUM(tdep) (I387_FCTRL_REGNUM
> (tdep) +
> > 5)
> > #define I387_FOOFF_REGNUM(tdep) (I387_FCTRL_REGNUM
> (tdep) +
> > 6)
> > #define I387_FOP_REGNUM(tdep) (I387_FCTRL_REGNUM
> (tdep) +
> > 7)
> > #define I387_XMM0_REGNUM(tdep) (I387_ST0_REGNUM (tdep)
> +
> > 16)
> > #define I387_MXCSR_REGNUM(tdep) \
> >   (I387_XMM0_REGNUM (tdep) + I387_NUM_XMM_REGS
> > (tdep))
> > 
> > They are in i387-tdep.h.
> > 
> > And maybe you can try function i387_supply_fsave and
> > i387_collect_fsave.
> > 
> > 
> > 4.  Your code's format is not very well.  Please
> > make it like the code in cvs.
> > 
> > 
> > 
> > Thanks,
> > Hui
> > 
> > 
> > 
> > 
> > On Sat, Jul 4, 2009 at 13:19, paawan oza<paawan1982@yahoo.com>
> > wrote:
> > >
> > > Hi,
> > >
> > > Actually, the initial patch which I submitted
> were
> > using them.
> > > but as I have incorporated Hui's comments I have
> > removed those constants completely.
> > > in the sense I have no longer extended the
> > enumration.
> > >
> > > but of course, those registers are recorded as
> and
> > when required.
> > > e.g. (ffree insn changes FTAG register, so we
> record
> > it)
> > >
> > > Regards,
> > > Oza.
> > >
> > > --- On Sat, 7/4/09, Michael Snyder <msnyder@vmware.com>
> > wrote:
> > >
> > >> From: Michael Snyder <msnyder@vmware.com>
> > >> Subject: Re: i386.record.floating.point.patch
> :
> > with more testing and assurity
> > >> To: "paawan oza" <paawan1982@yahoo.com>
> > >> Cc: "Mark Kettenis" <mark.kettenis@xs4all.nl>,
> > "pedro@codesourcery.com"
> > <pedro@codesourcery.com>,
> > "teawater@gmail.com"
> > <teawater@gmail.com>,
> > "gdb-patches@sourceware.org"
> > <gdb-patches@sourceware.org>
> > >> Date: Saturday, July 4, 2009, 3:19 AM
> > >> paawan oza wrote:
> > >> > Hi,
> > >> >
> > >> > In My understanding the point was like
> > below.
> > >> > in the patch there were following
> register
> > extended in
> > >> enumeration in i386-tdep.h
> > >> >
> > >> > I386_FSTAT,
> > >> > I386_FTAG,       I386_FISEG,
> > >> > I386_FIOFF,
> > >> > I386_FOSEG,
> > >> > I386_FOOFF,
> > >> > I386_FOP
> > >> >
> > >> >
> > >> > According to Hui in some of his
> previous
> > mails...his
> > >> idea was
> > >> >> FCTRL, FOP and so on are the fp reg
> of
> > >> amd64.  For now, prec is still
> > >> >> not support amd64 And amd64's
> support are
> > in
> > >> amd64-tedp.... files.  >Change
> i386_regnum is
> > not a
> > >> good idea. I suggest you divide fp patch to
> 2
> > >parts. One
> > >> is for i386, the other for amd64. For now,
> just
> > send i386
> > >> patch >for review.  And send amd64 patch
> when
> > prec
> > >> support amd64"
> > >> >
> > >> >
> > >> > while, my idea/understanding is:
> > >> > FCTRL, FOP registers are not only a part
> of
> > amd64, but
> > >> also part of i386 (x87 FPU unit) also.
> > >> > so according to me these registers are
> part
> > of i386
> > >> also and it needed to be also in
> i386-tdep.h.
> > >> >
> > >> > Regards,
> > >> > Oza.
> > >>
> > >> I'm not sure why you want to add those
> constants
> > to
> > >> i386-tdep.h,
> > >> when the rest of your patch does not seem to
> use
> > them.
> > >>
> > >>
> > >
> > >
> > >
> > >
> > 
> 
> 
> 
> 




^ permalink raw reply	[flat|nested] 40+ messages in thread
* Re: i386.record.floating.point.patch : with more testing and assurity
@ 2009-07-06 19:05 paawan oza
  2009-07-08  9:00 ` Hui Zhu
  2009-07-12  9:52 ` Michael Snyder
  0 siblings, 2 replies; 40+ messages in thread
From: paawan oza @ 2009-07-06 19:05 UTC (permalink / raw)
  To: Hui Zhu; +Cc: Michael Snyder, Mark Kettenis, pedro, gdb-patches


Hi,

please find the latest patch and ChangeLog as follows.

********************
ChangeLog
********************
Current: gdb-6.8.50.20090706
2009-07-06  Oza  <paawan1982@yahoo.com>

        * i386-tdep.c: Support for floating point recording.


***************************
i386.records.floats.patch
***************************


diff -urN ./gdb.orig/i386-tdep.c gdb.new/i386-tdep.c
--- ./gdb.orig/i386-tdep.c	2009-07-02 13:25:54.000000000 -0400
+++ gdb.new/i386-tdep.c	2009-07-06 23:44:07.000000000 -0400
@@ -3056,6 +3056,66 @@
   return 0;
 }
 
+
+/* Defines contents to record.  */
+#define I386_SAVE_FPU_REGS              0xfffd
+#define I386_SAVE_FPU_ENV               0xfffe
+#define I386_SAVE_FPU_ENV_REG_STACK     0xffff
+
+/* Record the value of floating point registers which will be changed by the
+   Current instruction to "record_arch_list".  
+   Return -1 if something is wrong.  */  
+
+static int i386_record_floats(struct gdbarch *gdbarch, 
+                              struct i386_record_s *ir, 
+                              uint32_t iregnum)
+{
+  struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
+  int i;
+
+  /* Oza : because of floating point insn push/pop of fpu stack 
+  Is going to happen. currently we store st0-st7 registers, 
+  But we need not store all registers all the time, In future 
+  We use ftag register and record only those who are not marked as an empty.  
+  */
+  if (I386_SAVE_FPU_REGS == iregnum)
+    {
+      for (i = I387_ST0_REGNUM (tdep);i <= I387_ST0_REGNUM (tdep) + 7;i++)
+        {
+          if (record_arch_list_add_reg (ir->regcache,i))
+            return -1;
+        }
+    }
+  else if (I386_SAVE_FPU_ENV == iregnum)
+    {
+      for (i = I387_FCTRL_REGNUM(tdep);i <= I387_FOP_REGNUM(tdep);i++)
+      {
+        if (record_arch_list_add_reg (ir->regcache,i))
+          return -1;
+      }
+    }
+  else if (I386_SAVE_FPU_ENV_REG_STACK == iregnum)
+    {
+      for (i = I387_ST0_REGNUM (tdep);i <= I387_FOP_REGNUM(tdep);i++)
+      {
+        if (record_arch_list_add_reg (ir->regcache,i))
+          return -1;    
+      }
+    }
+  else if ((iregnum >= I387_ST0_REGNUM (tdep)) && 
+           (iregnum <= I387_FOP_REGNUM(tdep)))
+    {
+      if (record_arch_list_add_reg (ir->regcache,iregnum))
+        return -1;
+    }
+  else
+    {
+      /* Parameter error.  */
+      return -1;
+    } 
+  return 0;
+}
+
 /* Parse the current instruction and record the values of the registers and
    memory that will be changed in current instruction to "record_arch_list".
    Return -1 if something wrong. */
@@ -3070,6 +3130,7 @@
   uint32_t tmpu32;
   uint32_t opcode;
   struct i386_record_s ir;
+  struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
 
   memset (&ir, 0, sizeof (struct i386_record_s));
   ir.regcache = regcache;
@@ -4105,8 +4166,7 @@
 	}
       break;
 
-      /* floats */
-      /* It just record the memory change of instrcution. */
+      /* Floats.  */
     case 0xd8:
     case 0xd9:
     case 0xda:
@@ -4120,46 +4180,57 @@
       ir.reg |= ((opcode & 7) << 3);
       if (ir.mod != 3)
 	{
-	  /* memory */
+	  /* Memory.  */
 	  uint32_t addr;
 
 	  if (i386_record_lea_modrm_addr (&ir, &addr))
 	    return -1;
 	  switch (ir.reg)
 	    {
-	    case 0x00:
-	    case 0x01:
 	    case 0x02:
-	    case 0x03:
+	    case 0x12:
+	    case 0x22:
+	    case 0x32:
+	      /* For fcom, ficom nothing to do.  */
+              break;
+            case 0x03:
+	    case 0x13:
+	    case 0x23:
+	    case 0x33:
+  	      /* For fcomp, ficomp pop FPU stack, store all.  */
+	      if (i386_record_floats(gdbarch, &ir, I386_SAVE_FPU_REGS))
+                return -1;
+              break;
+	    case 0x00:
+      	    case 0x01:
 	    case 0x04:
 	    case 0x05:
 	    case 0x06:
 	    case 0x07:
 	    case 0x10:
-	    case 0x11:
-	    case 0x12:
-	    case 0x13:
+      	    case 0x11:
 	    case 0x14:
 	    case 0x15:
 	    case 0x16:
 	    case 0x17:
 	    case 0x20:
 	    case 0x21:
-	    case 0x22:
-	    case 0x23:
 	    case 0x24:
 	    case 0x25:
 	    case 0x26:
 	    case 0x27:
 	    case 0x30:
 	    case 0x31:
-	    case 0x32:
-	    case 0x33:
 	    case 0x34:
 	    case 0x35:
 	    case 0x36:
 	    case 0x37:
-	      break;
+	      /* For fadd, fmul, fsub, fsubr, fdiv, fdivr, fiadd, fimul, 
+                 fisub, fisubr, fidiv, fidivr, modR/M.reg is an extension of code, 
+                 Always affects st(0) register.  */
+	      if (i386_record_floats(gdbarch, &ir, I387_ST0_REGNUM (tdep)))
+                return -1;
+              break;           	    	    
 	    case 0x08:
 	    case 0x0a:
 	    case 0x0b:
@@ -4167,6 +4238,7 @@
 	    case 0x19:
 	    case 0x1a:
 	    case 0x1b:
+	    case 0x1d: 
 	    case 0x28:
 	    case 0x29:
 	    case 0x2a:
@@ -4174,11 +4246,16 @@
 	    case 0x38:
 	    case 0x39:
 	    case 0x3a:
-	    case 0x3b:
+	    case 0x3b:	   
+	    case 0x3c: 
+	    case 0x3d: 
 	      switch (ir.reg & 7)
 		{
 		case 0:
-		  break;
+		  /* Handling fld, fild.  */
+	          if (i386_record_floats(gdbarch, &ir, I386_SAVE_FPU_REGS))
+                    return -1;    
+                  break;
 		case 1:
 		  switch (ir.reg >> 4)
 		    {
@@ -4191,6 +4268,7 @@
 			return -1;
 		      break;
 		    case 3:
+		      break;
 		    default:
 		      if (record_arch_list_add_mem (addr, 2))
 			return -1;
@@ -4201,15 +4279,48 @@
 		  switch (ir.reg >> 4)
 		    {
 		    case 0:
+		      if (record_arch_list_add_mem (addr, 4))
+			return -1;
+		      if (3 == (ir.reg & 7))
+                        {
+                        /* For fstp m32fp */
+		        if (i386_record_floats(gdbarch, &ir,  \
+                                               I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        } 
+                      break;
 		    case 1:
 		      if (record_arch_list_add_mem (addr, 4))
 			return -1;
+		      if ((3 == (ir.reg & 7))  \
+                         || (5 == (ir.reg & 7))  \
+                         || (7 == (ir.reg & 7)))
+                        {
+                        /* For fstp insn */
+		        if (i386_record_floats(gdbarch, &ir,  \
+                                               I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        } 
 		      break;
 		    case 2:
 		      if (record_arch_list_add_mem (addr, 8))
 			return -1;
+		      if (3 == (ir.reg & 7))
+                        {
+                        /* For fstp m64fp */
+		        if (i386_record_floats(gdbarch, &ir,  \
+                                               I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        } 
 		      break;
 		    case 3:
+		      if ((3 <= (ir.reg & 7)) && (6 <= (ir.reg & 7)))
+                        {
+                        /* For fistp, fbld, fild, fbstp.  */
+		        if (i386_record_floats(gdbarch, &ir,  \
+                                               I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        }                        
 		    default:
 		      if (record_arch_list_add_mem (addr, 2))
 			return -1;
@@ -4218,54 +4329,74 @@
 		  break;
 		}
 	      break;
-	    case 0x0c:
-	    case 0x0d:
-	    case 0x1d:
-	    case 0x2c:
-	    case 0x3c:
-	    case 0x3d:
-	      break;
-	    case 0x0e:
+   	    case 0x0c:
+	      /* Insn fldenv.  */
+	      if (i386_record_floats(gdbarch, &ir,  \
+                                     I386_SAVE_FPU_ENV_REG_STACK))
+	        return -1;  
+              break;
+	    case 0x0d: 
+              /* Insn fldcw.  */
+	      if (i386_record_floats(gdbarch, &ir, I387_FCTRL_REGNUM (tdep)))
+	        return -1;  
+              break;
+	    case 0x2c: 
+              /* Insn frstor.  */
+	      if (i386_record_floats(gdbarch, &ir,  \
+                                     I386_SAVE_FPU_ENV_REG_STACK))
+	        return -1;  
+	      break; 
+	    case 0x0e: 
 	      if (ir.dflag)
 		{
-		  if (record_arch_list_add_mem (addr, 28))
-		    return -1;
+		if (record_arch_list_add_mem (addr, 28))
+		  return -1;
 		}
 	      else
 		{
-		  if (record_arch_list_add_mem (addr, 14))
-		    return -1;
+		if (record_arch_list_add_mem (addr, 14))
+		  return -1;
 		}
 	      break;
-	    case 0x0f:
-	    case 0x2f:
+	    case 0x0f:  
+	    case 0x2f:  
 	      if (record_arch_list_add_mem (addr, 2))
 		return -1;
 	      break;
-	    case 0x1f:
-	    case 0x3e:
+	    case 0x1f:  
+	    case 0x3e:  
 	      if (record_arch_list_add_mem (addr, 10))
 		return -1;
+              /* Insn fstp, fbstp.  */
+              if (i386_record_floats(gdbarch, &ir, I386_SAVE_FPU_REGS))
+	        return -1;                                  
 	      break;
-	    case 0x2e:
+	    case 0x2e: 
 	      if (ir.dflag)
 		{
-		  if (record_arch_list_add_mem (addr, 28))
-		    return -1;
-		  addr += 28;
+		if (record_arch_list_add_mem (addr, 28))
+		  return -1;
+		addr += 28;
 		}
 	      else
 		{
-		  if (record_arch_list_add_mem (addr, 14))
-		    return -1;
-		  addr += 14;
+		if (record_arch_list_add_mem (addr, 14))
+		  return -1;
+		addr += 14;
 		}
 	      if (record_arch_list_add_mem (addr, 80))
 		return -1;
+              /* Insn fsave.  */
+	      if (i386_record_floats(gdbarch, &ir,  \
+				     I386_SAVE_FPU_ENV_REG_STACK))
+	        return -1;   
 	      break;
-	    case 0x3f:
+	    case 0x3f: 
 	      if (record_arch_list_add_mem (addr, 8))
 		return -1;
+		/* Ins fistp.  */
+              if (i386_record_floats(gdbarch, &ir, I386_SAVE_FPU_REGS))
+	        return -1;   
 	      break;
 	    default:
 	      ir.addr -= 2;
@@ -4273,9 +4404,198 @@
 	      goto no_support;
 	      break;
 	    }
-	}
+	}   
+        /* Opcode is an extension of modR/M byte.  */     
+	else
+	{ 
+          switch (opcode)
+            {
+            case 0xd8:
+              if (i386_record_floats(gdbarch, &ir, I387_ST0_REGNUM (tdep)))
+                return -1;	
+              break;
+            case 0xd9:    
+              if (0x0c == (ir.modrm >> 4))
+                {
+                  if ((ir.modrm & 0x0f) <= 7)
+                    {
+                    if (i386_record_floats(gdbarch, &ir, I386_SAVE_FPU_REGS))
+                      return -1;	
+                    }
+                  else
+                    {
+                    if (i386_record_floats(gdbarch, &ir,  \
+                                           I387_ST0_REGNUM (tdep)))
+                      return -1;	
+                    /* If only st(0) is changing, then we have already recorded */
+                    if ((ir.modrm & 0x0f) - 0x08)
+                      {
+                      if (i386_record_floats(gdbarch, &ir,  \
+                        I387_ST0_REGNUM (tdep) + ((ir.modrm & 0x0f) - 0x08)))
+                        return -1;	                      
+                      } 
+                    }  
+                }
+              else
+                {
+                switch(ir.modrm)
+                  {
+                  case 0xe0:
+                  case 0xe1:
+                  case 0xf0:
+                  case 0xf5:
+                  case 0xf8:
+                  case 0xfa:
+                  case 0xfc:
+                  case 0xfe:
+                  case 0xff:
+                    if (i386_record_floats(gdbarch, &ir,  \
+                                           I387_ST0_REGNUM (tdep)))
+                      return -1;
+                    break;           
+                  case 0xf1:  
+                  case 0xf2:  
+                  case 0xf3:  
+                  case 0xf4:
+		  case 0xf6: 
+                  case 0xf7:    
+                  case 0xe8:  
+                  case 0xe9:  
+                  case 0xea:  
+                  case 0xeb:
+                  case 0xec:        
+                  case 0xed:    
+                  case 0xee:   
+                  case 0xf9:     
+                  case 0xfb:
+                    if (i386_record_floats(gdbarch, &ir, I386_SAVE_FPU_REGS))
+                      return -1;	
+                    break;
+                  case 0xfd: 
+                    if (i386_record_floats(gdbarch, &ir,  \
+                                           I387_ST0_REGNUM (tdep)))
+                      return -1;
+                    if (i386_record_floats(gdbarch, &ir,  \
+                                           I387_ST0_REGNUM (tdep) + 1))
+                      return -1;
+                    break;
+                  } 
+              }
+              break;
+            case 0xda:
+              if (0xe9 == ir.modrm)
+                {
+		if (i386_record_floats(gdbarch, &ir, I386_SAVE_FPU_REGS))
+                  return -1;                    
+                }
+              else if ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >> 4))
+                {
+                if (i386_record_floats(gdbarch, &ir, I387_ST0_REGNUM (tdep)))
+                  return -1;	                
+                if (((ir.modrm & 0x0f) > 0) && ((ir.modrm & 0x0f) <= 7))
+                  {
+                  if (i386_record_floats(gdbarch, &ir,  \
+                     I387_ST0_REGNUM (tdep) + (ir.modrm & 0x0f)))
+                    return -1;	                      
+                  }
+                else if ((ir.modrm & 0x0f) - 0x08)
+                  {
+		  if (i386_record_floats(gdbarch, &ir,  \
+                     I387_ST0_REGNUM (tdep) + ((ir.modrm & 0x0f) - 0x08)))
+                    return -1;
+                  }
+                }  
+              break; 
+            case 0xdb:
+              if (0xe3 == ir.modrm)
+                {
+		if (i386_record_floats(gdbarch, &ir, I386_SAVE_FPU_ENV))
+                  return -1;                    
+                }
+              else if ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >> 4))
+                {
+                if (i386_record_floats(gdbarch, &ir, I387_ST0_REGNUM (tdep)))
+                  return -1;	                
+                if (((ir.modrm & 0x0f) > 0) && ((ir.modrm & 0x0f) <= 7))
+                  {
+                  if (i386_record_floats(gdbarch, &ir,  \
+                     I387_ST0_REGNUM (tdep) + (ir.modrm & 0x0f)))
+                    return -1;	                      
+                  }
+                else if ((ir.modrm & 0x0f) - 0x08)
+                  {
+		  if (i386_record_floats(gdbarch, &ir,  \
+                      I387_ST0_REGNUM (tdep) + ((ir.modrm & 0x0f) - 0x08)))
+                    return -1;
+                  }
+                }  
+              break;
+            case 0xdc:
+              if (  (0x0c == ir.modrm >> 4)  \
+                 || (0x0d == ir.modrm >> 4)  \
+                 || (0x0f == ir.modrm >> 4))
+                {
+                if ((ir.modrm & 0x0f) <= 7)
+                  {
+                  if (i386_record_floats(gdbarch, &ir,  \
+                      I387_ST0_REGNUM (tdep) + (ir.modrm & 0x0f)))
+                    return -1;	                      
+                  }
+                else
+                  {
+		  if (i386_record_floats(gdbarch, &ir,  \
+                     I387_ST0_REGNUM (tdep) + ((ir.modrm & 0x0f) - 0x08)))
+                    return -1;
+                  }
+                }  
+               break;
+            case 0xdd:             
+              if (0x0c == ir.modrm >> 4)
+                {
+                  if (i386_record_floats(gdbarch, &ir,  \
+                                         I387_FTAG_REGNUM (tdep)))
+                    return -1;
+                }
+              else if ((0x0d == ir.modrm >> 4) || (0x0e == ir.modrm >> 4))
+                { 
+                  if ((ir.modrm & 0x0f) <= 7)
+                    {
+                      if (i386_record_floats(gdbarch, &ir,  \
+                          I387_ST0_REGNUM (tdep) + (ir.modrm & 0x0f)))
+                        return -1;	 
+                    }
+                  else
+                    {
+                      if (i386_record_floats(gdbarch, &ir, I386_SAVE_FPU_REGS))
+                        return -1;
+                    }
+                }            
+              break;
+            case 0xde:
+              if ((0x0c == ir.modrm >> 4)  \
+                 || (0x0e == ir.modrm >> 4)  \
+                 || (0x0f == ir.modrm >> 4)  \
+                 || (0xd9 == ir.modrm))
+                {                   
+                  if (i386_record_floats(gdbarch, &ir, I386_SAVE_FPU_REGS))
+                    return -1;	 
+                }   
+              break;
+            case 0xdf:
+	      if (0xe0 == ir.modrm)
+                {
+                  if (record_arch_list_add_reg (ir.regcache, I386_EAX_REGNUM))
+	   	    return -1;
+                }
+              else if ((0x0f == ir.modrm >> 4) || (0x0e == ir.modrm >> 4))
+                { 
+                  if (i386_record_floats(gdbarch, &ir, I386_SAVE_FPU_REGS))
+                    return -1;
+                } 
+              break;
+            } 	  
+        }         
       break;
-
       /* string ops */
       /* movsS */
     case 0xa4:
@@ -4694,10 +5014,17 @@
       /* fwait */
       /* XXX */
     case 0x9b:
-      printf_unfiltered (_("Process record doesn't support instruction "
-			   "fwait.\n"));
-      ir.addr -= 1;
-      goto no_support;
+      if (target_read_memory (ir.addr, &tmpu8, 1))
+	{
+	  if (record_debug)
+	    printf_unfiltered (_("Process record: error reading memory at "
+				 "addr 0x%s len = 1.\n"),
+			       paddress (gdbarch, ir.addr));
+	  return -1;
+	}
+      opcode = (uint32_t) tmpu8;
+      ir.addr++;
+      goto reswitch;     
       break;
 
       /* int3 */






--- On Sun, 7/5/09, Hui Zhu <teawater@gmail.com> wrote:

> From: Hui Zhu <teawater@gmail.com>
> Subject: Re: i386.record.floating.point.patch : with more testing and assurity
> To: "paawan oza" <paawan1982@yahoo.com>
> Cc: "Michael Snyder" <msnyder@vmware.com>, "Mark Kettenis" <mark.kettenis@xs4all.nl>, "pedro@codesourcery.com" <pedro@codesourcery.com>, "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> Date: Sunday, July 5, 2009, 3:45 PM
> Hi Paawan,
> 
> 1.  gcc -g -O2   -I. -I../../src/gdb
> -I../../src/gdb/common
> -I../../src/gdb/config
> -DLOCALEDIR="\"/usr/local/share/locale\""
> -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode
> -I../../src/gdb/../readline/.. -I../bfd
> -I../../src/gdb/../bfd
> -I../../src/gdb/../include -I../libdecnumber
> -I../../src/gdb/../libdecnumber 
> -I../../src/gdb/gnulib -Ignulib
> -DMI_OUT=1 -DTUI=1  -Wall
> -Wdeclaration-after-statement
> -Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign
> -Wno-unused
> -Wno-switch -Wno-char-subscripts -Werror -c -o i386-tdep.o
> -MT
> i386-tdep.o -MMD -MP -MF .deps/i386-tdep.Tpo
> ../../src/gdb/i386-tdep.c
> cc1: warnings being treated as errors
> ../../src/gdb/i386-tdep.c: In function
> 'i386_process_record':
> ../../src/gdb/i386-tdep.c:4985: warning: implicit
> declaration of
> function 'paddr_nz'
> ../../src/gdb/i386-tdep.c:4985: warning: format '%s'
> expects type
> 'char *', but argument 2 has type 'int'
> make[2]: *** [i386-tdep.o] Error 1
> make[2]: Leaving directory `/media/disk/gdb/bgdb/gdb'
> make[1]: *** [all-gdb] Error 2
> make[1]: Leaving directory `/media/disk/gdb/bgdb'
> make: *** [all] Error 2
> 
> paddr_nz was removed.  Please update your patch follow
> cvs-head.
> 
> 2. +#define I386_SAVE_FPU_REGS   
>     0xFFFD
> +#define I386_SAVE_FPU_ENV   
>     0xFFFE
> +#define I386_SAVE_FPU_ENV_REG_STACK   
> 0xFFFF
> 
> They just used in prec right?  Maybe you can move them
> close to record
> code in i386-tedp.c.
> 
> 3. +static int i386_record_floats(struct i386_record_s *ir,
> uint32_t iregnum)
> +{
> +  int i;
> +
> +  /* Oza : push/pop of fpu stack is going to happen
> +     currently we store st0-st7
> registers, but we need not store all
> registers all the time.
> +     using fstatus, we use 11-13 bits
> which gives us stack top and
> hence we optimize our storage.
> +     alternatively we can use ftag
> register too */
> +  if (I386_SAVE_FPU_REGS == iregnum)
> +    {
> +      for
> (i=I386_ST0_REGNUM;i<=I386_ST0_REGNUM+7;i++)
> +        {
> +          if
> (record_arch_list_add_reg (ir->regcache,i))
> +            return -1;
> +        }
> +    }
> About the number of fp regs.  Please use the code:
> #define I387_ST0_REGNUM(tdep) ((tdep)->st0_regnum)
> #define I387_NUM_XMM_REGS(tdep) ((tdep)->num_xmm_regs)
> #define I387_MM0_REGNUM(tdep) ((tdep)->mm0_regnum)
> 
> #define I387_FCTRL_REGNUM(tdep) (I387_ST0_REGNUM (tdep) +
> 8)
> #define I387_FSTAT_REGNUM(tdep) (I387_FCTRL_REGNUM (tdep) +
> 1)
> #define I387_FTAG_REGNUM(tdep) (I387_FCTRL_REGNUM (tdep) +
> 2)
> #define I387_FISEG_REGNUM(tdep) (I387_FCTRL_REGNUM (tdep) +
> 3)
> #define I387_FIOFF_REGNUM(tdep) (I387_FCTRL_REGNUM (tdep) +
> 4)
> #define I387_FOSEG_REGNUM(tdep) (I387_FCTRL_REGNUM (tdep) +
> 5)
> #define I387_FOOFF_REGNUM(tdep) (I387_FCTRL_REGNUM (tdep) +
> 6)
> #define I387_FOP_REGNUM(tdep) (I387_FCTRL_REGNUM (tdep) +
> 7)
> #define I387_XMM0_REGNUM(tdep) (I387_ST0_REGNUM (tdep) +
> 16)
> #define I387_MXCSR_REGNUM(tdep) \
>   (I387_XMM0_REGNUM (tdep) + I387_NUM_XMM_REGS
> (tdep))
> 
> They are in i387-tdep.h.
> 
> And maybe you can try function i387_supply_fsave and
> i387_collect_fsave.
> 
> 
> 4.  Your code's format is not very well.  Please
> make it like the code in cvs.
> 
> 
> 
> Thanks,
> Hui
> 
> 
> 
> 
> On Sat, Jul 4, 2009 at 13:19, paawan oza<paawan1982@yahoo.com>
> wrote:
> >
> > Hi,
> >
> > Actually, the initial patch which I submitted were
> using them.
> > but as I have incorporated Hui's comments I have
> removed those constants completely.
> > in the sense I have no longer extended the
> enumration.
> >
> > but of course, those registers are recorded as and
> when required.
> > e.g. (ffree insn changes FTAG register, so we record
> it)
> >
> > Regards,
> > Oza.
> >
> > --- On Sat, 7/4/09, Michael Snyder <msnyder@vmware.com>
> wrote:
> >
> >> From: Michael Snyder <msnyder@vmware.com>
> >> Subject: Re: i386.record.floating.point.patch :
> with more testing and assurity
> >> To: "paawan oza" <paawan1982@yahoo.com>
> >> Cc: "Mark Kettenis" <mark.kettenis@xs4all.nl>,
> "pedro@codesourcery.com"
> <pedro@codesourcery.com>,
> "teawater@gmail.com"
> <teawater@gmail.com>,
> "gdb-patches@sourceware.org"
> <gdb-patches@sourceware.org>
> >> Date: Saturday, July 4, 2009, 3:19 AM
> >> paawan oza wrote:
> >> > Hi,
> >> >
> >> > In My understanding the point was like
> below.
> >> > in the patch there were following register
> extended in
> >> enumeration in i386-tdep.h
> >> >
> >> > I386_FSTAT,
> >> > I386_FTAG,       I386_FISEG,
> >> > I386_FIOFF,
> >> > I386_FOSEG,
> >> > I386_FOOFF,
> >> > I386_FOP
> >> >
> >> >
> >> > According to Hui in some of his previous
> mails...his
> >> idea was
> >> >> FCTRL, FOP and so on are the fp reg of
> >> amd64.  For now, prec is still
> >> >> not support amd64 And amd64's support are
> in
> >> amd64-tedp.... files.  >Change i386_regnum is
> not a
> >> good idea. I suggest you divide fp patch to 2
> >parts. One
> >> is for i386, the other for amd64. For now, just
> send i386
> >> patch >for review.  And send amd64 patch when
> prec
> >> support amd64"
> >> >
> >> >
> >> > while, my idea/understanding is:
> >> > FCTRL, FOP registers are not only a part of
> amd64, but
> >> also part of i386 (x87 FPU unit) also.
> >> > so according to me these registers are part
> of i386
> >> also and it needed to be also in i386-tdep.h.
> >> >
> >> > Regards,
> >> > Oza.
> >>
> >> I'm not sure why you want to add those constants
> to
> >> i386-tdep.h,
> >> when the rest of your patch does not seem to use
> them.
> >>
> >>
> >
> >
> >
> >
> 




^ permalink raw reply	[flat|nested] 40+ messages in thread
* Re: i386.record.floating.point.patch : with more testing and assurity
@ 2009-07-06 19:03 paawan oza
  0 siblings, 0 replies; 40+ messages in thread
From: paawan oza @ 2009-07-06 19:03 UTC (permalink / raw)
  To: Hui Zhu; +Cc: Michael Snyder, Mark Kettenis, pedro, gdb-patches


Hi Hui,

following comments are taken care.

1) paddr_nz is removed, now patch follows latest cvs head.
2) constants are moved close to prec code as you suggested.
3) for floating point register numbers, now I am using
I387_ST0_REGNUM(tdep) [gdbarch] struct.
4) I have tried my level best to make formatting better.

please find the latest patch in next mail.

Regards,
Oza.


--- On Sun, 7/5/09, Hui Zhu <teawater@gmail.com> wrote:

> From: Hui Zhu <teawater@gmail.com>
> Subject: Re: i386.record.floating.point.patch : with more testing and assurity
> To: "paawan oza" <paawan1982@yahoo.com>
> Cc: "Michael Snyder" <msnyder@vmware.com>, "Mark Kettenis" <mark.kettenis@xs4all.nl>, "pedro@codesourcery.com" <pedro@codesourcery.com>, "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> Date: Sunday, July 5, 2009, 3:45 PM
> Hi Paawan,
> 
> 1.  gcc -g -O2   -I. -I../../src/gdb
> -I../../src/gdb/common
> -I../../src/gdb/config
> -DLOCALEDIR="\"/usr/local/share/locale\""
> -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode
> -I../../src/gdb/../readline/.. -I../bfd
> -I../../src/gdb/../bfd
> -I../../src/gdb/../include -I../libdecnumber
> -I../../src/gdb/../libdecnumber 
> -I../../src/gdb/gnulib -Ignulib
> -DMI_OUT=1 -DTUI=1  -Wall
> -Wdeclaration-after-statement
> -Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign
> -Wno-unused
> -Wno-switch -Wno-char-subscripts -Werror -c -o i386-tdep.o
> -MT
> i386-tdep.o -MMD -MP -MF .deps/i386-tdep.Tpo
> ../../src/gdb/i386-tdep.c
> cc1: warnings being treated as errors
> ../../src/gdb/i386-tdep.c: In function
> 'i386_process_record':
> ../../src/gdb/i386-tdep.c:4985: warning: implicit
> declaration of
> function 'paddr_nz'
> ../../src/gdb/i386-tdep.c:4985: warning: format '%s'
> expects type
> 'char *', but argument 2 has type 'int'
> make[2]: *** [i386-tdep.o] Error 1
> make[2]: Leaving directory `/media/disk/gdb/bgdb/gdb'
> make[1]: *** [all-gdb] Error 2
> make[1]: Leaving directory `/media/disk/gdb/bgdb'
> make: *** [all] Error 2
> 
> paddr_nz was removed.  Please update your patch follow
> cvs-head.
> 
> 2. +#define I386_SAVE_FPU_REGS   
>     0xFFFD
> +#define I386_SAVE_FPU_ENV   
>     0xFFFE
> +#define I386_SAVE_FPU_ENV_REG_STACK   
> 0xFFFF
> 
> They just used in prec right?  Maybe you can move them
> close to record
> code in i386-tedp.c.
> 
> 3. +static int i386_record_floats(struct i386_record_s *ir,
> uint32_t iregnum)
> +{
> +  int i;
> +
> +  /* Oza : push/pop of fpu stack is going to happen
> +     currently we store st0-st7
> registers, but we need not store all
> registers all the time.
> +     using fstatus, we use 11-13 bits
> which gives us stack top and
> hence we optimize our storage.
> +     alternatively we can use ftag
> register too */
> +  if (I386_SAVE_FPU_REGS == iregnum)
> +    {
> +      for
> (i=I386_ST0_REGNUM;i<=I386_ST0_REGNUM+7;i++)
> +        {
> +          if
> (record_arch_list_add_reg (ir->regcache,i))
> +            return -1;
> +        }
> +    }
> About the number of fp regs.  Please use the code:
> #define I387_ST0_REGNUM(tdep) ((tdep)->st0_regnum)
> #define I387_NUM_XMM_REGS(tdep) ((tdep)->num_xmm_regs)
> #define I387_MM0_REGNUM(tdep) ((tdep)->mm0_regnum)
> 
> #define I387_FCTRL_REGNUM(tdep) (I387_ST0_REGNUM (tdep) +
> 8)
> #define I387_FSTAT_REGNUM(tdep) (I387_FCTRL_REGNUM (tdep) +
> 1)
> #define I387_FTAG_REGNUM(tdep) (I387_FCTRL_REGNUM (tdep) +
> 2)
> #define I387_FISEG_REGNUM(tdep) (I387_FCTRL_REGNUM (tdep) +
> 3)
> #define I387_FIOFF_REGNUM(tdep) (I387_FCTRL_REGNUM (tdep) +
> 4)
> #define I387_FOSEG_REGNUM(tdep) (I387_FCTRL_REGNUM (tdep) +
> 5)
> #define I387_FOOFF_REGNUM(tdep) (I387_FCTRL_REGNUM (tdep) +
> 6)
> #define I387_FOP_REGNUM(tdep) (I387_FCTRL_REGNUM (tdep) +
> 7)
> #define I387_XMM0_REGNUM(tdep) (I387_ST0_REGNUM (tdep) +
> 16)
> #define I387_MXCSR_REGNUM(tdep) \
>   (I387_XMM0_REGNUM (tdep) + I387_NUM_XMM_REGS
> (tdep))
> 
> They are in i387-tdep.h.
> 
> And maybe you can try function i387_supply_fsave and
> i387_collect_fsave.
> 
> 
> 4.  Your code's format is not very well.  Please
> make it like the code in cvs.
> 
> 
> 
> Thanks,
> Hui
> 
> 
> 
> 
> On Sat, Jul 4, 2009 at 13:19, paawan oza<paawan1982@yahoo.com>
> wrote:
> >
> > Hi,
> >
> > Actually, the initial patch which I submitted were
> using them.
> > but as I have incorporated Hui's comments I have
> removed those constants completely.
> > in the sense I have no longer extended the
> enumration.
> >
> > but of course, those registers are recorded as and
> when required.
> > e.g. (ffree insn changes FTAG register, so we record
> it)
> >
> > Regards,
> > Oza.
> >
> > --- On Sat, 7/4/09, Michael Snyder <msnyder@vmware.com>
> wrote:
> >
> >> From: Michael Snyder <msnyder@vmware.com>
> >> Subject: Re: i386.record.floating.point.patch :
> with more testing and assurity
> >> To: "paawan oza" <paawan1982@yahoo.com>
> >> Cc: "Mark Kettenis" <mark.kettenis@xs4all.nl>,
> "pedro@codesourcery.com"
> <pedro@codesourcery.com>,
> "teawater@gmail.com"
> <teawater@gmail.com>,
> "gdb-patches@sourceware.org"
> <gdb-patches@sourceware.org>
> >> Date: Saturday, July 4, 2009, 3:19 AM
> >> paawan oza wrote:
> >> > Hi,
> >> >
> >> > In My understanding the point was like
> below.
> >> > in the patch there were following register
> extended in
> >> enumeration in i386-tdep.h
> >> >
> >> > I386_FSTAT,
> >> > I386_FTAG,       I386_FISEG,
> >> > I386_FIOFF,
> >> > I386_FOSEG,
> >> > I386_FOOFF,
> >> > I386_FOP
> >> >
> >> >
> >> > According to Hui in some of his previous
> mails...his
> >> idea was
> >> >> FCTRL, FOP and so on are the fp reg of
> >> amd64.  For now, prec is still
> >> >> not support amd64 And amd64's support are
> in
> >> amd64-tedp.... files.  >Change i386_regnum is
> not a
> >> good idea. I suggest you divide fp patch to 2
> >parts. One
> >> is for i386, the other for amd64. For now, just
> send i386
> >> patch >for review.  And send amd64 patch when
> prec
> >> support amd64"
> >> >
> >> >
> >> > while, my idea/understanding is:
> >> > FCTRL, FOP registers are not only a part of
> amd64, but
> >> also part of i386 (x87 FPU unit) also.
> >> > so according to me these registers are part
> of i386
> >> also and it needed to be also in i386-tdep.h.
> >> >
> >> > Regards,
> >> > Oza.
> >>
> >> I'm not sure why you want to add those constants
> to
> >> i386-tdep.h,
> >> when the rest of your patch does not seem to use
> them.
> >>
> >>
> >
> >
> >
> >
> 




^ permalink raw reply	[flat|nested] 40+ messages in thread
* Re: i386.record.floating.point.patch : with more testing and assurity
@ 2009-07-06 19:01 paawan oza
  0 siblings, 0 replies; 40+ messages in thread
From: paawan oza @ 2009-07-06 19:01 UTC (permalink / raw)
  To: Mark Kettenis; +Cc: gdb-patches, teawater


Hi,
All the comments by you are taken care. As far as possible I took care of spacing issues and commenting issues as suggested.
I will try to integrate test example with gdb testsuite.
I am sending a patch which includes yours and Hui's review comments.
Regards,
Oza.

--- On Mon, 7/6/09, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:

> From: Mark Kettenis <mark.kettenis@xs4all.nl>
> Subject: Re: i386.record.floating.point.patch : with more testing and assurity
> To: paawan1982@yahoo.com
> Cc: gdb-patches@sourceware.org, teawater@gmail.com
> Date: Monday, July 6, 2009, 12:03 AM
> > Date: Wed, 1 Jul 2009 09:17:41
> -0700 (PDT)
> > From: paawan oza <paawan1982@yahoo.com>
> > 
> > Hi,
> > 
> > For your review convenience, I am sending the patch in
> plain text as a part of email body.
> > please also refer to the previous mails, where a point
> is raised by Hui.
> > I provided justification for the same.
> > please help with the point to throw more light.
> 
> Please review the GNU coding standards.  Your new code
> has some
> formatting problems.
> 
> > TEST_CASE
> > ****************************************************
> > test_float.c
> > ****************************************************
> > #include <stdio.h>
> > #include <math.h>
> > #include <stdlib.h>
> > 
> > /* the test intends to test following insns.  
> > flds faddp fstps fstpl fldl fxch fabs fdivrp fmulp
> fsubrp fucomp fnstsw fsqrt
> > fchs f2xm1 fyl2x fxtract fprem1 fld fdecstp fld1
> fldl2t fldl2e FLDPI FLDLG2 FLDLN2
> > FLDZ fincstp ffree fptan fpatan fincstp fsincos
> frndint fscale fsin fcos fcmovb
> > fcmovbe fcmove fcmovu fcmovnb fcmovnbe fsave frstor
> fstsw 
> > */
> > 
> > float no1,no2,no3,no4,no5,no6,no7;
> > double x = 100.345, y = 25.7789;
> > long double ldx = 88888888888888888888.88, ldy =
> 9999999999999999999.99;
> > float result,resultd,resultld; 
> > float *float_memory;
> > 
> > /* initialization of floats */
> > void init_floats()
> > {
> >   no1 = 10.45;
> >   no2 = 20.77;
> >   no3 = 156.89874646;
> >   no4 = 14.56;
> >   no5 = 11.11;
> >   no6 = 66.77;
> >   no7 = 88.88;
> >   float_memory = malloc(sizeof(float) *
> 4);
> >   *float_memory = 256.256;
> >   *(float_memory + 1) = 356.356;
> >   *(float_memory + 2) = 456.456;
> >   *(float_memory + 3) = 556.556;
> > }
> > 
> > /* marks FPU stack as empty */
> > void empty_fpu_stack()
> > {
> >   asm ("ffree %st(1) \n\t"
> >        "ffree %st(2) \n\t"
> >        "ffree %st(3) \n\t"
> >        "ffree %st(4) \n\t"
> >        "ffree %st(5) \n\t"
> >        "ffree %st(6) \n\t"
> >        "ffree %st(7)");
> > }   
> > 
> > /* tests floating point arithmatic */
> > void test_arith_floats()
> > {
> >   result = no1 + no2 + no3 + no4 + no5
> + no6 + no7;
> >   printf("result is %f\n",result);
> > 
> >   result = fmodf(no2,no1); 
> >   printf("result is %f\n",result);
> > 
> >   resultd = fmod(x,y); 
> >   printf("result is %f\n",resultd);
> > 
> >   resultld = fmodl(ldy,ldy); 
> >   printf("result is %f\n",resultld);
> > 
> >   result = fabsf(no1);   
>     
> >   printf("result is %f\n",result);
> > 
> >   result = no3 / no4;
> >   printf("result is %f\n",result);
> > 
> >   result = no1 * no2 * no3 * no4;
> >   printf("result is %f\n",result);
> > 
> >   result = no1 - no2 - no3 - no4;
> >   printf("result is %f\n",result);
> > 
> > 
> >   asm ("fld %0" :
> :"m"(*float_memory));
> >   asm ("fchs");
> >   
> >   /* test for f2xm1 */  
> >   asm ("fld %0" : :"m"(*float_memory));
> 
> >   asm ("f2xm1");
> > 
> >   asm ("fyl2x");
> > 
> >   asm ("fld %0" : :"m"(*float_memory));
> 
> >   asm ("fxtract");
> > 
> >   asm ("fld %0" : :"m"(*float_memory));
> 
> >   asm ("fprem1");
> > 
> >   /* decrement fpu stack pointer only
> status register should get affected */
> >   asm ("fld %0" :
> :"m"(*float_memory));   
> >   
> >   empty_fpu_stack();
> >   
> >   asm ("fld1");
> >   asm ("fldl2t");
> >   asm ("fldl2e");
> >   asm ("fldpi");
> >   asm ("fldlg2");
> >   asm ("fldln2");
> >   asm ("fldz");
> > 
> >   empty_fpu_stack();
> >   /* finishing emptying the stack */
> >       
> >   result = sqrt(no3);
> >   printf("result is %f\n",result);
> > }
> > 
> > void test_log_exp_floats()
> > {
> >   result = log10(no3);
> >   printf("result is %f\n",result);
> > 
> >   result = log(no3);
> >   printf("result is %f\n",result);
> > 
> >   result = exp10(no3);
> >   printf("result is %f\n",result);
> > 
> >   result = exp(no3);
> >   printf("result is %f\n",result);
> > }
> > 
> > void test_trigo_floats()
> > {
> >   result = sin(30);
> >   printf("result is %f\n",result);
> > 
> >   result = cos(30);
> >   printf("result is %f\n",result);
> > 
> >   result = tan(30);
> >   printf("result is %f\n",result);
> > 
> >   result = atan(30);
> >   printf("result is %f\n",result);
> > 
> >   asm ("fld %0" : :"m"(*float_memory));
> 
> >   asm ("fptan");
> > 
> >   /* changes st1 and popping register
> stack */
> >   asm ("fpatan");  
> > 
> >   asm("fincstp");
> >   asm ("fld %0" : :"m"(float_memory));
> 
> >   asm ("fsincos");
> > 
> >   asm ("fld %0" : :"m"(*float_memory));
> 
> >   asm ("frndint");
> > 
> >   asm ("fld %0" :
> :"m"(*float_memory));
> >   asm ("fld %0" :
> :"m"(*(float_memory+1)));  
> >   asm ("fscale");
> > 
> >   empty_fpu_stack();
> > 
> >   asm ("fld %0" : :"m"(*float_memory));
> 
> >   asm ("fsin");
> >   asm ("fcos");
> > 
> >   /* currently we assume condition
> likely and always record the registers 
> >   code could be optimized only if the
> flag is set then record */
> >   asm ("fld %0" :
> :"m"(*float_memory));
> >   asm ("fld %0" :
> :"m"(*(float_memory+1)));  
> >   asm ("fcmovb %st(1), %st");
> >   asm ("fcmovbe %st(1), %st");
> >   asm ("fcmove %st(1), %st");
> >   asm ("fcmovu %st(1), %st");
> >   asm ("fcmovnb %st(1), %st");
> >   asm ("fcmovnbe %st(1), %st");
> > 
> >   empty_fpu_stack();
> >   /* finished emtyping the stack */
> > }
> > 
> > void test_compare_floats()
> > {
> >     ldy =
> 88888888888888888888.88;
> >     if (ldx == ldy)
> >       ldy =
> 7777777777777777777777777777.777;
> >     else
> >       ldy =
> 666666666666666666666666666.666;
> > }
> > 
> > /* test loading and saving of FPU environment */
> > void test_fpu_env()
> > {
> >   asm ("fsave %0" : "=m"(*float_memory)
> : );
> >   asm ("frstor %0" : :
> "m"(*float_memory));
> >   asm ("fstsw %ax");  
> > }
> > 
> > int main()
> > {
> >     init_floats();
> >     test_arith_floats();
> >     test_log_exp_floats();
> >     test_trigo_floats();
> >     test_compare_floats();
> >     test_fpu_env();
> > }
> 
> As other already indicated, you should really turn this
> into something
> that is integrated in the GDB testsuite.
> 
> > diff -urN gdb.orig/i386-tdep.c gdb.new/i386-tdep.c
> > --- gdb.orig/i386-tdep.c    2009-05-29
> 17:08:40.000000000 -0400
> > +++ gdb.new/i386-tdep.c    2009-06-01
> 20:02:23.000000000 -0400
> > @@ -543,6 +543,9 @@
> > /* The maximum number of saved registers.  This
> should include all
> >     registers mentioned above, and
> %eip.  */
> > #define I386_NUM_SAVED_REGS   
> I386_NUM_GREGS
> > +#define I386_SAVE_FPU_REGS       
> 0xFFFD
> > +#define I386_SAVE_FPU_ENV       
> 0xFFFE
> > +#define I386_SAVE_FPU_ENV_REG_STACK   
> 0xFFFF
> 
> What are these constants used for?  Do they have
> anything to do with
> the number of saved registers?  Also, please use
> lowercase for
> hexadecimal constants.
> 
> > struct i386_frame_cache
> > {
> > @@ -2985,6 +2988,54 @@
> >    return 0;
> > }
> > 
> > +/* Record the value of floating point registers which
> will be changed by the current instruction
> > +   to "record_arch_list".
> > +   return -1 if something is wrong.
> */  
> 
> Everey new sentence should start with a capital; everey
> full stop (.)
> should be followed by two spaces.  Also please wrap
> your comments such
> that fit in a 80-column wide screen.
> 
> > +
> > +static int i386_record_floats(struct i386_record_s
> *ir, uint32_t iregnum)
> 
> static int
> 
> > +{
> > +  int i;
> > +
> > +  /* Oza : push/pop of fpu stack is going to
> happen 
> > +     currently we store st0-st7
> registers, but we need not store all registers all the
> time.
> > +     using fstatus, we use 11-13
> bits which gives us stack top and hence we optimize our
> storage. */
> 
> Sorry, but I don't understand what you're saying here.
> 
> > +  if (I386_SAVE_FPU_REGS == iregnum)
> > +    {
> > +      for
> (i=I386_ST0_REGNUM;i<=I386_ST7_REGNUM;i++)
> 
> Spacing problems.
> 
> > +        {
> > +          if
> (record_arch_list_add_reg (ir->regcache,i))
> > +            return
> -1;    
> > +        }
> > +    }
> > +  else if (I386_SAVE_FPU_ENV == iregnum)
> > +    {
> > +      for
> (i=I386_FCTRL;i<=I386_FOP;i++)
> > +      {
> > +        if
> (record_arch_list_add_reg (ir->regcache,i))
> > +          return -1; 
>   
> > +      }
> > +    }
> > +  else if (I386_SAVE_FPU_ENV_REG_STACK ==
> iregnum)
> > +    {
> > +      for
> (i=I386_ST0_REGNUM;i<=I386_FOP;i++)
> > +      {
> > +        if
> (record_arch_list_add_reg (ir->regcache,i))
> > +          return -1; 
>   
> > +      }
> > +    }
> > +  else if (iregnum >= I386_ST0_REGNUM
> && iregnum <= I386_FOP)
> > +    {
> > +      if (record_arch_list_add_reg
> (ir->regcache,iregnum))
> > +        return -1;
> > +    }
> > +  else
> > +    {
> > +      /* param Error */
> 
> Capitalization; missing full stop.
> 
> > +      return -1;
> > +    } 
> > +  return 0;
> > +}
> > +
> > /* Parse the current instruction and record the values
> of the registers and
> >     memory that will be changed in
> current instruction to "record_arch_list".
> >     Return -1 if something wrong.
> */
> > @@ -4035,7 +4086,6 @@
> >        break;
> > 
> >        /* floats */
> > -      /* It just record the memory
> change of instrcution. */
> >      case 0xd8:
> >      case 0xd9:
> >      case 0xda:
> > @@ -4056,39 +4106,49 @@
> >         return -1;
> >       switch (ir.reg)
> >         {
> > -        case 0x00:
> > -        case 0x01:
> >         case 0x02:
> > -        case 0x03:
> > +        case 0x12:
> > +        case 0x22:
> > +        case 0x32:
> > +          /* for FCOM, FICOM
> nothing to do */
> 
> Please use lowercase for assembler mnemonics.
> 
> > +             
> break;
> > +            case 0x03:
> > +        case 0x13:
> > +        case 0x23:
> > +        case 0x33:
> > +            /* FCOMP,
> FICOMP pop FPU stack, store all */
> > +          if
> (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
> > +             
>   return -1;
> > +             
> break;
> > +        case 0x00:
> > +           
>    case 0x01:
> >         case 0x04:
> >         case 0x05:
> >         case 0x06:
> >         case 0x07:
> >         case 0x10:
> > -        case 0x11:
> > -        case 0x12:
> > -        case 0x13:
> > +           
>    case 0x11:
> >         case 0x14:
> >         case 0x15:
> >         case 0x16:
> >         case 0x17:
> >         case 0x20:
> >         case 0x21:
> > -        case 0x22:
> > -        case 0x23:
> >         case 0x24:
> >         case 0x25:
> >         case 0x26:
> >         case 0x27:
> >         case 0x30:
> >         case 0x31:
> > -        case 0x32:
> > -        case 0x33:
> >         case 0x34:
> >         case 0x35:
> >         case 0x36:
> >         case 0x37:
> > -          break;
> > +          /* FADD, FMUL,
> FSUB, FSUBR, FDIV, FDIVR, FIADD, FIMUL, FISUB, FISUBR,
> FIDIV, FIDIVR  
> > +             
> ModR/M.reg is an extension of code, always affects st(0)
> register */
> > +          if
> (i386_record_floats(&ir, I386_ST0_REGNUM))
> > +             
>   return -1;
> > +             
> break;             
>              
> >         case 0x08:
> >         case 0x0a:
> >         case 0x0b:
> > @@ -4096,6 +4156,7 @@
> >         case 0x19:
> >         case 0x1a:
> >         case 0x1b:
> > +        case 0x1d: 
> >         case 0x28:
> >         case 0x29:
> >         case 0x2a:
> > @@ -4103,11 +4164,16 @@
> >         case 0x38:
> >         case 0x39:
> >         case 0x3a:
> > -        case 0x3b:
> > +        case 0x3b:   
>    
> > +        case 0x3c: 
> > +        case 0x3d: 
> >           switch
> (ir.reg & 7)
> >         {
> >         case 0:
> > -          break;
> > +          /* FLD, FILD */
> > +              if
> (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
> > +             
>       return -1;    
> > +             
>     break;
> >         case 1:
> >           switch
> (ir.reg >> 4)
> >             {
> > @@ -4120,6 +4186,7 @@
> >         
>    return -1;
> >           
>    break;
> >         
>    case 3:
> > +             
> break;
> >         
>    default:
> >           
>    if (record_arch_list_add_mem (addr, 2))
> >         
>    return -1;
> > @@ -4130,15 +4197,42 @@
> >           switch
> (ir.reg >> 4)
> >             {
> >         
>    case 0:
> > +              if
> (record_arch_list_add_mem (addr, 4))
> > +            return -1;
> > +              if
> (3 == (ir.reg & 7))
> > +             
>           {
> > +             
>           /* FSTP m32fp */
> > +             
>   if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
> > +             
>     return -1;         
>               
> > +             
>           } 
> > +             
>         break;
> >         
>    case 1:
> >           
>    if (record_arch_list_add_mem (addr, 4))
> >         
>    return -1;
> > +              if
> ((3 == (ir.reg & 7)) || (5 == (ir.reg & 7)) || (7 ==
> (ir.reg & 7)))
> > +             
>           {
> > +             
>           /* FSTP */
> > +             
>   if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
> > +             
>     return -1;         
>               
> > +             
>           } 
> >           
>    break;
> >         
>    case 2:
> >           
>    if (record_arch_list_add_mem (addr, 8))
> >         
>    return -1;
> > +              if
> (3 == (ir.reg & 7))
> > +             
>           {
> > +             
>           /* FSTP m64fp */
> > +             
>   if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
> > +             
>     return -1;         
>               
> > +             
>           } 
> >           
>    break;
> >         
>    case 3:
> > +              if
> ((3 <= (ir.reg & 7)) && (6 <= (ir.reg
> & 7)))
> > +             
>           {
> > +             
>           /* FISTP, FBLD, FILD,
> FBSTP */
> > +             
>   if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
> > +             
>     return -1;         
>               
> > +             
>           }     
>                
>   
> >         
>    default:
> >           
>    if (record_arch_list_add_mem (addr, 2))
> >         
>    return -1;
> > @@ -4147,54 +4241,71 @@
> >           break;
> >         }
> >           break;
> > -        case 0x0c:
> > -        case 0x0d:
> > -        case 0x1d:
> > -        case 0x2c:
> > -        case 0x3c:
> > -        case 0x3d:
> > -          break;
> > -        case 0x0e:
> > +           case
> 0x0c:
> > +          /* FLDENV */
> > +          if
> (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
> > +            return
> -1;  
> > +             
> break;
> > +        case 0x0d: 
> > +              /*
> FLDCW */
> > +          if
> (i386_record_floats(&ir, I386_FCTRL))
> > +            return
> -1;  
> > +             
> break;
> > +        case 0x2c: 
> > +              /*
> FRTSTOR */
> > +          if
> (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
> > +            return
> -1;  
> > +          break; 
> > +        case 0x0e: 
> >           if
> (ir.dflag)
> >         {
> > -          if
> (record_arch_list_add_mem (addr, 28))
> > -            return -1;
> > +        if
> (record_arch_list_add_mem (addr, 28))
> > +          return -1;
> >         }
> >           else
> >         {
> > -          if
> (record_arch_list_add_mem (addr, 14))
> > -            return -1;
> > +        if
> (record_arch_list_add_mem (addr, 14))
> > +          return -1;
> >         }
> >           break;
> > -        case 0x0f:
> > -        case 0x2f:
> > +        case 0x0f:  
> > +        case 0x2f:  
> >           if
> (record_arch_list_add_mem (addr, 2))
> >         return -1;
> >           break;
> > -        case 0x1f:
> > -        case 0x3e:
> > +        case 0x1f:  
> > +        case 0x3e:  
> >           if
> (record_arch_list_add_mem (addr, 10))
> >         return -1;
> > +              /*
> FSTP, FBSTP */
> > +              if
> (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
> > +            return
> -1;               
>                
>   
> >           break;
> > -        case 0x2e:
> > +        case 0x2e: 
> >           if
> (ir.dflag)
> >         {
> > -          if
> (record_arch_list_add_mem (addr, 28))
> > -            return -1;
> > -          addr += 28;
> > +        if
> (record_arch_list_add_mem (addr, 28))
> > +          return -1;
> > +        addr += 28;
> >         }
> >           else
> >         {
> > -          if
> (record_arch_list_add_mem (addr, 14))
> > -            return -1;
> > -          addr += 14;
> > +        if
> (record_arch_list_add_mem (addr, 14))
> > +          return -1;
> > +        addr += 14;
> >         }
> >           if
> (record_arch_list_add_mem (addr, 80))
> >         return -1;
> > +              /*
> FSAVE */
> > +          if
> (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
> > +            return
> -1;   
> >           break;
> > -        case 0x3f:
> > +        case 0x3f: 
> >           if
> (record_arch_list_add_mem (addr, 8))
> >         return -1;
> > +        /* FISTP */
> > +              if
> (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
> > +            return
> -1;   
> >           break;
> >         default:
> >           ir.addr
> -= 2;
> > @@ -4202,9 +4313,180 @@
> >           goto
> no_support;
> >           break;
> >         }
> > -    }
> > +    }   
> > +        /* opcode is an extension
> of modR/M byte */     
> > +    else
> > +    { 
> > +          switch (opcode)
> > +            {
> > +            case 0xd8:
> > +              if
> (i386_record_floats(&ir, I386_ST0_REGNUM))
> > +             
>   return -1;    
> > +             
> break;
> > +            case
> 0xd9:    
> > +              if
> (0x0c == (ir.modrm >> 4))
> > +             
>   {
> > +             
>     if ((ir.modrm & 0x0f) <= 7)
> > +             
>       {
> > +             
>       if (i386_record_floats(&ir,
> I386_SAVE_FPU_REGS))
> > +             
>         return -1;    
> > +             
>       }
> > +             
>     else
> > +             
>       {
> > +             
>       if (i386_record_floats(&ir,
> I386_ST0_REGNUM))
> > +             
>         return -1;    
> > +             
>       /* if only st(0) is changing, then we
> have already recorded */
> > +             
>       if ((ir.modrm & 0x0f) - 0x08)
> > +             
>         {
> > +             
>         if (i386_record_floats(&ir,
> I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
> > +             
>           return -1;   
>                
>       
> > +             
>         } 
> > +             
>       }  
> > +             
>   }
> > +             
> else
> > +             
>   {
> > +             
>   switch(ir.modrm)
> > +             
>     {
> > +             
>     case 0xe0:
> > +             
>     case 0xe1:
> > +             
>     case 0xf0:
> > +             
>     case 0xf5:
> > +             
>     case 0xf8:
> > +             
>     case 0xfa:
> > +             
>     case 0xfc:
> > +             
>     case 0xfe:
> > +             
>     case 0xff:
> > +             
>       if (i386_record_floats(&ir,
> I386_ST0_REGNUM))
> > +             
>         return -1;
> > +             
>       break;       
>    
> > +             
>     case 0xf1:  
> > +             
>     case 0xf2:  
> > +             
>     case 0xf3:  
> > +             
>     case 0xf4:
> > +             
>     case 0xf6:        
> > +             
>     case 0xf7:    
> > +             
>     case 0xe8:  
> > +             
>     case 0xe9:  
> > +             
>     case 0xea:  
> > +             
>     case 0xeb:
> > +             
>     case 0xec:        
> > +             
>     case 0xed:    
> > +             
>     case 0xee:   
> > +             
>     case 0xf9:     
> > +             
>     case 0xfb:
> > +             
>       if (i386_record_floats(&ir,
> I386_SAVE_FPU_REGS))
> > +             
>         return -1;    
> > +             
>       break;
> > +             
>     case 0xfd: 
> > +             
>       if (i386_record_floats(&ir,
> I386_ST0_REGNUM))
> > +             
>         return -1;
> > +             
>       if (i386_record_floats(&ir,
> I386_ST1_REGNUM))
> > +             
>         return -1;
> > +             
>       break;
> > +             
>     } 
> > +              }
> > +             
> break;
> > +            case 0xda:
> > +              if
> (0xe9 == ir.modrm)
> > +             
>   {
> > +        if
> (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
> > +             
>     return -1;         
>           
> > +             
>   }
> > +              else
> if ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm
> >> 4))
> > +             
>   {
> > +             
>   if (i386_record_floats(&ir, I386_ST0_REGNUM))
> > +             
>     return -1;         
>           
> > +             
>   if (((ir.modrm & 0x0f) > 0) &&
> ((ir.modrm & 0x0f) <= 7))
> > +             
>     {
> > +             
>     if (i386_record_floats(&ir,
> I386_ST0_REGNUM + (ir.modrm & 0x0f)))
> > +             
>       return -1;       
>                
>   
> > +             
>     }
> > +             
>   else if ((ir.modrm & 0x0f) - 0x08)
> > +             
>     {
> > +          if
> (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm
> & 0x0f) - 0x08)))
> > +             
>       return -1;
> > +             
>     }
> > +             
>   }  
> > +             
> break; 
> > +            case 0xdb:
> > +              if
> (0xe3 == ir.modrm)
> > +             
>   {
> > +        if
> (i386_record_floats(&ir, I386_SAVE_FPU_ENV))
> > +             
>     return -1;         
>           
> > +             
>   }
> > +              else
> if ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm
> >> 4))
> > +             
>   {
> > +             
>   if (i386_record_floats(&ir, I386_ST0_REGNUM))
> > +             
>     return -1;         
>           
> > +             
>   if (((ir.modrm & 0x0f) > 0) &&
> ((ir.modrm & 0x0f) <= 7))
> > +             
>     {
> > +             
>     if (i386_record_floats(&ir,
> I386_ST0_REGNUM + (ir.modrm & 0x0f)))
> > +             
>       return -1;       
>                
>   
> > +             
>     }
> > +             
>   else if ((ir.modrm & 0x0f) - 0x08)
> > +             
>     {
> > +          if
> (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm
> & 0x0f) - 0x08)))
> > +             
>       return -1;
> > +             
>     }
> > +             
>   }  
> > +             
> break;
> > +            case 0xdc:
> > +              if
> ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >>
> 4) || (0x0f == ir.modrm >> 4))
> > +             
>   {
> > +             
>   if ((ir.modrm & 0x0f) <= 7)
> > +             
>     {
> > +             
>     if (i386_record_floats(&ir,
> I386_ST0_REGNUM + (ir.modrm & 0x0f)))
> > +             
>       return -1;       
>                
>   
> > +             
>     }
> > +             
>   else
> > +             
>     {
> > +          if
> (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm
> & 0x0f) - 0x08)))
> > +             
>       return -1;
> > +             
>     }
> > +             
>   }  
> > +           
>    break;
> > +            case
> 0xdd:             
> > +              if
> (0x0c == ir.modrm >> 4)
> > +             
>   {
> > +             
>     if (i386_record_floats(&ir,I386_FTAG))
> > +             
>       return -1;
> > +             
>   }
> > +              else
> if ((0x0d == ir.modrm >> 4) || (0x0e == ir.modrm
> >> 4))
> > +             
>   { 
> > +             
>     if ((ir.modrm & 0x0f) <= 7)
> > +             
>       {
> > +             
>         if (i386_record_floats(&ir,
> I386_ST0_REGNUM + (ir.modrm & 0x0f)))
> > +             
>           return -1; 
>    
> > +             
>       }
> > +             
>     else
> > +             
>       {
> > +             
>         if (i386_record_floats(&ir,
> I386_SAVE_FPU_REGS))
> > +             
>           return -1;
> > +             
>       }
> > +             
>   }            
> > +             
> break;
> > +            case 0xde:
> > +              if
> ((0x0c == ir.modrm >> 4) || (0x0e == ir.modrm >>
> 4) || (0x0f == ir.modrm >> 4) || (0xd9 == ir.modrm))
> > +             
>   {             
>      
> > +             
>     if (i386_record_floats(&ir,
> I386_SAVE_FPU_REGS))
> > +             
>       return -1;     
> > +             
>   }   
> > +             
> break;
> > +            case 0xdf:
> > +          if (0xe0 ==
> ir.modrm)
> > +             
>   {
> > +             
>     if (record_arch_list_add_reg (ir.regcache,
> I386_EAX_REGNUM))
> > +           
>    return -1;
> > +             
>   }
> > +              else
> if ((0x0f == ir.modrm >> 4) || (0x0e == ir.modrm
> >> 4))
> > +             
>   { 
> > +             
>     if (i386_record_floats(&ir,
> I386_SAVE_FPU_REGS))
> > +             
>       return -1;
> > +             
>   } 
> > +             
> break;
> > +            } 
>      
> > +        }     
>    
> >        break;
> > -
> >        /* string ops */
> >        /* movsS */
> >      case 0xa4:
> > @@ -4623,10 +4905,17 @@
> >        /* fwait */
> >        /* XXX */
> >      case 0x9b:
> > -      printf_unfiltered (_("Process
> record doesn't support instruction "
> > -           
>    "fwait.\n"));
> > -      ir.addr -= 1;
> > -      goto no_support;
> > +      if (target_read_memory (ir.addr,
> &tmpu8, 1))
> > +    {
> > +      if (record_debug)
> > +        printf_unfiltered
> (_("Process record: error reading memory at "
> > +             
>    "addr 0x%s len = 1.\n"),
> > +             
>      paddr_nz (ir.addr));
> > +      return -1;
> > +    }
> > +      opcode = (uint32_t) tmpu8;
> > +      ir.addr++;
> > +      goto reswitch; 
>    
> >        break;
> > 
> >        /* int3 */
> > diff -urN gdb.orig/i386-tdep.h gdb.new/i386-tdep.h
> > --- gdb.orig/i386-tdep.h    2009-05-17
> 17:56:44.000000000 -0400
> > +++ gdb.new/i386-tdep.h    2009-05-31
> 16:33:14.000000000 -0400
> > @@ -145,7 +145,22 @@
> >    I386_ES_REGNUM,     
>   /* %es */
> >    I386_FS_REGNUM,     
>   /* %fs */
> >    I386_GS_REGNUM,     
>   /* %gs */
> > -  I386_ST0_REGNUM        /*
> %st(0) */
> > +  I386_ST0_REGNUM,        /*
> %st(0) */
> > +  I386_ST1_REGNUM,        /*
> %st(1) */
> > +  I386_ST2_REGNUM,        /*
> %st(2) */
> > +  I386_ST3_REGNUM,        /*
> %st(3) */
> > +  I386_ST4_REGNUM,        /*
> %st(4) */
> > +  I386_ST5_REGNUM,        /*
> %st(5) */
> > +  I386_ST6_REGNUM,        /*
> %st(6) */
> > +  I386_ST7_REGNUM,        /*
> %st(7) */
> > +  I386_FCTRL,         
>   /* floating point env regs : FCTRL-FOP */ 
>   
> > +  I386_FSTAT,         
>          
> > +  I386_FTAG,         
>   
> > +  I386_FISEG,
> > +  I386_FIOFF,
> > +  I386_FOSEG,
> > +  I386_FOOFF,
> > +  I386_FOP
> > };
> 
> If you no longer need this, please remove this from your
> diff.
> 




^ permalink raw reply	[flat|nested] 40+ messages in thread
* Re: i386.record.floating.point.patch : with more testing and assurity
@ 2009-07-04  5:19 paawan oza
  2009-07-05 10:15 ` Hui Zhu
  0 siblings, 1 reply; 40+ messages in thread
From: paawan oza @ 2009-07-04  5:19 UTC (permalink / raw)
  To: Michael Snyder; +Cc: Mark Kettenis, pedro, teawater, gdb-patches


Hi,

Actually, the initial patch which I submitted were using them.
but as I have incorporated Hui's comments I have removed those constants completely.
in the sense I have no longer extended the enumration.

but of course, those registers are recorded as and when required.
e.g. (ffree insn changes FTAG register, so we record it)

Regards,
Oza.

--- On Sat, 7/4/09, Michael Snyder <msnyder@vmware.com> wrote:

> From: Michael Snyder <msnyder@vmware.com>
> Subject: Re: i386.record.floating.point.patch : with more testing and assurity
> To: "paawan oza" <paawan1982@yahoo.com>
> Cc: "Mark Kettenis" <mark.kettenis@xs4all.nl>, "pedro@codesourcery.com" <pedro@codesourcery.com>, "teawater@gmail.com" <teawater@gmail.com>, "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> Date: Saturday, July 4, 2009, 3:19 AM
> paawan oza wrote:
> > Hi,
> > 
> > In My understanding the point was like below.
> > in the patch there were following register extended in
> enumeration in i386-tdep.h
> > 
> > I386_FSTAT,
> > I386_FTAG,       I386_FISEG,
> > I386_FIOFF,
> > I386_FOSEG,
> > I386_FOOFF,
> > I386_FOP
> > 
> > 
> > According to Hui in some of his previous mails...his
> idea was
> >> FCTRL, FOP and so on are the fp reg of
> amd64.  For now, prec is still
> >> not support amd64 And amd64's support are in
> amd64-tedp.... files.  >Change i386_regnum is not a
> good idea. I suggest you divide fp patch to 2 >parts. One
> is for i386, the other for amd64. For now, just send i386
> patch >for review.  And send amd64 patch when prec
> support amd64"
> > 
> > 
> > while, my idea/understanding is:
> > FCTRL, FOP registers are not only a part of amd64, but
> also part of i386 (x87 FPU unit) also.
> > so according to me these registers are part of i386
> also and it needed to be also in i386-tdep.h.
> > 
> > Regards,
> > Oza.
> 
> I'm not sure why you want to add those constants to
> i386-tdep.h,
> when the rest of your patch does not seem to use them.
> 
> 




^ permalink raw reply	[flat|nested] 40+ messages in thread
* Re: i386.record.floating.point.patch : with more testing and assurity
@ 2009-07-02  7:40 paawan oza
  0 siblings, 0 replies; 40+ messages in thread
From: paawan oza @ 2009-07-02  7:40 UTC (permalink / raw)
  To: Hui Zhu, Pedro Alves, Mark Kettenis, Michael Snyder, gdb-patches


Hi,

please ignore my previous mail regarding patch, some symbols were missing.

I have incorporated the comments given by Hui. 
please find the latest patch in the email body. 

------------
ChangeLog
-----------
Current: gdb-6.8.50.20090531
2009-07-02  Oza  <paawan1982@yahoo.com>
        * i386-tdep.c: Support for floating point recording.


------------
README
-----------
Patch description:

-> Provides floating point support for i386  (reversible debugging:record-replay)
-> previously gdb was not recording floating point registers, now all the floating point registers which are likely to be changed by floating   point instructions, are recorded and replayed.
-> the patch intends to provide the full support for all i386 floating point instructions.

-----------------------------
test cases for the patch
----------------------------

#include <stdio.h>
#include <math.h>
#include <stdlib.h>

/* the test intends to test following insns.  
flds faddp fstps fstpl fldl fxch fabs fdivrp fmulp fsubrp fucomp fnstsw fsqrt
fchs f2xm1 fyl2x fxtract fprem1 fld fdecstp fld1 fldl2t fldl2e FLDPI FLDLG2 FLDLN2
FLDZ fincstp ffree fptan fpatan fincstp fsincos frndint fscale fsin fcos fcmovb
fcmovbe fcmove fcmovu fcmovnb fcmovnbe fsave frstor fstsw 
*/

float no1,no2,no3,no4,no5,no6,no7;
double x = 100.345, y = 25.7789;
long double ldx = 88888888888888888888.88, ldy = 9999999999999999999.99;
float result,resultd,resultld; 
float *float_memory;

/* initialization of floats */
void init_floats()
{
  no1 = 10.45;
  no2 = 20.77;
  no3 = 156.89874646;
  no4 = 14.56;
  no5 = 11.11;
  no6 = 66.77;
  no7 = 88.88;
  float_memory = malloc(sizeof(float) * 4);
  *float_memory = 256.256;
  *(float_memory + 1) = 356.356;
  *(float_memory + 2) = 456.456;
  *(float_memory + 3) = 556.556;
}

/* marks FPU stack as empty */
void empty_fpu_stack()
{
  asm ("ffree %st(1) \n\t"
       "ffree %st(2) \n\t"
       "ffree %st(3) \n\t"
       "ffree %st(4) \n\t"
       "ffree %st(5) \n\t"
       "ffree %st(6) \n\t"
       "ffree %st(7)");
}   

/* tests floating point arithmatic */
void test_arith_floats()
{
  result = no1 + no2 + no3 + no4 + no5 + no6 + no7;
  printf("result is %f\n",result);

  result = fmodf(no2,no1); 
  printf("result is %f\n",result);

  resultd = fmod(x,y); 
  printf("result is %f\n",resultd);

  resultld = fmodl(ldy,ldy); 
  printf("result is %f\n",resultld);

  result = fabsf(no1);        
  printf("result is %f\n",result);

  result = no3 / no4;
  printf("result is %f\n",result);

  result = no1 * no2 * no3 * no4;
  printf("result is %f\n",result);

  result = no1 - no2 - no3 - no4;
  printf("result is %f\n",result);


  asm ("fld %0" : :"m"(*float_memory));
  asm ("fchs");
  
  /* test for f2xm1 */  
  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("f2xm1");

  asm ("fyl2x");

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fxtract");

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fprem1");

  /* decrement fpu stack pointer only status register should get affected */
  asm ("fld %0" : :"m"(*float_memory));   
  
  empty_fpu_stack();
  
  asm ("fld1");
  asm ("fldl2t");
  asm ("fldl2e");
  asm ("fldpi");
  asm ("fldlg2");
  asm ("fldln2");
  asm ("fldz");

  empty_fpu_stack();
  /* finishing emptying the stack */
      
  result = sqrt(no3);
  printf("result is %f\n",result);
}

void test_log_exp_floats()
{
  result = log10(no3);
  printf("result is %f\n",result);

  result = log(no3);
  printf("result is %f\n",result);

  result = exp10(no3);
  printf("result is %f\n",result);

  result = exp(no3);
  printf("result is %f\n",result);
}

void test_trigo_floats()
{
  result = sin(30);
  printf("result is %f\n",result);

  result = cos(30);
  printf("result is %f\n",result);

  result = tan(30);
  printf("result is %f\n",result);

  result = atan(30);
  printf("result is %f\n",result);

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fptan");

  /* changes st1 and popping register stack */
  asm ("fpatan");  

  asm("fincstp");
  asm ("fld %0" : :"m"(float_memory)); 
  asm ("fsincos");

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("frndint");

  asm ("fld %0" : :"m"(*float_memory));
  asm ("fld %0" : :"m"(*(float_memory+1)));  
  asm ("fscale");

  empty_fpu_stack();

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fsin");
  asm ("fcos");

  /* currently we assume condition likely and always record the registers 
  code could be optimized only if the flag is set then record */
  asm ("fld %0" : :"m"(*float_memory));
  asm ("fld %0" : :"m"(*(float_memory+1)));  
  asm ("fcmovb %st(1), %st");
  asm ("fcmovbe %st(1), %st");
  asm ("fcmove %st(1), %st");
  asm ("fcmovu %st(1), %st");
  asm ("fcmovnb %st(1), %st");
  asm ("fcmovnbe %st(1), %st");

  empty_fpu_stack();
  /* finished emtyping the stack */
}

void test_compare_floats()
{
    ldy = 88888888888888888888.88;
    if (ldx == ldy)
      ldy = 7777777777777777777777777777.777;
    else
      ldy = 666666666666666666666666666.666;
}

/* test loading and saving of FPU environment */
void test_fpu_env()
{
  asm ("fsave %0" : "=m"(*float_memory) : );
  asm ("frstor %0" : : "m"(*float_memory));
  asm ("fstsw %ax");  
}

int main()
{
    init_floats();
    test_arith_floats();
    test_log_exp_floats();
    test_trigo_floats();
    test_compare_floats();
    test_fpu_env();
}


------------------------
i386.floats.prec.patch
-------------------------

diff -urN gdb.orig/i386-tdep.c gdb.new/i386-tdep.c
--- gdb.orig/i386-tdep.c	2009-05-29 17:08:40.000000000 -0400
+++ gdb.new/i386-tdep.c	2009-07-02 12:56:56.000000000 -0400
@@ -543,6 +543,9 @@
 /* The maximum number of saved registers.  This should include all
    registers mentioned above, and %eip.  */
 #define I386_NUM_SAVED_REGS	I386_NUM_GREGS
+#define I386_SAVE_FPU_REGS		0xFFFD
+#define I386_SAVE_FPU_ENV		0xFFFE
+#define I386_SAVE_FPU_ENV_REG_STACK	0xFFFF
 
 struct i386_frame_cache
 {
@@ -2985,6 +2988,55 @@
   return 0;
 }
 
+/* Record the value of floating point registers which will be changed by the current instruction
+   to "record_arch_list".
+   return -1 if something is wrong. */  
+
+static int i386_record_floats(struct i386_record_s *ir, uint32_t iregnum)
+{
+  int i;
+
+  /* Oza : push/pop of fpu stack is going to happen 
+     currently we store st0-st7 registers, but we need not store all registers all the time.
+     using fstatus, we use 11-13 bits which gives us stack top and hence we optimize our storage.
+     alternatively we can use ftag register too */
+  if (I386_SAVE_FPU_REGS == iregnum)
+    {
+      for (i=I386_ST0_REGNUM;i<=I386_ST0_REGNUM+7;i++)
+        {
+          if (record_arch_list_add_reg (ir->regcache,i))
+            return -1;    
+        }
+    }
+  else if (I386_SAVE_FPU_ENV == iregnum)
+    {
+      for (i=I386_ST0_REGNUM+8;i<=I386_ST0_REGNUM+15;i++)
+      {
+        if (record_arch_list_add_reg (ir->regcache,i))
+          return -1;    
+      }
+    }
+  else if (I386_SAVE_FPU_ENV_REG_STACK == iregnum)
+    {
+      for (i=I386_ST0_REGNUM;i<=I386_ST0_REGNUM+15;i++)
+      {
+        if (record_arch_list_add_reg (ir->regcache,i))
+          return -1;    
+      }
+    }
+  else if (iregnum >= I386_ST0_REGNUM && iregnum <= I386_ST0_REGNUM+15)
+    {
+      if (record_arch_list_add_reg (ir->regcache,iregnum))
+        return -1;
+    }
+  else
+    {
+      /* param Error */
+      return -1;
+    } 
+  return 0;
+}
+
 /* Parse the current instruction and record the values of the registers and
    memory that will be changed in current instruction to "record_arch_list".
    Return -1 if something wrong. */
@@ -4035,7 +4087,6 @@
       break;
 
       /* floats */
-      /* It just record the memory change of instrcution. */
     case 0xd8:
     case 0xd9:
     case 0xda:
@@ -4056,39 +4107,49 @@
 	    return -1;
 	  switch (ir.reg)
 	    {
-	    case 0x00:
-	    case 0x01:
 	    case 0x02:
-	    case 0x03:
+	    case 0x12:
+	    case 0x22:
+	    case 0x32:
+	      /* for FCOM, FICOM nothing to do */
+              break;
+            case 0x03:
+	    case 0x13:
+	    case 0x23:
+	    case 0x33:
+  	      /* FCOMP, FICOMP pop FPU stack, store all */
+	      if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                return -1;
+              break;
+	    case 0x00:
+       	    case 0x01:
 	    case 0x04:
 	    case 0x05:
 	    case 0x06:
 	    case 0x07:
 	    case 0x10:
-	    case 0x11:
-	    case 0x12:
-	    case 0x13:
+       	    case 0x11:
 	    case 0x14:
 	    case 0x15:
 	    case 0x16:
 	    case 0x17:
 	    case 0x20:
 	    case 0x21:
-	    case 0x22:
-	    case 0x23:
 	    case 0x24:
 	    case 0x25:
 	    case 0x26:
 	    case 0x27:
 	    case 0x30:
 	    case 0x31:
-	    case 0x32:
-	    case 0x33:
 	    case 0x34:
 	    case 0x35:
 	    case 0x36:
 	    case 0x37:
-	      break;
+	      /* FADD, FMUL, FSUB, FSUBR, FDIV, FDIVR, FIADD, FIMUL, FISUB, FISUBR, FIDIV, FIDIVR  
+              ModR/M.reg is an extension of code, always affects st(0) register */
+	      if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                return -1;
+              break;           	    	    
 	    case 0x08:
 	    case 0x0a:
 	    case 0x0b:
@@ -4096,6 +4157,7 @@
 	    case 0x19:
 	    case 0x1a:
 	    case 0x1b:
+	    case 0x1d: 
 	    case 0x28:
 	    case 0x29:
 	    case 0x2a:
@@ -4103,11 +4165,16 @@
 	    case 0x38:
 	    case 0x39:
 	    case 0x3a:
-	    case 0x3b:
+	    case 0x3b:	   
+	    case 0x3c: 
+	    case 0x3d: 
 	      switch (ir.reg & 7)
 		{
 		case 0:
-		  break;
+		  /* FLD, FILD */
+	          if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                    return -1;    
+                  break;
 		case 1:
 		  switch (ir.reg >> 4)
 		    {
@@ -4120,6 +4187,7 @@
 			return -1;
 		      break;
 		    case 3:
+		      break;
 		    default:
 		      if (record_arch_list_add_mem (addr, 2))
 			return -1;
@@ -4130,15 +4198,42 @@
 		  switch (ir.reg >> 4)
 		    {
 		    case 0:
+		      if (record_arch_list_add_mem (addr, 4))
+			return -1;
+		      if (3 == (ir.reg & 7))
+                        {
+                        /* FSTP m32fp */
+		        if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        } 
+                      break;
 		    case 1:
 		      if (record_arch_list_add_mem (addr, 4))
 			return -1;
+		      if ((3 == (ir.reg & 7)) || (5 == (ir.reg & 7)) || (7 == (ir.reg & 7)))
+                        {
+                        /* FSTP */
+		        if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        } 
 		      break;
 		    case 2:
 		      if (record_arch_list_add_mem (addr, 8))
 			return -1;
+		      if (3 == (ir.reg & 7))
+                        {
+                        /* FSTP m64fp */
+		        if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        } 
 		      break;
 		    case 3:
+		      if ((3 <= (ir.reg & 7)) && (6 <= (ir.reg & 7)))
+                        {
+                        /* FISTP, FBLD, FILD, FBSTP */
+		        if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        }                        
 		    default:
 		      if (record_arch_list_add_mem (addr, 2))
 			return -1;
@@ -4147,54 +4242,71 @@
 		  break;
 		}
 	      break;
-	    case 0x0c:
-	    case 0x0d:
-	    case 0x1d:
-	    case 0x2c:
-	    case 0x3c:
-	    case 0x3d:
-	      break;
-	    case 0x0e:
+   	    case 0x0c:
+	      /* FLDENV */
+	      if (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
+	        return -1;  
+              break;
+	    case 0x0d: 
+              /* FLDCW */
+	      if (i386_record_floats(&ir, I386_ST0_REGNUM + 8))
+	        return -1;  
+              break;
+	    case 0x2c: 
+              /* FRTSTOR */
+	      if (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
+	        return -1;  
+	      break; 
+	    case 0x0e: 
 	      if (ir.dflag)
 		{
-		  if (record_arch_list_add_mem (addr, 28))
-		    return -1;
+		if (record_arch_list_add_mem (addr, 28))
+		  return -1;
 		}
 	      else
 		{
-		  if (record_arch_list_add_mem (addr, 14))
-		    return -1;
+		if (record_arch_list_add_mem (addr, 14))
+		  return -1;
 		}
 	      break;
-	    case 0x0f:
-	    case 0x2f:
+	    case 0x0f:  
+	    case 0x2f:  
 	      if (record_arch_list_add_mem (addr, 2))
 		return -1;
 	      break;
-	    case 0x1f:
-	    case 0x3e:
+	    case 0x1f:  
+	    case 0x3e:  
 	      if (record_arch_list_add_mem (addr, 10))
 		return -1;
+              /* FSTP, FBSTP */
+              if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+	        return -1;                                  
 	      break;
-	    case 0x2e:
+	    case 0x2e: 
 	      if (ir.dflag)
 		{
-		  if (record_arch_list_add_mem (addr, 28))
-		    return -1;
-		  addr += 28;
+		if (record_arch_list_add_mem (addr, 28))
+		  return -1;
+		addr += 28;
 		}
 	      else
 		{
-		  if (record_arch_list_add_mem (addr, 14))
-		    return -1;
-		  addr += 14;
+		if (record_arch_list_add_mem (addr, 14))
+		  return -1;
+		addr += 14;
 		}
 	      if (record_arch_list_add_mem (addr, 80))
 		return -1;
+              /* FSAVE */
+	      if (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
+	        return -1;   
 	      break;
-	    case 0x3f:
+	    case 0x3f: 
 	      if (record_arch_list_add_mem (addr, 8))
 		return -1;
+		/* FISTP */
+              if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+	        return -1;   
 	      break;
 	    default:
 	      ir.addr -= 2;
@@ -4202,9 +4314,180 @@
 	      goto no_support;
 	      break;
 	    }
-	}
+	}   
+        /* opcode is an extension of modR/M byte */     
+	else
+	{ 
+          switch (opcode)
+            {
+            case 0xd8:
+              if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                return -1;	
+              break;
+            case 0xd9:    
+              if (0x0c == (ir.modrm >> 4))
+                {
+                  if ((ir.modrm & 0x0f) <= 7)
+                    {
+                    if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                      return -1;	
+                    }
+                  else
+                    {
+                    if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                      return -1;	
+                    /* if only st(0) is changing, then we have already recorded */
+                    if ((ir.modrm & 0x0f) - 0x08)
+                      {
+                      if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                        return -1;	                      
+                      } 
+                    }  
+                }
+              else
+                {
+                switch(ir.modrm)
+                  {
+                  case 0xe0:
+                  case 0xe1:
+                  case 0xf0:
+                  case 0xf5:
+                  case 0xf8:
+                  case 0xfa:
+                  case 0xfc:
+                  case 0xfe:
+                  case 0xff:
+                    if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                      return -1;
+                    break;           
+                  case 0xf1:  
+                  case 0xf2:  
+                  case 0xf3:  
+                  case 0xf4:
+		  case 0xf6: 
+                  case 0xf7:    
+                  case 0xe8:  
+                  case 0xe9:  
+                  case 0xea:  
+                  case 0xeb:
+                  case 0xec:        
+                  case 0xed:    
+                  case 0xee:   
+                  case 0xf9:     
+                  case 0xfb:
+                    if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                      return -1;	
+                    break;
+                  case 0xfd: 
+                    if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                      return -1;
+                    if (i386_record_floats(&ir, I386_ST0_REGNUM + 1))
+                      return -1;
+                    break;
+                  } 
+              }
+              break;
+            case 0xda:
+              if (0xe9 == ir.modrm)
+                {
+		if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                  return -1;                    
+                }
+              else if ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >> 4))
+                {
+                if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                  return -1;	                
+                if (((ir.modrm & 0x0f) > 0) && ((ir.modrm & 0x0f) <= 7))
+                  {
+                  if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                    return -1;	                      
+                  }
+                else if ((ir.modrm & 0x0f) - 0x08)
+                  {
+		  if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                    return -1;
+                  }
+                }  
+              break; 
+            case 0xdb:
+              if (0xe3 == ir.modrm)
+                {
+		if (i386_record_floats(&ir, I386_SAVE_FPU_ENV))
+                  return -1;                    
+                }
+              else if ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >> 4))
+                {
+                if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                  return -1;	                
+                if (((ir.modrm & 0x0f) > 0) && ((ir.modrm & 0x0f) <= 7))
+                  {
+                  if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                    return -1;	                      
+                  }
+                else if ((ir.modrm & 0x0f) - 0x08)
+                  {
+		  if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                    return -1;
+                  }
+                }  
+              break;
+            case 0xdc:
+              if ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >> 4) || (0x0f == ir.modrm >> 4))
+                {
+                if ((ir.modrm & 0x0f) <= 7)
+                  {
+                  if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                    return -1;	                      
+                  }
+                else
+                  {
+		  if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                    return -1;
+                  }
+                }  
+               break;
+            case 0xdd:             
+              if (0x0c == ir.modrm >> 4)
+                {
+                  if (i386_record_floats(&ir,I386_ST0_REGNUM + 10))
+                    return -1;
+                }
+              else if ((0x0d == ir.modrm >> 4) || (0x0e == ir.modrm >> 4))
+                { 
+                  if ((ir.modrm & 0x0f) <= 7)
+                    {
+                      if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                        return -1;	 
+                    }
+                  else
+                    {
+                      if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                        return -1;
+                    }
+                }            
+              break;
+            case 0xde:
+              if ((0x0c == ir.modrm >> 4) || (0x0e == ir.modrm >> 4) || (0x0f == ir.modrm >> 4) || (0xd9 == ir.modrm))
+                {                   
+                  if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                    return -1;	 
+                }   
+              break;
+            case 0xdf:
+	      if (0xe0 == ir.modrm)
+                {
+                  if (record_arch_list_add_reg (ir.regcache, I386_EAX_REGNUM))
+	   	    return -1;
+                }
+              else if ((0x0f == ir.modrm >> 4) || (0x0e == ir.modrm >> 4))
+                { 
+                  if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                    return -1;
+                } 
+              break;
+            } 	  
+        }         
       break;
-
       /* string ops */
       /* movsS */
     case 0xa4:
@@ -4623,10 +4906,17 @@
       /* fwait */
       /* XXX */
     case 0x9b:
-      printf_unfiltered (_("Process record doesn't support instruction "
-			   "fwait.\n"));
-      ir.addr -= 1;
-      goto no_support;
+      if (target_read_memory (ir.addr, &tmpu8, 1))
+	{
+	  if (record_debug)
+	    printf_unfiltered (_("Process record: error reading memory at "
+				 "addr 0x%s len = 1.\n"),
+			       paddr_nz (ir.addr));
+	  return -1;
+	}
+      opcode = (uint32_t) tmpu8;
+      ir.addr++;
+      goto reswitch;     
       break;
 
       /* int3 */





--- On Thu, 7/2/09, Hui Zhu <teawater@gmail.com> wrote:

> From: Hui Zhu <teawater@gmail.com>
> Subject: Re: i386.record.floating.point.patch : with more testing and assurity
> To: "paawan oza" <paawan1982@yahoo.com>
> Cc: "Pedro Alves" <pedro@codesourcery.com>, "Mark Kettenis" <mark.kettenis@xs4all.nl>, "Michael Snyder" <msnyder@vmware.com>, gdb-patches@sourceware.org
> Date: Thursday, July 2, 2009, 7:31 AM
> On Wed, Jul 1, 2009 at 23:59, paawan
> oza<paawan1982@yahoo.com>
> wrote:
> >
> > Hi Hui,
> >
> > As I clarified earlier,
> > these registers are already supported and extended by
> gdb much before this patch.
> > all floating point registers are already supported by
> gdb
> > (info floats/info all-registers command gives it)
> >
> > My aim is : only to make sure that whenever any
> floating point insn gets executed, we record the registers
> > (no matter whether it is %st(n) or FCTRL or FTAG or
> FSTATUS)
> > there are insns
> > e.g. 'ffree' changes FTAG register, so we must record
> it.
> >
> > Do you mean to say that we should remove it from just
> enumaration ?
> > but anyway we need to record those registers.
> >
> 
> You are working on make prec x86 support fp insn, not to
> extend the fp
> function of i386 (If you want, you can make a special patch
> for it).
> 
> 
> 
> 
> >
> > --- On Wed, 7/1/09, Hui Zhu <teawater@gmail.com>
> wrote:
> >
> >> From: Hui Zhu <teawater@gmail.com>
> >> Subject: Re: i386.record.floating.point.patch :
> with more testing and assurity
> >> To: "paawan oza" <paawan1982@yahoo.com>,
> "Pedro Alves" <pedro@codesourcery.com>,
> "Mark Kettenis" <mark.kettenis@xs4all.nl>,
> "Michael Snyder" <msnyder@vmware.com>
> >> Cc: gdb-patches@sourceware.org
> >> Date: Wednesday, July 1, 2009, 11:23 AM
> >> About this patch, I say my idea
> >> again, I told in
> >> http://sourceware.org/ml/gdb-patches/2009-06/msg00014.html
> >> @@ -145,7 +145,22 @@
> >>    I386_ES_REGNUM,
> >>     /* %es */
> >>    I386_FS_REGNUM,
> >>     /* %fs */
> >>    I386_GS_REGNUM,
> >>     /* %gs */
> >> -  I386_ST0_REGNUM
> >>     /* %st(0) */
> >> +  I386_ST0_REGNUM,
> >>     /* %st(0) */
> >> +  I386_ST1_REGNUM,
> >>     /* %st(1) */
> >> +  I386_ST2_REGNUM,
> >>     /* %st(2) */
> >> +  I386_ST3_REGNUM,
> >>     /* %st(3) */
> >> +  I386_ST4_REGNUM,
> >>     /* %st(4) */
> >> +  I386_ST5_REGNUM,
> >>     /* %st(5) */
> >> +  I386_ST6_REGNUM,
> >>     /* %st(6) */
> >> +  I386_ST7_REGNUM,
> >>     /* %st(7) */
> >> +  I386_FCTRL,
> >>     /* floating point env regs : FCTRL-FOP
> >> */
> >> +  I386_FSTAT,
> >> +  I386_FTAG,
> >>
> >> +  I386_FISEG,
> >> +  I386_FIOFF,
> >> +  I386_FOSEG,
> >> +  I386_FOOFF,
> >> +  I386_FOP
> >>  };
> >>
> >> You are working on make prec x86 support fp insn,
> not to
> >> extend the fp
> >> function of i386 (If you want, you can make a
> special patch
> >> for it).
> >>
> >> Hui
> >>
> >> On Tue, Jun 30, 2009 at 23:05, paawan oza<paawan1982@yahoo.com>
> >> wrote:
> >> >
> >> > Hi,
> >> > As I am submitting the patch for the first
> time, I am
> >> not much aware of gdb test suite.
> >> > would you please guide me about how I can put
> the
> >> things in the testsuite ?
> >> > is it the testsuite which comes along with
> the gdb
> >> source ?
> >> > gdb\testsuite\gdb.base ??
> >> > Regards,
> >> > Oza.
> >> >
> >> > --- On Tue, 6/30/09, Pedro Alves <pedro@codesourcery.com>
> >> wrote:
> >> >
> >> >> From: Pedro Alves <pedro@codesourcery.com>
> >> >> Subject: Re:
> i386.record.floating.point.patch :
> >> with more testing and assurity
> >> >> To: gdb-patches@sourceware.org
> >> >> Cc: "paawan oza" <paawan1982@yahoo.com>,
> >> teawater@gmail.com
> >> >> Date: Tuesday, June 30, 2009, 7:09 PM
> >> >> On Tuesday 30 June 2009 14:23:30,
> >> >> paawan oza wrote:
> >> >> >
> >> >> > > As suggested by Hui,
> >> >> > > I have come up with more
> detailed and
> >> granular
> >> >> test case
> >> >> > > for the patch which I had
> submitted last
> >> week.
> >> >>
> >> >> Could you please consider migrating that
> test into
> >> the
> >> >> testsuite?
> >> >> You've gone through the trouble of
> writing tests
> >> to make
> >> >> sure
> >> >> the features work now --- putting it in
> the
> >> testsuite means
> >> >> we
> >> >> have an automatic-ish means to check that
> it
> >> doesn't get
> >> >> inadvertently broken in the future.  The
> way it
> >> is,
> >> >> when your
> >> >> code gets in, the test will probably end
> up lost
> >> in the
> >> >> archives.
> >> >> We wouldn't want that, would we?  :-) 
> Having
> >> >> auto-tests, also helps
> >> >> the person doing the review in confirming
> things
> >> work as
> >> >> expected (without much effort).
> >> >>
> >> >> --
> >> >> Pedro Alves
> >> >>
> >> >
> >> >
> >> >
> >> >
> >>
> >
> >
> >
> >
> 




^ permalink raw reply	[flat|nested] 40+ messages in thread
* Re: i386.record.floating.point.patch : with more testing and assurity
@ 2009-07-02  3:39 paawan oza
  0 siblings, 0 replies; 40+ messages in thread
From: paawan oza @ 2009-07-02  3:39 UTC (permalink / raw)
  To: Pedro Alves, Mark Kettenis, Michael Snyder, gdb-patches, Hui Zhu


Hi,

I have incorporated the comments of Hui. please find the new patch in the email body.

------------
ChangeLog
-----------
Current: gdb-6.8.50.20090531
2009-07-02  Oza  <paawan1982@yahoo.com>
        * i386-tdep.c: Support for floating point recording.


------------
README
-----------
Patch description:

-> Provides floating point support for i386  (reversible debugging:record-replay)
-> previously gdb was not recording floating point registers, now all the floating point registers which are likely to be changed by floating   point instructions, are recorded and replayed.
-> the patch intends to provide the full support for all i386 floating point instructions.

-----------------------------
test cases  for the patch
----------------------------

#include <stdio.h>
#include <math.h>
#include <stdlib.h>

/* the test intends to test following insns.  
flds faddp fstps fstpl fldl fxch fabs fdivrp fmulp fsubrp fucomp fnstsw fsqrt
fchs f2xm1 fyl2x fxtract fprem1 fld fdecstp fld1 fldl2t fldl2e FLDPI FLDLG2 FLDLN2
FLDZ fincstp ffree fptan fpatan fincstp fsincos frndint fscale fsin fcos fcmovb
fcmovbe fcmove fcmovu fcmovnb fcmovnbe fsave frstor fstsw 
*/

float no1,no2,no3,no4,no5,no6,no7;
double x = 100.345, y = 25.7789;
long double ldx = 88888888888888888888.88, ldy = 9999999999999999999.99;
float result,resultd,resultld; 
float *float_memory;

/* initialization of floats */
void init_floats()
{
  no1 = 10.45;
  no2 = 20.77;
  no3 = 156.89874646;
  no4 = 14.56;
  no5 = 11.11;
  no6 = 66.77;
  no7 = 88.88;
  float_memory = malloc(sizeof(float) * 4);
  *float_memory = 256.256;
  *(float_memory + 1) = 356.356;
  *(float_memory + 2) = 456.456;
  *(float_memory + 3) = 556.556;
}

/* marks FPU stack as empty */
void empty_fpu_stack()
{
  asm ("ffree %st(1) \n\t"
       "ffree %st(2) \n\t"
       "ffree %st(3) \n\t"
       "ffree %st(4) \n\t"
       "ffree %st(5) \n\t"
       "ffree %st(6) \n\t"
       "ffree %st(7)");
}   

/* tests floating point arithmatic */
void test_arith_floats()
{
  result = no1 + no2 + no3 + no4 + no5 + no6 + no7;
  printf("result is %f\n",result);

  result = fmodf(no2,no1); 
  printf("result is %f\n",result);

  resultd = fmod(x,y); 
  printf("result is %f\n",resultd);
 
  resultld = fmodl(ldy,ldy); 
  printf("result is %f\n",resultld);

  result = fabsf(no1);        
  printf("result is %f\n",result);

  result = no3 / no4;
  printf("result is %f\n",result);

  result = no1 * no2 * no3 * no4;
  printf("result is %f\n",result);

  result = no1 - no2 - no3 - no4;
  printf("result is %f\n",result);


  asm ("fld %0" : :"m"(*float_memory));
  asm ("fchs");
  
  /* test for f2xm1 */  
  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("f2xm1");

  asm ("fyl2x");

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fxtract");

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fprem1");

  /* decrement fpu stack pointer only status register should get affected */
  asm ("fld %0" : :"m"(*float_memory));   
  
  empty_fpu_stack();
  
  asm ("fld1");
  asm ("fldl2t");
  asm ("fldl2e");
  asm ("fldpi");
  asm ("fldlg2");
  asm ("fldln2");
  asm ("fldz");

  empty_fpu_stack();
  /* finishing emptying the stack */
      
  result = sqrt(no3);
  printf("result is %f\n",result);
}

void test_log_exp_floats()
{
  result = log10(no3);
  printf("result is %f\n",result);

  result = log(no3);
  printf("result is %f\n",result);

  result = exp10(no3);
  printf("result is %f\n",result);

  result = exp(no3);
  printf("result is %f\n",result);
}

void test_trigo_floats()
{
  result = sin(30);
  printf("result is %f\n",result);

  result = cos(30);
  printf("result is %f\n",result);

  result = tan(30);
  printf("result is %f\n",result);

  result = atan(30);
  printf("result is %f\n",result);

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fptan");

  /* changes st1 and popping register stack */
  asm ("fpatan");  

  asm("fincstp");
  asm ("fld %0" : :"m"(float_memory)); 
  asm ("fsincos");

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("frndint");

  asm ("fld %0" : :"m"(*float_memory));
  asm ("fld %0" : :"m"(*(float_memory+1)));  
  asm ("fscale");

  empty_fpu_stack();

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fsin");
  asm ("fcos");

  /* currently we assume condition likely and always record the registers 
  code could be optimized only if the flag is set then record */
  asm ("fld %0" : :"m"(*float_memory));
  asm ("fld %0" : :"m"(*(float_memory+1)));  
  asm ("fcmovb %st(1), %st");
  asm ("fcmovbe %st(1), %st");
  asm ("fcmove %st(1), %st");
  asm ("fcmovu %st(1), %st");
  asm ("fcmovnb %st(1), %st");
  asm ("fcmovnbe %st(1), %st");

  empty_fpu_stack();
  /* finished emtyping the stack */
}

void test_compare_floats()
{
    ldy = 88888888888888888888.88;
    if (ldx == ldy)
      ldy = 7777777777777777777777777777.777;
    else
      ldy = 666666666666666666666666666.666;
}

/* test loading and saving of FPU environment */
void test_fpu_env()
{
  asm ("fsave %0" : "=m"(*float_memory) : );
  asm ("frstor %0" : : "m"(*float_memory));
  asm ("fstsw %ax");  
}

int main()
{
    init_floats();
    test_arith_floats();
    test_log_exp_floats();
    test_trigo_floats();
    test_compare_floats();
    test_fpu_env();
}


-----------
patch
-----------

diff -urN gdb.orig/i386-tdep.c gdb.new/i386-tdep.c
--- gdb.orig/i386-tdep.c	2009-05-29 17:08:40.000000000 -0400
+++ gdb.new/i386-tdep.c	2009-07-02 08:44:37.000000000 -0400
@@ -543,6 +543,9 @@
 /* The maximum number of saved registers.  This should include all
    registers mentioned above, and %eip.  */
 #define I386_NUM_SAVED_REGS	I386_NUM_GREGS
+#define I386_SAVE_FPU_REGS		0xFFFD
+#define I386_SAVE_FPU_ENV		0xFFFE
+#define I386_SAVE_FPU_ENV_REG_STACK	0xFFFF
 
 struct i386_frame_cache
 {
@@ -2985,6 +2988,55 @@
   return 0;
 }
 
+/* Record the value of floating point registers which will be changed by the current instruction
+   to "record_arch_list".
+   return -1 if something is wrong. */  
+
+static int i386_record_floats(struct i386_record_s *ir, uint32_t iregnum)
+{
+  int i;
+
+  /* Oza : push/pop of fpu stack is going to happen 
+     currently we store st0-st7 registers, but we need not store all registers all the time.
+     using fstatus, we use 11-13 bits which gives us stack top and hence we optimize our storage.
+     alternatively we can use ftag register too */
+  if (I386_SAVE_FPU_REGS == iregnum)
+    {
+      for (i=I386_ST0_REGNUM;i<=I386_ST0_REGNUM+7;i++)
+        {
+          if (record_arch_list_add_reg (ir->regcache,i))
+            return -1;    
+        }
+    }
+  else if (I386_SAVE_FPU_ENV == iregnum)
+    {
+      for (i=I386_ST0_REGNUM+8;i<=I386_ST0_REGNUM+15;i++)
+      {
+        if (record_arch_list_add_reg (ir->regcache,i))
+          return -1;    
+      }
+    }
+  else if (I386_SAVE_FPU_ENV_REG_STACK == iregnum)
+    {
+      for (i=I386_ST0_REGNUM;i<=I386_ST0_REGNUM+15;i++)
+      {
+        if (record_arch_list_add_reg (ir->regcache,i))
+          return -1;    
+      }
+    }
+  else if (iregnum >= I386_ST0_REGNUM && iregnum <= I386_ST0_REGNUM+15)
+    {
+      if (record_arch_list_add_reg (ir->regcache,iregnum))
+        return -1;
+    }
+  else
+    {
+      /* param Error */
+      return -1;
+    } 
+  return 0;
+}
+
 /* Parse the current instruction and record the values of the registers and
    memory that will be changed in current instruction to "record_arch_list".
    Return -1 if something wrong. */
@@ -4035,7 +4087,6 @@
       break;
 
       /* floats */
-      /* It just record the memory change of instrcution. */
     case 0xd8:
     case 0xd9:
     case 0xda:
@@ -4056,39 +4107,49 @@
 	    return -1;
 	  switch (ir.reg)
 	    {
-	    case 0x00:
-	    case 0x01:
 	    case 0x02:
-	    case 0x03:
+	    case 0x12:
+	    case 0x22:
+	    case 0x32:
+	      /* for FCOM, FICOM nothing to do */
+              break;
+            case 0x03:
+	    case 0x13:
+	    case 0x23:
+	    case 0x33:
+  	      /* FCOMP, FICOMP pop FPU stack, store all */
+	      if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                return -1;
+              break;
+	    case 0x00:
+       	    case 0x01:
 	    case 0x04:
 	    case 0x05:
 	    case 0x06:
 	    case 0x07:
 	    case 0x10:
-	    case 0x11:
-	    case 0x12:
-	    case 0x13:
+       	    case 0x11:
 	    case 0x14:
 	    case 0x15:
 	    case 0x16:
 	    case 0x17:
 	    case 0x20:
 	    case 0x21:
-	    case 0x22:
-	    case 0x23:
 	    case 0x24:
 	    case 0x25:
 	    case 0x26:
 	    case 0x27:
 	    case 0x30:
 	    case 0x31:
-	    case 0x32:
-	    case 0x33:
 	    case 0x34:
 	    case 0x35:
 	    case 0x36:
 	    case 0x37:
-	      break;
+	      /* FADD, FMUL, FSUB, FSUBR, FDIV, FDIVR, FIADD, FIMUL, FISUB, FISUBR, FIDIV, FIDIVR  
+              ModR/M.reg is an extension of code, always affects st(0) register */
+	      if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                return -1;
+              break;           	    	    
 	    case 0x08:
 	    case 0x0a:
 	    case 0x0b:
@@ -4096,6 +4157,7 @@
 	    case 0x19:
 	    case 0x1a:
 	    case 0x1b:
+	    case 0x1d: 
 	    case 0x28:
 	    case 0x29:
 	    case 0x2a:
@@ -4103,11 +4165,16 @@
 	    case 0x38:
 	    case 0x39:
 	    case 0x3a:
-	    case 0x3b:
+	    case 0x3b:	   
+	    case 0x3c: 
+	    case 0x3d: 
 	      switch (ir.reg & 7)
 		{
 		case 0:
-		  break;
+		  /* FLD, FILD */
+	          if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                    return -1;    
+                  break;
 		case 1:
 		  switch (ir.reg >> 4)
 		    {
@@ -4120,6 +4187,7 @@
 			return -1;
 		      break;
 		    case 3:
+		      break;
 		    default:
 		      if (record_arch_list_add_mem (addr, 2))
 			return -1;
@@ -4130,15 +4198,42 @@
 		  switch (ir.reg >> 4)
 		    {
 		    case 0:
+		      if (record_arch_list_add_mem (addr, 4))
+			return -1;
+		      if (3 == (ir.reg & 7))
+                        {
+                        /* FSTP m32fp */
+		        if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        } 
+                      break;
 		    case 1:
 		      if (record_arch_list_add_mem (addr, 4))
 			return -1;
+		      if ((3 == (ir.reg & 7)) || (5 == (ir.reg & 7)) || (7 == (ir.reg & 7)))
+                        {
+                        /* FSTP */
+		        if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        } 
 		      break;
 		    case 2:
 		      if (record_arch_list_add_mem (addr, 8))
 			return -1;
+		      if (3 == (ir.reg & 7))
+                        {
+                        /* FSTP m64fp */
+		        if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        } 
 		      break;
 		    case 3:
+		      if ((3 <= (ir.reg & 7)) && (6 <= (ir.reg & 7)))
+                        {
+                        /* FISTP, FBLD, FILD, FBSTP */
+		        if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        }                        
 		    default:
 		      if (record_arch_list_add_mem (addr, 2))
 			return -1;
@@ -4147,54 +4242,71 @@
 		  break;
 		}
 	      break;
-	    case 0x0c:
-	    case 0x0d:
-	    case 0x1d:
-	    case 0x2c:
-	    case 0x3c:
-	    case 0x3d:
-	      break;
-	    case 0x0e:
+   	    case 0x0c:
+	      /* FLDENV */
+	      if (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
+	        return -1;  
+              break;
+	    case 0x0d: 
+              /* FLDCW */
+	      if (i386_record_floats(&ir, I386_FCTRL))
+	        return -1;  
+              break;
+	    case 0x2c: 
+              /* FRTSTOR */
+	      if (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
+	        return -1;  
+	      break; 
+	    case 0x0e: 
 	      if (ir.dflag)
 		{
-		  if (record_arch_list_add_mem (addr, 28))
-		    return -1;
+		if (record_arch_list_add_mem (addr, 28))
+		  return -1;
 		}
 	      else
 		{
-		  if (record_arch_list_add_mem (addr, 14))
-		    return -1;
+		if (record_arch_list_add_mem (addr, 14))
+		  return -1;
 		}
 	      break;
-	    case 0x0f:
-	    case 0x2f:
+	    case 0x0f:  
+	    case 0x2f:  
 	      if (record_arch_list_add_mem (addr, 2))
 		return -1;
 	      break;
-	    case 0x1f:
-	    case 0x3e:
+	    case 0x1f:  
+	    case 0x3e:  
 	      if (record_arch_list_add_mem (addr, 10))
 		return -1;
+              /* FSTP, FBSTP */
+              if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+	        return -1;                                  
 	      break;
-	    case 0x2e:
+	    case 0x2e: 
 	      if (ir.dflag)
 		{
-		  if (record_arch_list_add_mem (addr, 28))
-		    return -1;
-		  addr += 28;
+		if (record_arch_list_add_mem (addr, 28))
+		  return -1;
+		addr += 28;
 		}
 	      else
 		{
-		  if (record_arch_list_add_mem (addr, 14))
-		    return -1;
-		  addr += 14;
+		if (record_arch_list_add_mem (addr, 14))
+		  return -1;
+		addr += 14;
 		}
 	      if (record_arch_list_add_mem (addr, 80))
 		return -1;
+              /* FSAVE */
+	      if (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
+	        return -1;   
 	      break;
-	    case 0x3f:
+	    case 0x3f: 
 	      if (record_arch_list_add_mem (addr, 8))
 		return -1;
+		/* FISTP */
+              if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+	        return -1;   
 	      break;
 	    default:
 	      ir.addr -= 2;
@@ -4202,9 +4314,180 @@
 	      goto no_support;
 	      break;
 	    }
-	}
+	}   
+        /* opcode is an extension of modR/M byte */     
+	else
+	{ 
+          switch (opcode)
+            {
+            case 0xd8:
+              if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                return -1;	
+              break;
+            case 0xd9:    
+              if (0x0c == (ir.modrm >> 4))
+                {
+                  if ((ir.modrm & 0x0f) <= 7)
+                    {
+                    if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                      return -1;	
+                    }
+                  else
+                    {
+                    if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                      return -1;	
+                    /* if only st(0) is changing, then we have already recorded */
+                    if ((ir.modrm & 0x0f) - 0x08)
+                      {
+                      if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                        return -1;	                      
+                      } 
+                    }  
+                }
+              else
+                {
+                switch(ir.modrm)
+                  {
+                  case 0xe0:
+                  case 0xe1:
+                  case 0xf0:
+                  case 0xf5:
+                  case 0xf8:
+                  case 0xfa:
+                  case 0xfc:
+                  case 0xfe:
+                  case 0xff:
+                    if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                      return -1;
+                    break;           
+                  case 0xf1:  
+                  case 0xf2:  
+                  case 0xf3:  
+                  case 0xf4:
+		  case 0xf6: 
+                  case 0xf7:    
+                  case 0xe8:  
+                  case 0xe9:  
+                  case 0xea:  
+                  case 0xeb:
+                  case 0xec:        
+                  case 0xed:    
+                  case 0xee:   
+                  case 0xf9:     
+                  case 0xfb:
+                    if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                      return -1;	
+                    break;
+                  case 0xfd: 
+                    if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                      return -1;
+                    if (i386_record_floats(&ir, I386_ST1_REGNUM))
+                      return -1;
+                    break;
+                  } 
+              }
+              break;
+            case 0xda:
+              if (0xe9 == ir.modrm)
+                {
+		if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                  return -1;                    
+                }
+              else if ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >> 4))
+                {
+                if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                  return -1;	                
+                if (((ir.modrm & 0x0f) > 0) && ((ir.modrm & 0x0f) <= 7))
+                  {
+                  if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                    return -1;	                      
+                  }
+                else if ((ir.modrm & 0x0f) - 0x08)
+                  {
+		  if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                    return -1;
+                  }
+                }  
+              break; 
+            case 0xdb:
+              if (0xe3 == ir.modrm)
+                {
+		if (i386_record_floats(&ir, I386_SAVE_FPU_ENV))
+                  return -1;                    
+                }
+              else if ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >> 4))
+                {
+                if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                  return -1;	                
+                if (((ir.modrm & 0x0f) > 0) && ((ir.modrm & 0x0f) <= 7))
+                  {
+                  if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                    return -1;	                      
+                  }
+                else if ((ir.modrm & 0x0f) - 0x08)
+                  {
+		  if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                    return -1;
+                  }
+                }  
+              break;
+            case 0xdc:
+              if ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >> 4) || (0x0f == ir.modrm >> 4))
+                {
+                if ((ir.modrm & 0x0f) <= 7)
+                  {
+                  if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                    return -1;	                      
+                  }
+                else
+                  {
+		  if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                    return -1;
+                  }
+                }  
+               break;
+            case 0xdd:             
+              if (0x0c == ir.modrm >> 4)
+                {
+                  if (i386_record_floats(&ir,I386_FTAG))
+                    return -1;
+                }
+              else if ((0x0d == ir.modrm >> 4) || (0x0e == ir.modrm >> 4))
+                { 
+                  if ((ir.modrm & 0x0f) <= 7)
+                    {
+                      if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                        return -1;	 
+                    }
+                  else
+                    {
+                      if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                        return -1;
+                    }
+                }            
+              break;
+            case 0xde:
+              if ((0x0c == ir.modrm >> 4) || (0x0e == ir.modrm >> 4) || (0x0f == ir.modrm >> 4) || (0xd9 == ir.modrm))
+                {                   
+                  if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                    return -1;	 
+                }   
+              break;
+            case 0xdf:
+	      if (0xe0 == ir.modrm)
+                {
+                  if (record_arch_list_add_reg (ir.regcache, I386_EAX_REGNUM))
+	   	    return -1;
+                }
+              else if ((0x0f == ir.modrm >> 4) || (0x0e == ir.modrm >> 4))
+                { 
+                  if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                    return -1;
+                } 
+              break;
+            } 	  
+        }         
       break;
-
       /* string ops */
       /* movsS */
     case 0xa4:
@@ -4623,10 +4906,17 @@
       /* fwait */
       /* XXX */
     case 0x9b:
-      printf_unfiltered (_("Process record doesn't support instruction "
-			   "fwait.\n"));
-      ir.addr -= 1;
-      goto no_support;
+      if (target_read_memory (ir.addr, &tmpu8, 1))
+	{
+	  if (record_debug)
+	    printf_unfiltered (_("Process record: error reading memory at "
+				 "addr 0x%s len = 1.\n"),
+			       paddr_nz (ir.addr));
+	  return -1;
+	}
+      opcode = (uint32_t) tmpu8;
+      ir.addr++;
+      goto reswitch;     
       break;
 
       /* int3 */














--- On Thu, 7/2/09, Hui Zhu <teawater@gmail.com> wrote:

> From: Hui Zhu <teawater@gmail.com>
> Subject: Re: i386.record.floating.point.patch : with more testing and assurity
> To: "paawan oza" <paawan1982@yahoo.com>
> Cc: "Pedro Alves" <pedro@codesourcery.com>, "Mark Kettenis" <mark.kettenis@xs4all.nl>, "Michael Snyder" <msnyder@vmware.com>, gdb-patches@sourceware.org
> Date: Thursday, July 2, 2009, 7:31 AM
> On Wed, Jul 1, 2009 at 23:59, paawan
> oza<paawan1982@yahoo.com>
> wrote:
> >
> > Hi Hui,
> >
> > As I clarified earlier,
> > these registers are already supported and extended by
> gdb much before this patch.
> > all floating point registers are already supported by
> gdb
> > (info floats/info all-registers command gives it)
> >
> > My aim is : only to make sure that whenever any
> floating point insn gets executed, we record the registers
> > (no matter whether it is %st(n) or FCTRL or FTAG or
> FSTATUS)
> > there are insns
> > e.g. 'ffree' changes FTAG register, so we must record
> it.
> >
> > Do you mean to say that we should remove it from just
> enumaration ?
> > but anyway we need to record those registers.
> >
> 
> You are working on make prec x86 support fp insn, not to
> extend the fp
> function of i386 (If you want, you can make a special patch
> for it).
> 
> 
> 
> 
> >
> > --- On Wed, 7/1/09, Hui Zhu <teawater@gmail.com>
> wrote:
> >
> >> From: Hui Zhu <teawater@gmail.com>
> >> Subject: Re: i386.record.floating.point.patch :
> with more testing and assurity
> >> To: "paawan oza" <paawan1982@yahoo.com>,
> "Pedro Alves" <pedro@codesourcery.com>,
> "Mark Kettenis" <mark.kettenis@xs4all.nl>,
> "Michael Snyder" <msnyder@vmware.com>
> >> Cc: gdb-patches@sourceware.org
> >> Date: Wednesday, July 1, 2009, 11:23 AM
> >> About this patch, I say my idea
> >> again, I told in
> >> http://sourceware.org/ml/gdb-patches/2009-06/msg00014.html
> >> @@ -145,7 +145,22 @@
> >>    I386_ES_REGNUM,
> >>     /* %es */
> >>    I386_FS_REGNUM,
> >>     /* %fs */
> >>    I386_GS_REGNUM,
> >>     /* %gs */
> >> -  I386_ST0_REGNUM
> >>     /* %st(0) */
> >> +  I386_ST0_REGNUM,
> >>     /* %st(0) */
> >> +  I386_ST1_REGNUM,
> >>     /* %st(1) */
> >> +  I386_ST2_REGNUM,
> >>     /* %st(2) */
> >> +  I386_ST3_REGNUM,
> >>     /* %st(3) */
> >> +  I386_ST4_REGNUM,
> >>     /* %st(4) */
> >> +  I386_ST5_REGNUM,
> >>     /* %st(5) */
> >> +  I386_ST6_REGNUM,
> >>     /* %st(6) */
> >> +  I386_ST7_REGNUM,
> >>     /* %st(7) */
> >> +  I386_FCTRL,
> >>     /* floating point env regs : FCTRL-FOP
> >> */
> >> +  I386_FSTAT,
> >> +  I386_FTAG,
> >>
> >> +  I386_FISEG,
> >> +  I386_FIOFF,
> >> +  I386_FOSEG,
> >> +  I386_FOOFF,
> >> +  I386_FOP
> >>  };
> >>
> >> You are working on make prec x86 support fp insn,
> not to
> >> extend the fp
> >> function of i386 (If you want, you can make a
> special patch
> >> for it).
> >>
> >> Hui
> >>
> >> On Tue, Jun 30, 2009 at 23:05, paawan oza<paawan1982@yahoo.com>
> >> wrote:
> >> >
> >> > Hi,
> >> > As I am submitting the patch for the first
> time, I am
> >> not much aware of gdb test suite.
> >> > would you please guide me about how I can put
> the
> >> things in the testsuite ?
> >> > is it the testsuite which comes along with
> the gdb
> >> source ?
> >> > gdb\testsuite\gdb.base ??
> >> > Regards,
> >> > Oza.
> >> >
> >> > --- On Tue, 6/30/09, Pedro Alves <pedro@codesourcery.com>
> >> wrote:
> >> >
> >> >> From: Pedro Alves <pedro@codesourcery.com>
> >> >> Subject: Re:
> i386.record.floating.point.patch :
> >> with more testing and assurity
> >> >> To: gdb-patches@sourceware.org
> >> >> Cc: "paawan oza" <paawan1982@yahoo.com>,
> >> teawater@gmail.com
> >> >> Date: Tuesday, June 30, 2009, 7:09 PM
> >> >> On Tuesday 30 June 2009 14:23:30,
> >> >> paawan oza wrote:
> >> >> >
> >> >> > > As suggested by Hui,
> >> >> > > I have come up with more
> detailed and
> >> granular
> >> >> test case
> >> >> > > for the patch which I had
> submitted last
> >> week.
> >> >>
> >> >> Could you please consider migrating that
> test into
> >> the
> >> >> testsuite?
> >> >> You've gone through the trouble of
> writing tests
> >> to make
> >> >> sure
> >> >> the features work now --- putting it in
> the
> >> testsuite means
> >> >> we
> >> >> have an automatic-ish means to check that
> it
> >> doesn't get
> >> >> inadvertently broken in the future.  The
> way it
> >> is,
> >> >> when your
> >> >> code gets in, the test will probably end
> up lost
> >> in the
> >> >> archives.
> >> >> We wouldn't want that, would we?  :-) 
> Having
> >> >> auto-tests, also helps
> >> >> the person doing the review in confirming
> things
> >> work as
> >> >> expected (without much effort).
> >> >>
> >> >> --
> >> >> Pedro Alves
> >> >>
> >> >
> >> >
> >> >
> >> >
> >>
> >
> >
> >
> >
> 


      


^ permalink raw reply	[flat|nested] 40+ messages in thread
* Re: i386.record.floating.point.patch : with more testing and assurity
@ 2009-07-02  3:34 paawan oza
  0 siblings, 0 replies; 40+ messages in thread
From: paawan oza @ 2009-07-02  3:34 UTC (permalink / raw)
  To: Hui Zhu; +Cc: Pedro Alves, Mark Kettenis, Michael Snyder, gdb-patches


Hi Hui,
Ok fine. I try to understand and incorporate your review comments.
I am sending the new patch in next mail.
Regards,
Oza.

--- On Thu, 7/2/09, Hui Zhu <teawater@gmail.com> wrote:

> From: Hui Zhu <teawater@gmail.com>
> Subject: Re: i386.record.floating.point.patch : with more testing and assurity
> To: "paawan oza" <paawan1982@yahoo.com>
> Cc: "Pedro Alves" <pedro@codesourcery.com>, "Mark Kettenis" <mark.kettenis@xs4all.nl>, "Michael Snyder" <msnyder@vmware.com>, gdb-patches@sourceware.org
> Date: Thursday, July 2, 2009, 7:31 AM
> On Wed, Jul 1, 2009 at 23:59, paawan
> oza<paawan1982@yahoo.com>
> wrote:
> >
> > Hi Hui,
> >
> > As I clarified earlier,
> > these registers are already supported and extended by
> gdb much before this patch.
> > all floating point registers are already supported by
> gdb
> > (info floats/info all-registers command gives it)
> >
> > My aim is : only to make sure that whenever any
> floating point insn gets executed, we record the registers
> > (no matter whether it is %st(n) or FCTRL or FTAG or
> FSTATUS)
> > there are insns
> > e.g. 'ffree' changes FTAG register, so we must record
> it.
> >
> > Do you mean to say that we should remove it from just
> enumaration ?
> > but anyway we need to record those registers.
> >
> 
> You are working on make prec x86 support fp insn, not to
> extend the fp
> function of i386 (If you want, you can make a special patch
> for it).
> 
> 
> 
> 
> >
> > --- On Wed, 7/1/09, Hui Zhu <teawater@gmail.com>
> wrote:
> >
> >> From: Hui Zhu <teawater@gmail.com>
> >> Subject: Re: i386.record.floating.point.patch :
> with more testing and assurity
> >> To: "paawan oza" <paawan1982@yahoo.com>,
> "Pedro Alves" <pedro@codesourcery.com>,
> "Mark Kettenis" <mark.kettenis@xs4all.nl>,
> "Michael Snyder" <msnyder@vmware.com>
> >> Cc: gdb-patches@sourceware.org
> >> Date: Wednesday, July 1, 2009, 11:23 AM
> >> About this patch, I say my idea
> >> again, I told in
> >> http://sourceware.org/ml/gdb-patches/2009-06/msg00014.html
> >> @@ -145,7 +145,22 @@
> >>    I386_ES_REGNUM,
> >>     /* %es */
> >>    I386_FS_REGNUM,
> >>     /* %fs */
> >>    I386_GS_REGNUM,
> >>     /* %gs */
> >> -  I386_ST0_REGNUM
> >>     /* %st(0) */
> >> +  I386_ST0_REGNUM,
> >>     /* %st(0) */
> >> +  I386_ST1_REGNUM,
> >>     /* %st(1) */
> >> +  I386_ST2_REGNUM,
> >>     /* %st(2) */
> >> +  I386_ST3_REGNUM,
> >>     /* %st(3) */
> >> +  I386_ST4_REGNUM,
> >>     /* %st(4) */
> >> +  I386_ST5_REGNUM,
> >>     /* %st(5) */
> >> +  I386_ST6_REGNUM,
> >>     /* %st(6) */
> >> +  I386_ST7_REGNUM,
> >>     /* %st(7) */
> >> +  I386_FCTRL,
> >>     /* floating point env regs : FCTRL-FOP
> >> */
> >> +  I386_FSTAT,
> >> +  I386_FTAG,
> >>
> >> +  I386_FISEG,
> >> +  I386_FIOFF,
> >> +  I386_FOSEG,
> >> +  I386_FOOFF,
> >> +  I386_FOP
> >>  };
> >>
> >> You are working on make prec x86 support fp insn,
> not to
> >> extend the fp
> >> function of i386 (If you want, you can make a
> special patch
> >> for it).
> >>
> >> Hui
> >>
> >> On Tue, Jun 30, 2009 at 23:05, paawan oza<paawan1982@yahoo.com>
> >> wrote:
> >> >
> >> > Hi,
> >> > As I am submitting the patch for the first
> time, I am
> >> not much aware of gdb test suite.
> >> > would you please guide me about how I can put
> the
> >> things in the testsuite ?
> >> > is it the testsuite which comes along with
> the gdb
> >> source ?
> >> > gdb\testsuite\gdb.base ??
> >> > Regards,
> >> > Oza.
> >> >
> >> > --- On Tue, 6/30/09, Pedro Alves <pedro@codesourcery.com>
> >> wrote:
> >> >
> >> >> From: Pedro Alves <pedro@codesourcery.com>
> >> >> Subject: Re:
> i386.record.floating.point.patch :
> >> with more testing and assurity
> >> >> To: gdb-patches@sourceware.org
> >> >> Cc: "paawan oza" <paawan1982@yahoo.com>,
> >> teawater@gmail.com
> >> >> Date: Tuesday, June 30, 2009, 7:09 PM
> >> >> On Tuesday 30 June 2009 14:23:30,
> >> >> paawan oza wrote:
> >> >> >
> >> >> > > As suggested by Hui,
> >> >> > > I have come up with more
> detailed and
> >> granular
> >> >> test case
> >> >> > > for the patch which I had
> submitted last
> >> week.
> >> >>
> >> >> Could you please consider migrating that
> test into
> >> the
> >> >> testsuite?
> >> >> You've gone through the trouble of
> writing tests
> >> to make
> >> >> sure
> >> >> the features work now --- putting it in
> the
> >> testsuite means
> >> >> we
> >> >> have an automatic-ish means to check that
> it
> >> doesn't get
> >> >> inadvertently broken in the future.  The
> way it
> >> is,
> >> >> when your
> >> >> code gets in, the test will probably end
> up lost
> >> in the
> >> >> archives.
> >> >> We wouldn't want that, would we?  :-) 
> Having
> >> >> auto-tests, also helps
> >> >> the person doing the review in confirming
> things
> >> work as
> >> >> expected (without much effort).
> >> >>
> >> >> --
> >> >> Pedro Alves
> >> >>
> >> >
> >> >
> >> >
> >> >
> >>
> >
> >
> >
> >
> 


      


^ permalink raw reply	[flat|nested] 40+ messages in thread
* Re: i386.record.floating.point.patch : with more testing and assurity
@ 2009-07-01 16:17 paawan oza
  2009-07-05 18:33 ` Mark Kettenis
  0 siblings, 1 reply; 40+ messages in thread
From: paawan oza @ 2009-07-01 16:17 UTC (permalink / raw)
  To: Mark Kettenis; +Cc: gdb-patches, teawater


Hi,

For your review convenience, I am sending the patch in plain text as a part of email body.
please also refer to the previous mails, where a point is raised by Hui.
I provided justification for the same.
please help with the point to throw more light.


TEST_CASE
****************************************************
test_float.c
****************************************************
#include <stdio.h>
#include <math.h>
#include <stdlib.h>

/* the test intends to test following insns.  
flds faddp fstps fstpl fldl fxch fabs fdivrp fmulp fsubrp fucomp fnstsw fsqrt
fchs f2xm1 fyl2x fxtract fprem1 fld fdecstp fld1 fldl2t fldl2e FLDPI FLDLG2 FLDLN2
FLDZ fincstp ffree fptan fpatan fincstp fsincos frndint fscale fsin fcos fcmovb
fcmovbe fcmove fcmovu fcmovnb fcmovnbe fsave frstor fstsw 
*/

float no1,no2,no3,no4,no5,no6,no7;
double x = 100.345, y = 25.7789;
long double ldx = 88888888888888888888.88, ldy = 9999999999999999999.99;
float result,resultd,resultld; 
float *float_memory;

/* initialization of floats */
void init_floats()
{
  no1 = 10.45;
  no2 = 20.77;
  no3 = 156.89874646;
  no4 = 14.56;
  no5 = 11.11;
  no6 = 66.77;
  no7 = 88.88;
  float_memory = malloc(sizeof(float) * 4);
  *float_memory = 256.256;
  *(float_memory + 1) = 356.356;
  *(float_memory + 2) = 456.456;
  *(float_memory + 3) = 556.556;
}

/* marks FPU stack as empty */
void empty_fpu_stack()
{
  asm ("ffree %st(1) \n\t"
       "ffree %st(2) \n\t"
       "ffree %st(3) \n\t"
       "ffree %st(4) \n\t"
       "ffree %st(5) \n\t"
       "ffree %st(6) \n\t"
       "ffree %st(7)");
}   

/* tests floating point arithmatic */
void test_arith_floats()
{
  result = no1 + no2 + no3 + no4 + no5 + no6 + no7;
  printf("result is %f\n",result);

  result = fmodf(no2,no1); 
  printf("result is %f\n",result);

  resultd = fmod(x,y); 
  printf("result is %f\n",resultd);

  resultld = fmodl(ldy,ldy); 
  printf("result is %f\n",resultld);

  result = fabsf(no1);        
  printf("result is %f\n",result);

  result = no3 / no4;
  printf("result is %f\n",result);

  result = no1 * no2 * no3 * no4;
  printf("result is %f\n",result);

  result = no1 - no2 - no3 - no4;
  printf("result is %f\n",result);


  asm ("fld %0" : :"m"(*float_memory));
  asm ("fchs");
  
  /* test for f2xm1 */  
  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("f2xm1");

  asm ("fyl2x");

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fxtract");

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fprem1");

  /* decrement fpu stack pointer only status register should get affected */
  asm ("fld %0" : :"m"(*float_memory));   
  
  empty_fpu_stack();
  
  asm ("fld1");
  asm ("fldl2t");
  asm ("fldl2e");
  asm ("fldpi");
  asm ("fldlg2");
  asm ("fldln2");
  asm ("fldz");

  empty_fpu_stack();
  /* finishing emptying the stack */
      
  result = sqrt(no3);
  printf("result is %f\n",result);
}

void test_log_exp_floats()
{
  result = log10(no3);
  printf("result is %f\n",result);

  result = log(no3);
  printf("result is %f\n",result);

  result = exp10(no3);
  printf("result is %f\n",result);

  result = exp(no3);
  printf("result is %f\n",result);
}

void test_trigo_floats()
{
  result = sin(30);
  printf("result is %f\n",result);

  result = cos(30);
  printf("result is %f\n",result);

  result = tan(30);
  printf("result is %f\n",result);

  result = atan(30);
  printf("result is %f\n",result);

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fptan");

  /* changes st1 and popping register stack */
  asm ("fpatan");  

  asm("fincstp");
  asm ("fld %0" : :"m"(float_memory)); 
  asm ("fsincos");

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("frndint");

  asm ("fld %0" : :"m"(*float_memory));
  asm ("fld %0" : :"m"(*(float_memory+1)));  
  asm ("fscale");

  empty_fpu_stack();

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fsin");
  asm ("fcos");

  /* currently we assume condition likely and always record the registers 
  code could be optimized only if the flag is set then record */
  asm ("fld %0" : :"m"(*float_memory));
  asm ("fld %0" : :"m"(*(float_memory+1)));  
  asm ("fcmovb %st(1), %st");
  asm ("fcmovbe %st(1), %st");
  asm ("fcmove %st(1), %st");
  asm ("fcmovu %st(1), %st");
  asm ("fcmovnb %st(1), %st");
  asm ("fcmovnbe %st(1), %st");

  empty_fpu_stack();
  /* finished emtyping the stack */
}

void test_compare_floats()
{
    ldy = 88888888888888888888.88;
    if (ldx == ldy)
      ldy = 7777777777777777777777777777.777;
    else
      ldy = 666666666666666666666666666.666;
}

/* test loading and saving of FPU environment */
void test_fpu_env()
{
  asm ("fsave %0" : "=m"(*float_memory) : );
  asm ("frstor %0" : : "m"(*float_memory));
  asm ("fstsw %ax");  
}

int main()
{
    init_floats();
    test_arith_floats();
    test_log_exp_floats();
    test_trigo_floats();
    test_compare_floats();
    test_fpu_env();
}

******************************************************
i386-record-floats.patch
******************************************************

diff -urN gdb.orig/i386-tdep.c gdb.new/i386-tdep.c
--- gdb.orig/i386-tdep.c    2009-05-29 17:08:40.000000000 -0400
+++ gdb.new/i386-tdep.c    2009-06-01 20:02:23.000000000 -0400
@@ -543,6 +543,9 @@
/* The maximum number of saved registers.  This should include all
    registers mentioned above, and %eip.  */
#define I386_NUM_SAVED_REGS    I386_NUM_GREGS
+#define I386_SAVE_FPU_REGS        0xFFFD
+#define I386_SAVE_FPU_ENV        0xFFFE
+#define I386_SAVE_FPU_ENV_REG_STACK    0xFFFF

struct i386_frame_cache
{
@@ -2985,6 +2988,54 @@
   return 0;
}

+/* Record the value of floating point registers which will be changed by the current instruction
+   to "record_arch_list".
+   return -1 if something is wrong. */  
+
+static int i386_record_floats(struct i386_record_s *ir, uint32_t iregnum)
+{
+  int i;
+
+  /* Oza : push/pop of fpu stack is going to happen 
+     currently we store st0-st7 registers, but we need not store all registers all the time.
+     using fstatus, we use 11-13 bits which gives us stack top and hence we optimize our storage. */
+  if (I386_SAVE_FPU_REGS == iregnum)
+    {
+      for (i=I386_ST0_REGNUM;i<=I386_ST7_REGNUM;i++)
+        {
+          if (record_arch_list_add_reg (ir->regcache,i))
+            return -1;    
+        }
+    }
+  else if (I386_SAVE_FPU_ENV == iregnum)
+    {
+      for (i=I386_FCTRL;i<=I386_FOP;i++)
+      {
+        if (record_arch_list_add_reg (ir->regcache,i))
+          return -1;    
+      }
+    }
+  else if (I386_SAVE_FPU_ENV_REG_STACK == iregnum)
+    {
+      for (i=I386_ST0_REGNUM;i<=I386_FOP;i++)
+      {
+        if (record_arch_list_add_reg (ir->regcache,i))
+          return -1;    
+      }
+    }
+  else if (iregnum >= I386_ST0_REGNUM && iregnum <= I386_FOP)
+    {
+      if (record_arch_list_add_reg (ir->regcache,iregnum))
+        return -1;
+    }
+  else
+    {
+      /* param Error */
+      return -1;
+    } 
+  return 0;
+}
+
/* Parse the current instruction and record the values of the registers and
    memory that will be changed in current instruction to "record_arch_list".
    Return -1 if something wrong. */
@@ -4035,7 +4086,6 @@
       break;

       /* floats */
-      /* It just record the memory change of instrcution. */
     case 0xd8:
     case 0xd9:
     case 0xda:
@@ -4056,39 +4106,49 @@
        return -1;
      switch (ir.reg)
        {
-        case 0x00:
-        case 0x01:
        case 0x02:
-        case 0x03:
+        case 0x12:
+        case 0x22:
+        case 0x32:
+          /* for FCOM, FICOM nothing to do */
+              break;
+            case 0x03:
+        case 0x13:
+        case 0x23:
+        case 0x33:
+            /* FCOMP, FICOMP pop FPU stack, store all */
+          if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                return -1;
+              break;
+        case 0x00:
+               case 0x01:
        case 0x04:
        case 0x05:
        case 0x06:
        case 0x07:
        case 0x10:
-        case 0x11:
-        case 0x12:
-        case 0x13:
+               case 0x11:
        case 0x14:
        case 0x15:
        case 0x16:
        case 0x17:
        case 0x20:
        case 0x21:
-        case 0x22:
-        case 0x23:
        case 0x24:
        case 0x25:
        case 0x26:
        case 0x27:
        case 0x30:
        case 0x31:
-        case 0x32:
-        case 0x33:
        case 0x34:
        case 0x35:
        case 0x36:
        case 0x37:
-          break;
+          /* FADD, FMUL, FSUB, FSUBR, FDIV, FDIVR, FIADD, FIMUL, FISUB, FISUBR, FIDIV, FIDIVR  
+              ModR/M.reg is an extension of code, always affects st(0) register */
+          if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                return -1;
+              break;                           
        case 0x08:
        case 0x0a:
        case 0x0b:
@@ -4096,6 +4156,7 @@
        case 0x19:
        case 0x1a:
        case 0x1b:
+        case 0x1d: 
        case 0x28:
        case 0x29:
        case 0x2a:
@@ -4103,11 +4164,16 @@
        case 0x38:
        case 0x39:
        case 0x3a:
-        case 0x3b:
+        case 0x3b:       
+        case 0x3c: 
+        case 0x3d: 
          switch (ir.reg & 7)
        {
        case 0:
-          break;
+          /* FLD, FILD */
+              if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                    return -1;    
+                  break;
        case 1:
          switch (ir.reg >> 4)
            {
@@ -4120,6 +4186,7 @@
            return -1;
              break;
            case 3:
+              break;
            default:
              if (record_arch_list_add_mem (addr, 2))
            return -1;
@@ -4130,15 +4197,42 @@
          switch (ir.reg >> 4)
            {
            case 0:
+              if (record_arch_list_add_mem (addr, 4))
+            return -1;
+              if (3 == (ir.reg & 7))
+                        {
+                        /* FSTP m32fp */
+                if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                  return -1;                        
+                        } 
+                      break;
            case 1:
              if (record_arch_list_add_mem (addr, 4))
            return -1;
+              if ((3 == (ir.reg & 7)) || (5 == (ir.reg & 7)) || (7 == (ir.reg & 7)))
+                        {
+                        /* FSTP */
+                if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                  return -1;                        
+                        } 
              break;
            case 2:
              if (record_arch_list_add_mem (addr, 8))
            return -1;
+              if (3 == (ir.reg & 7))
+                        {
+                        /* FSTP m64fp */
+                if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                  return -1;                        
+                        } 
              break;
            case 3:
+              if ((3 <= (ir.reg & 7)) && (6 <= (ir.reg & 7)))
+                        {
+                        /* FISTP, FBLD, FILD, FBSTP */
+                if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                  return -1;                        
+                        }                        
            default:
              if (record_arch_list_add_mem (addr, 2))
            return -1;
@@ -4147,54 +4241,71 @@
          break;
        }
          break;
-        case 0x0c:
-        case 0x0d:
-        case 0x1d:
-        case 0x2c:
-        case 0x3c:
-        case 0x3d:
-          break;
-        case 0x0e:
+           case 0x0c:
+          /* FLDENV */
+          if (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
+            return -1;  
+              break;
+        case 0x0d: 
+              /* FLDCW */
+          if (i386_record_floats(&ir, I386_FCTRL))
+            return -1;  
+              break;
+        case 0x2c: 
+              /* FRTSTOR */
+          if (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
+            return -1;  
+          break; 
+        case 0x0e: 
          if (ir.dflag)
        {
-          if (record_arch_list_add_mem (addr, 28))
-            return -1;
+        if (record_arch_list_add_mem (addr, 28))
+          return -1;
        }
          else
        {
-          if (record_arch_list_add_mem (addr, 14))
-            return -1;
+        if (record_arch_list_add_mem (addr, 14))
+          return -1;
        }
          break;
-        case 0x0f:
-        case 0x2f:
+        case 0x0f:  
+        case 0x2f:  
          if (record_arch_list_add_mem (addr, 2))
        return -1;
          break;
-        case 0x1f:
-        case 0x3e:
+        case 0x1f:  
+        case 0x3e:  
          if (record_arch_list_add_mem (addr, 10))
        return -1;
+              /* FSTP, FBSTP */
+              if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+            return -1;                                  
          break;
-        case 0x2e:
+        case 0x2e: 
          if (ir.dflag)
        {
-          if (record_arch_list_add_mem (addr, 28))
-            return -1;
-          addr += 28;
+        if (record_arch_list_add_mem (addr, 28))
+          return -1;
+        addr += 28;
        }
          else
        {
-          if (record_arch_list_add_mem (addr, 14))
-            return -1;
-          addr += 14;
+        if (record_arch_list_add_mem (addr, 14))
+          return -1;
+        addr += 14;
        }
          if (record_arch_list_add_mem (addr, 80))
        return -1;
+              /* FSAVE */
+          if (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
+            return -1;   
          break;
-        case 0x3f:
+        case 0x3f: 
          if (record_arch_list_add_mem (addr, 8))
        return -1;
+        /* FISTP */
+              if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+            return -1;   
          break;
        default:
          ir.addr -= 2;
@@ -4202,9 +4313,180 @@
          goto no_support;
          break;
        }
-    }
+    }   
+        /* opcode is an extension of modR/M byte */     
+    else
+    { 
+          switch (opcode)
+            {
+            case 0xd8:
+              if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                return -1;    
+              break;
+            case 0xd9:    
+              if (0x0c == (ir.modrm >> 4))
+                {
+                  if ((ir.modrm & 0x0f) <= 7)
+                    {
+                    if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                      return -1;    
+                    }
+                  else
+                    {
+                    if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                      return -1;    
+                    /* if only st(0) is changing, then we have already recorded */
+                    if ((ir.modrm & 0x0f) - 0x08)
+                      {
+                      if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                        return -1;                          
+                      } 
+                    }  
+                }
+              else
+                {
+                switch(ir.modrm)
+                  {
+                  case 0xe0:
+                  case 0xe1:
+                  case 0xf0:
+                  case 0xf5:
+                  case 0xf8:
+                  case 0xfa:
+                  case 0xfc:
+                  case 0xfe:
+                  case 0xff:
+                    if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                      return -1;
+                    break;           
+                  case 0xf1:  
+                  case 0xf2:  
+                  case 0xf3:  
+                  case 0xf4:
+                  case 0xf6:        
+                  case 0xf7:    
+                  case 0xe8:  
+                  case 0xe9:  
+                  case 0xea:  
+                  case 0xeb:
+                  case 0xec:        
+                  case 0xed:    
+                  case 0xee:   
+                  case 0xf9:     
+                  case 0xfb:
+                    if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                      return -1;    
+                    break;
+                  case 0xfd: 
+                    if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                      return -1;
+                    if (i386_record_floats(&ir, I386_ST1_REGNUM))
+                      return -1;
+                    break;
+                  } 
+              }
+              break;
+            case 0xda:
+              if (0xe9 == ir.modrm)
+                {
+        if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                  return -1;                    
+                }
+              else if ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >> 4))
+                {
+                if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                  return -1;                    
+                if (((ir.modrm & 0x0f) > 0) && ((ir.modrm & 0x0f) <= 7))
+                  {
+                  if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                    return -1;                          
+                  }
+                else if ((ir.modrm & 0x0f) - 0x08)
+                  {
+          if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                    return -1;
+                  }
+                }  
+              break; 
+            case 0xdb:
+              if (0xe3 == ir.modrm)
+                {
+        if (i386_record_floats(&ir, I386_SAVE_FPU_ENV))
+                  return -1;                    
+                }
+              else if ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >> 4))
+                {
+                if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                  return -1;                    
+                if (((ir.modrm & 0x0f) > 0) && ((ir.modrm & 0x0f) <= 7))
+                  {
+                  if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                    return -1;                          
+                  }
+                else if ((ir.modrm & 0x0f) - 0x08)
+                  {
+          if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                    return -1;
+                  }
+                }  
+              break;
+            case 0xdc:
+              if ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >> 4) || (0x0f == ir.modrm >> 4))
+                {
+                if ((ir.modrm & 0x0f) <= 7)
+                  {
+                  if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                    return -1;                          
+                  }
+                else
+                  {
+          if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                    return -1;
+                  }
+                }  
+               break;
+            case 0xdd:             
+              if (0x0c == ir.modrm >> 4)
+                {
+                  if (i386_record_floats(&ir,I386_FTAG))
+                    return -1;
+                }
+              else if ((0x0d == ir.modrm >> 4) || (0x0e == ir.modrm >> 4))
+                { 
+                  if ((ir.modrm & 0x0f) <= 7)
+                    {
+                      if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                        return -1;     
+                    }
+                  else
+                    {
+                      if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                        return -1;
+                    }
+                }            
+              break;
+            case 0xde:
+              if ((0x0c == ir.modrm >> 4) || (0x0e == ir.modrm >> 4) || (0x0f == ir.modrm >> 4) || (0xd9 == ir.modrm))
+                {                   
+                  if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                    return -1;     
+                }   
+              break;
+            case 0xdf:
+          if (0xe0 == ir.modrm)
+                {
+                  if (record_arch_list_add_reg (ir.regcache, I386_EAX_REGNUM))
+               return -1;
+                }
+              else if ((0x0f == ir.modrm >> 4) || (0x0e == ir.modrm >> 4))
+                { 
+                  if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                    return -1;
+                } 
+              break;
+            }       
+        }         
       break;
-
       /* string ops */
       /* movsS */
     case 0xa4:
@@ -4623,10 +4905,17 @@
       /* fwait */
       /* XXX */
     case 0x9b:
-      printf_unfiltered (_("Process record doesn't support instruction "
-               "fwait.\n"));
-      ir.addr -= 1;
-      goto no_support;
+      if (target_read_memory (ir.addr, &tmpu8, 1))
+    {
+      if (record_debug)
+        printf_unfiltered (_("Process record: error reading memory at "
+                 "addr 0x%s len = 1.\n"),
+                   paddr_nz (ir.addr));
+      return -1;
+    }
+      opcode = (uint32_t) tmpu8;
+      ir.addr++;
+      goto reswitch;     
       break;

       /* int3 */
diff -urN gdb.orig/i386-tdep.h gdb.new/i386-tdep.h
--- gdb.orig/i386-tdep.h    2009-05-17 17:56:44.000000000 -0400
+++ gdb.new/i386-tdep.h    2009-05-31 16:33:14.000000000 -0400
@@ -145,7 +145,22 @@
   I386_ES_REGNUM,        /* %es */
   I386_FS_REGNUM,        /* %fs */
   I386_GS_REGNUM,        /* %gs */
-  I386_ST0_REGNUM        /* %st(0) */
+  I386_ST0_REGNUM,        /* %st(0) */
+  I386_ST1_REGNUM,        /* %st(1) */
+  I386_ST2_REGNUM,        /* %st(2) */
+  I386_ST3_REGNUM,        /* %st(3) */
+  I386_ST4_REGNUM,        /* %st(4) */
+  I386_ST5_REGNUM,        /* %st(5) */
+  I386_ST6_REGNUM,        /* %st(6) */
+  I386_ST7_REGNUM,        /* %st(7) */
+  I386_FCTRL,            /* floating point env regs : FCTRL-FOP */    
+  I386_FSTAT,                   
+  I386_FTAG,            
+  I386_FISEG,
+  I386_FIOFF,
+  I386_FOSEG,
+  I386_FOOFF,
+  I386_FOP
};

#define I386_NUM_GREGS    16


--- On Tue, 6/30/09, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:

> From: Mark Kettenis <mark.kettenis@xs4all.nl>
> Subject: Re: i386.record.floating.point.patch : with more testing and assurity
> To: paawan1982@yahoo.com
> Cc: gdb-patches@sourceware.org, teawater@gmail.com
> Date: Tuesday, June 30, 2009, 7:12 PM
> > Date: Tue, 30 Jun 2009 06:23:30
> -0700 (PDT)
> > From: paawan oza <paawan1982@yahoo.com>
> > 
> > Hi,
> > Again I am sending the patch, with the test cases.
> > please do the needful
> > Regards,
> > Oza.
> 
> Sorry, but if you want me to review your patch, don't send
> it as
> base64 encoded MIME.
> 


      


^ permalink raw reply	[flat|nested] 40+ messages in thread
* Re: i386.record.floating.point.patch : with more testing and assurity
@ 2009-07-01 16:02 paawan oza
  2009-07-01 16:14 ` Mark Kettenis
  0 siblings, 1 reply; 40+ messages in thread
From: paawan oza @ 2009-07-01 16:02 UTC (permalink / raw)
  To: Pedro Alves, Mark Kettenis, Michael Snyder, Hui Zhu; +Cc: gdb-patches


Can somebody please help with this open point ?

--- On Wed, 7/1/09, paawan oza <paawan1982@yahoo.com> wrote:

> From: paawan oza <paawan1982@yahoo.com>
> Subject: Re: i386.record.floating.point.patch : with more testing and assurity
> To: "Pedro Alves" <pedro@codesourcery.com>, "Mark Kettenis" <mark.kettenis@xs4all.nl>, "Michael Snyder" <msnyder@vmware.com>, "Hui Zhu" <teawater@gmail.com>
> Cc: gdb-patches@sourceware.org
> Date: Wednesday, July 1, 2009, 9:30 PM
> Hi Hui,
> 
> As I clarified earlier, 
> these registers are already supported and extended by gdb
> much before this patch.
> all floating point registers are already supported by gdb 
> (info floats/info all-registers command gives it)
> 
> My aim is : only to make sure that whenever any floating
> point insn gets executed, we record the registers 
> (no matter whether it is %st(n) or FCTRL or FTAG or
> FSTATUS)
> there are insns
> e.g. 'ffree' changes FTAG register, so we must record it.
> 
> Do you mean to say that we should remove it from just
> enumaration ?
> but anyway we need to record those registers.
> 
> Regards,
> Oza.
> 
> --- On Wed, 7/1/09, Hui Zhu <teawater@gmail.com>
> wrote:
> 
> > From: Hui Zhu <teawater@gmail.com>
> > Subject: Re: i386.record.floating.point.patch : with
> more testing and assurity
> > To: "paawan oza" <paawan1982@yahoo.com>,
> "Pedro Alves" <pedro@codesourcery.com>,
> "Mark Kettenis" <mark.kettenis@xs4all.nl>,
> "Michael Snyder" <msnyder@vmware.com>
> > Cc: gdb-patches@sourceware.org
> > Date: Wednesday, July 1, 2009, 11:23 AM
> > About this patch, I say my idea
> > again, I told in
> > http://sourceware.org/ml/gdb-patches/2009-06/msg00014.html
> > @@ -145,7 +145,22 @@
> >    I386_ES_REGNUM,   
> >     /* %es */
> >    I386_FS_REGNUM,   
> >     /* %fs */
> >    I386_GS_REGNUM,   
> >     /* %gs */
> > -  I386_ST0_REGNUM   
> >     /* %st(0) */
> > +  I386_ST0_REGNUM,   
> >     /* %st(0) */
> > +  I386_ST1_REGNUM,   
> >     /* %st(1) */
> > +  I386_ST2_REGNUM,   
> >     /* %st(2) */
> > +  I386_ST3_REGNUM,   
> >     /* %st(3) */
> > +  I386_ST4_REGNUM,   
> >     /* %st(4) */
> > +  I386_ST5_REGNUM,   
> >     /* %st(5) */
> > +  I386_ST6_REGNUM,   
> >     /* %st(6) */
> > +  I386_ST7_REGNUM,   
> >     /* %st(7) */
> > +  I386_FCTRL,       
> >     /* floating point env regs : FCTRL-FOP
> > */    
> > +  I386_FSTAT,
> > +  I386_FTAG,       
> >     
> > +  I386_FISEG,
> > +  I386_FIOFF,
> > +  I386_FOSEG,
> > +  I386_FOOFF,
> > +  I386_FOP
> >  };
> > 
> > You are working on make prec x86 support fp insn, not
> to
> > extend the fp
> > function of i386 (If you want, you can make a special
> patch
> > for it).
> > 
> > Hui
> > 
> > On Tue, Jun 30, 2009 at 23:05, paawan oza<paawan1982@yahoo.com>
> > wrote:
> > >
> > > Hi,
> > > As I am submitting the patch for the first time,
> I am
> > not much aware of gdb test suite.
> > > would you please guide me about how I can put
> the
> > things in the testsuite ?
> > > is it the testsuite which comes along with the
> gdb
> > source ?
> > > gdb\testsuite\gdb.base ??
> > > Regards,
> > > Oza.
> > >
> > > --- On Tue, 6/30/09, Pedro Alves <pedro@codesourcery.com>
> > wrote:
> > >
> > >> From: Pedro Alves <pedro@codesourcery.com>
> > >> Subject: Re: i386.record.floating.point.patch
> :
> > with more testing and assurity
> > >> To: gdb-patches@sourceware.org
> > >> Cc: "paawan oza" <paawan1982@yahoo.com>,
> > teawater@gmail.com
> > >> Date: Tuesday, June 30, 2009, 7:09 PM
> > >> On Tuesday 30 June 2009 14:23:30,
> > >> paawan oza wrote:
> > >> >
> > >> > > As suggested by Hui,
> > >> > > I have come up with more detailed
> and
> > granular
> > >> test case
> > >> > > for the patch which I had submitted
> last
> > week.
> > >>
> > >> Could you please consider migrating that test
> into
> > the
> > >> testsuite?
> > >> You've gone through the trouble of writing
> tests
> > to make
> > >> sure
> > >> the features work now --- putting it in the
> > testsuite means
> > >> we
> > >> have an automatic-ish means to check that it
> > doesn't get
> > >> inadvertently broken in the future.  The way
> it
> > is,
> > >> when your
> > >> code gets in, the test will probably end up
> lost
> > in the
> > >> archives.
> > >> We wouldn't want that, would we?  :-) 
> Having
> > >> auto-tests, also helps
> > >> the person doing the review in confirming
> things
> > work as
> > >> expected (without much effort).
> > >>
> > >> --
> > >> Pedro Alves
> > >>
> > >
> > >
> > >
> > >
> > 
> 
> 
> 
> 




^ permalink raw reply	[flat|nested] 40+ messages in thread
* Re: i386.record.floating.point.patch : with more testing and assurity
@ 2009-07-01 16:01 paawan oza
  0 siblings, 0 replies; 40+ messages in thread
From: paawan oza @ 2009-07-01 16:01 UTC (permalink / raw)
  To: Pedro Alves, Mark Kettenis, Michael Snyder, Hui Zhu; +Cc: gdb-patches


Hi Hui,

As I clarified earlier, 
these registers are already supported and extended by gdb much before this patch.
all floating point registers are already supported by gdb 
(info floats/info all-registers command gives it)

My aim is : only to make sure that whenever any floating point insn gets executed, we record the registers 
(no matter whether it is %st(n) or FCTRL or FTAG or FSTATUS)
there are insns
e.g. 'ffree' changes FTAG register, so we must record it.

Do you mean to say that we should remove it from just enumaration ?
but anyway we need to record those registers.

Regards,
Oza.

--- On Wed, 7/1/09, Hui Zhu <teawater@gmail.com> wrote:

> From: Hui Zhu <teawater@gmail.com>
> Subject: Re: i386.record.floating.point.patch : with more testing and assurity
> To: "paawan oza" <paawan1982@yahoo.com>, "Pedro Alves" <pedro@codesourcery.com>, "Mark Kettenis" <mark.kettenis@xs4all.nl>, "Michael Snyder" <msnyder@vmware.com>
> Cc: gdb-patches@sourceware.org
> Date: Wednesday, July 1, 2009, 11:23 AM
> About this patch, I say my idea
> again, I told in
> http://sourceware.org/ml/gdb-patches/2009-06/msg00014.html
> @@ -145,7 +145,22 @@
>    I386_ES_REGNUM,   
>     /* %es */
>    I386_FS_REGNUM,   
>     /* %fs */
>    I386_GS_REGNUM,   
>     /* %gs */
> -  I386_ST0_REGNUM   
>     /* %st(0) */
> +  I386_ST0_REGNUM,   
>     /* %st(0) */
> +  I386_ST1_REGNUM,   
>     /* %st(1) */
> +  I386_ST2_REGNUM,   
>     /* %st(2) */
> +  I386_ST3_REGNUM,   
>     /* %st(3) */
> +  I386_ST4_REGNUM,   
>     /* %st(4) */
> +  I386_ST5_REGNUM,   
>     /* %st(5) */
> +  I386_ST6_REGNUM,   
>     /* %st(6) */
> +  I386_ST7_REGNUM,   
>     /* %st(7) */
> +  I386_FCTRL,       
>     /* floating point env regs : FCTRL-FOP
> */    
> +  I386_FSTAT,
> +  I386_FTAG,       
>     
> +  I386_FISEG,
> +  I386_FIOFF,
> +  I386_FOSEG,
> +  I386_FOOFF,
> +  I386_FOP
>  };
> 
> You are working on make prec x86 support fp insn, not to
> extend the fp
> function of i386 (If you want, you can make a special patch
> for it).
> 
> Hui
> 
> On Tue, Jun 30, 2009 at 23:05, paawan oza<paawan1982@yahoo.com>
> wrote:
> >
> > Hi,
> > As I am submitting the patch for the first time, I am
> not much aware of gdb test suite.
> > would you please guide me about how I can put the
> things in the testsuite ?
> > is it the testsuite which comes along with the gdb
> source ?
> > gdb\testsuite\gdb.base ??
> > Regards,
> > Oza.
> >
> > --- On Tue, 6/30/09, Pedro Alves <pedro@codesourcery.com>
> wrote:
> >
> >> From: Pedro Alves <pedro@codesourcery.com>
> >> Subject: Re: i386.record.floating.point.patch :
> with more testing and assurity
> >> To: gdb-patches@sourceware.org
> >> Cc: "paawan oza" <paawan1982@yahoo.com>,
> teawater@gmail.com
> >> Date: Tuesday, June 30, 2009, 7:09 PM
> >> On Tuesday 30 June 2009 14:23:30,
> >> paawan oza wrote:
> >> >
> >> > > As suggested by Hui,
> >> > > I have come up with more detailed and
> granular
> >> test case
> >> > > for the patch which I had submitted last
> week.
> >>
> >> Could you please consider migrating that test into
> the
> >> testsuite?
> >> You've gone through the trouble of writing tests
> to make
> >> sure
> >> the features work now --- putting it in the
> testsuite means
> >> we
> >> have an automatic-ish means to check that it
> doesn't get
> >> inadvertently broken in the future.  The way it
> is,
> >> when your
> >> code gets in, the test will probably end up lost
> in the
> >> archives.
> >> We wouldn't want that, would we?  :-)  Having
> >> auto-tests, also helps
> >> the person doing the review in confirming things
> work as
> >> expected (without much effort).
> >>
> >> --
> >> Pedro Alves
> >>
> >
> >
> >
> >
> 




^ permalink raw reply	[flat|nested] 40+ messages in thread
* Re: i386.record.floating.point.patch : with more testing and assurity
@ 2009-07-01 15:59 paawan oza
  2009-07-02  2:02 ` Hui Zhu
  0 siblings, 1 reply; 40+ messages in thread
From: paawan oza @ 2009-07-01 15:59 UTC (permalink / raw)
  To: Pedro Alves, Mark Kettenis, Michael Snyder, Hui Zhu; +Cc: gdb-patches


Hi Hui,

As I clarified earlier, 
these registers are already supported and extended by gdb much before this patch.
all floating point registers are already supported by gdb 
(info floats/info all-registers command gives it)

My aim is : only to make sure that whenever any floating point insn gets executed, we record the registers 
(no matter whether it is %st(n) or FCTRL or FTAG or FSTATUS)
there are insns
e.g. 'ffree' changes FTAG register, so we must record it.

Do you mean to say that we should remove it from just enumaration ?
but anyway we need to record those registers.

Regards,
Oza.

--- On Wed, 7/1/09, Hui Zhu <teawater@gmail.com> wrote:

> From: Hui Zhu <teawater@gmail.com>
> Subject: Re: i386.record.floating.point.patch : with more testing and assurity
> To: "paawan oza" <paawan1982@yahoo.com>, "Pedro Alves" <pedro@codesourcery.com>, "Mark Kettenis" <mark.kettenis@xs4all.nl>, "Michael Snyder" <msnyder@vmware.com>
> Cc: gdb-patches@sourceware.org
> Date: Wednesday, July 1, 2009, 11:23 AM
> About this patch, I say my idea
> again, I told in
> http://sourceware.org/ml/gdb-patches/2009-06/msg00014.html
> @@ -145,7 +145,22 @@
>    I386_ES_REGNUM,   
>     /* %es */
>    I386_FS_REGNUM,   
>     /* %fs */
>    I386_GS_REGNUM,   
>     /* %gs */
> -  I386_ST0_REGNUM   
>     /* %st(0) */
> +  I386_ST0_REGNUM,   
>     /* %st(0) */
> +  I386_ST1_REGNUM,   
>     /* %st(1) */
> +  I386_ST2_REGNUM,   
>     /* %st(2) */
> +  I386_ST3_REGNUM,   
>     /* %st(3) */
> +  I386_ST4_REGNUM,   
>     /* %st(4) */
> +  I386_ST5_REGNUM,   
>     /* %st(5) */
> +  I386_ST6_REGNUM,   
>     /* %st(6) */
> +  I386_ST7_REGNUM,   
>     /* %st(7) */
> +  I386_FCTRL,       
>     /* floating point env regs : FCTRL-FOP
> */    
> +  I386_FSTAT,
> +  I386_FTAG,       
>     
> +  I386_FISEG,
> +  I386_FIOFF,
> +  I386_FOSEG,
> +  I386_FOOFF,
> +  I386_FOP
>  };
> 
> You are working on make prec x86 support fp insn, not to
> extend the fp
> function of i386 (If you want, you can make a special patch
> for it).
> 
> Hui
> 
> On Tue, Jun 30, 2009 at 23:05, paawan oza<paawan1982@yahoo.com>
> wrote:
> >
> > Hi,
> > As I am submitting the patch for the first time, I am
> not much aware of gdb test suite.
> > would you please guide me about how I can put the
> things in the testsuite ?
> > is it the testsuite which comes along with the gdb
> source ?
> > gdb\testsuite\gdb.base ??
> > Regards,
> > Oza.
> >
> > --- On Tue, 6/30/09, Pedro Alves <pedro@codesourcery.com>
> wrote:
> >
> >> From: Pedro Alves <pedro@codesourcery.com>
> >> Subject: Re: i386.record.floating.point.patch :
> with more testing and assurity
> >> To: gdb-patches@sourceware.org
> >> Cc: "paawan oza" <paawan1982@yahoo.com>,
> teawater@gmail.com
> >> Date: Tuesday, June 30, 2009, 7:09 PM
> >> On Tuesday 30 June 2009 14:23:30,
> >> paawan oza wrote:
> >> >
> >> > > As suggested by Hui,
> >> > > I have come up with more detailed and
> granular
> >> test case
> >> > > for the patch which I had submitted last
> week.
> >>
> >> Could you please consider migrating that test into
> the
> >> testsuite?
> >> You've gone through the trouble of writing tests
> to make
> >> sure
> >> the features work now --- putting it in the
> testsuite means
> >> we
> >> have an automatic-ish means to check that it
> doesn't get
> >> inadvertently broken in the future.  The way it
> is,
> >> when your
> >> code gets in, the test will probably end up lost
> in the
> >> archives.
> >> We wouldn't want that, would we?  :-)  Having
> >> auto-tests, also helps
> >> the person doing the review in confirming things
> work as
> >> expected (without much effort).
> >>
> >> --
> >> Pedro Alves
> >>
> >
> >
> >
> >
> 




^ permalink raw reply	[flat|nested] 40+ messages in thread
* Re: i386.record.floating.point.patch : with more testing and assurity
@ 2009-06-30 15:05 paawan oza
  2009-07-01  5:53 ` Hui Zhu
  2009-07-12 11:12 ` Michael Snyder
  0 siblings, 2 replies; 40+ messages in thread
From: paawan oza @ 2009-06-30 15:05 UTC (permalink / raw)
  To: gdb-patches, Pedro Alves; +Cc: teawater


Hi,
As I am submitting the patch for the first time, I am not much aware of gdb test suite.
would you please guide me about how I can put the things in the testsuite ?
is it the testsuite which comes along with the gdb source ?
gdb\testsuite\gdb.base ??
Regards,
Oza.

--- On Tue, 6/30/09, Pedro Alves <pedro@codesourcery.com> wrote:

> From: Pedro Alves <pedro@codesourcery.com>
> Subject: Re: i386.record.floating.point.patch : with more testing and assurity
> To: gdb-patches@sourceware.org
> Cc: "paawan oza" <paawan1982@yahoo.com>, teawater@gmail.com
> Date: Tuesday, June 30, 2009, 7:09 PM
> On Tuesday 30 June 2009 14:23:30,
> paawan oza wrote:
> > 
> > > As suggested by Hui, 
> > > I have come up with more detailed and granular
> test case
> > > for the patch which I had submitted last week.
> 
> Could you please consider migrating that test into the
> testsuite?
> You've gone through the trouble of writing tests to make
> sure
> the features work now --- putting it in the testsuite means
> we
> have an automatic-ish means to check that it doesn't get
> inadvertently broken in the future.  The way it is,
> when your
> code gets in, the test will probably end up lost in the
> archives.
> We wouldn't want that, would we?  :-)  Having
> auto-tests, also helps
> the person doing the review in confirming things work as
> expected (without much effort).
> 
> -- 
> Pedro Alves
> 




^ permalink raw reply	[flat|nested] 40+ messages in thread
* i386.record.floating.point.patch : with more testing and assurity
@ 2009-06-30 13:23 paawan oza
  2009-06-30 13:38 ` Pedro Alves
  2009-06-30 13:42 ` Mark Kettenis
  0 siblings, 2 replies; 40+ messages in thread
From: paawan oza @ 2009-06-30 13:23 UTC (permalink / raw)
  To: gdb-patches; +Cc: teawater

[-- Attachment #1: Type: text/plain, Size: 26513 bytes --]

Hi,
Again I am sending the patch, with the test cases.
please do the needful
Regards,
Oza.

--- On Thu, 6/4/09, paawan oza <paawan1982@yahoo.com> wrote:

> From: paawan oza <paawan1982@yahoo.com>
> Subject: i386.record.floating.point.patch : with more testing and assurity
> To: gdb-patches@sourceware.org
> Cc: "Hui Zhu" <teawater@gmail.com>
> Date: Thursday, June 4, 2009, 8:20 PM
> Hi All,
> 
> As suggested by Hui, 
> I have come up with more detailed and granular test case
> for the patch which I had submitted last week.
> 
> -> it does basic as well as advanced verification for
> the patch, details could be found in test_floats.c
> -> I have also tried to take coverage using gcov and the
> number is almost around 80-85% for that patch, which is nice
> to have.
> -> the patch works well with all the scenarios described
> in test_floats.c
> 
> please find the patch and test_float.c attached, as well as
> part of email body also. 
> 
> PS : there os no change in patch, only improvement is it is
> tested throughly as much as posible.
> 
> please provide your review comments.
> 
> Regards,
> Oza.
> 
> 
> ****************************************************
> test_float.c
> ****************************************************
> #include <stdio.h>
> #include <math.h>
> #include <stdlib.h>
> 
> /* the test intends to test following insns.  
> flds faddp fstps fstpl fldl fxch fabs fdivrp fmulp fsubrp
> fucomp fnstsw fsqrt
> fchs f2xm1 fyl2x fxtract fprem1 fld fdecstp fld1 fldl2t
> fldl2e FLDPI FLDLG2 FLDLN2
> FLDZ fincstp ffree fptan fpatan fincstp fsincos frndint
> fscale fsin fcos fcmovb
> fcmovbe fcmove fcmovu fcmovnb fcmovnbe fsave frstor fstsw 
> */
> 
> float no1,no2,no3,no4,no5,no6,no7;
> double x = 100.345, y = 25.7789;
> long double ldx = 88888888888888888888.88, ldy =
> 9999999999999999999.99;
> float result,resultd,resultld; 
> float *float_memory;
> 
> /* initialization of floats */
> void init_floats()
> {
>   no1 = 10.45;
>   no2 = 20.77;
>   no3 = 156.89874646;
>   no4 = 14.56;
>   no5 = 11.11;
>   no6 = 66.77;
>   no7 = 88.88;
>   float_memory = malloc(sizeof(float) * 4);
>   *float_memory = 256.256;
>   *(float_memory + 1) = 356.356;
>   *(float_memory + 2) = 456.456;
>   *(float_memory + 3) = 556.556;
> }
> 
> /* marks FPU stack as empty */
> void empty_fpu_stack()
> {
>   asm ("ffree %st(1) \n\t"
>        "ffree %st(2) \n\t"
>        "ffree %st(3) \n\t"
>        "ffree %st(4) \n\t"
>        "ffree %st(5) \n\t"
>        "ffree %st(6) \n\t"
>        "ffree %st(7)");
> }   
> 
> /* tests floating point arithmatic */
> void test_arith_floats()
> {
>   result = no1 + no2 + no3 + no4 + no5 + no6 + no7;
>   printf("result is %f\n",result);
> 
>   result = fmodf(no2,no1); 
>   printf("result is %f\n",result);
> 
>   resultd = fmod(x,y); 
>   printf("result is %f\n",resultd);
>  
>   resultld = fmodl(ldy,ldy); 
>   printf("result is %f\n",resultld);
> 
>   result = fabsf(no1);        
>   printf("result is %f\n",result);
> 
>   result = no3 / no4;
>   printf("result is %f\n",result);
> 
>   result = no1 * no2 * no3 * no4;
>   printf("result is %f\n",result);
> 
>   result = no1 - no2 - no3 - no4;
>   printf("result is %f\n",result);
> 
> 
>   asm ("fld %0" : :"m"(*float_memory));
>   asm ("fchs");
>   
>   /* test for f2xm1 */  
>   asm ("fld %0" : :"m"(*float_memory)); 
>   asm ("f2xm1");
> 
>   asm ("fyl2x");
> 
>   asm ("fld %0" : :"m"(*float_memory)); 
>   asm ("fxtract");
> 
>   asm ("fld %0" : :"m"(*float_memory)); 
>   asm ("fprem1");
> 
>   /* decrement fpu stack pointer only status register
> should get affected */
>   asm ("fld %0" :
> :"m"(*float_memory));   
>   
>   empty_fpu_stack();
>   
>   asm ("fld1");
>   asm ("fldl2t");
>   asm ("fldl2e");
>   asm ("fldpi");
>   asm ("fldlg2");
>   asm ("fldln2");
>   asm ("fldz");
> 
>   empty_fpu_stack();
>   /* finishing emptying the stack */
>       
>   result = sqrt(no3);
>   printf("result is %f\n",result);
> }
> 
> void test_log_exp_floats()
> {
>   result = log10(no3);
>   printf("result is %f\n",result);
> 
>   result = log(no3);
>   printf("result is %f\n",result);
> 
>   result = exp10(no3);
>   printf("result is %f\n",result);
> 
>   result = exp(no3);
>   printf("result is %f\n",result);
> }
> 
> void test_trigo_floats()
> {
>   result = sin(30);
>   printf("result is %f\n",result);
> 
>   result = cos(30);
>   printf("result is %f\n",result);
> 
>   result = tan(30);
>   printf("result is %f\n",result);
> 
>   result = atan(30);
>   printf("result is %f\n",result);
> 
>   asm ("fld %0" : :"m"(*float_memory)); 
>   asm ("fptan");
> 
>   /* changes st1 and popping register stack */
>   asm ("fpatan");  
> 
>   asm("fincstp");
>   asm ("fld %0" : :"m"(float_memory)); 
>   asm ("fsincos");
> 
>   asm ("fld %0" : :"m"(*float_memory)); 
>   asm ("frndint");
> 
>   asm ("fld %0" : :"m"(*float_memory));
>   asm ("fld %0" : :"m"(*(float_memory+1)));  
>   asm ("fscale");
> 
>   empty_fpu_stack();
> 
>   asm ("fld %0" : :"m"(*float_memory)); 
>   asm ("fsin");
>   asm ("fcos");
> 
>   /* currently we assume condition likely and always
> record the registers 
>   code could be optimized only if the flag is set then
> record */
>   asm ("fld %0" : :"m"(*float_memory));
>   asm ("fld %0" : :"m"(*(float_memory+1)));  
>   asm ("fcmovb %st(1), %st");
>   asm ("fcmovbe %st(1), %st");
>   asm ("fcmove %st(1), %st");
>   asm ("fcmovu %st(1), %st");
>   asm ("fcmovnb %st(1), %st");
>   asm ("fcmovnbe %st(1), %st");
> 
>   empty_fpu_stack();
>   /* finished emtyping the stack */
> }
> 
> void test_compare_floats()
> {
>     ldy = 88888888888888888888.88;
>     if (ldx == ldy)
>       ldy =
> 7777777777777777777777777777.777;
>     else
>       ldy =
> 666666666666666666666666666.666;
> }
> 
> /* test loading and saving of FPU environment */
> void test_fpu_env()
> {
>   asm ("fsave %0" : "=m"(*float_memory) : );
>   asm ("frstor %0" : : "m"(*float_memory));
>   asm ("fstsw %ax");  
> }
> 
> int main()
> {
>     init_floats();
>     test_arith_floats();
>     test_log_exp_floats();
>     test_trigo_floats();
>     test_compare_floats();
>     test_fpu_env();
> }
> 
> ******************************************************
> i386-record-floats.patch
> ******************************************************
> 
> diff -urN gdb.orig/i386-tdep.c gdb.new/i386-tdep.c
> --- gdb.orig/i386-tdep.c    2009-05-29
> 17:08:40.000000000 -0400
> +++ gdb.new/i386-tdep.c    2009-06-01
> 20:02:23.000000000 -0400
> @@ -543,6 +543,9 @@
>  /* The maximum number of saved registers.  This
> should include all
>     registers mentioned above, and %eip. 
> */
>  #define I386_NUM_SAVED_REGS   
> I386_NUM_GREGS
> +#define I386_SAVE_FPU_REGS   
>     0xFFFD
> +#define I386_SAVE_FPU_ENV   
>     0xFFFE
> +#define I386_SAVE_FPU_ENV_REG_STACK   
> 0xFFFF
>  
>  struct i386_frame_cache
>  {
> @@ -2985,6 +2988,54 @@
>    return 0;
>  }
>  
> +/* Record the value of floating point registers which will
> be changed by the current instruction
> +   to "record_arch_list".
> +   return -1 if something is wrong.
> */  
> +
> +static int i386_record_floats(struct i386_record_s *ir,
> uint32_t iregnum)
> +{
> +  int i;
> +
> +  /* Oza : push/pop of fpu stack is going to happen 
> +     currently we store st0-st7
> registers, but we need not store all registers all the
> time.
> +     using fstatus, we use 11-13 bits
> which gives us stack top and hence we optimize our storage.
> */
> +  if (I386_SAVE_FPU_REGS == iregnum)
> +    {
> +      for
> (i=I386_ST0_REGNUM;i<=I386_ST7_REGNUM;i++)
> +        {
> +          if
> (record_arch_list_add_reg (ir->regcache,i))
> +            return -1; 
>   
> +        }
> +    }
> +  else if (I386_SAVE_FPU_ENV == iregnum)
> +    {
> +      for
> (i=I386_FCTRL;i<=I386_FOP;i++)
> +      {
> +        if (record_arch_list_add_reg
> (ir->regcache,i))
> +          return -1;   
> 
> +      }
> +    }
> +  else if (I386_SAVE_FPU_ENV_REG_STACK == iregnum)
> +    {
> +      for
> (i=I386_ST0_REGNUM;i<=I386_FOP;i++)
> +      {
> +        if (record_arch_list_add_reg
> (ir->regcache,i))
> +          return -1;   
> 
> +      }
> +    }
> +  else if (iregnum >= I386_ST0_REGNUM &&
> iregnum <= I386_FOP)
> +    {
> +      if (record_arch_list_add_reg
> (ir->regcache,iregnum))
> +        return -1;
> +    }
> +  else
> +    {
> +      /* param Error */
> +      return -1;
> +    } 
> +  return 0;
> +}
> +
>  /* Parse the current instruction and record the values of
> the registers and
>     memory that will be changed in current
> instruction to "record_arch_list".
>     Return -1 if something wrong. */
> @@ -4035,7 +4086,6 @@
>        break;
>  
>        /* floats */
> -      /* It just record the memory change
> of instrcution. */
>      case 0xd8:
>      case 0xd9:
>      case 0xda:
> @@ -4056,39 +4106,49 @@
>          return -1;
>        switch (ir.reg)
>          {
> -        case 0x00:
> -        case 0x01:
>          case 0x02:
> -        case 0x03:
> +        case 0x12:
> +        case 0x22:
> +        case 0x32:
> +          /* for FCOM, FICOM
> nothing to do */
> +              break;
> +            case 0x03:
> +        case 0x13:
> +        case 0x23:
> +        case 0x33:
> +            /* FCOMP,
> FICOMP pop FPU stack, store all */
> +          if
> (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
> +               
> return -1;
> +              break;
> +        case 0x00:
> +            
>   case 0x01:
>          case 0x04:
>          case 0x05:
>          case 0x06:
>          case 0x07:
>          case 0x10:
> -        case 0x11:
> -        case 0x12:
> -        case 0x13:
> +            
>   case 0x11:
>          case 0x14:
>          case 0x15:
>          case 0x16:
>          case 0x17:
>          case 0x20:
>          case 0x21:
> -        case 0x22:
> -        case 0x23:
>          case 0x24:
>          case 0x25:
>          case 0x26:
>          case 0x27:
>          case 0x30:
>          case 0x31:
> -        case 0x32:
> -        case 0x33:
>          case 0x34:
>          case 0x35:
>          case 0x36:
>          case 0x37:
> -          break;
> +          /* FADD, FMUL,
> FSUB, FSUBR, FDIV, FDIVR, FIADD, FIMUL, FISUB, FISUBR,
> FIDIV, FIDIVR  
> +             
> ModR/M.reg is an extension of code, always affects st(0)
> register */
> +          if
> (i386_record_floats(&ir, I386_ST0_REGNUM))
> +               
> return -1;
> +             
> break;       
>           
>         
>          case 0x08:
>          case 0x0a:
>          case 0x0b:
> @@ -4096,6 +4156,7 @@
>          case 0x19:
>          case 0x1a:
>          case 0x1b:
> +        case 0x1d: 
>          case 0x28:
>          case 0x29:
>          case 0x2a:
> @@ -4103,11 +4164,16 @@
>          case 0x38:
>          case 0x39:
>          case 0x3a:
> -        case 0x3b:
> +        case
> 0x3b:       
> +        case 0x3c: 
> +        case 0x3d: 
>            switch (ir.reg
> & 7)
>          {
>          case 0:
> -          break;
> +          /* FLD, FILD
> */
> +              if
> (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
> +               
>     return -1;    
> +               
>   break;
>          case 1:
>            switch
> (ir.reg >> 4)
>              {
> @@ -4120,6 +4186,7 @@
>             
> return -1;
>               
> break;
>              case
> 3:
> +             
> break;
>             
> default:
>               
> if (record_arch_list_add_mem (addr, 2))
>             
> return -1;
> @@ -4130,15 +4197,42 @@
>            switch
> (ir.reg >> 4)
>              {
>              case
> 0:
> +             
> if (record_arch_list_add_mem (addr, 4))
> +           
> return -1;
> +             
> if (3 == (ir.reg & 7))
> +               
>         {
> +               
>         /* FSTP m32fp */
> +             
>   if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
> +             
>     return -1;         
>               
> +               
>         } 
> +               
>       break;
>              case
> 1:
>               
> if (record_arch_list_add_mem (addr, 4))
>             
> return -1;
> +             
> if ((3 == (ir.reg & 7)) || (5 == (ir.reg & 7)) || (7
> == (ir.reg & 7)))
> +               
>         {
> +               
>         /* FSTP */
> +             
>   if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
> +             
>     return -1;         
>               
> +               
>         } 
>               
> break;
>              case
> 2:
>               
> if (record_arch_list_add_mem (addr, 8))
>             
> return -1;
> +             
> if (3 == (ir.reg & 7))
> +               
>         {
> +               
>         /* FSTP m64fp */
> +             
>   if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
> +             
>     return -1;         
>               
> +               
>         } 
>               
> break;
>              case
> 3:
> +             
> if ((3 <= (ir.reg & 7)) && (6 <= (ir.reg
> & 7)))
> +               
>         {
> +               
>         /* FISTP, FBLD, FILD, FBSTP */
> +             
>   if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
> +             
>     return -1;         
>               
> +               
>         }       
>                 
>             
> default:
>               
> if (record_arch_list_add_mem (addr, 2))
>             
> return -1;
> @@ -4147,54 +4241,71 @@
>            break;
>          }
>            break;
> -        case 0x0c:
> -        case 0x0d:
> -        case 0x1d:
> -        case 0x2c:
> -        case 0x3c:
> -        case 0x3d:
> -          break;
> -        case 0x0e:
> +           case
> 0x0c:
> +          /* FLDENV */
> +          if
> (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
> +            return
> -1;  
> +              break;
> +        case 0x0d: 
> +              /* FLDCW
> */
> +          if
> (i386_record_floats(&ir, I386_FCTRL))
> +            return
> -1;  
> +              break;
> +        case 0x2c: 
> +              /*
> FRTSTOR */
> +          if
> (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
> +            return
> -1;  
> +          break; 
> +        case 0x0e: 
>            if (ir.dflag)
>          {
> -          if
> (record_arch_list_add_mem (addr, 28))
> -            return
> -1;
> +        if
> (record_arch_list_add_mem (addr, 28))
> +          return -1;
>          }
>            else
>          {
> -          if
> (record_arch_list_add_mem (addr, 14))
> -            return
> -1;
> +        if
> (record_arch_list_add_mem (addr, 14))
> +          return -1;
>          }
>            break;
> -        case 0x0f:
> -        case 0x2f:
> +        case 0x0f:  
> +        case 0x2f:  
>            if
> (record_arch_list_add_mem (addr, 2))
>          return -1;
>            break;
> -        case 0x1f:
> -        case 0x3e:
> +        case 0x1f:  
> +        case 0x3e:  
>            if
> (record_arch_list_add_mem (addr, 10))
>          return -1;
> +              /* FSTP,
> FBSTP */
> +              if
> (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
> +            return
> -1;               
>                
>   
>            break;
> -        case 0x2e:
> +        case 0x2e: 
>            if (ir.dflag)
>          {
> -          if
> (record_arch_list_add_mem (addr, 28))
> -            return
> -1;
> -          addr += 28;
> +        if
> (record_arch_list_add_mem (addr, 28))
> +          return -1;
> +        addr += 28;
>          }
>            else
>          {
> -          if
> (record_arch_list_add_mem (addr, 14))
> -            return
> -1;
> -          addr += 14;
> +        if
> (record_arch_list_add_mem (addr, 14))
> +          return -1;
> +        addr += 14;
>          }
>            if
> (record_arch_list_add_mem (addr, 80))
>          return -1;
> +              /* FSAVE
> */
> +          if
> (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
> +            return
> -1;   
>            break;
> -        case 0x3f:
> +        case 0x3f: 
>            if
> (record_arch_list_add_mem (addr, 8))
>          return -1;
> +        /* FISTP */
> +              if
> (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
> +            return
> -1;   
>            break;
>          default:
>            ir.addr -= 2;
> @@ -4202,9 +4313,180 @@
>            goto no_support;
>            break;
>          }
> -    }
> +    }   
> +        /* opcode is an extension of
> modR/M byte */     
> +    else
> +    { 
> +          switch (opcode)
> +            {
> +            case 0xd8:
> +              if
> (i386_record_floats(&ir, I386_ST0_REGNUM))
> +               
> return -1;    
> +              break;
> +            case 0xd9: 
>   
> +              if (0x0c
> == (ir.modrm >> 4))
> +                {
> +               
>   if ((ir.modrm & 0x0f) <= 7)
> +               
>     {
> +               
>     if (i386_record_floats(&ir,
> I386_SAVE_FPU_REGS))
> +               
>       return -1;    
> +               
>     }
> +               
>   else
> +               
>     {
> +               
>     if (i386_record_floats(&ir,
> I386_ST0_REGNUM))
> +               
>       return -1;    
> +               
>     /* if only st(0) is changing, then we have
> already recorded */
> +               
>     if ((ir.modrm & 0x0f) - 0x08)
> +               
>       {
> +               
>       if (i386_record_floats(&ir,
> I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
> +               
>         return -1;   
>                
>       
> +               
>       } 
> +               
>     }  
> +                }
> +              else
> +                {
> +               
> switch(ir.modrm)
> +               
>   {
> +               
>   case 0xe0:
> +               
>   case 0xe1:
> +               
>   case 0xf0:
> +               
>   case 0xf5:
> +               
>   case 0xf8:
> +               
>   case 0xfa:
> +               
>   case 0xfc:
> +               
>   case 0xfe:
> +               
>   case 0xff:
> +               
>     if (i386_record_floats(&ir,
> I386_ST0_REGNUM))
> +               
>       return -1;
> +               
>     break;       
>    
> +               
>   case 0xf1:  
> +               
>   case 0xf2:  
> +               
>   case 0xf3:  
> +               
>   case 0xf4:
> +               
>   case 0xf6:        
> +               
>   case 0xf7:    
> +               
>   case 0xe8:  
> +               
>   case 0xe9:  
> +               
>   case 0xea:  
> +               
>   case 0xeb:
> +               
>   case 0xec:        
> +               
>   case 0xed:    
> +               
>   case 0xee:   
> +               
>   case 0xf9:     
> +               
>   case 0xfb:
> +               
>     if (i386_record_floats(&ir,
> I386_SAVE_FPU_REGS))
> +               
>       return -1;    
> +               
>     break;
> +               
>   case 0xfd: 
> +               
>     if (i386_record_floats(&ir,
> I386_ST0_REGNUM))
> +               
>       return -1;
> +               
>     if (i386_record_floats(&ir,
> I386_ST1_REGNUM))
> +               
>       return -1;
> +               
>     break;
> +               
>   } 
> +              }
> +              break;
> +            case 0xda:
> +              if (0xe9
> == ir.modrm)
> +                {
> +        if
> (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
> +               
>   return -1;           
>         
> +                }
> +              else if
> ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >>
> 4))
> +                {
> +                if
> (i386_record_floats(&ir, I386_ST0_REGNUM))
> +               
>   return -1;         
>           
> +                if
> (((ir.modrm & 0x0f) > 0) && ((ir.modrm &
> 0x0f) <= 7))
> +               
>   {
> +               
>   if (i386_record_floats(&ir, I386_ST0_REGNUM +
> (ir.modrm & 0x0f)))
> +               
>     return -1;       
>                
>   
> +               
>   }
> +               
> else if ((ir.modrm & 0x0f) - 0x08)
> +               
>   {
> +          if
> (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm
> & 0x0f) - 0x08)))
> +               
>     return -1;
> +               
>   }
> +               
> }  
> +              break; 
> +            case 0xdb:
> +              if (0xe3
> == ir.modrm)
> +                {
> +        if
> (i386_record_floats(&ir, I386_SAVE_FPU_ENV))
> +               
>   return -1;           
>         
> +                }
> +              else if
> ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >>
> 4))
> +                {
> +                if
> (i386_record_floats(&ir, I386_ST0_REGNUM))
> +               
>   return -1;         
>           
> +                if
> (((ir.modrm & 0x0f) > 0) && ((ir.modrm &
> 0x0f) <= 7))
> +               
>   {
> +               
>   if (i386_record_floats(&ir, I386_ST0_REGNUM +
> (ir.modrm & 0x0f)))
> +               
>     return -1;       
>                
>   
> +               
>   }
> +               
> else if ((ir.modrm & 0x0f) - 0x08)
> +               
>   {
> +          if
> (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm
> & 0x0f) - 0x08)))
> +               
>     return -1;
> +               
>   }
> +               
> }  
> +              break;
> +            case 0xdc:
> +              if ((0x0c
> == ir.modrm >> 4) || (0x0d == ir.modrm >> 4) ||
> (0x0f == ir.modrm >> 4))
> +                {
> +                if
> ((ir.modrm & 0x0f) <= 7)
> +               
>   {
> +               
>   if (i386_record_floats(&ir, I386_ST0_REGNUM +
> (ir.modrm & 0x0f)))
> +               
>     return -1;       
>                
>   
> +               
>   }
> +               
> else
> +               
>   {
> +          if
> (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm
> & 0x0f) - 0x08)))
> +               
>     return -1;
> +               
>   }
> +               
> }  
> +           
>    break;
> +            case 0xdd: 
>            
> +              if (0x0c
> == ir.modrm >> 4)
> +                {
> +               
>   if (i386_record_floats(&ir,I386_FTAG))
> +               
>     return -1;
> +                }
> +              else if
> ((0x0d == ir.modrm >> 4) || (0x0e == ir.modrm >>
> 4))
> +                {
> 
> +               
>   if ((ir.modrm & 0x0f) <= 7)
> +               
>     {
> +               
>       if (i386_record_floats(&ir,
> I386_ST0_REGNUM + (ir.modrm & 0x0f)))
> +               
>         return
> -1;     
> +               
>     }
> +               
>   else
> +               
>     {
> +               
>       if (i386_record_floats(&ir,
> I386_SAVE_FPU_REGS))
> +               
>         return -1;
> +               
>     }
> +               
> }            
> +              break;
> +            case 0xde:
> +              if ((0x0c
> == ir.modrm >> 4) || (0x0e == ir.modrm >> 4) ||
> (0x0f == ir.modrm >> 4) || (0xd9 == ir.modrm))
> +               
> {               
>    
> +               
>   if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
> +               
>     return -1;     
> +               
> }   
> +              break;
> +            case 0xdf:
> +          if (0xe0 ==
> ir.modrm)
> +                {
> +               
>   if (record_arch_list_add_reg (ir.regcache,
> I386_EAX_REGNUM))
> +          
>     return -1;
> +                }
> +              else if
> ((0x0f == ir.modrm >> 4) || (0x0e == ir.modrm >>
> 4))
> +                {
> 
> +               
>   if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
> +               
>     return -1;
> +                }
> 
> +              break;
> +            }
>       
> +        }     
>    
>        break;
> -
>        /* string ops */
>        /* movsS */
>      case 0xa4:
> @@ -4623,10 +4905,17 @@
>        /* fwait */
>        /* XXX */
>      case 0x9b:
> -      printf_unfiltered (_("Process record
> doesn't support instruction "
> -           
>    "fwait.\n"));
> -      ir.addr -= 1;
> -      goto no_support;
> +      if (target_read_memory (ir.addr,
> &tmpu8, 1))
> +    {
> +      if (record_debug)
> +        printf_unfiltered
> (_("Process record: error reading memory at "
> +           
>      "addr 0x%s len = 1.\n"),
> +           
>        paddr_nz (ir.addr));
> +      return -1;
> +    }
> +      opcode = (uint32_t) tmpu8;
> +      ir.addr++;
> +      goto reswitch; 
>    
>        break;
>  
>        /* int3 */
> diff -urN gdb.orig/i386-tdep.h gdb.new/i386-tdep.h
> --- gdb.orig/i386-tdep.h    2009-05-17
> 17:56:44.000000000 -0400
> +++ gdb.new/i386-tdep.h    2009-05-31
> 16:33:14.000000000 -0400
> @@ -145,7 +145,22 @@
>    I386_ES_REGNUM,   
>     /* %es */
>    I386_FS_REGNUM,   
>     /* %fs */
>    I386_GS_REGNUM,   
>     /* %gs */
> -  I386_ST0_REGNUM   
>     /* %st(0) */
> +  I386_ST0_REGNUM,   
>     /* %st(0) */
> +  I386_ST1_REGNUM,   
>     /* %st(1) */
> +  I386_ST2_REGNUM,   
>     /* %st(2) */
> +  I386_ST3_REGNUM,   
>     /* %st(3) */
> +  I386_ST4_REGNUM,   
>     /* %st(4) */
> +  I386_ST5_REGNUM,   
>     /* %st(5) */
> +  I386_ST6_REGNUM,   
>     /* %st(6) */
> +  I386_ST7_REGNUM,   
>     /* %st(7) */
> +  I386_FCTRL,       
>     /* floating point env regs : FCTRL-FOP
> */    
> +  I386_FSTAT,         
>          
> +  I386_FTAG,       
>     
> +  I386_FISEG,
> +  I386_FIOFF,
> +  I386_FOSEG,
> +  I386_FOOFF,
> +  I386_FOP
>  };
>  
>  #define I386_NUM_GREGS    16
> 
> 
> 
>       


      

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: i386-record-floats.patch --]
[-- Type: text/x-patch; name="i386-record-floats.patch", Size: 16155 bytes --]

diff -urN gdb.orig/i386-tdep.c gdb.new/i386-tdep.c
--- gdb.orig/i386-tdep.c	2009-05-29 17:08:40.000000000 -0400
+++ gdb.new/i386-tdep.c	2009-06-01 20:02:23.000000000 -0400
@@ -543,6 +543,9 @@
 /* The maximum number of saved registers.  This should include all
    registers mentioned above, and %eip.  */
 #define I386_NUM_SAVED_REGS	I386_NUM_GREGS
+#define I386_SAVE_FPU_REGS		0xFFFD
+#define I386_SAVE_FPU_ENV		0xFFFE
+#define I386_SAVE_FPU_ENV_REG_STACK	0xFFFF
 
 struct i386_frame_cache
 {
@@ -2985,6 +2988,54 @@
   return 0;
 }
 
+/* Record the value of floating point registers which will be changed by the current instruction
+   to "record_arch_list".
+   return -1 if something is wrong. */  
+
+static int i386_record_floats(struct i386_record_s *ir, uint32_t iregnum)
+{
+  int i;
+
+  /* Oza : push/pop of fpu stack is going to happen 
+     currently we store st0-st7 registers, but we need not store all registers all the time.
+     using fstatus, we use 11-13 bits which gives us stack top and hence we optimize our storage. */
+  if (I386_SAVE_FPU_REGS == iregnum)
+    {
+      for (i=I386_ST0_REGNUM;i<=I386_ST7_REGNUM;i++)
+        {
+          if (record_arch_list_add_reg (ir->regcache,i))
+            return -1;    
+        }
+    }
+  else if (I386_SAVE_FPU_ENV == iregnum)
+    {
+      for (i=I386_FCTRL;i<=I386_FOP;i++)
+      {
+        if (record_arch_list_add_reg (ir->regcache,i))
+          return -1;    
+      }
+    }
+  else if (I386_SAVE_FPU_ENV_REG_STACK == iregnum)
+    {
+      for (i=I386_ST0_REGNUM;i<=I386_FOP;i++)
+      {
+        if (record_arch_list_add_reg (ir->regcache,i))
+          return -1;    
+      }
+    }
+  else if (iregnum >= I386_ST0_REGNUM && iregnum <= I386_FOP)
+    {
+      if (record_arch_list_add_reg (ir->regcache,iregnum))
+        return -1;
+    }
+  else
+    {
+      /* param Error */
+      return -1;
+    } 
+  return 0;
+}
+
 /* Parse the current instruction and record the values of the registers and
    memory that will be changed in current instruction to "record_arch_list".
    Return -1 if something wrong. */
@@ -4035,7 +4086,6 @@
       break;
 
       /* floats */
-      /* It just record the memory change of instrcution. */
     case 0xd8:
     case 0xd9:
     case 0xda:
@@ -4056,39 +4106,49 @@
 	    return -1;
 	  switch (ir.reg)
 	    {
-	    case 0x00:
-	    case 0x01:
 	    case 0x02:
-	    case 0x03:
+	    case 0x12:
+	    case 0x22:
+	    case 0x32:
+	      /* for FCOM, FICOM nothing to do */
+              break;
+            case 0x03:
+	    case 0x13:
+	    case 0x23:
+	    case 0x33:
+  	      /* FCOMP, FICOMP pop FPU stack, store all */
+	      if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                return -1;
+              break;
+	    case 0x00:
+       	    case 0x01:
 	    case 0x04:
 	    case 0x05:
 	    case 0x06:
 	    case 0x07:
 	    case 0x10:
-	    case 0x11:
-	    case 0x12:
-	    case 0x13:
+       	    case 0x11:
 	    case 0x14:
 	    case 0x15:
 	    case 0x16:
 	    case 0x17:
 	    case 0x20:
 	    case 0x21:
-	    case 0x22:
-	    case 0x23:
 	    case 0x24:
 	    case 0x25:
 	    case 0x26:
 	    case 0x27:
 	    case 0x30:
 	    case 0x31:
-	    case 0x32:
-	    case 0x33:
 	    case 0x34:
 	    case 0x35:
 	    case 0x36:
 	    case 0x37:
-	      break;
+	      /* FADD, FMUL, FSUB, FSUBR, FDIV, FDIVR, FIADD, FIMUL, FISUB, FISUBR, FIDIV, FIDIVR  
+              ModR/M.reg is an extension of code, always affects st(0) register */
+	      if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                return -1;
+              break;           	    	    
 	    case 0x08:
 	    case 0x0a:
 	    case 0x0b:
@@ -4096,6 +4156,7 @@
 	    case 0x19:
 	    case 0x1a:
 	    case 0x1b:
+	    case 0x1d: 
 	    case 0x28:
 	    case 0x29:
 	    case 0x2a:
@@ -4103,11 +4164,16 @@
 	    case 0x38:
 	    case 0x39:
 	    case 0x3a:
-	    case 0x3b:
+	    case 0x3b:	   
+	    case 0x3c: 
+	    case 0x3d: 
 	      switch (ir.reg & 7)
 		{
 		case 0:
-		  break;
+		  /* FLD, FILD */
+	          if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                    return -1;    
+                  break;
 		case 1:
 		  switch (ir.reg >> 4)
 		    {
@@ -4120,6 +4186,7 @@
 			return -1;
 		      break;
 		    case 3:
+		      break;
 		    default:
 		      if (record_arch_list_add_mem (addr, 2))
 			return -1;
@@ -4130,15 +4197,42 @@
 		  switch (ir.reg >> 4)
 		    {
 		    case 0:
+		      if (record_arch_list_add_mem (addr, 4))
+			return -1;
+		      if (3 == (ir.reg & 7))
+                        {
+                        /* FSTP m32fp */
+		        if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        } 
+                      break;
 		    case 1:
 		      if (record_arch_list_add_mem (addr, 4))
 			return -1;
+		      if ((3 == (ir.reg & 7)) || (5 == (ir.reg & 7)) || (7 == (ir.reg & 7)))
+                        {
+                        /* FSTP */
+		        if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        } 
 		      break;
 		    case 2:
 		      if (record_arch_list_add_mem (addr, 8))
 			return -1;
+		      if (3 == (ir.reg & 7))
+                        {
+                        /* FSTP m64fp */
+		        if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        } 
 		      break;
 		    case 3:
+		      if ((3 <= (ir.reg & 7)) && (6 <= (ir.reg & 7)))
+                        {
+                        /* FISTP, FBLD, FILD, FBSTP */
+		        if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        }                        
 		    default:
 		      if (record_arch_list_add_mem (addr, 2))
 			return -1;
@@ -4147,54 +4241,71 @@
 		  break;
 		}
 	      break;
-	    case 0x0c:
-	    case 0x0d:
-	    case 0x1d:
-	    case 0x2c:
-	    case 0x3c:
-	    case 0x3d:
-	      break;
-	    case 0x0e:
+   	    case 0x0c:
+	      /* FLDENV */
+	      if (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
+	        return -1;  
+              break;
+	    case 0x0d: 
+              /* FLDCW */
+	      if (i386_record_floats(&ir, I386_FCTRL))
+	        return -1;  
+              break;
+	    case 0x2c: 
+              /* FRTSTOR */
+	      if (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
+	        return -1;  
+	      break; 
+	    case 0x0e: 
 	      if (ir.dflag)
 		{
-		  if (record_arch_list_add_mem (addr, 28))
-		    return -1;
+		if (record_arch_list_add_mem (addr, 28))
+		  return -1;
 		}
 	      else
 		{
-		  if (record_arch_list_add_mem (addr, 14))
-		    return -1;
+		if (record_arch_list_add_mem (addr, 14))
+		  return -1;
 		}
 	      break;
-	    case 0x0f:
-	    case 0x2f:
+	    case 0x0f:  
+	    case 0x2f:  
 	      if (record_arch_list_add_mem (addr, 2))
 		return -1;
 	      break;
-	    case 0x1f:
-	    case 0x3e:
+	    case 0x1f:  
+	    case 0x3e:  
 	      if (record_arch_list_add_mem (addr, 10))
 		return -1;
+              /* FSTP, FBSTP */
+              if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+	        return -1;                                  
 	      break;
-	    case 0x2e:
+	    case 0x2e: 
 	      if (ir.dflag)
 		{
-		  if (record_arch_list_add_mem (addr, 28))
-		    return -1;
-		  addr += 28;
+		if (record_arch_list_add_mem (addr, 28))
+		  return -1;
+		addr += 28;
 		}
 	      else
 		{
-		  if (record_arch_list_add_mem (addr, 14))
-		    return -1;
-		  addr += 14;
+		if (record_arch_list_add_mem (addr, 14))
+		  return -1;
+		addr += 14;
 		}
 	      if (record_arch_list_add_mem (addr, 80))
 		return -1;
+              /* FSAVE */
+	      if (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
+	        return -1;   
 	      break;
-	    case 0x3f:
+	    case 0x3f: 
 	      if (record_arch_list_add_mem (addr, 8))
 		return -1;
+		/* FISTP */
+              if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+	        return -1;   
 	      break;
 	    default:
 	      ir.addr -= 2;
@@ -4202,9 +4313,180 @@
 	      goto no_support;
 	      break;
 	    }
-	}
+	}   
+        /* opcode is an extension of modR/M byte */     
+	else
+	{ 
+          switch (opcode)
+            {
+            case 0xd8:
+              if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                return -1;	
+              break;
+            case 0xd9:    
+              if (0x0c == (ir.modrm >> 4))
+                {
+                  if ((ir.modrm & 0x0f) <= 7)
+                    {
+                    if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                      return -1;	
+                    }
+                  else
+                    {
+                    if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                      return -1;	
+                    /* if only st(0) is changing, then we have already recorded */
+                    if ((ir.modrm & 0x0f) - 0x08)
+                      {
+                      if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                        return -1;	                      
+                      } 
+                    }  
+                }
+              else
+                {
+                switch(ir.modrm)
+                  {
+                  case 0xe0:
+                  case 0xe1:
+                  case 0xf0:
+                  case 0xf5:
+                  case 0xf8:
+                  case 0xfa:
+                  case 0xfc:
+                  case 0xfe:
+                  case 0xff:
+                    if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                      return -1;
+                    break;           
+                  case 0xf1:  
+                  case 0xf2:  
+                  case 0xf3:  
+                  case 0xf4:
+                  case 0xf6:        
+                  case 0xf7:    
+                  case 0xe8:  
+                  case 0xe9:  
+                  case 0xea:  
+                  case 0xeb:
+                  case 0xec:        
+                  case 0xed:    
+                  case 0xee:   
+                  case 0xf9:     
+                  case 0xfb:
+                    if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                      return -1;	
+                    break;
+                  case 0xfd: 
+                    if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                      return -1;
+                    if (i386_record_floats(&ir, I386_ST1_REGNUM))
+                      return -1;
+                    break;
+                  } 
+              }
+              break;
+            case 0xda:
+              if (0xe9 == ir.modrm)
+                {
+		if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                  return -1;                    
+                }
+              else if ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >> 4))
+                {
+                if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                  return -1;	                
+                if (((ir.modrm & 0x0f) > 0) && ((ir.modrm & 0x0f) <= 7))
+                  {
+                  if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                    return -1;	                      
+                  }
+                else if ((ir.modrm & 0x0f) - 0x08)
+                  {
+		  if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                    return -1;
+                  }
+                }  
+              break; 
+            case 0xdb:
+              if (0xe3 == ir.modrm)
+                {
+		if (i386_record_floats(&ir, I386_SAVE_FPU_ENV))
+                  return -1;                    
+                }
+              else if ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >> 4))
+                {
+                if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                  return -1;	                
+                if (((ir.modrm & 0x0f) > 0) && ((ir.modrm & 0x0f) <= 7))
+                  {
+                  if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                    return -1;	                      
+                  }
+                else if ((ir.modrm & 0x0f) - 0x08)
+                  {
+		  if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                    return -1;
+                  }
+                }  
+              break;
+            case 0xdc:
+              if ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >> 4) || (0x0f == ir.modrm >> 4))
+                {
+                if ((ir.modrm & 0x0f) <= 7)
+                  {
+                  if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                    return -1;	                      
+                  }
+                else
+                  {
+		  if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                    return -1;
+                  }
+                }  
+               break;
+            case 0xdd:             
+              if (0x0c == ir.modrm >> 4)
+                {
+                  if (i386_record_floats(&ir,I386_FTAG))
+                    return -1;
+                }
+              else if ((0x0d == ir.modrm >> 4) || (0x0e == ir.modrm >> 4))
+                { 
+                  if ((ir.modrm & 0x0f) <= 7)
+                    {
+                      if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                        return -1;	 
+                    }
+                  else
+                    {
+                      if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                        return -1;
+                    }
+                }            
+              break;
+            case 0xde:
+              if ((0x0c == ir.modrm >> 4) || (0x0e == ir.modrm >> 4) || (0x0f == ir.modrm >> 4) || (0xd9 == ir.modrm))
+                {                   
+                  if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                    return -1;	 
+                }   
+              break;
+            case 0xdf:
+	      if (0xe0 == ir.modrm)
+                {
+                  if (record_arch_list_add_reg (ir.regcache, I386_EAX_REGNUM))
+	   	    return -1;
+                }
+              else if ((0x0f == ir.modrm >> 4) || (0x0e == ir.modrm >> 4))
+                { 
+                  if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                    return -1;
+                } 
+              break;
+            } 	  
+        }         
       break;
-
       /* string ops */
       /* movsS */
     case 0xa4:
@@ -4623,10 +4905,17 @@
       /* fwait */
       /* XXX */
     case 0x9b:
-      printf_unfiltered (_("Process record doesn't support instruction "
-			   "fwait.\n"));
-      ir.addr -= 1;
-      goto no_support;
+      if (target_read_memory (ir.addr, &tmpu8, 1))
+	{
+	  if (record_debug)
+	    printf_unfiltered (_("Process record: error reading memory at "
+				 "addr 0x%s len = 1.\n"),
+			       paddr_nz (ir.addr));
+	  return -1;
+	}
+      opcode = (uint32_t) tmpu8;
+      ir.addr++;
+      goto reswitch;     
       break;
 
       /* int3 */
diff -urN gdb.orig/i386-tdep.h gdb.new/i386-tdep.h
--- gdb.orig/i386-tdep.h	2009-05-17 17:56:44.000000000 -0400
+++ gdb.new/i386-tdep.h	2009-05-31 16:33:14.000000000 -0400
@@ -145,7 +145,22 @@
   I386_ES_REGNUM,		/* %es */
   I386_FS_REGNUM,		/* %fs */
   I386_GS_REGNUM,		/* %gs */
-  I386_ST0_REGNUM		/* %st(0) */
+  I386_ST0_REGNUM,		/* %st(0) */
+  I386_ST1_REGNUM,		/* %st(1) */
+  I386_ST2_REGNUM,		/* %st(2) */
+  I386_ST3_REGNUM,		/* %st(3) */
+  I386_ST4_REGNUM,		/* %st(4) */
+  I386_ST5_REGNUM,		/* %st(5) */
+  I386_ST6_REGNUM,		/* %st(6) */
+  I386_ST7_REGNUM,		/* %st(7) */
+  I386_FCTRL,			/* floating point env regs : FCTRL-FOP */	
+  I386_FSTAT,                   
+  I386_FTAG,			
+  I386_FISEG,
+  I386_FIOFF,
+  I386_FOSEG,
+  I386_FOOFF,
+  I386_FOP
 };
 
 #define I386_NUM_GREGS	16

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: test_floats.c --]
[-- Type: text/x-csrc; name="test_floats.c", Size: 4462 bytes --]

#include <stdio.h>
#include <math.h>
#include <stdlib.h>

/* the test intends to test following insns.  
flds faddp fstps fstpl fldl fxch fabs fdivrp fmulp fsubrp fucomp fnstsw fsqrt
fchs f2xm1 fyl2x fxtract fprem1 fld fdecstp fld1 fldl2t fldl2e FLDPI FLDLG2 FLDLN2
FLDZ fincstp ffree fptan fpatan fincstp fsincos frndint fscale fsin fcos fcmovb
fcmovbe fcmove fcmovu fcmovnb fcmovnbe fsave frstor fstsw 
*/

float no1,no2,no3,no4,no5,no6,no7;
double x = 100.345, y = 25.7789;
long double ldx = 88888888888888888888.88, ldy = 9999999999999999999.99;
float result,resultd,resultld; 
float *float_memory;

/* initialization of floats */
void init_floats()
{
  no1 = 10.45;
  no2 = 20.77;
  no3 = 156.89874646;
  no4 = 14.56;
  no5 = 11.11;
  no6 = 66.77;
  no7 = 88.88;
  float_memory = malloc(sizeof(float) * 4);
  *float_memory = 256.256;
  *(float_memory + 1) = 356.356;
  *(float_memory + 2) = 456.456;
  *(float_memory + 3) = 556.556;
}

/* marks FPU stack as empty */
void empty_fpu_stack()
{
  asm ("ffree %st(1) \n\t"
       "ffree %st(2) \n\t"
       "ffree %st(3) \n\t"
       "ffree %st(4) \n\t"
       "ffree %st(5) \n\t"
       "ffree %st(6) \n\t"
       "ffree %st(7)");
}   

/* tests floating point arithmatic */
void test_arith_floats()
{
  result = no1 + no2 + no3 + no4 + no5 + no6 + no7;
  printf("result is %f\n",result);

  result = fmodf(no2,no1); 
  printf("result is %f\n",result);

  resultd = fmod(x,y); 
  printf("result is %f\n",resultd);
 
  resultld = fmodl(ldy,ldy); 
  printf("result is %f\n",resultld);

  result = fabsf(no1);        
  printf("result is %f\n",result);

  result = no3 / no4;
  printf("result is %f\n",result);

  result = no1 * no2 * no3 * no4;
  printf("result is %f\n",result);

  result = no1 - no2 - no3 - no4;
  printf("result is %f\n",result);


  asm ("fld %0" : :"m"(*float_memory));
  asm ("fchs");
  
  /* test for f2xm1 */  
  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("f2xm1");

  asm ("fyl2x");

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fxtract");

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fprem1");

  /* decrement fpu stack pointer only status register should get affected */
  asm ("fld %0" : :"m"(*float_memory));   
  
  empty_fpu_stack();
  
  asm ("fld1");
  asm ("fldl2t");
  asm ("fldl2e");
  asm ("fldpi");
  asm ("fldlg2");
  asm ("fldln2");
  asm ("fldz");

  empty_fpu_stack();
  /* finishing emptying the stack */
      
  result = sqrt(no3);
  printf("result is %f\n",result);
}

void test_log_exp_floats()
{
  result = log10(no3);
  printf("result is %f\n",result);

  result = log(no3);
  printf("result is %f\n",result);

  result = exp10(no3);
  printf("result is %f\n",result);

  result = exp(no3);
  printf("result is %f\n",result);
}

void test_trigo_floats()
{
  result = sin(30);
  printf("result is %f\n",result);

  result = cos(30);
  printf("result is %f\n",result);

  result = tan(30);
  printf("result is %f\n",result);

  result = atan(30);
  printf("result is %f\n",result);

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fptan");

  /* changes st1 and popping register stack */
  asm ("fpatan");  

  asm("fincstp");
  asm ("fld %0" : :"m"(float_memory)); 
  asm ("fsincos");

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("frndint");

  asm ("fld %0" : :"m"(*float_memory));
  asm ("fld %0" : :"m"(*(float_memory+1)));  
  asm ("fscale");

  empty_fpu_stack();

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fsin");
  asm ("fcos");

  /* currently we assume condition likely and always record the registers 
  code could be optimized only if the flag is set then record */
  asm ("fld %0" : :"m"(*float_memory));
  asm ("fld %0" : :"m"(*(float_memory+1)));  
  asm ("fcmovb %st(1), %st");
  asm ("fcmovbe %st(1), %st");
  asm ("fcmove %st(1), %st");
  asm ("fcmovu %st(1), %st");
  asm ("fcmovnb %st(1), %st");
  asm ("fcmovnbe %st(1), %st");

  empty_fpu_stack();
  /* finished emtyping the stack */
}

void test_compare_floats()
{
    ldy = 88888888888888888888.88;
    if (ldx == ldy)
      ldy = 7777777777777777777777777777.777;
    else
      ldy = 666666666666666666666666666.666;
}

/* test loading and saving of FPU environment */
void test_fpu_env()
{
  asm ("fsave %0" : "=m"(*float_memory) : );
  asm ("frstor %0" : : "m"(*float_memory));
  asm ("fstsw %ax");  
}

int main()
{
    init_floats();
    test_arith_floats();
    test_log_exp_floats();
    test_trigo_floats();
    test_compare_floats();
    test_fpu_env();
}

^ permalink raw reply	[flat|nested] 40+ messages in thread
* i386.record.floating.point.patch : with more testing and assurity
@ 2009-06-04 14:50 paawan oza
  0 siblings, 0 replies; 40+ messages in thread
From: paawan oza @ 2009-06-04 14:50 UTC (permalink / raw)
  To: gdb-patches; +Cc: Hui Zhu

[-- Attachment #1: Type: text/plain, Size: 21564 bytes --]

Hi All,

As suggested by Hui, 
I have come up with more detailed and granular test case for the patch which I had submitted last week.

-> it does basic as well as advanced verification for the patch, details could be found in test_floats.c
-> I have also tried to take coverage using gcov and the number is almost around 80-85% for that patch, which is nice to have.
-> the patch works well with all the scenarios described in test_floats.c

please find the patch and test_float.c attached, as well as part of email body also. 

PS : there os no change in patch, only improvement is it is tested throughly as much as posible.

please provide your review comments.

Regards,
Oza.


****************************************************
test_float.c
****************************************************
#include <stdio.h>
#include <math.h>
#include <stdlib.h>

/* the test intends to test following insns.  
flds faddp fstps fstpl fldl fxch fabs fdivrp fmulp fsubrp fucomp fnstsw fsqrt
fchs f2xm1 fyl2x fxtract fprem1 fld fdecstp fld1 fldl2t fldl2e FLDPI FLDLG2 FLDLN2
FLDZ fincstp ffree fptan fpatan fincstp fsincos frndint fscale fsin fcos fcmovb
fcmovbe fcmove fcmovu fcmovnb fcmovnbe fsave frstor fstsw 
*/

float no1,no2,no3,no4,no5,no6,no7;
double x = 100.345, y = 25.7789;
long double ldx = 88888888888888888888.88, ldy = 9999999999999999999.99;
float result,resultd,resultld; 
float *float_memory;

/* initialization of floats */
void init_floats()
{
  no1 = 10.45;
  no2 = 20.77;
  no3 = 156.89874646;
  no4 = 14.56;
  no5 = 11.11;
  no6 = 66.77;
  no7 = 88.88;
  float_memory = malloc(sizeof(float) * 4);
  *float_memory = 256.256;
  *(float_memory + 1) = 356.356;
  *(float_memory + 2) = 456.456;
  *(float_memory + 3) = 556.556;
}

/* marks FPU stack as empty */
void empty_fpu_stack()
{
  asm ("ffree %st(1) \n\t"
       "ffree %st(2) \n\t"
       "ffree %st(3) \n\t"
       "ffree %st(4) \n\t"
       "ffree %st(5) \n\t"
       "ffree %st(6) \n\t"
       "ffree %st(7)");
}   

/* tests floating point arithmatic */
void test_arith_floats()
{
  result = no1 + no2 + no3 + no4 + no5 + no6 + no7;
  printf("result is %f\n",result);

  result = fmodf(no2,no1); 
  printf("result is %f\n",result);

  resultd = fmod(x,y); 
  printf("result is %f\n",resultd);
 
  resultld = fmodl(ldy,ldy); 
  printf("result is %f\n",resultld);

  result = fabsf(no1);        
  printf("result is %f\n",result);

  result = no3 / no4;
  printf("result is %f\n",result);

  result = no1 * no2 * no3 * no4;
  printf("result is %f\n",result);

  result = no1 - no2 - no3 - no4;
  printf("result is %f\n",result);


  asm ("fld %0" : :"m"(*float_memory));
  asm ("fchs");
  
  /* test for f2xm1 */  
  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("f2xm1");

  asm ("fyl2x");

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fxtract");

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fprem1");

  /* decrement fpu stack pointer only status register should get affected */
  asm ("fld %0" : :"m"(*float_memory));   
  
  empty_fpu_stack();
  
  asm ("fld1");
  asm ("fldl2t");
  asm ("fldl2e");
  asm ("fldpi");
  asm ("fldlg2");
  asm ("fldln2");
  asm ("fldz");

  empty_fpu_stack();
  /* finishing emptying the stack */
      
  result = sqrt(no3);
  printf("result is %f\n",result);
}

void test_log_exp_floats()
{
  result = log10(no3);
  printf("result is %f\n",result);

  result = log(no3);
  printf("result is %f\n",result);

  result = exp10(no3);
  printf("result is %f\n",result);

  result = exp(no3);
  printf("result is %f\n",result);
}

void test_trigo_floats()
{
  result = sin(30);
  printf("result is %f\n",result);

  result = cos(30);
  printf("result is %f\n",result);

  result = tan(30);
  printf("result is %f\n",result);

  result = atan(30);
  printf("result is %f\n",result);

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fptan");

  /* changes st1 and popping register stack */
  asm ("fpatan");  

  asm("fincstp");
  asm ("fld %0" : :"m"(float_memory)); 
  asm ("fsincos");

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("frndint");

  asm ("fld %0" : :"m"(*float_memory));
  asm ("fld %0" : :"m"(*(float_memory+1)));  
  asm ("fscale");

  empty_fpu_stack();

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fsin");
  asm ("fcos");

  /* currently we assume condition likely and always record the registers 
  code could be optimized only if the flag is set then record */
  asm ("fld %0" : :"m"(*float_memory));
  asm ("fld %0" : :"m"(*(float_memory+1)));  
  asm ("fcmovb %st(1), %st");
  asm ("fcmovbe %st(1), %st");
  asm ("fcmove %st(1), %st");
  asm ("fcmovu %st(1), %st");
  asm ("fcmovnb %st(1), %st");
  asm ("fcmovnbe %st(1), %st");

  empty_fpu_stack();
  /* finished emtyping the stack */
}

void test_compare_floats()
{
    ldy = 88888888888888888888.88;
    if (ldx == ldy)
      ldy = 7777777777777777777777777777.777;
    else
      ldy = 666666666666666666666666666.666;
}

/* test loading and saving of FPU environment */
void test_fpu_env()
{
  asm ("fsave %0" : "=m"(*float_memory) : );
  asm ("frstor %0" : : "m"(*float_memory));
  asm ("fstsw %ax");  
}

int main()
{
    init_floats();
    test_arith_floats();
    test_log_exp_floats();
    test_trigo_floats();
    test_compare_floats();
    test_fpu_env();
}

******************************************************
i386-record-floats.patch
******************************************************

diff -urN gdb.orig/i386-tdep.c gdb.new/i386-tdep.c
--- gdb.orig/i386-tdep.c	2009-05-29 17:08:40.000000000 -0400
+++ gdb.new/i386-tdep.c	2009-06-01 20:02:23.000000000 -0400
@@ -543,6 +543,9 @@
 /* The maximum number of saved registers.  This should include all
    registers mentioned above, and %eip.  */
 #define I386_NUM_SAVED_REGS	I386_NUM_GREGS
+#define I386_SAVE_FPU_REGS		0xFFFD
+#define I386_SAVE_FPU_ENV		0xFFFE
+#define I386_SAVE_FPU_ENV_REG_STACK	0xFFFF
 
 struct i386_frame_cache
 {
@@ -2985,6 +2988,54 @@
   return 0;
 }
 
+/* Record the value of floating point registers which will be changed by the current instruction
+   to "record_arch_list".
+   return -1 if something is wrong. */  
+
+static int i386_record_floats(struct i386_record_s *ir, uint32_t iregnum)
+{
+  int i;
+
+  /* Oza : push/pop of fpu stack is going to happen 
+     currently we store st0-st7 registers, but we need not store all registers all the time.
+     using fstatus, we use 11-13 bits which gives us stack top and hence we optimize our storage. */
+  if (I386_SAVE_FPU_REGS == iregnum)
+    {
+      for (i=I386_ST0_REGNUM;i<=I386_ST7_REGNUM;i++)
+        {
+          if (record_arch_list_add_reg (ir->regcache,i))
+            return -1;    
+        }
+    }
+  else if (I386_SAVE_FPU_ENV == iregnum)
+    {
+      for (i=I386_FCTRL;i<=I386_FOP;i++)
+      {
+        if (record_arch_list_add_reg (ir->regcache,i))
+          return -1;    
+      }
+    }
+  else if (I386_SAVE_FPU_ENV_REG_STACK == iregnum)
+    {
+      for (i=I386_ST0_REGNUM;i<=I386_FOP;i++)
+      {
+        if (record_arch_list_add_reg (ir->regcache,i))
+          return -1;    
+      }
+    }
+  else if (iregnum >= I386_ST0_REGNUM && iregnum <= I386_FOP)
+    {
+      if (record_arch_list_add_reg (ir->regcache,iregnum))
+        return -1;
+    }
+  else
+    {
+      /* param Error */
+      return -1;
+    } 
+  return 0;
+}
+
 /* Parse the current instruction and record the values of the registers and
    memory that will be changed in current instruction to "record_arch_list".
    Return -1 if something wrong. */
@@ -4035,7 +4086,6 @@
       break;
 
       /* floats */
-      /* It just record the memory change of instrcution. */
     case 0xd8:
     case 0xd9:
     case 0xda:
@@ -4056,39 +4106,49 @@
 	    return -1;
 	  switch (ir.reg)
 	    {
-	    case 0x00:
-	    case 0x01:
 	    case 0x02:
-	    case 0x03:
+	    case 0x12:
+	    case 0x22:
+	    case 0x32:
+	      /* for FCOM, FICOM nothing to do */
+              break;
+            case 0x03:
+	    case 0x13:
+	    case 0x23:
+	    case 0x33:
+  	      /* FCOMP, FICOMP pop FPU stack, store all */
+	      if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                return -1;
+              break;
+	    case 0x00:
+       	    case 0x01:
 	    case 0x04:
 	    case 0x05:
 	    case 0x06:
 	    case 0x07:
 	    case 0x10:
-	    case 0x11:
-	    case 0x12:
-	    case 0x13:
+       	    case 0x11:
 	    case 0x14:
 	    case 0x15:
 	    case 0x16:
 	    case 0x17:
 	    case 0x20:
 	    case 0x21:
-	    case 0x22:
-	    case 0x23:
 	    case 0x24:
 	    case 0x25:
 	    case 0x26:
 	    case 0x27:
 	    case 0x30:
 	    case 0x31:
-	    case 0x32:
-	    case 0x33:
 	    case 0x34:
 	    case 0x35:
 	    case 0x36:
 	    case 0x37:
-	      break;
+	      /* FADD, FMUL, FSUB, FSUBR, FDIV, FDIVR, FIADD, FIMUL, FISUB, FISUBR, FIDIV, FIDIVR  
+              ModR/M.reg is an extension of code, always affects st(0) register */
+	      if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                return -1;
+              break;           	    	    
 	    case 0x08:
 	    case 0x0a:
 	    case 0x0b:
@@ -4096,6 +4156,7 @@
 	    case 0x19:
 	    case 0x1a:
 	    case 0x1b:
+	    case 0x1d: 
 	    case 0x28:
 	    case 0x29:
 	    case 0x2a:
@@ -4103,11 +4164,16 @@
 	    case 0x38:
 	    case 0x39:
 	    case 0x3a:
-	    case 0x3b:
+	    case 0x3b:	   
+	    case 0x3c: 
+	    case 0x3d: 
 	      switch (ir.reg & 7)
 		{
 		case 0:
-		  break;
+		  /* FLD, FILD */
+	          if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                    return -1;    
+                  break;
 		case 1:
 		  switch (ir.reg >> 4)
 		    {
@@ -4120,6 +4186,7 @@
 			return -1;
 		      break;
 		    case 3:
+		      break;
 		    default:
 		      if (record_arch_list_add_mem (addr, 2))
 			return -1;
@@ -4130,15 +4197,42 @@
 		  switch (ir.reg >> 4)
 		    {
 		    case 0:
+		      if (record_arch_list_add_mem (addr, 4))
+			return -1;
+		      if (3 == (ir.reg & 7))
+                        {
+                        /* FSTP m32fp */
+		        if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        } 
+                      break;
 		    case 1:
 		      if (record_arch_list_add_mem (addr, 4))
 			return -1;
+		      if ((3 == (ir.reg & 7)) || (5 == (ir.reg & 7)) || (7 == (ir.reg & 7)))
+                        {
+                        /* FSTP */
+		        if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        } 
 		      break;
 		    case 2:
 		      if (record_arch_list_add_mem (addr, 8))
 			return -1;
+		      if (3 == (ir.reg & 7))
+                        {
+                        /* FSTP m64fp */
+		        if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        } 
 		      break;
 		    case 3:
+		      if ((3 <= (ir.reg & 7)) && (6 <= (ir.reg & 7)))
+                        {
+                        /* FISTP, FBLD, FILD, FBSTP */
+		        if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        }                        
 		    default:
 		      if (record_arch_list_add_mem (addr, 2))
 			return -1;
@@ -4147,54 +4241,71 @@
 		  break;
 		}
 	      break;
-	    case 0x0c:
-	    case 0x0d:
-	    case 0x1d:
-	    case 0x2c:
-	    case 0x3c:
-	    case 0x3d:
-	      break;
-	    case 0x0e:
+   	    case 0x0c:
+	      /* FLDENV */
+	      if (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
+	        return -1;  
+              break;
+	    case 0x0d: 
+              /* FLDCW */
+	      if (i386_record_floats(&ir, I386_FCTRL))
+	        return -1;  
+              break;
+	    case 0x2c: 
+              /* FRTSTOR */
+	      if (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
+	        return -1;  
+	      break; 
+	    case 0x0e: 
 	      if (ir.dflag)
 		{
-		  if (record_arch_list_add_mem (addr, 28))
-		    return -1;
+		if (record_arch_list_add_mem (addr, 28))
+		  return -1;
 		}
 	      else
 		{
-		  if (record_arch_list_add_mem (addr, 14))
-		    return -1;
+		if (record_arch_list_add_mem (addr, 14))
+		  return -1;
 		}
 	      break;
-	    case 0x0f:
-	    case 0x2f:
+	    case 0x0f:  
+	    case 0x2f:  
 	      if (record_arch_list_add_mem (addr, 2))
 		return -1;
 	      break;
-	    case 0x1f:
-	    case 0x3e:
+	    case 0x1f:  
+	    case 0x3e:  
 	      if (record_arch_list_add_mem (addr, 10))
 		return -1;
+              /* FSTP, FBSTP */
+              if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+	        return -1;                                  
 	      break;
-	    case 0x2e:
+	    case 0x2e: 
 	      if (ir.dflag)
 		{
-		  if (record_arch_list_add_mem (addr, 28))
-		    return -1;
-		  addr += 28;
+		if (record_arch_list_add_mem (addr, 28))
+		  return -1;
+		addr += 28;
 		}
 	      else
 		{
-		  if (record_arch_list_add_mem (addr, 14))
-		    return -1;
-		  addr += 14;
+		if (record_arch_list_add_mem (addr, 14))
+		  return -1;
+		addr += 14;
 		}
 	      if (record_arch_list_add_mem (addr, 80))
 		return -1;
+              /* FSAVE */
+	      if (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
+	        return -1;   
 	      break;
-	    case 0x3f:
+	    case 0x3f: 
 	      if (record_arch_list_add_mem (addr, 8))
 		return -1;
+		/* FISTP */
+              if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+	        return -1;   
 	      break;
 	    default:
 	      ir.addr -= 2;
@@ -4202,9 +4313,180 @@
 	      goto no_support;
 	      break;
 	    }
-	}
+	}   
+        /* opcode is an extension of modR/M byte */     
+	else
+	{ 
+          switch (opcode)
+            {
+            case 0xd8:
+              if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                return -1;	
+              break;
+            case 0xd9:    
+              if (0x0c == (ir.modrm >> 4))
+                {
+                  if ((ir.modrm & 0x0f) <= 7)
+                    {
+                    if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                      return -1;	
+                    }
+                  else
+                    {
+                    if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                      return -1;	
+                    /* if only st(0) is changing, then we have already recorded */
+                    if ((ir.modrm & 0x0f) - 0x08)
+                      {
+                      if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                        return -1;	                      
+                      } 
+                    }  
+                }
+              else
+                {
+                switch(ir.modrm)
+                  {
+                  case 0xe0:
+                  case 0xe1:
+                  case 0xf0:
+                  case 0xf5:
+                  case 0xf8:
+                  case 0xfa:
+                  case 0xfc:
+                  case 0xfe:
+                  case 0xff:
+                    if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                      return -1;
+                    break;           
+                  case 0xf1:  
+                  case 0xf2:  
+                  case 0xf3:  
+                  case 0xf4:
+                  case 0xf6:        
+                  case 0xf7:    
+                  case 0xe8:  
+                  case 0xe9:  
+                  case 0xea:  
+                  case 0xeb:
+                  case 0xec:        
+                  case 0xed:    
+                  case 0xee:   
+                  case 0xf9:     
+                  case 0xfb:
+                    if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                      return -1;	
+                    break;
+                  case 0xfd: 
+                    if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                      return -1;
+                    if (i386_record_floats(&ir, I386_ST1_REGNUM))
+                      return -1;
+                    break;
+                  } 
+              }
+              break;
+            case 0xda:
+              if (0xe9 == ir.modrm)
+                {
+		if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                  return -1;                    
+                }
+              else if ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >> 4))
+                {
+                if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                  return -1;	                
+                if (((ir.modrm & 0x0f) > 0) && ((ir.modrm & 0x0f) <= 7))
+                  {
+                  if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                    return -1;	                      
+                  }
+                else if ((ir.modrm & 0x0f) - 0x08)
+                  {
+		  if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                    return -1;
+                  }
+                }  
+              break; 
+            case 0xdb:
+              if (0xe3 == ir.modrm)
+                {
+		if (i386_record_floats(&ir, I386_SAVE_FPU_ENV))
+                  return -1;                    
+                }
+              else if ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >> 4))
+                {
+                if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                  return -1;	                
+                if (((ir.modrm & 0x0f) > 0) && ((ir.modrm & 0x0f) <= 7))
+                  {
+                  if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                    return -1;	                      
+                  }
+                else if ((ir.modrm & 0x0f) - 0x08)
+                  {
+		  if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                    return -1;
+                  }
+                }  
+              break;
+            case 0xdc:
+              if ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >> 4) || (0x0f == ir.modrm >> 4))
+                {
+                if ((ir.modrm & 0x0f) <= 7)
+                  {
+                  if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                    return -1;	                      
+                  }
+                else
+                  {
+		  if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                    return -1;
+                  }
+                }  
+               break;
+            case 0xdd:             
+              if (0x0c == ir.modrm >> 4)
+                {
+                  if (i386_record_floats(&ir,I386_FTAG))
+                    return -1;
+                }
+              else if ((0x0d == ir.modrm >> 4) || (0x0e == ir.modrm >> 4))
+                { 
+                  if ((ir.modrm & 0x0f) <= 7)
+                    {
+                      if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                        return -1;	 
+                    }
+                  else
+                    {
+                      if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                        return -1;
+                    }
+                }            
+              break;
+            case 0xde:
+              if ((0x0c == ir.modrm >> 4) || (0x0e == ir.modrm >> 4) || (0x0f == ir.modrm >> 4) || (0xd9 == ir.modrm))
+                {                   
+                  if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                    return -1;	 
+                }   
+              break;
+            case 0xdf:
+	      if (0xe0 == ir.modrm)
+                {
+                  if (record_arch_list_add_reg (ir.regcache, I386_EAX_REGNUM))
+	   	    return -1;
+                }
+              else if ((0x0f == ir.modrm >> 4) || (0x0e == ir.modrm >> 4))
+                { 
+                  if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                    return -1;
+                } 
+              break;
+            } 	  
+        }         
       break;
-
       /* string ops */
       /* movsS */
     case 0xa4:
@@ -4623,10 +4905,17 @@
       /* fwait */
       /* XXX */
     case 0x9b:
-      printf_unfiltered (_("Process record doesn't support instruction "
-			   "fwait.\n"));
-      ir.addr -= 1;
-      goto no_support;
+      if (target_read_memory (ir.addr, &tmpu8, 1))
+	{
+	  if (record_debug)
+	    printf_unfiltered (_("Process record: error reading memory at "
+				 "addr 0x%s len = 1.\n"),
+			       paddr_nz (ir.addr));
+	  return -1;
+	}
+      opcode = (uint32_t) tmpu8;
+      ir.addr++;
+      goto reswitch;     
       break;
 
       /* int3 */
diff -urN gdb.orig/i386-tdep.h gdb.new/i386-tdep.h
--- gdb.orig/i386-tdep.h	2009-05-17 17:56:44.000000000 -0400
+++ gdb.new/i386-tdep.h	2009-05-31 16:33:14.000000000 -0400
@@ -145,7 +145,22 @@
   I386_ES_REGNUM,		/* %es */
   I386_FS_REGNUM,		/* %fs */
   I386_GS_REGNUM,		/* %gs */
-  I386_ST0_REGNUM		/* %st(0) */
+  I386_ST0_REGNUM,		/* %st(0) */
+  I386_ST1_REGNUM,		/* %st(1) */
+  I386_ST2_REGNUM,		/* %st(2) */
+  I386_ST3_REGNUM,		/* %st(3) */
+  I386_ST4_REGNUM,		/* %st(4) */
+  I386_ST5_REGNUM,		/* %st(5) */
+  I386_ST6_REGNUM,		/* %st(6) */
+  I386_ST7_REGNUM,		/* %st(7) */
+  I386_FCTRL,			/* floating point env regs : FCTRL-FOP */	
+  I386_FSTAT,                   
+  I386_FTAG,			
+  I386_FISEG,
+  I386_FIOFF,
+  I386_FOSEG,
+  I386_FOOFF,
+  I386_FOP
 };
 
 #define I386_NUM_GREGS	16



      

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: i386-record-floats.patch --]
[-- Type: text/x-patch; name="i386-record-floats.patch", Size: 16155 bytes --]

diff -urN gdb.orig/i386-tdep.c gdb.new/i386-tdep.c
--- gdb.orig/i386-tdep.c	2009-05-29 17:08:40.000000000 -0400
+++ gdb.new/i386-tdep.c	2009-06-01 20:02:23.000000000 -0400
@@ -543,6 +543,9 @@
 /* The maximum number of saved registers.  This should include all
    registers mentioned above, and %eip.  */
 #define I386_NUM_SAVED_REGS	I386_NUM_GREGS
+#define I386_SAVE_FPU_REGS		0xFFFD
+#define I386_SAVE_FPU_ENV		0xFFFE
+#define I386_SAVE_FPU_ENV_REG_STACK	0xFFFF
 
 struct i386_frame_cache
 {
@@ -2985,6 +2988,54 @@
   return 0;
 }
 
+/* Record the value of floating point registers which will be changed by the current instruction
+   to "record_arch_list".
+   return -1 if something is wrong. */  
+
+static int i386_record_floats(struct i386_record_s *ir, uint32_t iregnum)
+{
+  int i;
+
+  /* Oza : push/pop of fpu stack is going to happen 
+     currently we store st0-st7 registers, but we need not store all registers all the time.
+     using fstatus, we use 11-13 bits which gives us stack top and hence we optimize our storage. */
+  if (I386_SAVE_FPU_REGS == iregnum)
+    {
+      for (i=I386_ST0_REGNUM;i<=I386_ST7_REGNUM;i++)
+        {
+          if (record_arch_list_add_reg (ir->regcache,i))
+            return -1;    
+        }
+    }
+  else if (I386_SAVE_FPU_ENV == iregnum)
+    {
+      for (i=I386_FCTRL;i<=I386_FOP;i++)
+      {
+        if (record_arch_list_add_reg (ir->regcache,i))
+          return -1;    
+      }
+    }
+  else if (I386_SAVE_FPU_ENV_REG_STACK == iregnum)
+    {
+      for (i=I386_ST0_REGNUM;i<=I386_FOP;i++)
+      {
+        if (record_arch_list_add_reg (ir->regcache,i))
+          return -1;    
+      }
+    }
+  else if (iregnum >= I386_ST0_REGNUM && iregnum <= I386_FOP)
+    {
+      if (record_arch_list_add_reg (ir->regcache,iregnum))
+        return -1;
+    }
+  else
+    {
+      /* param Error */
+      return -1;
+    } 
+  return 0;
+}
+
 /* Parse the current instruction and record the values of the registers and
    memory that will be changed in current instruction to "record_arch_list".
    Return -1 if something wrong. */
@@ -4035,7 +4086,6 @@
       break;
 
       /* floats */
-      /* It just record the memory change of instrcution. */
     case 0xd8:
     case 0xd9:
     case 0xda:
@@ -4056,39 +4106,49 @@
 	    return -1;
 	  switch (ir.reg)
 	    {
-	    case 0x00:
-	    case 0x01:
 	    case 0x02:
-	    case 0x03:
+	    case 0x12:
+	    case 0x22:
+	    case 0x32:
+	      /* for FCOM, FICOM nothing to do */
+              break;
+            case 0x03:
+	    case 0x13:
+	    case 0x23:
+	    case 0x33:
+  	      /* FCOMP, FICOMP pop FPU stack, store all */
+	      if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                return -1;
+              break;
+	    case 0x00:
+       	    case 0x01:
 	    case 0x04:
 	    case 0x05:
 	    case 0x06:
 	    case 0x07:
 	    case 0x10:
-	    case 0x11:
-	    case 0x12:
-	    case 0x13:
+       	    case 0x11:
 	    case 0x14:
 	    case 0x15:
 	    case 0x16:
 	    case 0x17:
 	    case 0x20:
 	    case 0x21:
-	    case 0x22:
-	    case 0x23:
 	    case 0x24:
 	    case 0x25:
 	    case 0x26:
 	    case 0x27:
 	    case 0x30:
 	    case 0x31:
-	    case 0x32:
-	    case 0x33:
 	    case 0x34:
 	    case 0x35:
 	    case 0x36:
 	    case 0x37:
-	      break;
+	      /* FADD, FMUL, FSUB, FSUBR, FDIV, FDIVR, FIADD, FIMUL, FISUB, FISUBR, FIDIV, FIDIVR  
+              ModR/M.reg is an extension of code, always affects st(0) register */
+	      if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                return -1;
+              break;           	    	    
 	    case 0x08:
 	    case 0x0a:
 	    case 0x0b:
@@ -4096,6 +4156,7 @@
 	    case 0x19:
 	    case 0x1a:
 	    case 0x1b:
+	    case 0x1d: 
 	    case 0x28:
 	    case 0x29:
 	    case 0x2a:
@@ -4103,11 +4164,16 @@
 	    case 0x38:
 	    case 0x39:
 	    case 0x3a:
-	    case 0x3b:
+	    case 0x3b:	   
+	    case 0x3c: 
+	    case 0x3d: 
 	      switch (ir.reg & 7)
 		{
 		case 0:
-		  break;
+		  /* FLD, FILD */
+	          if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                    return -1;    
+                  break;
 		case 1:
 		  switch (ir.reg >> 4)
 		    {
@@ -4120,6 +4186,7 @@
 			return -1;
 		      break;
 		    case 3:
+		      break;
 		    default:
 		      if (record_arch_list_add_mem (addr, 2))
 			return -1;
@@ -4130,15 +4197,42 @@
 		  switch (ir.reg >> 4)
 		    {
 		    case 0:
+		      if (record_arch_list_add_mem (addr, 4))
+			return -1;
+		      if (3 == (ir.reg & 7))
+                        {
+                        /* FSTP m32fp */
+		        if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        } 
+                      break;
 		    case 1:
 		      if (record_arch_list_add_mem (addr, 4))
 			return -1;
+		      if ((3 == (ir.reg & 7)) || (5 == (ir.reg & 7)) || (7 == (ir.reg & 7)))
+                        {
+                        /* FSTP */
+		        if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        } 
 		      break;
 		    case 2:
 		      if (record_arch_list_add_mem (addr, 8))
 			return -1;
+		      if (3 == (ir.reg & 7))
+                        {
+                        /* FSTP m64fp */
+		        if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        } 
 		      break;
 		    case 3:
+		      if ((3 <= (ir.reg & 7)) && (6 <= (ir.reg & 7)))
+                        {
+                        /* FISTP, FBLD, FILD, FBSTP */
+		        if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+		          return -1;                        
+                        }                        
 		    default:
 		      if (record_arch_list_add_mem (addr, 2))
 			return -1;
@@ -4147,54 +4241,71 @@
 		  break;
 		}
 	      break;
-	    case 0x0c:
-	    case 0x0d:
-	    case 0x1d:
-	    case 0x2c:
-	    case 0x3c:
-	    case 0x3d:
-	      break;
-	    case 0x0e:
+   	    case 0x0c:
+	      /* FLDENV */
+	      if (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
+	        return -1;  
+              break;
+	    case 0x0d: 
+              /* FLDCW */
+	      if (i386_record_floats(&ir, I386_FCTRL))
+	        return -1;  
+              break;
+	    case 0x2c: 
+              /* FRTSTOR */
+	      if (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
+	        return -1;  
+	      break; 
+	    case 0x0e: 
 	      if (ir.dflag)
 		{
-		  if (record_arch_list_add_mem (addr, 28))
-		    return -1;
+		if (record_arch_list_add_mem (addr, 28))
+		  return -1;
 		}
 	      else
 		{
-		  if (record_arch_list_add_mem (addr, 14))
-		    return -1;
+		if (record_arch_list_add_mem (addr, 14))
+		  return -1;
 		}
 	      break;
-	    case 0x0f:
-	    case 0x2f:
+	    case 0x0f:  
+	    case 0x2f:  
 	      if (record_arch_list_add_mem (addr, 2))
 		return -1;
 	      break;
-	    case 0x1f:
-	    case 0x3e:
+	    case 0x1f:  
+	    case 0x3e:  
 	      if (record_arch_list_add_mem (addr, 10))
 		return -1;
+              /* FSTP, FBSTP */
+              if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+	        return -1;                                  
 	      break;
-	    case 0x2e:
+	    case 0x2e: 
 	      if (ir.dflag)
 		{
-		  if (record_arch_list_add_mem (addr, 28))
-		    return -1;
-		  addr += 28;
+		if (record_arch_list_add_mem (addr, 28))
+		  return -1;
+		addr += 28;
 		}
 	      else
 		{
-		  if (record_arch_list_add_mem (addr, 14))
-		    return -1;
-		  addr += 14;
+		if (record_arch_list_add_mem (addr, 14))
+		  return -1;
+		addr += 14;
 		}
 	      if (record_arch_list_add_mem (addr, 80))
 		return -1;
+              /* FSAVE */
+	      if (i386_record_floats(&ir, I386_SAVE_FPU_ENV_REG_STACK))
+	        return -1;   
 	      break;
-	    case 0x3f:
+	    case 0x3f: 
 	      if (record_arch_list_add_mem (addr, 8))
 		return -1;
+		/* FISTP */
+              if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+	        return -1;   
 	      break;
 	    default:
 	      ir.addr -= 2;
@@ -4202,9 +4313,180 @@
 	      goto no_support;
 	      break;
 	    }
-	}
+	}   
+        /* opcode is an extension of modR/M byte */     
+	else
+	{ 
+          switch (opcode)
+            {
+            case 0xd8:
+              if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                return -1;	
+              break;
+            case 0xd9:    
+              if (0x0c == (ir.modrm >> 4))
+                {
+                  if ((ir.modrm & 0x0f) <= 7)
+                    {
+                    if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                      return -1;	
+                    }
+                  else
+                    {
+                    if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                      return -1;	
+                    /* if only st(0) is changing, then we have already recorded */
+                    if ((ir.modrm & 0x0f) - 0x08)
+                      {
+                      if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                        return -1;	                      
+                      } 
+                    }  
+                }
+              else
+                {
+                switch(ir.modrm)
+                  {
+                  case 0xe0:
+                  case 0xe1:
+                  case 0xf0:
+                  case 0xf5:
+                  case 0xf8:
+                  case 0xfa:
+                  case 0xfc:
+                  case 0xfe:
+                  case 0xff:
+                    if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                      return -1;
+                    break;           
+                  case 0xf1:  
+                  case 0xf2:  
+                  case 0xf3:  
+                  case 0xf4:
+                  case 0xf6:        
+                  case 0xf7:    
+                  case 0xe8:  
+                  case 0xe9:  
+                  case 0xea:  
+                  case 0xeb:
+                  case 0xec:        
+                  case 0xed:    
+                  case 0xee:   
+                  case 0xf9:     
+                  case 0xfb:
+                    if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                      return -1;	
+                    break;
+                  case 0xfd: 
+                    if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                      return -1;
+                    if (i386_record_floats(&ir, I386_ST1_REGNUM))
+                      return -1;
+                    break;
+                  } 
+              }
+              break;
+            case 0xda:
+              if (0xe9 == ir.modrm)
+                {
+		if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                  return -1;                    
+                }
+              else if ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >> 4))
+                {
+                if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                  return -1;	                
+                if (((ir.modrm & 0x0f) > 0) && ((ir.modrm & 0x0f) <= 7))
+                  {
+                  if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                    return -1;	                      
+                  }
+                else if ((ir.modrm & 0x0f) - 0x08)
+                  {
+		  if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                    return -1;
+                  }
+                }  
+              break; 
+            case 0xdb:
+              if (0xe3 == ir.modrm)
+                {
+		if (i386_record_floats(&ir, I386_SAVE_FPU_ENV))
+                  return -1;                    
+                }
+              else if ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >> 4))
+                {
+                if (i386_record_floats(&ir, I386_ST0_REGNUM))
+                  return -1;	                
+                if (((ir.modrm & 0x0f) > 0) && ((ir.modrm & 0x0f) <= 7))
+                  {
+                  if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                    return -1;	                      
+                  }
+                else if ((ir.modrm & 0x0f) - 0x08)
+                  {
+		  if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                    return -1;
+                  }
+                }  
+              break;
+            case 0xdc:
+              if ((0x0c == ir.modrm >> 4) || (0x0d == ir.modrm >> 4) || (0x0f == ir.modrm >> 4))
+                {
+                if ((ir.modrm & 0x0f) <= 7)
+                  {
+                  if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                    return -1;	                      
+                  }
+                else
+                  {
+		  if (i386_record_floats(&ir, I386_ST0_REGNUM + ((ir.modrm & 0x0f) - 0x08)))
+                    return -1;
+                  }
+                }  
+               break;
+            case 0xdd:             
+              if (0x0c == ir.modrm >> 4)
+                {
+                  if (i386_record_floats(&ir,I386_FTAG))
+                    return -1;
+                }
+              else if ((0x0d == ir.modrm >> 4) || (0x0e == ir.modrm >> 4))
+                { 
+                  if ((ir.modrm & 0x0f) <= 7)
+                    {
+                      if (i386_record_floats(&ir, I386_ST0_REGNUM + (ir.modrm & 0x0f)))
+                        return -1;	 
+                    }
+                  else
+                    {
+                      if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                        return -1;
+                    }
+                }            
+              break;
+            case 0xde:
+              if ((0x0c == ir.modrm >> 4) || (0x0e == ir.modrm >> 4) || (0x0f == ir.modrm >> 4) || (0xd9 == ir.modrm))
+                {                   
+                  if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                    return -1;	 
+                }   
+              break;
+            case 0xdf:
+	      if (0xe0 == ir.modrm)
+                {
+                  if (record_arch_list_add_reg (ir.regcache, I386_EAX_REGNUM))
+	   	    return -1;
+                }
+              else if ((0x0f == ir.modrm >> 4) || (0x0e == ir.modrm >> 4))
+                { 
+                  if (i386_record_floats(&ir, I386_SAVE_FPU_REGS))
+                    return -1;
+                } 
+              break;
+            } 	  
+        }         
       break;
-
       /* string ops */
       /* movsS */
     case 0xa4:
@@ -4623,10 +4905,17 @@
       /* fwait */
       /* XXX */
     case 0x9b:
-      printf_unfiltered (_("Process record doesn't support instruction "
-			   "fwait.\n"));
-      ir.addr -= 1;
-      goto no_support;
+      if (target_read_memory (ir.addr, &tmpu8, 1))
+	{
+	  if (record_debug)
+	    printf_unfiltered (_("Process record: error reading memory at "
+				 "addr 0x%s len = 1.\n"),
+			       paddr_nz (ir.addr));
+	  return -1;
+	}
+      opcode = (uint32_t) tmpu8;
+      ir.addr++;
+      goto reswitch;     
       break;
 
       /* int3 */
diff -urN gdb.orig/i386-tdep.h gdb.new/i386-tdep.h
--- gdb.orig/i386-tdep.h	2009-05-17 17:56:44.000000000 -0400
+++ gdb.new/i386-tdep.h	2009-05-31 16:33:14.000000000 -0400
@@ -145,7 +145,22 @@
   I386_ES_REGNUM,		/* %es */
   I386_FS_REGNUM,		/* %fs */
   I386_GS_REGNUM,		/* %gs */
-  I386_ST0_REGNUM		/* %st(0) */
+  I386_ST0_REGNUM,		/* %st(0) */
+  I386_ST1_REGNUM,		/* %st(1) */
+  I386_ST2_REGNUM,		/* %st(2) */
+  I386_ST3_REGNUM,		/* %st(3) */
+  I386_ST4_REGNUM,		/* %st(4) */
+  I386_ST5_REGNUM,		/* %st(5) */
+  I386_ST6_REGNUM,		/* %st(6) */
+  I386_ST7_REGNUM,		/* %st(7) */
+  I386_FCTRL,			/* floating point env regs : FCTRL-FOP */	
+  I386_FSTAT,                   
+  I386_FTAG,			
+  I386_FISEG,
+  I386_FIOFF,
+  I386_FOSEG,
+  I386_FOOFF,
+  I386_FOP
 };
 
 #define I386_NUM_GREGS	16

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: test_floats.c --]
[-- Type: text/x-csrc; name="test_floats.c", Size: 4462 bytes --]

#include <stdio.h>
#include <math.h>
#include <stdlib.h>

/* the test intends to test following insns.  
flds faddp fstps fstpl fldl fxch fabs fdivrp fmulp fsubrp fucomp fnstsw fsqrt
fchs f2xm1 fyl2x fxtract fprem1 fld fdecstp fld1 fldl2t fldl2e FLDPI FLDLG2 FLDLN2
FLDZ fincstp ffree fptan fpatan fincstp fsincos frndint fscale fsin fcos fcmovb
fcmovbe fcmove fcmovu fcmovnb fcmovnbe fsave frstor fstsw 
*/

float no1,no2,no3,no4,no5,no6,no7;
double x = 100.345, y = 25.7789;
long double ldx = 88888888888888888888.88, ldy = 9999999999999999999.99;
float result,resultd,resultld; 
float *float_memory;

/* initialization of floats */
void init_floats()
{
  no1 = 10.45;
  no2 = 20.77;
  no3 = 156.89874646;
  no4 = 14.56;
  no5 = 11.11;
  no6 = 66.77;
  no7 = 88.88;
  float_memory = malloc(sizeof(float) * 4);
  *float_memory = 256.256;
  *(float_memory + 1) = 356.356;
  *(float_memory + 2) = 456.456;
  *(float_memory + 3) = 556.556;
}

/* marks FPU stack as empty */
void empty_fpu_stack()
{
  asm ("ffree %st(1) \n\t"
       "ffree %st(2) \n\t"
       "ffree %st(3) \n\t"
       "ffree %st(4) \n\t"
       "ffree %st(5) \n\t"
       "ffree %st(6) \n\t"
       "ffree %st(7)");
}   

/* tests floating point arithmatic */
void test_arith_floats()
{
  result = no1 + no2 + no3 + no4 + no5 + no6 + no7;
  printf("result is %f\n",result);

  result = fmodf(no2,no1); 
  printf("result is %f\n",result);

  resultd = fmod(x,y); 
  printf("result is %f\n",resultd);
 
  resultld = fmodl(ldy,ldy); 
  printf("result is %f\n",resultld);

  result = fabsf(no1);        
  printf("result is %f\n",result);

  result = no3 / no4;
  printf("result is %f\n",result);

  result = no1 * no2 * no3 * no4;
  printf("result is %f\n",result);

  result = no1 - no2 - no3 - no4;
  printf("result is %f\n",result);


  asm ("fld %0" : :"m"(*float_memory));
  asm ("fchs");
  
  /* test for f2xm1 */  
  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("f2xm1");

  asm ("fyl2x");

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fxtract");

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fprem1");

  /* decrement fpu stack pointer only status register should get affected */
  asm ("fld %0" : :"m"(*float_memory));   
  
  empty_fpu_stack();
  
  asm ("fld1");
  asm ("fldl2t");
  asm ("fldl2e");
  asm ("fldpi");
  asm ("fldlg2");
  asm ("fldln2");
  asm ("fldz");

  empty_fpu_stack();
  /* finishing emptying the stack */
      
  result = sqrt(no3);
  printf("result is %f\n",result);
}

void test_log_exp_floats()
{
  result = log10(no3);
  printf("result is %f\n",result);

  result = log(no3);
  printf("result is %f\n",result);

  result = exp10(no3);
  printf("result is %f\n",result);

  result = exp(no3);
  printf("result is %f\n",result);
}

void test_trigo_floats()
{
  result = sin(30);
  printf("result is %f\n",result);

  result = cos(30);
  printf("result is %f\n",result);

  result = tan(30);
  printf("result is %f\n",result);

  result = atan(30);
  printf("result is %f\n",result);

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fptan");

  /* changes st1 and popping register stack */
  asm ("fpatan");  

  asm("fincstp");
  asm ("fld %0" : :"m"(float_memory)); 
  asm ("fsincos");

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("frndint");

  asm ("fld %0" : :"m"(*float_memory));
  asm ("fld %0" : :"m"(*(float_memory+1)));  
  asm ("fscale");

  empty_fpu_stack();

  asm ("fld %0" : :"m"(*float_memory)); 
  asm ("fsin");
  asm ("fcos");

  /* currently we assume condition likely and always record the registers 
  code could be optimized only if the flag is set then record */
  asm ("fld %0" : :"m"(*float_memory));
  asm ("fld %0" : :"m"(*(float_memory+1)));  
  asm ("fcmovb %st(1), %st");
  asm ("fcmovbe %st(1), %st");
  asm ("fcmove %st(1), %st");
  asm ("fcmovu %st(1), %st");
  asm ("fcmovnb %st(1), %st");
  asm ("fcmovnbe %st(1), %st");

  empty_fpu_stack();
  /* finished emtyping the stack */
}

void test_compare_floats()
{
    ldy = 88888888888888888888.88;
    if (ldx == ldy)
      ldy = 7777777777777777777777777777.777;
    else
      ldy = 666666666666666666666666666.666;
}

/* test loading and saving of FPU environment */
void test_fpu_env()
{
  asm ("fsave %0" : "=m"(*float_memory) : );
  asm ("frstor %0" : : "m"(*float_memory));
  asm ("fstsw %ax");  
}

int main()
{
    init_floats();
    test_arith_floats();
    test_log_exp_floats();
    test_trigo_floats();
    test_compare_floats();
    test_fpu_env();
}

^ permalink raw reply	[flat|nested] 40+ messages in thread
end of thread, other threads:[~2009-07-26 22:51 UTC | newest]

Thread overview: 40+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-03 18:55 i386.record.floating.point.patch : with more testing and assurity paawan oza
2009-07-03 21:52 ` Michael Snyder
     [not found] <992589.56162.qm@web112513.mail.gq1.yahoo.com>
2009-07-26 19:10 ` Mark Kettenis
  -- strict thread matches above, loose matches on Subject: below --
2009-07-26 14:27 paawan oza
2009-07-26 22:51 ` Michael Snyder
2009-07-27  1:09 ` Michael Snyder
2009-07-27  2:33 ` Samuel Bronson
2009-07-06 19:09 paawan oza
2009-07-06 19:05 paawan oza
2009-07-08  9:00 ` Hui Zhu
2009-07-12  9:52 ` Michael Snyder
2009-07-12 18:12   ` Michael Snyder
2009-07-06 19:03 paawan oza
2009-07-06 19:01 paawan oza
2009-07-04  5:19 paawan oza
2009-07-05 10:15 ` Hui Zhu
2009-07-02  7:40 paawan oza
2009-07-02  3:39 paawan oza
2009-07-02  3:34 paawan oza
2009-07-01 16:17 paawan oza
2009-07-05 18:33 ` Mark Kettenis
2009-07-01 16:02 paawan oza
2009-07-01 16:14 ` Mark Kettenis
2009-07-01 16:01 paawan oza
2009-07-01 15:59 paawan oza
2009-07-02  2:02 ` Hui Zhu
2009-06-30 15:05 paawan oza
2009-07-01  5:53 ` Hui Zhu
2009-07-12 11:12 ` Michael Snyder
2009-07-12 17:47   ` paawan oza
2009-07-13  0:38     ` Michael Snyder
2009-07-13 17:03       ` Hui Zhu
2009-07-13 20:16         ` Michael Snyder
2009-07-15  9:21           ` Hui Zhu
2009-07-19  3:27             ` paawan oza
2009-07-18 23:36           ` paawan oza
2009-06-30 13:23 paawan oza
2009-06-30 13:38 ` Pedro Alves
2009-06-30 13:42 ` Mark Kettenis
2009-06-04 14:50 paawan oza

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox