From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24341 invoked by alias); 30 Jun 2009 15:05:58 -0000 Received: (qmail 23978 invoked by uid 22791); 30 Jun 2009 15:05:56 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from web112516.mail.gq1.yahoo.com (HELO web112516.mail.gq1.yahoo.com) (98.137.26.182) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Tue, 30 Jun 2009 15:05:48 +0000 Received: (qmail 16661 invoked by uid 60001); 30 Jun 2009 15:05:46 -0000 Message-ID: <736794.15455.qm@web112516.mail.gq1.yahoo.com> Received: from [124.125.223.141] by web112516.mail.gq1.yahoo.com via HTTP; Tue, 30 Jun 2009 08:05:46 PDT Date: Tue, 30 Jun 2009 15:05:00 -0000 From: paawan oza Subject: Re: i386.record.floating.point.patch : with more testing and assurity To: gdb-patches@sourceware.org, Pedro Alves Cc: teawater@gmail.com MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00871.txt.bz2 Hi, As I am submitting the patch for the first time, I am not much aware of gdb= test suite. would you please guide me about how I can put the things in the testsuite ? is it the testsuite which comes along with the gdb source ? gdb\testsuite\gdb.base ?? Regards, Oza. --- On Tue, 6/30/09, Pedro Alves wrote: > From: Pedro Alves > Subject: Re: i386.record.floating.point.patch : with more testing and ass= urity > To: gdb-patches@sourceware.org > Cc: "paawan oza" , teawater@gmail.com > Date: Tuesday, June 30, 2009, 7:09 PM > On Tuesday 30 June 2009 14:23:30, > paawan oza wrote: > >=20 > > > As suggested by Hui,=20 > > > I have come up with more detailed and granular > test case > > > for the patch which I had submitted last week. >=20 > Could you please consider migrating that test into the > testsuite? > You've gone through the trouble of writing tests to make > sure > the features work now --- putting it in the testsuite means > we > have an automatic-ish means to check that it doesn't get > inadvertently broken in the future.=A0 The way it is, > when your > code gets in, the test will probably end up lost in the > archives. > We wouldn't want that, would we?=A0 :-)=A0 Having > auto-tests, also helps > the person doing the review in confirming things work as > expected (without much effort). >=20 > --=20 > Pedro Alves >=20