From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-65369-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4198 invoked by alias); 12 Jul 2009 17:53:59 -0000
Received: (qmail 4190 invoked by uid 22791); 12 Jul 2009 17:53:59 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 12 Jul 2009 17:53:51 +0000
Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) 	by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 93C403C006; 	Sun, 12 Jul 2009 10:53:49 -0700 (PDT)
Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) 	by mailhost2.vmware.com (Postfix) with ESMTP id 5C1498E9CE; 	Sun, 12 Jul 2009 10:53:49 -0700 (PDT)
Message-ID: <4A5A2227.60007@vmware.com>
Date: Sun, 12 Jul 2009 18:12:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 1.5.0.12 (X11/20080411)
MIME-Version: 1.0
To: Michael Snyder <msnyder@vmware.com>
CC: paawan oza <paawan1982@yahoo.com>, Hui Zhu <teawater@gmail.com>,   Mark Kettenis <mark.kettenis@xs4all.nl>,  "pedro@codesourcery.com" <pedro@codesourcery.com>,   "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: i386.record.floating.point.patch : with more testing and assurity
References: <978078.82017.qm@web112508.mail.gq1.yahoo.com> <4A58FBF3.9020207@vmware.com>
In-Reply-To: <4A58FBF3.9020207@vmware.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-07/txt/msg00348.txt.bz2

Two more things that I missed...


>> +          return -1;
>> +      }
>> +    }
>> +  else if ((iregnum >= I387_ST0_REGNUM (tdep)) &&
>> +           (iregnum <= I387_FOP_REGNUM(tdep)))

Space here...


>>                     case 3:
>> +                     if ((3 <= (ir.reg & 7)) && (6 <= (ir.reg & 7)))
>> +                        {
>> +                        /* For fistp, fbld, fild, fbstp.  */
>> +                       if (i386_record_floats(gdbarch, &ir,  \
>> +                                               I386_SAVE_FPU_REGS))
> 
> Space after function name.
> 
>> +                         return -1;
>> +                        }
>>                     default:
>>                       if (record_arch_list_add_mem (addr, 2))
>>                         return -1;

And right here, is there supposed to be a break before default?

If not, ie. if case 3 is supposed to "fall through" into the
default case, we like to put a comment there, just to make sure
it is clear that the lack of a "break" is intentional.

Just like this:

	/* Fall through.  */
	default: