Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: paawan oza <paawan1982@yahoo.com>,  teawater@gmail.com
Subject: Re: i386.record.floating.point.patch : with more testing and assurity
Date: Tue, 30 Jun 2009 13:38:00 -0000	[thread overview]
Message-ID: <200906301439.22219.pedro@codesourcery.com> (raw)
In-Reply-To: <933776.18995.qm@web112515.mail.gq1.yahoo.com>

On Tuesday 30 June 2009 14:23:30, paawan oza wrote:
> 
> > As suggested by Hui, 
> > I have come up with more detailed and granular test case
> > for the patch which I had submitted last week.

Could you please consider migrating that test into the testsuite?
You've gone through the trouble of writing tests to make sure
the features work now --- putting it in the testsuite means we
have an automatic-ish means to check that it doesn't get
inadvertently broken in the future.  The way it is, when your
code gets in, the test will probably end up lost in the archives.
We wouldn't want that, would we?  :-)  Having auto-tests, also helps
the person doing the review in confirming things work as
expected (without much effort).

-- 
Pedro Alves


  reply	other threads:[~2009-06-30 13:38 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-30 13:23 paawan oza
2009-06-30 13:38 ` Pedro Alves [this message]
2009-06-30 13:42 ` Mark Kettenis
     [not found] <992589.56162.qm@web112513.mail.gq1.yahoo.com>
2009-07-26 19:10 ` Mark Kettenis
  -- strict thread matches above, loose matches on Subject: below --
2009-07-26 14:27 paawan oza
2009-07-26 22:51 ` Michael Snyder
2009-07-27  1:09 ` Michael Snyder
2009-07-27  2:33 ` Samuel Bronson
2009-07-06 19:09 paawan oza
2009-07-06 19:05 paawan oza
2009-07-08  9:00 ` Hui Zhu
2009-07-12  9:52 ` Michael Snyder
2009-07-12 18:12   ` Michael Snyder
2009-07-06 19:03 paawan oza
2009-07-06 19:01 paawan oza
2009-07-04  5:19 paawan oza
2009-07-05 10:15 ` Hui Zhu
2009-07-03 18:55 paawan oza
2009-07-03 21:52 ` Michael Snyder
2009-07-02  7:40 paawan oza
2009-07-02  3:39 paawan oza
2009-07-02  3:34 paawan oza
2009-07-01 16:17 paawan oza
2009-07-05 18:33 ` Mark Kettenis
2009-07-01 16:02 paawan oza
2009-07-01 16:14 ` Mark Kettenis
2009-07-01 16:01 paawan oza
2009-07-01 15:59 paawan oza
2009-07-02  2:02 ` Hui Zhu
2009-06-30 15:05 paawan oza
2009-07-01  5:53 ` Hui Zhu
2009-07-12 11:12 ` Michael Snyder
2009-07-12 17:47   ` paawan oza
2009-07-13  0:38     ` Michael Snyder
2009-07-13 17:03       ` Hui Zhu
2009-07-13 20:16         ` Michael Snyder
2009-07-15  9:21           ` Hui Zhu
2009-07-19  3:27             ` paawan oza
2009-07-18 23:36           ` paawan oza
2009-06-04 14:50 paawan oza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906301439.22219.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=paawan1982@yahoo.com \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox