From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18918 invoked by alias); 30 Jun 2009 13:38:23 -0000 Received: (qmail 18909 invoked by uid 22791); 30 Jun 2009 13:38:22 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Jun 2009 13:38:15 +0000 Received: (qmail 707 invoked from network); 30 Jun 2009 13:38:13 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 30 Jun 2009 13:38:13 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: i386.record.floating.point.patch : with more testing and assurity Date: Tue, 30 Jun 2009 13:38:00 -0000 User-Agent: KMail/1.9.10 Cc: paawan oza , teawater@gmail.com References: <933776.18995.qm@web112515.mail.gq1.yahoo.com> In-Reply-To: <933776.18995.qm@web112515.mail.gq1.yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200906301439.22219.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00867.txt.bz2 On Tuesday 30 June 2009 14:23:30, paawan oza wrote: > > > As suggested by Hui, > > I have come up with more detailed and granular test case > > for the patch which I had submitted last week. Could you please consider migrating that test into the testsuite? You've gone through the trouble of writing tests to make sure the features work now --- putting it in the testsuite means we have an automatic-ish means to check that it doesn't get inadvertently broken in the future. The way it is, when your code gets in, the test will probably end up lost in the archives. We wouldn't want that, would we? :-) Having auto-tests, also helps the person doing the review in confirming things work as expected (without much effort). -- Pedro Alves