Re: i386.record.floating.point.patch : with more testing and assurity

[Michael Snyder <msnyder@vmware.com>]

Two more things that I missed...


>> +          return -1;
>> +      }
>> +    }
>> +  else if ((iregnum >= I387_ST0_REGNUM (tdep)) &&
>> +           (iregnum <= I387_FOP_REGNUM(tdep)))

Space here...


>>                     case 3:
>> +                     if ((3 <= (ir.reg & 7)) && (6 <= (ir.reg & 7)))
>> +                        {
>> +                        /* For fistp, fbld, fild, fbstp.  */
>> +                       if (i386_record_floats(gdbarch, &ir,  \
>> +                                               I386_SAVE_FPU_REGS))
> 
> Space after function name.
> 
>> +                         return -1;
>> +                        }
>>                     default:
>>                       if (record_arch_list_add_mem (addr, 2))
>>                         return -1;

And right here, is there supposed to be a break before default?

If not, ie. if case 3 is supposed to "fall through" into the
default case, we like to put a comment there, just to make sure
it is clear that the lack of a "break" is intentional.

Just like this:

	/* Fall through.  */
	default: