From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24348 invoked by alias); 1 Jul 2009 05:53:29 -0000 Received: (qmail 24338 invoked by uid 22791); 1 Jul 2009 05:53:28 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from wf-out-1314.google.com (HELO wf-out-1314.google.com) (209.85.200.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Jul 2009 05:53:21 +0000 Received: by wf-out-1314.google.com with SMTP id 23so275222wfg.24 for ; Tue, 30 Jun 2009 22:53:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.126.6 with SMTP id y6mr971849wfc.230.1246427599398; Tue, 30 Jun 2009 22:53:19 -0700 (PDT) In-Reply-To: <736794.15455.qm@web112516.mail.gq1.yahoo.com> References: <736794.15455.qm@web112516.mail.gq1.yahoo.com> Date: Wed, 01 Jul 2009 05:53:00 -0000 Message-ID: Subject: Re: i386.record.floating.point.patch : with more testing and assurity From: Hui Zhu To: paawan oza , Pedro Alves , Mark Kettenis , Michael Snyder Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00005.txt.bz2 About this patch, I say my idea again, I told in http://sourceware.org/ml/gdb-patches/2009-06/msg00014.html @@ -145,7 +145,22 @@ I386_ES_REGNUM, /* %es */ I386_FS_REGNUM, /* %fs */ I386_GS_REGNUM, /* %gs */ - I386_ST0_REGNUM /* %st(0) */ + I386_ST0_REGNUM, /* %st(0) */ + I386_ST1_REGNUM, /* %st(1) */ + I386_ST2_REGNUM, /* %st(2) */ + I386_ST3_REGNUM, /* %st(3) */ + I386_ST4_REGNUM, /* %st(4) */ + I386_ST5_REGNUM, /* %st(5) */ + I386_ST6_REGNUM, /* %st(6) */ + I386_ST7_REGNUM, /* %st(7) */ + I386_FCTRL, /* floating point env regs : FCTRL-FOP */=09 + I386_FSTAT, + I386_FTAG,=09=09=09 + I386_FISEG, + I386_FIOFF, + I386_FOSEG, + I386_FOOFF, + I386_FOP }; You are working on make prec x86 support fp insn, not to extend the fp function of i386 (If you want, you can make a special patch for it). Hui On Tue, Jun 30, 2009 at 23:05, paawan oza wrote: > > Hi, > As I am submitting the patch for the first time, I am not much aware of g= db test suite. > would you please guide me about how I can put the things in the testsuite= ? > is it the testsuite which comes along with the gdb source ? > gdb\testsuite\gdb.base ?? > Regards, > Oza. > > --- On Tue, 6/30/09, Pedro Alves wrote: > >> From: Pedro Alves >> Subject: Re: i386.record.floating.point.patch : with more testing and as= surity >> To: gdb-patches@sourceware.org >> Cc: "paawan oza" , teawater@gmail.com >> Date: Tuesday, June 30, 2009, 7:09 PM >> On Tuesday 30 June 2009 14:23:30, >> paawan oza wrote: >> > >> > > As suggested by Hui, >> > > I have come up with more detailed and granular >> test case >> > > for the patch which I had submitted last week. >> >> Could you please consider migrating that test into the >> testsuite? >> You've gone through the trouble of writing tests to make >> sure >> the features work now --- putting it in the testsuite means >> we >> have an automatic-ish means to check that it doesn't get >> inadvertently broken in the future.=A0 The way it is, >> when your >> code gets in, the test will probably end up lost in the >> archives. >> We wouldn't want that, would we?=A0 :-)=A0 Having >> auto-tests, also helps >> the person doing the review in confirming things work as >> expected (without much effort). >> >> -- >> Pedro Alves >> > > > >