From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11738 invoked by alias); 2 Jul 2009 02:02:04 -0000 Received: (qmail 10595 invoked by uid 22791); 2 Jul 2009 02:02:00 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from wf-out-1314.google.com (HELO wf-out-1314.google.com) (209.85.200.170) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Jul 2009 02:01:53 +0000 Received: by wf-out-1314.google.com with SMTP id 23so553251wfg.24 for ; Wed, 01 Jul 2009 19:01:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.143.16.9 with SMTP id t9mr1311813wfi.45.1246500111437; Wed, 01 Jul 2009 19:01:51 -0700 (PDT) In-Reply-To: <656840.90117.qm@web112508.mail.gq1.yahoo.com> References: <656840.90117.qm@web112508.mail.gq1.yahoo.com> Date: Thu, 02 Jul 2009 02:02:00 -0000 Message-ID: Subject: Re: i386.record.floating.point.patch : with more testing and assurity From: Hui Zhu To: paawan oza Cc: Pedro Alves , Mark Kettenis , Michael Snyder , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00051.txt.bz2 On Wed, Jul 1, 2009 at 23:59, paawan oza wrote: > > Hi Hui, > > As I clarified earlier, > these registers are already supported and extended by gdb much before thi= s patch. > all floating point registers are already supported by gdb > (info floats/info all-registers command gives it) > > My aim is : only to make sure that whenever any floating point insn gets = executed, we record the registers > (no matter whether it is %st(n) or FCTRL or FTAG or FSTATUS) > there are insns > e.g. 'ffree' changes FTAG register, so we must record it. > > Do you mean to say that we should remove it from just enumaration ? > but anyway we need to record those registers. > You are working on make prec x86 support fp insn, not to extend the fp function of i386 (If you want, you can make a special patch for it). > > --- On Wed, 7/1/09, Hui Zhu wrote: > >> From: Hui Zhu >> Subject: Re: i386.record.floating.point.patch : with more testing and as= surity >> To: "paawan oza" , "Pedro Alves" , "Mark Kettenis" , "Michael Snyder" >> Cc: gdb-patches@sourceware.org >> Date: Wednesday, July 1, 2009, 11:23 AM >> About this patch, I say my idea >> again, I told in >> http://sourceware.org/ml/gdb-patches/2009-06/msg00014.html >> @@ -145,7 +145,22 @@ >> =A0=A0=A0I386_ES_REGNUM, >> =A0=A0=A0 /* %es */ >> =A0=A0=A0I386_FS_REGNUM, >> =A0=A0=A0 /* %fs */ >> =A0=A0=A0I386_GS_REGNUM, >> =A0=A0=A0 /* %gs */ >> -=A0 I386_ST0_REGNUM >> =A0=A0=A0 /* %st(0) */ >> +=A0 I386_ST0_REGNUM, >> =A0=A0=A0 /* %st(0) */ >> +=A0 I386_ST1_REGNUM, >> =A0=A0=A0 /* %st(1) */ >> +=A0 I386_ST2_REGNUM, >> =A0=A0=A0 /* %st(2) */ >> +=A0 I386_ST3_REGNUM, >> =A0=A0=A0 /* %st(3) */ >> +=A0 I386_ST4_REGNUM, >> =A0=A0=A0 /* %st(4) */ >> +=A0 I386_ST5_REGNUM, >> =A0=A0=A0 /* %st(5) */ >> +=A0 I386_ST6_REGNUM, >> =A0=A0=A0 /* %st(6) */ >> +=A0 I386_ST7_REGNUM, >> =A0=A0=A0 /* %st(7) */ >> +=A0 I386_FCTRL, >> =A0=A0=A0 /* floating point env regs : FCTRL-FOP >> */ >> +=A0 I386_FSTAT, >> +=A0 I386_FTAG, >> >> +=A0 I386_FISEG, >> +=A0 I386_FIOFF, >> +=A0 I386_FOSEG, >> +=A0 I386_FOOFF, >> +=A0 I386_FOP >> =A0}; >> >> You are working on make prec x86 support fp insn, not to >> extend the fp >> function of i386 (If you want, you can make a special patch >> for it). >> >> Hui >> >> On Tue, Jun 30, 2009 at 23:05, paawan oza >> wrote: >> > >> > Hi, >> > As I am submitting the patch for the first time, I am >> not much aware of gdb test suite. >> > would you please guide me about how I can put the >> things in the testsuite ? >> > is it the testsuite which comes along with the gdb >> source ? >> > gdb\testsuite\gdb.base ?? >> > Regards, >> > Oza. >> > >> > --- On Tue, 6/30/09, Pedro Alves >> wrote: >> > >> >> From: Pedro Alves >> >> Subject: Re: i386.record.floating.point.patch : >> with more testing and assurity >> >> To: gdb-patches@sourceware.org >> >> Cc: "paawan oza" , >> teawater@gmail.com >> >> Date: Tuesday, June 30, 2009, 7:09 PM >> >> On Tuesday 30 June 2009 14:23:30, >> >> paawan oza wrote: >> >> > >> >> > > As suggested by Hui, >> >> > > I have come up with more detailed and >> granular >> >> test case >> >> > > for the patch which I had submitted last >> week. >> >> >> >> Could you please consider migrating that test into >> the >> >> testsuite? >> >> You've gone through the trouble of writing tests >> to make >> >> sure >> >> the features work now --- putting it in the >> testsuite means >> >> we >> >> have an automatic-ish means to check that it >> doesn't get >> >> inadvertently broken in the future.=A0 The way it >> is, >> >> when your >> >> code gets in, the test will probably end up lost >> in the >> >> archives. >> >> We wouldn't want that, would we?=A0 :-)=A0 Having >> >> auto-tests, also helps >> >> the person doing the review in confirming things >> work as >> >> expected (without much effort). >> >> >> >> -- >> >> Pedro Alves >> >> >> > >> > >> > >> > >> > > > >