From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23736 invoked by alias); 12 Jul 2009 14:26:46 -0000 Received: (qmail 23727 invoked by uid 22791); 12 Jul 2009 14:26:45 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from web112504.mail.gq1.yahoo.com (HELO web112504.mail.gq1.yahoo.com) (98.137.26.134) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Sun, 12 Jul 2009 14:26:39 +0000 Received: (qmail 75396 invoked by uid 60001); 12 Jul 2009 14:26:37 -0000 Message-ID: <9950.73333.qm@web112504.mail.gq1.yahoo.com> Received: from [123.237.137.13] by web112504.mail.gq1.yahoo.com via HTTP; Sun, 12 Jul 2009 07:26:36 PDT Date: Sun, 12 Jul 2009 17:47:00 -0000 From: paawan oza Subject: Re: i386.record.floating.point.patch : with more testing and assurity To: Michael Snyder Cc: "gdb-patches@sourceware.org" , Pedro Alves , "teawater@gmail.com" In-Reply-To: <4A591F54.3030207@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00344.txt.bz2 Hi,=20 Thank you very much for your elaborated reply. I will integrate the test example with test suite by next week-end. And, also take of all yours and Hui's formatting comments. I will come up with the final up to date patch with integrated test-suite. Thank you again for your response. : ) I start working towards it. Regards, Oza. --- On Sun, 7/12/09, Michael Snyder wrote: > From: Michael Snyder > Subject: Re: i386.record.floating.point.patch : with more testing and ass= urity > To: "paawan oza" > Cc: "gdb-patches@sourceware.org" , "Pedro Alv= es" , "teawater@gmail.com" > Date: Sunday, July 12, 2009, 4:55 AM > paawan oza wrote: > > Hi, > > As I am submitting the patch for the first time, I am > not much aware of gdb test suite. > > would you please guide me about how I can put the > things in the testsuite ? > > is it the testsuite which comes along with the gdb > source ? > > gdb\testsuite\gdb.base ?? > > Regards, > > Oza. >=20 > Hi Oza, >=20 > Yes, we are talking about the automated regression > testsuite that > comes with the gdb source tree, at src/gdb/testsuite.=A0 > You'll need > to be familiar with it, both to use it and to write tests. >=20 > All tests for the GNU tools are written in (are you ready > for this) > * dejagnu, which is a layer written on top of > * expect, which is a language written on top of > * tcl. >=20 > There are many many tests already in the testsuite.=A0 > Each consists of > =A0 1) one 'expect' script, such as > =A0 > =A0=A0=A0src/gdb/testsuite/gdb.base/break-always.exp > =A0 2) one or more source files, such as > =A0 > =A0=A0=A0src/gdb/testsuite/gdb.base/break-always.c >=20 > I chose that one as a relatively simple example for you to > look at. >=20 > Each script > =A0 * compiles the corresponding source file, > =A0 * starts gdb, and > =A0 * runs a set of gdb commands. >=20 > The output of the commands is automatically compared to a > set > of expected outputs (hence the name 'expect'), and if the > output > matches the expected output the script will output "PASS". > Otherwise it will output "FAIL". >=20 > We use these test scripts regularly, both to validate new > patches, > and to make sure that new changes haven't broken any old > changes. >=20 > To run the gdb tests, you need to have installed > * dejagnu version 1.4.4 > * expect version 5.42.1 > * tcl at least version 8.4 >=20 > With those installed, you should be able to do the > following > in your build tree, with these results: then we'll talk > about > writing tests.=A0=A0=A0;-) >=20 > bash-3.00$ cd gdb/testsuite > bash-3.00$ make check RUNTESTFLAGS=3Dbreak-always.exp > [some noise] >=20 > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =3D=3D=3D > gdb tests =3D=3D=3D >=20 > Schedule of variations: > =A0 =A0 unix >=20 > Running target unix > Using /usr/share/dejagnu/baseboards/unix.exp as board > description file for target. > Using /usr/share/dejagnu/config/unix.exp as generic > interface file for target. > Using > /data/home/msnyder/cvs/localhost/oza/gdb/testsuite/config/unix.exp > as tool-and-target-specific interface file. > Running > /data/home/msnyder/cvs/localhost/oza/gdb/testsuite/gdb.base/break-always.= exp > ... >=20 > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =3D=3D=3D > gdb Summary =3D=3D=3D >=20 > # of expected passes=A0 =A0 =A0 =A0 =A0 > =A0 4 > /data/home/msnyder/builds/native/oza/gdb/testsuite/../../gdb/gdb > version=A0 6.8.50.20090711-cvs -nw -nx >=20 >=20