From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29035 invoked by alias); 1 Jul 2009 16:02:30 -0000 Received: (qmail 28892 invoked by uid 22791); 1 Jul 2009 16:02:28 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from web112516.mail.gq1.yahoo.com (HELO web112516.mail.gq1.yahoo.com) (98.137.26.182) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Wed, 01 Jul 2009 16:02:19 +0000 Received: (qmail 74862 invoked by uid 60001); 1 Jul 2009 16:02:17 -0000 Message-ID: <520037.71312.qm@web112516.mail.gq1.yahoo.com> Received: from [124.125.223.141] by web112516.mail.gq1.yahoo.com via HTTP; Wed, 01 Jul 2009 09:02:17 PDT Date: Wed, 01 Jul 2009 16:02:00 -0000 From: paawan oza Subject: Re: i386.record.floating.point.patch : with more testing and assurity To: Pedro Alves , Mark Kettenis , Michael Snyder , Hui Zhu Cc: gdb-patches@sourceware.org MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00014.txt.bz2 Can somebody please help with this open point ? --- On Wed, 7/1/09, paawan oza wrote: > From: paawan oza > Subject: Re: i386.record.floating.point.patch : with more testing and ass= urity > To: "Pedro Alves" , "Mark Kettenis" , "Michael Snyder" , "Hui Zhu" > Cc: gdb-patches@sourceware.org > Date: Wednesday, July 1, 2009, 9:30 PM > Hi Hui, >=20 > As I clarified earlier,=20 > these registers are already supported and extended by gdb > much before this patch. > all floating point registers are already supported by gdb=20 > (info floats/info all-registers command gives it) >=20 > My aim is : only to make sure that whenever any floating > point insn gets executed, we record the registers=20 > (no matter whether it is %st(n) or FCTRL or FTAG or > FSTATUS) > there are insns > e.g. 'ffree' changes FTAG register, so we must record it. >=20 > Do you mean to say that we should remove it from just > enumaration ? > but anyway we need to record those registers. >=20 > Regards, > Oza. >=20 > --- On Wed, 7/1/09, Hui Zhu > wrote: >=20 > > From: Hui Zhu > > Subject: Re: i386.record.floating.point.patch : with > more testing and assurity > > To: "paawan oza" , > "Pedro Alves" , > "Mark Kettenis" , > "Michael Snyder" > > Cc: gdb-patches@sourceware.org > > Date: Wednesday, July 1, 2009, 11:23 AM > > About this patch, I say my idea > > again, I told in > > http://sourceware.org/ml/gdb-patches/2009-06/msg00014.html > > @@ -145,7 +145,22 @@ > > =A0=A0=A0I386_ES_REGNUM,=A0=A0=A0 > > =A0=A0=A0 /* %es */ > > =A0=A0=A0I386_FS_REGNUM,=A0=A0=A0 > > =A0=A0=A0 /* %fs */ > > =A0=A0=A0I386_GS_REGNUM,=A0=A0=A0 > > =A0=A0=A0 /* %gs */ > > -=A0 I386_ST0_REGNUM=A0=A0=A0 > > =A0=A0=A0 /* %st(0) */ > > +=A0 I386_ST0_REGNUM,=A0=A0=A0 > > =A0=A0=A0 /* %st(0) */ > > +=A0 I386_ST1_REGNUM,=A0=A0=A0 > > =A0=A0=A0 /* %st(1) */ > > +=A0 I386_ST2_REGNUM,=A0=A0=A0 > > =A0=A0=A0 /* %st(2) */ > > +=A0 I386_ST3_REGNUM,=A0=A0=A0 > > =A0=A0=A0 /* %st(3) */ > > +=A0 I386_ST4_REGNUM,=A0=A0=A0 > > =A0=A0=A0 /* %st(4) */ > > +=A0 I386_ST5_REGNUM,=A0=A0=A0 > > =A0=A0=A0 /* %st(5) */ > > +=A0 I386_ST6_REGNUM,=A0=A0=A0 > > =A0=A0=A0 /* %st(6) */ > > +=A0 I386_ST7_REGNUM,=A0=A0=A0 > > =A0=A0=A0 /* %st(7) */ > > +=A0 I386_FCTRL,=A0=A0=A0 =A0=A0=A0 > > =A0=A0=A0 /* floating point env regs : FCTRL-FOP > > */=A0=A0=A0=20 > > +=A0 I386_FSTAT, > > +=A0 I386_FTAG,=A0=A0=A0 =A0=A0=A0 > > =A0=A0=A0=20 > > +=A0 I386_FISEG, > > +=A0 I386_FIOFF, > > +=A0 I386_FOSEG, > > +=A0 I386_FOOFF, > > +=A0 I386_FOP > >=A0 }; > >=20 > > You are working on make prec x86 support fp insn, not > to > > extend the fp > > function of i386 (If you want, you can make a special > patch > > for it). > >=20 > > Hui > >=20 > > On Tue, Jun 30, 2009 at 23:05, paawan oza > > wrote: > > > > > > Hi, > > > As I am submitting the patch for the first time, > I am > > not much aware of gdb test suite. > > > would you please guide me about how I can put > the > > things in the testsuite ? > > > is it the testsuite which comes along with the > gdb > > source ? > > > gdb\testsuite\gdb.base ?? > > > Regards, > > > Oza. > > > > > > --- On Tue, 6/30/09, Pedro Alves > > wrote: > > > > > >> From: Pedro Alves > > >> Subject: Re: i386.record.floating.point.patch > : > > with more testing and assurity > > >> To: gdb-patches@sourceware.org > > >> Cc: "paawan oza" , > > teawater@gmail.com > > >> Date: Tuesday, June 30, 2009, 7:09 PM > > >> On Tuesday 30 June 2009 14:23:30, > > >> paawan oza wrote: > > >> > > > >> > > As suggested by Hui, > > >> > > I have come up with more detailed > and > > granular > > >> test case > > >> > > for the patch which I had submitted > last > > week. > > >> > > >> Could you please consider migrating that test > into > > the > > >> testsuite? > > >> You've gone through the trouble of writing > tests > > to make > > >> sure > > >> the features work now --- putting it in the > > testsuite means > > >> we > > >> have an automatic-ish means to check that it > > doesn't get > > >> inadvertently broken in the future.=A0 The way > it > > is, > > >> when your > > >> code gets in, the test will probably end up > lost > > in the > > >> archives. > > >> We wouldn't want that, would we?=A0 :-)=A0 > Having > > >> auto-tests, also helps > > >> the person doing the review in confirming > things > > work as > > >> expected (without much effort). > > >> > > >> -- > > >> Pedro Alves > > >> > > > > > > > > > > > > > >=20 >=20 >=20 >=20 >=20