From: Eli Zaretskii <eliz@gnu.org>
To: Stan Shebs <stan@codesourcery.com>
Cc: tromey@redhat.com, pedro@codesourcery.com, gdb-patches@sourceware.org
Subject: Re: Modernize solaris threads support.
Date: Wed, 18 Feb 2009 10:13:00 -0000 [thread overview]
Message-ID: <umyckv0dm.fsf@gnu.org> (raw)
In-Reply-To: <499B35C8.9050101@codesourcery.com>
> Date: Tue, 17 Feb 2009 14:10:16 -0800
> From: Stan Shebs <stan@codesourcery.com>
> CC: Eli Zaretskii <eliz@gnu.org>, pedro@codesourcery.com,
> gdb-patches@sourceware.org
>
> As another take on it, one thing I think we want to avoid is to make GDB
> into a some kind of a museum of long-gone programming style.
I don't think prototypes are ``a long-gone programming style''.
The problem with changes that are not strictly needed for the patch at
hand is that they obscure the real change. It's the same as lumping
several unrelated changes in one diff, which is discouraged here (and
rightfully so).
next prev parent reply other threads:[~2009-02-18 4:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-16 8:57 Pedro Alves
2009-02-16 19:35 ` Eli Zaretskii
2009-02-16 20:45 ` Pedro Alves
2009-02-16 20:50 ` Eli Zaretskii
2009-02-17 0:07 ` Pedro Alves
2009-02-17 4:12 ` Eli Zaretskii
2009-02-17 13:30 ` Pedro Alves
2009-02-17 19:20 ` Eli Zaretskii
2009-02-17 20:01 ` Pedro Alves
2009-02-17 20:28 ` Tom Tromey
2009-02-17 20:50 ` Eli Zaretskii
2009-02-17 21:12 ` Tom Tromey
2009-02-18 2:06 ` Stan Shebs
2009-02-18 10:13 ` Eli Zaretskii [this message]
2009-02-18 14:47 ` Mark Kettenis
2009-02-18 19:50 ` Eli Zaretskii
2009-02-23 0:49 ` Pedro Alves
2009-02-23 1:22 ` Pedro Alves
2009-02-23 20:09 ` Pedro Alves
2009-02-24 14:48 ` Pierre Muller
2009-02-24 14:52 ` Pedro Alves
2009-02-24 15:04 ` Pierre Muller
2009-02-24 15:31 ` Pedro Alves
2009-02-24 15:58 ` [Commit] obvious: fix compilation failure for windows-nat.c Pierre Muller
2009-07-20 12:07 ` Restore GNU/Hurd functionality (was: Modernize solaris threads support.) Thomas Schwinge
2009-07-20 13:02 ` Pedro Alves
2009-07-20 15:08 ` Restore GNU/Hurd functionality Thomas Schwinge
2009-07-20 17:33 ` Pedro Alves
2009-02-26 19:45 ` Modernize solaris threads support David Daney
2009-02-27 18:22 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=umyckv0dm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=stan@codesourcery.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox