Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: David Daney <ddaney@caviumnetworks.com>
Subject: Re: Modernize solaris threads support.
Date: Fri, 27 Feb 2009 18:22:00 -0000	[thread overview]
Message-ID: <200902261945.11065.pedro@codesourcery.com> (raw)
In-Reply-To: <49A6EAFE.2000309@caviumnetworks.com>

On Thursday 26 February 2009 19:18:22, David Daney wrote:

> > On Monday 16 February 2009 05:49:48, Pedro Alves wrote:
> [...]
> >>         m68klinux-nat.c, m88kbsd-nat.c, mips-linux-nat.c,
> 
> Unfortunately I think your change to mips-linux-nat.c breaks things.
> 
> You added a struct target_ops * parameter to super_fetch_registers and 
> super_store_registers, but did not adjust the call sites.
> 

Indeed.  Fixed now.  Thanks.

-- 
Pedro Alves

2009-02-26  Pedro Alves  <pedro@codesourcery.com>

	* mips-linux-nat.c (mips64_linux_fetch_registers): Pass `ops' to
	call to super_fetch_registers.
	(mips64_linux_store_registers): Pass `ops' to call to
	super_store_registers.

---
 gdb/mips-linux-nat.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: src/gdb/mips-linux-nat.c
===================================================================
--- src.orig/gdb/mips-linux-nat.c	2009-02-26 19:35:26.000000000 +0000
+++ src/gdb/mips-linux-nat.c	2009-02-26 19:35:56.000000000 +0000
@@ -314,7 +314,7 @@ mips64_linux_fetch_registers (struct tar
   /* If we know, or just found out, that PTRACE_GETREGS does not work, fall
      back to PTRACE_PEEKUSER.  */
   if (!have_ptrace_regsets)
-    super_fetch_registers (regcache, regnum);
+    super_fetch_registers (ops, regcache, regnum);
 }
 
 /* Store REGNO (or all registers if REGNO == -1) to the target
@@ -331,7 +331,7 @@ mips64_linux_store_registers (struct tar
   /* If we know, or just found out, that PTRACE_GETREGS does not work, fall
      back to PTRACE_PEEKUSER.  */
   if (!have_ptrace_regsets)
-    super_store_registers (regcache, regnum);
+    super_store_registers (ops, regcache, regnum);
 }
 
 /* Return the address in the core dump or inferior of register


      reply	other threads:[~2009-02-26 19:45 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-16  8:57 Pedro Alves
2009-02-16 19:35 ` Eli Zaretskii
2009-02-16 20:45   ` Pedro Alves
2009-02-16 20:50     ` Eli Zaretskii
2009-02-17  0:07       ` Pedro Alves
2009-02-17  4:12         ` Eli Zaretskii
2009-02-17 13:30           ` Pedro Alves
2009-02-17 19:20             ` Eli Zaretskii
2009-02-17 20:01               ` Pedro Alves
2009-02-17 20:28               ` Tom Tromey
2009-02-17 20:50                 ` Eli Zaretskii
2009-02-17 21:12                   ` Tom Tromey
2009-02-18  2:06                     ` Stan Shebs
2009-02-18 10:13                       ` Eli Zaretskii
2009-02-18 14:47                         ` Mark Kettenis
2009-02-18 19:50                           ` Eli Zaretskii
2009-02-23  0:49 ` Pedro Alves
2009-02-23  1:22   ` Pedro Alves
2009-02-23 20:09     ` Pedro Alves
2009-02-24 14:48       ` Pierre Muller
2009-02-24 14:52         ` Pedro Alves
2009-02-24 15:04           ` Pierre Muller
2009-02-24 15:31             ` Pedro Alves
2009-02-24 15:58               ` [Commit] obvious: fix compilation failure for windows-nat.c Pierre Muller
2009-07-20 12:07           ` Restore GNU/Hurd functionality (was: Modernize solaris threads support.) Thomas Schwinge
2009-07-20 13:02             ` Pedro Alves
2009-07-20 15:08               ` Restore GNU/Hurd functionality Thomas Schwinge
2009-07-20 17:33                 ` Pedro Alves
2009-02-26 19:45   ` Modernize solaris threads support David Daney
2009-02-27 18:22     ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200902261945.11065.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=ddaney@caviumnetworks.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox