RE: Modernize solaris threads support.

["Pierre Muller" <muller@ics.u-strasbg.fr>]

Pedro, 
you also broke windows-nat.c compilation...

gcc -g -O2   -I. -I../../purecvs/gdb -I../../purecvs/gdb/config
-DLOCALEDIR="\"/
usr/local/share/locale\"" -DHAVE_CONFIG_H
-I../../purecvs/gdb/../include/opcode
-I../../purecvs/gdb/../readline/.. -I../bfd -I../../purecvs/gdb/../bfd
-I../../p
urecvs/gdb/../include -I../libdecnumber -I../../purecvs/gdb/../libdecnumber
-I.
./../purecvs/gdb/gnulib -Ignulib  -DMI_OUT=1 -DTUI=1   -Wall
-Wdeclaration-after
-statement -Wpointer-arith -Wformat-nonliteral -Wno-unused -Wno-switch
-Wno-char
-subscripts -Werror -c -o windows-nat.o -MT windows-nat.o -MMD -MP -MF
.deps/win
dows-nat.Tpo ../../purecvs/gdb/windows-nat.c
../../purecvs/gdb/windows-nat.c: In function `get_windows_debug_event':
../../purecvs/gdb/windows-nat.c:1435: error: incompatible type for argument
1 of
 `windows_resume'
../../purecvs/gdb/windows-nat.c:1435: error: incompatible type for argument
2 of
 `windows_resume'
../../purecvs/gdb/windows-nat.c:1435: error: too few arguments to function
`wind
ows_resume'
../../purecvs/gdb/windows-nat.c: In function `init_windows_ops':
../../purecvs/gdb/windows-nat.c:2133: warning: assignment from incompatible
poin
ter type
../../purecvs/gdb/windows-nat.c: At top level:
../../purecvs/gdb/windows-nat.c:2278: error: conflicting types for
'windows_thre
ad_alive'
../../purecvs/gdb/windows-nat.c:116: error: previous declaration of
'windows_thr
ead_alive' was here
../../purecvs/gdb/windows-nat.c:2278: error: conflicting types for
'windows_thre
ad_alive'
../../purecvs/gdb/windows-nat.c:116: error: previous declaration of
'windows_thr
ead_alive' was here
make: *** [windows-nat.o] Error 1



Pierre Muller
Pascal language support maintainer for GDB



> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pedro Alves
> Envoyé : Monday, February 23, 2009 7:36 PM
> À : gdb-patches@sourceware.org
> Objet : Re: Modernize solaris threads support.
> 
> I had converted three other callbacks in this file, but missed
> gdbsim_resume.
> 
> remote-sim.o isn't built with a x86-64-linux --enable-targets=all
> configuration.  I just built a --target=arm-elf gdb to confirm this
> builds OK now.
> 
> Checked in.
> 
> --
> Pedro Alves
> 
> 2009-02-23  Pedro Alves  <pedro@codesourcery.com>
> 
> 	* remote-sim.c (gdbsim_resume): Add target_ops* argument.
> 
> ---
>  gdb/remote-sim.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> Index: src/gdb/remote-sim.c
> ===================================================================
> --- src.orig/gdb/remote-sim.c	2009-02-23 18:20:05.000000000 +0000
> +++ src/gdb/remote-sim.c	2009-02-23 18:23:28.000000000 +0000
> @@ -82,8 +82,6 @@ static void gdbsim_close (int quitting);
> 
>  static void gdbsim_detach (struct target_ops *ops, char *args, int
> from_tty);
> 
> -static void gdbsim_resume (ptid_t ptid, int step, enum target_signal
> siggnal);
> -
>  static void gdbsim_prepare_to_store (struct regcache *regcache);
> 
>  static void gdbsim_files_info (struct target_ops *target);
> @@ -614,7 +612,8 @@ static enum target_signal resume_siggnal
>  static int resume_step;
> 
>  static void
> -gdbsim_resume (ptid_t ptid, int step, enum target_signal siggnal)
> +gdbsim_resume (struct target_ops *ops,
> +	       ptid_t ptid, int step, enum target_signal siggnal)
>  {
>    if (!ptid_equal (inferior_ptid, remote_sim_ptid))
>      error (_("The program is not being run."));