From: Tom Tromey <tromey@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Pedro Alves <pedro@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: Modernize solaris threads support.
Date: Tue, 17 Feb 2009 20:28:00 -0000 [thread overview]
Message-ID: <m33aec4yw0.fsf@fleche.redhat.com> (raw)
In-Reply-To: <u63j8x4of.fsf@gnu.org> (Eli Zaretskii's message of "Tue\, 17 Feb 2009 21\:08\:00 +0200")
>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
Perdo> If you still want those declarations for some reason, I'll
Pedro> put them back.
Eli> Please do, and thanks.
Please also provide your rationale.
We know Pedro's, but we don't know yours.
I have noticed that many patch reviews consist of an opinion without a
reason. This is bad because it conveys very little information.
Additionally, providing a rationale helps people work out what they
ought to do in the future, and also helps us document our decision
making.
Tom
next prev parent reply other threads:[~2009-02-17 20:01 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-16 8:57 Pedro Alves
2009-02-16 19:35 ` Eli Zaretskii
2009-02-16 20:45 ` Pedro Alves
2009-02-16 20:50 ` Eli Zaretskii
2009-02-17 0:07 ` Pedro Alves
2009-02-17 4:12 ` Eli Zaretskii
2009-02-17 13:30 ` Pedro Alves
2009-02-17 19:20 ` Eli Zaretskii
2009-02-17 20:01 ` Pedro Alves
2009-02-17 20:28 ` Tom Tromey [this message]
2009-02-17 20:50 ` Eli Zaretskii
2009-02-17 21:12 ` Tom Tromey
2009-02-18 2:06 ` Stan Shebs
2009-02-18 10:13 ` Eli Zaretskii
2009-02-18 14:47 ` Mark Kettenis
2009-02-18 19:50 ` Eli Zaretskii
2009-02-23 0:49 ` Pedro Alves
2009-02-23 1:22 ` Pedro Alves
2009-02-23 20:09 ` Pedro Alves
2009-02-24 14:48 ` Pierre Muller
2009-02-24 14:52 ` Pedro Alves
2009-02-24 15:04 ` Pierre Muller
2009-02-24 15:31 ` Pedro Alves
2009-02-24 15:58 ` [Commit] obvious: fix compilation failure for windows-nat.c Pierre Muller
2009-07-20 12:07 ` Restore GNU/Hurd functionality (was: Modernize solaris threads support.) Thomas Schwinge
2009-07-20 13:02 ` Pedro Alves
2009-07-20 15:08 ` Restore GNU/Hurd functionality Thomas Schwinge
2009-07-20 17:33 ` Pedro Alves
2009-02-26 19:45 ` Modernize solaris threads support David Daney
2009-02-27 18:22 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m33aec4yw0.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox