From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15786 invoked by alias); 17 Feb 2009 20:01:54 -0000 Received: (qmail 15545 invoked by uid 22791); 17 Feb 2009 20:01:54 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Feb 2009 20:01:43 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n1HK0aNh031661; Tue, 17 Feb 2009 15:00:36 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n1HK0ag4000768; Tue, 17 Feb 2009 15:00:36 -0500 Received: from opsy.redhat.com (vpn-13-59.rdu.redhat.com [10.11.13.59]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n1HK0WP9003363; Tue, 17 Feb 2009 15:00:34 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id B49195080FB; Tue, 17 Feb 2009 13:00:31 -0700 (MST) To: Eli Zaretskii Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: Modernize solaris threads support. References: <200902160549.49108.pedro@codesourcery.com> <200902162050.49191.pedro@codesourcery.com> <200902171310.24234.pedro@codesourcery.com> From: Tom Tromey Reply-To: tromey@redhat.com Date: Tue, 17 Feb 2009 20:28:00 -0000 In-Reply-To: (Eli Zaretskii's message of "Tue\, 17 Feb 2009 21\:08\:00 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00362.txt.bz2 >>>>> "Eli" == Eli Zaretskii writes: Perdo> If you still want those declarations for some reason, I'll Pedro> put them back. Eli> Please do, and thanks. Please also provide your rationale. We know Pedro's, but we don't know yours. I have noticed that many patch reviews consist of an opinion without a reason. This is bad because it conveys very little information. Additionally, providing a rationale helps people work out what they ought to do in the future, and also helps us document our decision making. Tom