From: Pedro Alves <pedro@codesourcery.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: Modernize solaris threads support.
Date: Mon, 16 Feb 2009 20:45:00 -0000 [thread overview]
Message-ID: <200902161934.52519.pedro@codesourcery.com> (raw)
In-Reply-To: <uhc2uw64a.fsf@gnu.org>
On Monday 16 February 2009 19:09:57, Eli Zaretskii wrote:
> Why did you need to remove these prototypes while at that?
Do you need the prototypes at all? These are static
functions that are defined before any use. Adjusting unneeded
prototypes is just unnecessary, redundant extra work, exactly in
cases like this one.
> Also, the argument you added is unused inside these functions.
> Shouldn't we do something to shut up GCC warnings about them?
No need. Nowhere in GDB's codebase do we do that currently. We
build gdb with -Wno-unused instead.
> Other than that, the changes to go32-nat.c are approved.
Thanks.
--
Pedro Alves
next prev parent reply other threads:[~2009-02-16 19:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-16 8:57 Pedro Alves
2009-02-16 19:35 ` Eli Zaretskii
2009-02-16 20:45 ` Pedro Alves [this message]
2009-02-16 20:50 ` Eli Zaretskii
2009-02-17 0:07 ` Pedro Alves
2009-02-17 4:12 ` Eli Zaretskii
2009-02-17 13:30 ` Pedro Alves
2009-02-17 19:20 ` Eli Zaretskii
2009-02-17 20:01 ` Pedro Alves
2009-02-17 20:28 ` Tom Tromey
2009-02-17 20:50 ` Eli Zaretskii
2009-02-17 21:12 ` Tom Tromey
2009-02-18 2:06 ` Stan Shebs
2009-02-18 10:13 ` Eli Zaretskii
2009-02-18 14:47 ` Mark Kettenis
2009-02-18 19:50 ` Eli Zaretskii
2009-02-23 0:49 ` Pedro Alves
2009-02-23 1:22 ` Pedro Alves
2009-02-23 20:09 ` Pedro Alves
2009-02-24 14:48 ` Pierre Muller
2009-02-24 14:52 ` Pedro Alves
2009-02-24 15:04 ` Pierre Muller
2009-02-24 15:31 ` Pedro Alves
2009-02-24 15:58 ` [Commit] obvious: fix compilation failure for windows-nat.c Pierre Muller
2009-07-20 12:07 ` Restore GNU/Hurd functionality (was: Modernize solaris threads support.) Thomas Schwinge
2009-07-20 13:02 ` Pedro Alves
2009-07-20 15:08 ` Restore GNU/Hurd functionality Thomas Schwinge
2009-07-20 17:33 ` Pedro Alves
2009-02-26 19:45 ` Modernize solaris threads support David Daney
2009-02-27 18:22 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902161934.52519.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox