Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Stan Shebs <stan@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
	pedro@codesourcery.com,   gdb-patches@sourceware.org
Subject: Re: Modernize solaris threads support.
Date: Wed, 18 Feb 2009 02:06:00 -0000	[thread overview]
Message-ID: <499B35C8.9050101@codesourcery.com> (raw)
In-Reply-To: <m3iqn83i36.fsf@fleche.redhat.com>

Tom Tromey wrote:
>>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
>>>>>>             
>
> Eli> It's a matter of personal preferences
>
> Thanks for explaining.
>
> Eli> I also dislike gratuitous changes in code that is there for at least 9
> Eli> years.
>
> Describing other people's considered changes as gratuitous has a
> negative effect.  I am sure Pedro did not think this was gratuitous
> when he wrote it; in fact, he explained why he did it.
>   
As another take on it, one thing I think we want to avoid is to make GDB 
into a some kind of a museum of long-gone programming style. Yes, it can 
be handy to have annotation show that some line hasn't changed in 15 
years (although the value of that is not so much when the lines have 
complicated interactions with each other). But we simply read the code 
more often than we run cvs annotate, and we want to attract new 
developers, so the general style of the code should be as modern and as 
sophisticated as is consistent with our other requirements. Also, while 
we might like somebody to take on wholesale mass updates as a separate 
task, that can result in us waiting for a long time, while the code gets 
older and moldier every day. Incremental progress is messier, but it's 
still progress!

Stan


  reply	other threads:[~2009-02-17 22:10 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-16  8:57 Pedro Alves
2009-02-16 19:35 ` Eli Zaretskii
2009-02-16 20:45   ` Pedro Alves
2009-02-16 20:50     ` Eli Zaretskii
2009-02-17  0:07       ` Pedro Alves
2009-02-17  4:12         ` Eli Zaretskii
2009-02-17 13:30           ` Pedro Alves
2009-02-17 19:20             ` Eli Zaretskii
2009-02-17 20:01               ` Pedro Alves
2009-02-17 20:28               ` Tom Tromey
2009-02-17 20:50                 ` Eli Zaretskii
2009-02-17 21:12                   ` Tom Tromey
2009-02-18  2:06                     ` Stan Shebs [this message]
2009-02-18 10:13                       ` Eli Zaretskii
2009-02-18 14:47                         ` Mark Kettenis
2009-02-18 19:50                           ` Eli Zaretskii
2009-02-23  0:49 ` Pedro Alves
2009-02-23  1:22   ` Pedro Alves
2009-02-23 20:09     ` Pedro Alves
2009-02-24 14:48       ` Pierre Muller
2009-02-24 14:52         ` Pedro Alves
2009-02-24 15:04           ` Pierre Muller
2009-02-24 15:31             ` Pedro Alves
2009-02-24 15:58               ` [Commit] obvious: fix compilation failure for windows-nat.c Pierre Muller
2009-07-20 12:07           ` Restore GNU/Hurd functionality (was: Modernize solaris threads support.) Thomas Schwinge
2009-07-20 13:02             ` Pedro Alves
2009-07-20 15:08               ` Restore GNU/Hurd functionality Thomas Schwinge
2009-07-20 17:33                 ` Pedro Alves
2009-02-26 19:45   ` Modernize solaris threads support David Daney
2009-02-27 18:22     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=499B35C8.9050101@codesourcery.com \
    --to=stan@codesourcery.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox