From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23222 invoked by alias); 17 Feb 2009 22:10:36 -0000 Received: (qmail 23214 invoked by uid 22791); 17 Feb 2009 22:10:35 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Feb 2009 22:10:24 +0000 Received: (qmail 22055 invoked from network); 17 Feb 2009 22:10:22 -0000 Received: from unknown (HELO macbook-2.local) (stan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 17 Feb 2009 22:10:22 -0000 Message-ID: <499B35C8.9050101@codesourcery.com> Date: Wed, 18 Feb 2009 02:06:00 -0000 From: Stan Shebs User-Agent: Thunderbird 2.0.0.19 (Macintosh/20081209) MIME-Version: 1.0 To: Tom Tromey CC: Eli Zaretskii , pedro@codesourcery.com, gdb-patches@sourceware.org Subject: Re: Modernize solaris threads support. References: <200902160549.49108.pedro@codesourcery.com> <200902162050.49191.pedro@codesourcery.com> <200902171310.24234.pedro@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00372.txt.bz2 Tom Tromey wrote: >>>>>> "Eli" == Eli Zaretskii writes: >>>>>> > > Eli> It's a matter of personal preferences > > Thanks for explaining. > > Eli> I also dislike gratuitous changes in code that is there for at least 9 > Eli> years. > > Describing other people's considered changes as gratuitous has a > negative effect. I am sure Pedro did not think this was gratuitous > when he wrote it; in fact, he explained why he did it. > As another take on it, one thing I think we want to avoid is to make GDB into a some kind of a museum of long-gone programming style. Yes, it can be handy to have annotation show that some line hasn't changed in 15 years (although the value of that is not so much when the lines have complicated interactions with each other). But we simply read the code more often than we run cvs annotate, and we want to attract new developers, so the general style of the code should be as modern and as sophisticated as is consistent with our other requirements. Also, while we might like somebody to take on wholesale mass updates as a separate task, that can result in us waiting for a long time, while the code gets older and moldier every day. Incremental progress is messier, but it's still progress! Stan