Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: "'Pedro Alves'" <pedro@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: RE: Modernize solaris threads support.
Date: Tue, 24 Feb 2009 15:04:00 -0000	[thread overview]
Message-ID: <001301c9968f$75d346c0$6179d440$@u-strasbg.fr> (raw)
In-Reply-To: <200902241438.58802.pedro@codesourcery.com>

I fixed compilation with that little change:

$ cvs diff -up windows-nat.c
Index: windows-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/windows-nat.c,v
retrieving revision 1.181
diff -u -p -r1.181 windows-nat.c
--- windows-nat.c       23 Feb 2009 00:03:50 -0000      1.181
+++ windows-nat.c       24 Feb 2009 14:50:30 -0000
@@ -113,7 +113,7 @@ static int debug_registers_used;
 #define DEBUG_EXCEPT(x)        if (debug_exceptions)   printf_unfiltered x

 static void windows_stop (ptid_t);
-static int windows_thread_alive (ptid_t);
+static int windows_thread_alive (struct target_ops *, ptid_t);
 static void windows_kill_inferior (void);

 static enum target_signal last_sig = TARGET_SIGNAL_0;
@@ -1432,7 +1432,7 @@ get_windows_debug_event (struct target_o
   if (!retval || saw_create != 1)
     {
       if (continue_status == -1)
-       windows_resume (minus_one_ptid, 0, 1);
+       windows_resume (ops, minus_one_ptid, 0, 1);
       else
        CHECK (windows_continue (continue_status, -1));
     }

Should I commit it?


Pierre Muller
Pascal language support maintainer for GDB




> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pedro Alves
> Envoyé : Tuesday, February 24, 2009 3:39 PM
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: Modernize solaris threads support.
> 
> On Tuesday 24 February 2009 14:33:05, Pierre Muller wrote:
> > Pedro,
> > you also broke windows-nat.c compilation...
> 
> Uh!  Darn it.
> 
> Ok, give me a moment to go through all to_resume implementations, as
> it seems I missed a few.
> 
> Sorry about that.
> 
> In any case, as I said before, I had to touch most *native*
> configurations, so it's likelly that I missed several cases.  If
> you do spot one, the fix is *dead trivial*, so go ahead and commit a
> fix as obvious ...
> 
> --
> Pedro Alves


  reply	other threads:[~2009-02-24 14:52 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-16  8:57 Pedro Alves
2009-02-16 19:35 ` Eli Zaretskii
2009-02-16 20:45   ` Pedro Alves
2009-02-16 20:50     ` Eli Zaretskii
2009-02-17  0:07       ` Pedro Alves
2009-02-17  4:12         ` Eli Zaretskii
2009-02-17 13:30           ` Pedro Alves
2009-02-17 19:20             ` Eli Zaretskii
2009-02-17 20:01               ` Pedro Alves
2009-02-17 20:28               ` Tom Tromey
2009-02-17 20:50                 ` Eli Zaretskii
2009-02-17 21:12                   ` Tom Tromey
2009-02-18  2:06                     ` Stan Shebs
2009-02-18 10:13                       ` Eli Zaretskii
2009-02-18 14:47                         ` Mark Kettenis
2009-02-18 19:50                           ` Eli Zaretskii
2009-02-23  0:49 ` Pedro Alves
2009-02-23  1:22   ` Pedro Alves
2009-02-23 20:09     ` Pedro Alves
2009-02-24 14:48       ` Pierre Muller
2009-02-24 14:52         ` Pedro Alves
2009-02-24 15:04           ` Pierre Muller [this message]
2009-02-24 15:31             ` Pedro Alves
2009-02-24 15:58               ` [Commit] obvious: fix compilation failure for windows-nat.c Pierre Muller
2009-07-20 12:07           ` Restore GNU/Hurd functionality (was: Modernize solaris threads support.) Thomas Schwinge
2009-07-20 13:02             ` Pedro Alves
2009-07-20 15:08               ` Restore GNU/Hurd functionality Thomas Schwinge
2009-07-20 17:33                 ` Pedro Alves
2009-02-26 19:45   ` Modernize solaris threads support David Daney
2009-02-27 18:22     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001301c9968f$75d346c0$6179d440$@u-strasbg.fr' \
    --to=muller@ics.u-strasbg.fr \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox