From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11556 invoked by alias); 24 Feb 2009 14:52:15 -0000 Received: (qmail 11548 invoked by uid 22791); 24 Feb 2009 14:52:14 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.157) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Feb 2009 14:52:09 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n1OEq3WX054019 ; Tue, 24 Feb 2009 15:52:03 +0100 (CET) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n1OEq3D1058201 ; Tue, 24 Feb 2009 15:52:03 +0100 (CET) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n1OEq340061821 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Tue, 24 Feb 2009 15:52:03 +0100 (CET) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: "'Pedro Alves'" Cc: References: <200902160549.49108.pedro@codesourcery.com> <200902231836.13188.pedro@codesourcery.com> <001201c9968c$ce7dab60$6b790220$@u-strasbg.fr> <200902241438.58802.pedro@codesourcery.com> In-Reply-To: <200902241438.58802.pedro@codesourcery.com> Subject: RE: Modernize solaris threads support. Date: Tue, 24 Feb 2009 15:04:00 -0000 Message-ID: <001301c9968f$75d346c0$6179d440$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00463.txt.bz2 I fixed compilation with that little change: $ cvs diff -up windows-nat.c Index: windows-nat.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/windows-nat.c,v retrieving revision 1.181 diff -u -p -r1.181 windows-nat.c --- windows-nat.c 23 Feb 2009 00:03:50 -0000 1.181 +++ windows-nat.c 24 Feb 2009 14:50:30 -0000 @@ -113,7 +113,7 @@ static int debug_registers_used; #define DEBUG_EXCEPT(x) if (debug_exceptions) printf_unfiltered x static void windows_stop (ptid_t); -static int windows_thread_alive (ptid_t); +static int windows_thread_alive (struct target_ops *, ptid_t); static void windows_kill_inferior (void); static enum target_signal last_sig =3D TARGET_SIGNAL_0; @@ -1432,7 +1432,7 @@ get_windows_debug_event (struct target_o if (!retval || saw_create !=3D 1) { if (continue_status =3D=3D -1) - windows_resume (minus_one_ptid, 0, 1); + windows_resume (ops, minus_one_ptid, 0, 1); else CHECK (windows_continue (continue_status, -1)); } Should I commit it? Pierre Muller Pascal language support maintainer for GDB > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Pedro Alves > Envoy=E9=A0: Tuesday, February 24, 2009 3:39 PM > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: Modernize solaris threads support. >=20 > On Tuesday 24 February 2009 14:33:05, Pierre Muller wrote: > > Pedro, > > you also broke windows-nat.c compilation... >=20 > Uh! Darn it. >=20 > Ok, give me a moment to go through all to_resume implementations, as > it seems I missed a few. >=20 > Sorry about that. >=20 > In any case, as I said before, I had to touch most *native* > configurations, so it's likelly that I missed several cases. If > you do spot one, the fix is *dead trivial*, so go ahead and commit a > fix as obvious ... >=20 > -- > Pedro Alves