Re: Modernize solaris threads support.

[Mark Kettenis <mark.kettenis@xs4all.nl>]

> Date: Wed, 18 Feb 2009 06:23:49 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > Date: Tue, 17 Feb 2009 14:10:16 -0800
> > From: Stan Shebs <stan@codesourcery.com>
> > CC: Eli Zaretskii <eliz@gnu.org>, pedro@codesourcery.com, 
> >  gdb-patches@sourceware.org
> > 
> > As another take on it, one thing I think we want to avoid is to make GDB 
> > into a some kind of a museum of long-gone programming style.
> 
> I don't think prototypes are ``a long-gone programming style''.
> 
> The problem with changes that are not strictly needed for the patch at
> hand is that they obscure the real change.  It's the same as lumping
> several unrelated changes in one diff, which is discouraged here (and
> rightfully so).

Eli, I'm really surprised by this discussion.  We have been doing this
(removing redundant prototypes) for years now (ever since we moved
away from K&R C to ISO C90).  It really makes doing the sort of
changes that Pedro is making a lot less labour intensive.  And I
disagree that they are unrelated to the changes he is making.