From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-61761-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10029 invoked by alias); 18 Feb 2009 10:19:09 -0000
Received: (qmail 10020 invoked by uid 22791); 18 Feb 2009 10:19:09 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Feb 2009 10:19:00 +0000
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id n1IAG6Sa032208; 	Wed, 18 Feb 2009 11:16:06 +0100 (CET)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id n1IAG4IX032608; 	Wed, 18 Feb 2009 11:16:04 +0100 (CET)
Date: Wed, 18 Feb 2009 14:47:00 -0000
Message-Id: <200902181016.n1IAG4IX032608@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: eliz@gnu.org
CC: stan@codesourcery.com, tromey@redhat.com, pedro@codesourcery.com,         gdb-patches@sourceware.org
In-reply-to: <umyckv0dm.fsf@gnu.org> (message from Eli Zaretskii on Wed, 18 	Feb 2009 06:23:49 +0200)
Subject: Re: Modernize solaris threads support.
References: <200902160549.49108.pedro@codesourcery.com> <200902162050.49191.pedro@codesourcery.com> <ubpt1wwae.fsf@gnu.org> <200902171310.24234.pedro@codesourcery.com> <u63j8x4of.fsf@gnu.org> <m33aec4yw0.fsf@fleche.redhat.com> <uwsbovlyx.fsf@gnu.org> <m3iqn83i36.fsf@fleche.redhat.com> <499B35C8.9050101@codesourcery.com> <umyckv0dm.fsf@gnu.org>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-02/txt/msg00380.txt.bz2

> Date: Wed, 18 Feb 2009 06:23:49 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > Date: Tue, 17 Feb 2009 14:10:16 -0800
> > From: Stan Shebs <stan@codesourcery.com>
> > CC: Eli Zaretskii <eliz@gnu.org>, pedro@codesourcery.com, 
> >  gdb-patches@sourceware.org
> > 
> > As another take on it, one thing I think we want to avoid is to make GDB 
> > into a some kind of a museum of long-gone programming style.
> 
> I don't think prototypes are ``a long-gone programming style''.
> 
> The problem with changes that are not strictly needed for the patch at
> hand is that they obscure the real change.  It's the same as lumping
> several unrelated changes in one diff, which is discouraged here (and
> rightfully so).

Eli, I'm really surprised by this discussion.  We have been doing this
(removing redundant prototypes) for years now (ever since we moved
away from K&R C to ISO C90).  It really makes doing the sort of
changes that Pedro is making a lot less labour intensive.  And I
disagree that they are unrelated to the changes he is making.