Re: Modernize solaris threads support.

[Eli Zaretskii <eliz@gnu.org>]

> From: Pedro Alves <pedro@codesourcery.com>
> Date: Mon, 16 Feb 2009 05:49:48 +0000
> 
> Started out as getting rid of a couple of deprecated_xfer_memory instances...
> * Adds a `this' target_ops pointer to a few more target_ops callbacks,
>   so we get rid of a bunch of things like this, by instead calling
>   the target beneath:
> 
>    -  if (target_has_execution)
>    -    procfs_ops.to_fetch_registers (regcache, -1);
>    -  else
>    -    orig_core_ops.to_fetch_registers (regcache, -1);

I don't mind doing this, but...

> Index: src/gdb/go32-nat.c
> ===================================================================
> --- src.orig/gdb/go32-nat.c	2009-02-16 00:20:30.000000000 +0000
> +++ src/gdb/go32-nat.c	2009-02-16 03:26:06.000000000 +0000
> @@ -169,11 +169,7 @@ static void go32_open (char *name, int f
>  static void go32_close (int quitting);
>  static void go32_attach (char *args, int from_tty);
>  static void go32_detach (char *args, int from_tty);
> -static void go32_resume (ptid_t ptid, int step,
> -                         enum target_signal siggnal);
> -static void go32_fetch_registers (struct regcache *, int regno);
>  static void store_register (const struct regcache *, int regno);
> -static void go32_store_registers (struct regcache *, int regno);

Why did you need to remove these prototypes while at that?

Also, the argument you added is unused inside these functions.
Shouldn't we do something to shut up GCC warnings about them?

Other than that, the changes to go32-nat.c are approved.

Thanks.