From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13168 invoked by alias); 16 Feb 2009 19:10:05 -0000 Received: (qmail 13150 invoked by uid 22791); 16 Feb 2009 19:10:03 -0000 X-SWARE-Spam-Status: No, hits=0.8 required=5.0 tests=AWL,BAYES_00,BOTNET,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout1.012.net.il (HELO mtaout1.012.net.il) (84.95.2.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Feb 2009 19:09:57 +0000 Received: from conversion-daemon.i-mtaout1.012.net.il by i-mtaout1.012.net.il (HyperSendmail v2007.08) id <0KF600E00AHTMD00@i-mtaout1.012.net.il> for gdb-patches@sourceware.org; Mon, 16 Feb 2009 21:10:24 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.228.82.14]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KF600DAOAL9XT10@i-mtaout1.012.net.il>; Mon, 16 Feb 2009 21:10:22 +0200 (IST) Date: Mon, 16 Feb 2009 19:35:00 -0000 From: Eli Zaretskii Subject: Re: Modernize solaris threads support. In-reply-to: <200902160549.49108.pedro@codesourcery.com> To: Pedro Alves Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: References: <200902160549.49108.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00334.txt.bz2 > From: Pedro Alves > Date: Mon, 16 Feb 2009 05:49:48 +0000 > > Started out as getting rid of a couple of deprecated_xfer_memory instances... > * Adds a `this' target_ops pointer to a few more target_ops callbacks, > so we get rid of a bunch of things like this, by instead calling > the target beneath: > > - if (target_has_execution) > - procfs_ops.to_fetch_registers (regcache, -1); > - else > - orig_core_ops.to_fetch_registers (regcache, -1); I don't mind doing this, but... > Index: src/gdb/go32-nat.c > =================================================================== > --- src.orig/gdb/go32-nat.c 2009-02-16 00:20:30.000000000 +0000 > +++ src/gdb/go32-nat.c 2009-02-16 03:26:06.000000000 +0000 > @@ -169,11 +169,7 @@ static void go32_open (char *name, int f > static void go32_close (int quitting); > static void go32_attach (char *args, int from_tty); > static void go32_detach (char *args, int from_tty); > -static void go32_resume (ptid_t ptid, int step, > - enum target_signal siggnal); > -static void go32_fetch_registers (struct regcache *, int regno); > static void store_register (const struct regcache *, int regno); > -static void go32_store_registers (struct regcache *, int regno); Why did you need to remove these prototypes while at that? Also, the argument you added is unused inside these functions. Shouldn't we do something to shut up GCC warnings about them? Other than that, the changes to go32-nat.c are approved. Thanks.