From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28297 invoked by alias); 16 Feb 2009 19:35:04 -0000 Received: (qmail 28289 invoked by uid 22791); 16 Feb 2009 19:35:03 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Feb 2009 19:34:55 +0000 Received: (qmail 31190 invoked from network); 16 Feb 2009 19:34:54 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 16 Feb 2009 19:34:54 -0000 From: Pedro Alves To: Eli Zaretskii Subject: Re: Modernize solaris threads support. Date: Mon, 16 Feb 2009 20:45:00 -0000 User-Agent: KMail/1.9.10 Cc: gdb-patches@sourceware.org References: <200902160549.49108.pedro@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200902161934.52519.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00335.txt.bz2 On Monday 16 February 2009 19:09:57, Eli Zaretskii wrote: > Why did you need to remove these prototypes while at that? Do you need the prototypes at all? These are static functions that are defined before any use. Adjusting unneeded prototypes is just unnecessary, redundant extra work, exactly in cases like this one. > Also, the argument you added is unused inside these functions. > Shouldn't we do something to shut up GCC warnings about them? No need. Nowhere in GDB's codebase do we do that currently. We build gdb with -Wno-unused instead. > Other than that, the changes to go32-nat.c are approved. Thanks. -- Pedro Alves