From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24651 invoked by alias); 24 Feb 2009 14:33:20 -0000 Received: (qmail 24640 invoked by uid 22791); 24 Feb 2009 14:33:18 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_20 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.156) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Feb 2009 14:33:12 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n1OEX4vc085899 ; Tue, 24 Feb 2009 15:33:04 +0100 (CET) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n1OEX4Ng041821 ; Tue, 24 Feb 2009 15:33:04 +0100 (CET) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n1OEX3ZJ046359 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Tue, 24 Feb 2009 15:33:03 +0100 (CET) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: "'Pedro Alves'" , References: <200902160549.49108.pedro@codesourcery.com> <200902230005.24063.pedro@codesourcery.com> <200902230051.44044.pedro@codesourcery.com> <200902231836.13188.pedro@codesourcery.com> In-Reply-To: <200902231836.13188.pedro@codesourcery.com> Subject: RE: Modernize solaris threads support. Date: Tue, 24 Feb 2009 14:48:00 -0000 Message-ID: <001201c9968c$ce7dab60$6b790220$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00460.txt.bz2 Pedro,=20 you also broke windows-nat.c compilation... gcc -g -O2 -I. -I../../purecvs/gdb -I../../purecvs/gdb/config -DLOCALEDIR=3D"\"/ usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../purecvs/gdb/../include/opcode -I../../purecvs/gdb/../readline/.. -I../bfd -I../../purecvs/gdb/../bfd -I../../p urecvs/gdb/../include -I../libdecnumber -I../../purecvs/gdb/../libdecnumber -I. ./../purecvs/gdb/gnulib -Ignulib -DMI_OUT=3D1 -DTUI=3D1 -Wall -Wdeclaration-after -statement -Wpointer-arith -Wformat-nonliteral -Wno-unused -Wno-switch -Wno-char -subscripts -Werror -c -o windows-nat.o -MT windows-nat.o -MMD -MP -MF .deps/win dows-nat.Tpo ../../purecvs/gdb/windows-nat.c ../../purecvs/gdb/windows-nat.c: In function `get_windows_debug_event': ../../purecvs/gdb/windows-nat.c:1435: error: incompatible type for argument 1 of `windows_resume' ../../purecvs/gdb/windows-nat.c:1435: error: incompatible type for argument 2 of `windows_resume' ../../purecvs/gdb/windows-nat.c:1435: error: too few arguments to function `wind ows_resume' ../../purecvs/gdb/windows-nat.c: In function `init_windows_ops': ../../purecvs/gdb/windows-nat.c:2133: warning: assignment from incompatible poin ter type ../../purecvs/gdb/windows-nat.c: At top level: ../../purecvs/gdb/windows-nat.c:2278: error: conflicting types for 'windows_thre ad_alive' ../../purecvs/gdb/windows-nat.c:116: error: previous declaration of 'windows_thr ead_alive' was here ../../purecvs/gdb/windows-nat.c:2278: error: conflicting types for 'windows_thre ad_alive' ../../purecvs/gdb/windows-nat.c:116: error: previous declaration of 'windows_thr ead_alive' was here make: *** [windows-nat.o] Error 1 Pierre Muller Pascal language support maintainer for GDB > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Pedro Alves > Envoy=E9=A0: Monday, February 23, 2009 7:36 PM > =C0=A0: gdb-patches@sourceware.org > Objet=A0: Re: Modernize solaris threads support. >=20 > I had converted three other callbacks in this file, but missed > gdbsim_resume. >=20 > remote-sim.o isn't built with a x86-64-linux --enable-targets=3Dall > configuration. I just built a --target=3Darm-elf gdb to confirm this > builds OK now. >=20 > Checked in. >=20 > -- > Pedro Alves >=20 > 2009-02-23 Pedro Alves >=20 > * remote-sim.c (gdbsim_resume): Add target_ops* argument. >=20 > --- > gdb/remote-sim.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >=20 > Index: src/gdb/remote-sim.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- src.orig/gdb/remote-sim.c 2009-02-23 18:20:05.000000000 +0000 > +++ src/gdb/remote-sim.c 2009-02-23 18:23:28.000000000 +0000 > @@ -82,8 +82,6 @@ static void gdbsim_close (int quitting); >=20 > static void gdbsim_detach (struct target_ops *ops, char *args, int > from_tty); >=20 > -static void gdbsim_resume (ptid_t ptid, int step, enum target_signal > siggnal); > - > static void gdbsim_prepare_to_store (struct regcache *regcache); >=20 > static void gdbsim_files_info (struct target_ops *target); > @@ -614,7 +612,8 @@ static enum target_signal resume_siggnal > static int resume_step; >=20 > static void > -gdbsim_resume (ptid_t ptid, int step, enum target_signal siggnal) > +gdbsim_resume (struct target_ops *ops, > + ptid_t ptid, int step, enum target_signal siggnal) > { > if (!ptid_equal (inferior_ptid, remote_sim_ptid)) > error (_("The program is not being run."));