From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25575 invoked by alias); 26 Feb 2009 19:45:16 -0000 Received: (qmail 25564 invoked by uid 22791); 26 Feb 2009 19:45:15 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Feb 2009 19:45:10 +0000 Received: (qmail 8306 invoked from network); 26 Feb 2009 19:45:08 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 26 Feb 2009 19:45:08 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: Modernize solaris threads support. Date: Fri, 27 Feb 2009 18:22:00 -0000 User-Agent: KMail/1.9.10 Cc: David Daney References: <200902160549.49108.pedro@codesourcery.com> <200902230005.24063.pedro@codesourcery.com> <49A6EAFE.2000309@caviumnetworks.com> In-Reply-To: <49A6EAFE.2000309@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200902261945.11065.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00492.txt.bz2 On Thursday 26 February 2009 19:18:22, David Daney wrote: > > On Monday 16 February 2009 05:49:48, Pedro Alves wrote: > [...] > >> m68klinux-nat.c, m88kbsd-nat.c, mips-linux-nat.c, > > Unfortunately I think your change to mips-linux-nat.c breaks things. > > You added a struct target_ops * parameter to super_fetch_registers and > super_store_registers, but did not adjust the call sites. > Indeed. Fixed now. Thanks. -- Pedro Alves 2009-02-26 Pedro Alves * mips-linux-nat.c (mips64_linux_fetch_registers): Pass `ops' to call to super_fetch_registers. (mips64_linux_store_registers): Pass `ops' to call to super_store_registers. --- gdb/mips-linux-nat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: src/gdb/mips-linux-nat.c =================================================================== --- src.orig/gdb/mips-linux-nat.c 2009-02-26 19:35:26.000000000 +0000 +++ src/gdb/mips-linux-nat.c 2009-02-26 19:35:56.000000000 +0000 @@ -314,7 +314,7 @@ mips64_linux_fetch_registers (struct tar /* If we know, or just found out, that PTRACE_GETREGS does not work, fall back to PTRACE_PEEKUSER. */ if (!have_ptrace_regsets) - super_fetch_registers (regcache, regnum); + super_fetch_registers (ops, regcache, regnum); } /* Store REGNO (or all registers if REGNO == -1) to the target @@ -331,7 +331,7 @@ mips64_linux_store_registers (struct tar /* If we know, or just found out, that PTRACE_GETREGS does not work, fall back to PTRACE_PEEKUSER. */ if (!have_ptrace_regsets) - super_store_registers (regcache, regnum); + super_store_registers (ops, regcache, regnum); } /* Return the address in the core dump or inferior of register