From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-61758-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10048 invoked by alias); 18 Feb 2009 04:24:59 -0000
Received: (qmail 10038 invoked by uid 22791); 18 Feb 2009 04:24:58 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout5.012.net.il (HELO mtaout5.012.net.il) (84.95.2.13)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Feb 2009 04:24:47 +0000
Received: from conversion-daemon.i_mtaout5.012.net.il by i_mtaout5.012.net.il (HyperSendmail v2004.12) id <0KF800100UVQWL00@i_mtaout5.012.net.il> for gdb-patches@sourceware.org; Wed, 18 Feb 2009 06:24:07 +0200 (IST)
Received: from HOME-C4E4A596F7 ([84.228.82.14]) by i_mtaout5.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KF800190UW6VE92@i_mtaout5.012.net.il>; Wed, 18 Feb 2009 06:24:07 +0200 (IST)
Date: Wed, 18 Feb 2009 10:13:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: Modernize solaris threads support.
In-reply-to: <499B35C8.9050101@codesourcery.com>
To: Stan Shebs <stan@codesourcery.com>
Cc: tromey@redhat.com, pedro@codesourcery.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <umyckv0dm.fsf@gnu.org>
References: <200902160549.49108.pedro@codesourcery.com> <200902162050.49191.pedro@codesourcery.com> <ubpt1wwae.fsf@gnu.org> <200902171310.24234.pedro@codesourcery.com> <u63j8x4of.fsf@gnu.org> <m33aec4yw0.fsf@fleche.redhat.com> <uwsbovlyx.fsf@gnu.org> <m3iqn83i36.fsf@fleche.redhat.com> <499B35C8.9050101@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-02/txt/msg00377.txt.bz2

> Date: Tue, 17 Feb 2009 14:10:16 -0800
> From: Stan Shebs <stan@codesourcery.com>
> CC: Eli Zaretskii <eliz@gnu.org>, pedro@codesourcery.com, 
>  gdb-patches@sourceware.org
> 
> As another take on it, one thing I think we want to avoid is to make GDB 
> into a some kind of a museum of long-gone programming style.

I don't think prototypes are ``a long-gone programming style''.

The problem with changes that are not strictly needed for the patch at
hand is that they obscure the real change.  It's the same as lumping
several unrelated changes in one diff, which is discouraged here (and
rightfully so).