* New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt
@ 2013-02-05 2:01 GDB Administrator
2013-02-05 10:09 ` Pierre Muller
2013-02-06 2:05 ` New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt Sergio Durigan Junior
0 siblings, 2 replies; 14+ messages in thread
From: GDB Administrator @ 2013-02-05 2:01 UTC (permalink / raw)
To: gdb-patches
0a1,2
> gdb/aarch64-tdep.c:776: code: OP eol: Do not use &&, or || at the end of a line
gdb/aarch64-tdep.c:776: pv_add_constant (regs[rn], imm)) ||
> gdb/aarch64-tdep.c:2619: deprecate: write_pc: Replace write_pc() with get_frame_base_address or get_frame_id; at present the inferior function call code still uses this when doing a DECR_PC_AFTER_BREAK
gdb/aarch64-tdep.c:2619: set_gdbarch_write_pc (gdbarch, aarch64_write_pc);
gdb/aarch64-tdep.c:2619: set_gdbarch_write_pc (gdbarch, aarch64_write_pc);
274a277,279
> gdb/gdbarch.h:740: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
gdb/gdbarch.h:740:/* The elfcore writer hook to use to write Linux prpsinfo notes to core
> gdb/gdbarch.h:741: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
gdb/gdbarch.h:741: files. Most Linux architectures use the same prpsinfo32 or
> gdb/gdbarch.h:743: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
gdb/gdbarch.h:743: call the Linux generic routines in bfd to write prpsinfo notes by
556a562
> gdb/ppc-linux-tdep.c:1451: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
gdb/ppc-linux-tdep.c:1451: /* Initialize the Linux target descriptions. */
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt
2013-02-05 2:01 New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt GDB Administrator
@ 2013-02-05 10:09 ` Pierre Muller
2013-02-14 9:44 ` [RFC/RFA] Remove ARI warning for set_gdbarch_write_pc use Pierre Muller
2013-02-06 2:05 ` New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt Sergio Durigan Junior
1 sibling, 1 reply; 14+ messages in thread
From: Pierre Muller @ 2013-02-05 10:09 UTC (permalink / raw)
To: gdb-patches
Hi all,
As ARI maintainer,
I was wondering if the fact that
set_gdbarch_write_pc is treated as write_pc
inside the ARI script is really correct:
I was always considering that gdbarch specific method are
the right way to do things correctly in multi-target GDB.
Why is then set_gdbarch_write_pc also considered as deprecated?
If it should not be, the change below would take care of this:
Pierre Muller
as ARI maintainer.
2013-02-05 Pierre Muller <muller@sourceware.org>
* contrib/ari/gdb_ari.sh (write_pc rule): Do not consider
set_gdbarch_write_pc as deprecated anymore.
Index: gdb_ari.sh
===================================================================
RCS file: /cvs/src/src/gdb/contrib/ari/gdb_ari.sh,v
retrieving revision 1.7
diff -u -p -r1.7 gdb_ari.sh
--- gdb_ari.sh 1 Jan 2013 06:32:56 -0000 1.7
+++ gdb_ari.sh 5 Feb 2013 10:06:14 -0000
@@ -1051,7 +1051,6 @@ a DECR_PC_AFTER_BREAK"
category["write_pc"] = ari_deprecate
}
/(^|[^_[:alnum:]])write_pc[[:space:]]*\(/ || \
-/(^|[^_[:alnum:]])set_gdbarch_write_pc[[:space:]]*\(/ || \
/(^|[^_[:alnum:]])TARGET_WRITE_PC[[:space:]]*\(/ {
fail("write_pc")
}
> > gdb/aarch64-tdep.c:2619: deprecate: write_pc: Replace write_pc() with
> get_frame_base_address or get_frame_id; at present the inferior function
> call code still uses this when doing a DECR_PC_AFTER_BREAK
> gdb/aarch64-tdep.c:2619: set_gdbarch_write_pc (gdbarch,
aarch64_write_pc);
> gdb/aarch64-tdep.c:2619: set_gdbarch_write_pc (gdbarch,
aarch64_write_pc);
> 274a277,279
> > gdb/gdbarch.h:740: comment: GNU/Linux: Do not use 'Linux', instead use
> 'Linux kernel' or 'GNU/Linux system'; comments should clearly
differentiate
> between the two (this test assumes that word 'Linux' appears on the same
> line as the word 'GNU' or 'kernel' or a kernel version
> gdb/gdbarch.h:740:/* The elfcore writer hook to use to write Linux
prpsinfo
> notes to core
> > gdb/gdbarch.h:741: comment: GNU/Linux: Do not use 'Linux', instead use
> 'Linux kernel' or 'GNU/Linux system'; comments should clearly
differentiate
> between the two (this test assumes that word 'Linux' appears on the same
> line as the word 'GNU' or 'kernel' or a kernel version
> gdb/gdbarch.h:741: files. Most Linux architectures use the same
> prpsinfo32 or
> > gdb/gdbarch.h:743: comment: GNU/Linux: Do not use 'Linux', instead use
> 'Linux kernel' or 'GNU/Linux system'; comments should clearly
differentiate
> between the two (this test assumes that word 'Linux' appears on the same
> line as the word 'GNU' or 'kernel' or a kernel version
> gdb/gdbarch.h:743: call the Linux generic routines in bfd to write
> prpsinfo notes by
> 556a562
> > gdb/ppc-linux-tdep.c:1451: comment: GNU/Linux: Do not use 'Linux',
instead
> use 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> differentiate between the two (this test assumes that word 'Linux' appears
> on the same line as the word 'GNU' or 'kernel' or a kernel version
> gdb/ppc-linux-tdep.c:1451: /* Initialize the Linux target descriptions.
*/
^ permalink raw reply [flat|nested] 14+ messages in thread* [RFC/RFA] Remove ARI warning for set_gdbarch_write_pc use
2013-02-05 10:09 ` Pierre Muller
@ 2013-02-14 9:44 ` Pierre Muller
2013-04-15 17:33 ` Joel Brobecker
0 siblings, 1 reply; 14+ messages in thread
From: Pierre Muller @ 2013-02-14 9:44 UTC (permalink / raw)
To: gdb-patches
I realized that the global maintainers might not have
seen this message, which is really
a request for comments or approval.
Pierre Muller
as ARI maintainer
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pierre Muller
> Envoyé : mardi 5 février 2013 11:10
> À : gdb-patches@sourceware.org
> Objet : RE: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D
2013-02-05-gmt
>
> Hi all,
>
> As ARI maintainer,
> I was wondering if the fact that
> set_gdbarch_write_pc is treated as write_pc
> inside the ARI script is really correct:
>
> I was always considering that gdbarch specific method are
> the right way to do things correctly in multi-target GDB.
>
> Why is then set_gdbarch_write_pc also considered as deprecated?
>
> If it should not be, the change below would take care of this:
>
> Pierre Muller
> as ARI maintainer.
>
>
> 2013-02-05 Pierre Muller <muller@sourceware.org>
>
> * contrib/ari/gdb_ari.sh (write_pc rule): Do not consider
> set_gdbarch_write_pc as deprecated anymore.
>
> Index: gdb_ari.sh
> ===================================================================
> RCS file: /cvs/src/src/gdb/contrib/ari/gdb_ari.sh,v
> retrieving revision 1.7
> diff -u -p -r1.7 gdb_ari.sh
> --- gdb_ari.sh 1 Jan 2013 06:32:56 -0000 1.7
> +++ gdb_ari.sh 5 Feb 2013 10:06:14 -0000
> @@ -1051,7 +1051,6 @@ a DECR_PC_AFTER_BREAK"
> category["write_pc"] = ari_deprecate
> }
> /(^|[^_[:alnum:]])write_pc[[:space:]]*\(/ || \
> -/(^|[^_[:alnum:]])set_gdbarch_write_pc[[:space:]]*\(/ || \
> /(^|[^_[:alnum:]])TARGET_WRITE_PC[[:space:]]*\(/ {
> fail("write_pc")
> }
>
> > > gdb/aarch64-tdep.c:2619: deprecate: write_pc: Replace write_pc() with
> > get_frame_base_address or get_frame_id; at present the inferior function
> > call code still uses this when doing a DECR_PC_AFTER_BREAK
> > gdb/aarch64-tdep.c:2619: set_gdbarch_write_pc (gdbarch,
> aarch64_write_pc);
> > gdb/aarch64-tdep.c:2619: set_gdbarch_write_pc (gdbarch,
> aarch64_write_pc);
> > 274a277,279
> > > gdb/gdbarch.h:740: comment: GNU/Linux: Do not use 'Linux', instead use
> > 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> differentiate
> > between the two (this test assumes that word 'Linux' appears on the same
> > line as the word 'GNU' or 'kernel' or a kernel version
> > gdb/gdbarch.h:740:/* The elfcore writer hook to use to write Linux
> prpsinfo
> > notes to core
> > > gdb/gdbarch.h:741: comment: GNU/Linux: Do not use 'Linux', instead use
> > 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> differentiate
> > between the two (this test assumes that word 'Linux' appears on the same
> > line as the word 'GNU' or 'kernel' or a kernel version
> > gdb/gdbarch.h:741: files. Most Linux architectures use the same
> > prpsinfo32 or
> > > gdb/gdbarch.h:743: comment: GNU/Linux: Do not use 'Linux', instead use
> > 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> differentiate
> > between the two (this test assumes that word 'Linux' appears on the same
> > line as the word 'GNU' or 'kernel' or a kernel version
> > gdb/gdbarch.h:743: call the Linux generic routines in bfd to write
> > prpsinfo notes by
> > 556a562
> > > gdb/ppc-linux-tdep.c:1451: comment: GNU/Linux: Do not use 'Linux',
> instead
> > use 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> > differentiate between the two (this test assumes that word 'Linux'
appears
> > on the same line as the word 'GNU' or 'kernel' or a kernel version
> > gdb/ppc-linux-tdep.c:1451: /* Initialize the Linux target descriptions.
> */
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt
2013-02-05 2:01 New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt GDB Administrator
2013-02-05 10:09 ` Pierre Muller
@ 2013-02-06 2:05 ` Sergio Durigan Junior
2013-02-06 9:59 ` Pierre Muller
[not found] ` <002001ce0450$9de57b00$d9b07100$%muller@ics-cnrs.unistra.fr>
1 sibling, 2 replies; 14+ messages in thread
From: Sergio Durigan Junior @ 2013-02-06 2:05 UTC (permalink / raw)
To: gdb-patches
On Tuesday, February 05 2013, GDB Administrator wrote:
>> gdb/gdbarch.h:740: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
> gdb/gdbarch.h:740:/* The elfcore writer hook to use to write Linux prpsinfo notes to core
>> gdb/gdbarch.h:741: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
> gdb/gdbarch.h:741: files. Most Linux architectures use the same prpsinfo32 or
>> gdb/gdbarch.h:743: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
> gdb/gdbarch.h:743: call the Linux generic routines in bfd to write prpsinfo notes by
> 556a562
These were introduced by the PRPSINFO patches, but I don't agree with
them (and don't see an elegant way to fix them). Is there any way to
silent those warnings?
--
Sergio
^ permalink raw reply [flat|nested] 14+ messages in thread* RE: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt
2013-02-06 2:05 ` New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt Sergio Durigan Junior
@ 2013-02-06 9:59 ` Pierre Muller
2013-02-06 10:04 ` [RFC] Remove ARI GNU/Linux rule (was: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt) Pierre Muller
[not found] ` <19773.0148713619$1360145095@news.gmane.org>
[not found] ` <002001ce0450$9de57b00$d9b07100$%muller@ics-cnrs.unistra.fr>
1 sibling, 2 replies; 14+ messages in thread
From: Pierre Muller @ 2013-02-06 9:59 UTC (permalink / raw)
To: 'Sergio Durigan Junior', gdb-patches
This issue has been discussed partly
already in the thread:
http://sourceware.org/ml/gdb-patches/2009-04/msg00286.html
But I don't think that we really reached the point
to agree that we should simply completely remove this
rule.
I will resubmit the removal as a separate email
to see if we can agree on it.
Pierre
as ARI maintainer
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Sergio Durigan Junior
> Envoyé : mercredi 6 février 2013 03:05
> À : gdb-patches@sourceware.org
> Objet : Re: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D
2013-02-05-gmt
>
> On Tuesday, February 05 2013, GDB Administrator wrote:
>
> >> gdb/gdbarch.h:740: comment: GNU/Linux: Do not use 'Linux', instead use
> 'Linux kernel' or 'GNU/Linux system'; comments should clearly
differentiate
> between the two (this test assumes that word 'Linux' appears on the same
> line as the word 'GNU' or 'kernel' or a kernel version
> > gdb/gdbarch.h:740:/* The elfcore writer hook to use to write Linux
> prpsinfo notes to core
> >> gdb/gdbarch.h:741: comment: GNU/Linux: Do not use 'Linux', instead use
> 'Linux kernel' or 'GNU/Linux system'; comments should clearly
differentiate
> between the two (this test assumes that word 'Linux' appears on the same
> line as the word 'GNU' or 'kernel' or a kernel version
> > gdb/gdbarch.h:741: files. Most Linux architectures use the same
> prpsinfo32 or
> >> gdb/gdbarch.h:743: comment: GNU/Linux: Do not use 'Linux', instead use
> 'Linux kernel' or 'GNU/Linux system'; comments should clearly
differentiate
> between the two (this test assumes that word 'Linux' appears on the same
> line as the word 'GNU' or 'kernel' or a kernel version
> > gdb/gdbarch.h:743: call the Linux generic routines in bfd to write
> prpsinfo notes by
> > 556a562
>
> These were introduced by the PRPSINFO patches, but I don't agree with
> them (and don't see an elegant way to fix them). Is there any way to
> silent those warnings?
>
> --
> Sergio
^ permalink raw reply [flat|nested] 14+ messages in thread* [RFC] Remove ARI GNU/Linux rule (was: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt)
2013-02-06 9:59 ` Pierre Muller
@ 2013-02-06 10:04 ` Pierre Muller
2013-02-06 15:29 ` Joel Brobecker
2013-02-14 13:56 ` Joel Brobecker
[not found] ` <19773.0148713619$1360145095@news.gmane.org>
1 sibling, 2 replies; 14+ messages in thread
From: Pierre Muller @ 2013-02-06 10:04 UTC (permalink / raw)
To: 'Sergio Durigan Junior', gdb-patches
As announced in the previous email,
I would like to rediscuss the question
about removing the GNU/Linux rule.
Comments expected,
Pierre Muller
as ARI maintainer
2013-02-06 Pierre Muller <muller@sourceware.org>
* contrib/ari/gdb_ari.sh (GNU/Linux rule): Remove.
Index: contrib/ari/gdb_ari.sh
===================================================================
RCS file: /cvs/src/src/gdb/contrib/ari/gdb_ari.sh,v
retrieving revision 1.7
diff -u -p -r1.7 gdb_ari.sh
--- contrib/ari/gdb_ari.sh 1 Jan 2013 06:32:56 -0000 1.7
+++ contrib/ari/gdb_ari.sh 6 Feb 2013 10:01:03 -0000
@@ -257,21 +257,6 @@ BEGIN {
# Things in comments
-BEGIN { doc["GNU/Linux"] = "\
-Do not use `Linux'\'', instead use `Linux kernel'\'' or `GNU/Linux
system'\'';\
- comments should clearly differentiate between the two (this test assumes
that\
- word `Linux'\'' appears on the same line as the word `GNU'\'' or
`kernel'\''\
- or a kernel version"
- category["GNU/Linux"] = ari_comment
-}
-/(^|[^_[:alnum:]])Linux([^_[:alnum:]]|$)/ \
-&& !/(^|[^_[:alnum:]])Linux\[sic\]([^_[:alnum:]]|$)/ \
-&& !/(^|[^_[:alnum:]])GNU\/Linux([^_[:alnum:]]|$)/ \
-&& !/(^|[^_[:alnum:]])Linux kernel([^_[:alnum:]]|$)/ \
-&& !/(^|[^_[:alnum:]])Linux [[:digit:]]\.[[:digit:]]+)/ {
- fail("GNU/Linux")
-}
-
BEGIN { doc["ARGSUSED"] = "\
Do not use ARGSUSED, unnecessary"
category["ARGSUSED"] = ari_regression
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pierre Muller
> Envoyé : mercredi 6 février 2013 10:59
> À : 'Sergio Durigan Junior'; gdb-patches@sourceware.org
> Objet : RE: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D
2013-02-05-gmt
>
> This issue has been discussed partly
> already in the thread:
>
> http://sourceware.org/ml/gdb-patches/2009-04/msg00286.html
>
> But I don't think that we really reached the point
> to agree that we should simply completely remove this
> rule.
>
> I will resubmit the removal as a separate email
> to see if we can agree on it.
>
>
> Pierre
> as ARI maintainer
>
>
> > -----Message d'origine-----
> > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> > owner@sourceware.org] De la part de Sergio Durigan Junior
> > Envoyé : mercredi 6 février 2013 03:05
> > À : gdb-patches@sourceware.org
> > Objet : Re: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D
> 2013-02-05-gmt
> >
> > On Tuesday, February 05 2013, GDB Administrator wrote:
> >
> > >> gdb/gdbarch.h:740: comment: GNU/Linux: Do not use 'Linux', instead
use
> > 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> differentiate
> > between the two (this test assumes that word 'Linux' appears on the same
> > line as the word 'GNU' or 'kernel' or a kernel version
> > > gdb/gdbarch.h:740:/* The elfcore writer hook to use to write Linux
> > prpsinfo notes to core
> > >> gdb/gdbarch.h:741: comment: GNU/Linux: Do not use 'Linux', instead
use
> > 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> differentiate
> > between the two (this test assumes that word 'Linux' appears on the same
> > line as the word 'GNU' or 'kernel' or a kernel version
> > > gdb/gdbarch.h:741: files. Most Linux architectures use the same
> > prpsinfo32 or
> > >> gdb/gdbarch.h:743: comment: GNU/Linux: Do not use 'Linux', instead
use
> > 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> differentiate
> > between the two (this test assumes that word 'Linux' appears on the same
> > line as the word 'GNU' or 'kernel' or a kernel version
> > > gdb/gdbarch.h:743: call the Linux generic routines in bfd to write
> > prpsinfo notes by
> > > 556a562
> >
> > These were introduced by the PRPSINFO patches, but I don't agree with
> > them (and don't see an elegant way to fix them). Is there any way to
> > silent those warnings?
> >
> > --
> > Sergio
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [RFC] Remove ARI GNU/Linux rule (was: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt)
2013-02-06 10:04 ` [RFC] Remove ARI GNU/Linux rule (was: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt) Pierre Muller
@ 2013-02-06 15:29 ` Joel Brobecker
2013-02-14 13:56 ` Joel Brobecker
1 sibling, 0 replies; 14+ messages in thread
From: Joel Brobecker @ 2013-02-06 15:29 UTC (permalink / raw)
To: Pierre Muller; +Cc: 'Sergio Durigan Junior', gdb-patches
> As announced in the previous email,
> I would like to rediscuss the question
> about removing the GNU/Linux rule.
I cannot approve by myself, but I agree with removing the rule.
This rule has caused way to much work already, and I do not think
it helps anything.
> 2013-02-06 Pierre Muller <muller@sourceware.org>
>
> * contrib/ari/gdb_ari.sh (GNU/Linux rule): Remove.
>
> Index: contrib/ari/gdb_ari.sh
> ===================================================================
> RCS file: /cvs/src/src/gdb/contrib/ari/gdb_ari.sh,v
> retrieving revision 1.7
> diff -u -p -r1.7 gdb_ari.sh
> --- contrib/ari/gdb_ari.sh 1 Jan 2013 06:32:56 -0000 1.7
> +++ contrib/ari/gdb_ari.sh 6 Feb 2013 10:01:03 -0000
> @@ -257,21 +257,6 @@ BEGIN {
>
> # Things in comments
>
> -BEGIN { doc["GNU/Linux"] = "\
> -Do not use `Linux'\'', instead use `Linux kernel'\'' or `GNU/Linux
> system'\'';\
> - comments should clearly differentiate between the two (this test assumes
> that\
> - word `Linux'\'' appears on the same line as the word `GNU'\'' or
> `kernel'\''\
> - or a kernel version"
> - category["GNU/Linux"] = ari_comment
> -}
> -/(^|[^_[:alnum:]])Linux([^_[:alnum:]]|$)/ \
> -&& !/(^|[^_[:alnum:]])Linux\[sic\]([^_[:alnum:]]|$)/ \
> -&& !/(^|[^_[:alnum:]])GNU\/Linux([^_[:alnum:]]|$)/ \
> -&& !/(^|[^_[:alnum:]])Linux kernel([^_[:alnum:]]|$)/ \
> -&& !/(^|[^_[:alnum:]])Linux [[:digit:]]\.[[:digit:]]+)/ {
> - fail("GNU/Linux")
> -}
> -
> BEGIN { doc["ARGSUSED"] = "\
> Do not use ARGSUSED, unnecessary"
> category["ARGSUSED"] = ari_regression
>
>
> > -----Message d'origine-----
> > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> > owner@sourceware.org] De la part de Pierre Muller
> > Envoyé : mercredi 6 février 2013 10:59
> > ÃÂ : 'Sergio Durigan Junior'; gdb-patches@sourceware.org
> > Objet : RE: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D
> 2013-02-05-gmt
> >
> > This issue has been discussed partly
> > already in the thread:
> >
> > http://sourceware.org/ml/gdb-patches/2009-04/msg00286.html
> >
> > But I don't think that we really reached the point
> > to agree that we should simply completely remove this
> > rule.
> >
> > I will resubmit the removal as a separate email
> > to see if we can agree on it.
> >
> >
> > Pierre
> > as ARI maintainer
> >
> >
> > > -----Message d'origine-----
> > > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> > > owner@sourceware.org] De la part de Sergio Durigan Junior
> > > Envoyé : mercredi 6 février 2013 03:05
> > > ÃÂ : gdb-patches@sourceware.org
> > > Objet : Re: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D
> > 2013-02-05-gmt
> > >
> > > On Tuesday, February 05 2013, GDB Administrator wrote:
> > >
> > > >> gdb/gdbarch.h:740: comment: GNU/Linux: Do not use 'Linux', instead
> use
> > > 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> > differentiate
> > > between the two (this test assumes that word 'Linux' appears on the same
> > > line as the word 'GNU' or 'kernel' or a kernel version
> > > > gdb/gdbarch.h:740:/* The elfcore writer hook to use to write Linux
> > > prpsinfo notes to core
> > > >> gdb/gdbarch.h:741: comment: GNU/Linux: Do not use 'Linux', instead
> use
> > > 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> > differentiate
> > > between the two (this test assumes that word 'Linux' appears on the same
> > > line as the word 'GNU' or 'kernel' or a kernel version
> > > > gdb/gdbarch.h:741: files. Most Linux architectures use the same
> > > prpsinfo32 or
> > > >> gdb/gdbarch.h:743: comment: GNU/Linux: Do not use 'Linux', instead
> use
> > > 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> > differentiate
> > > between the two (this test assumes that word 'Linux' appears on the same
> > > line as the word 'GNU' or 'kernel' or a kernel version
> > > > gdb/gdbarch.h:743: call the Linux generic routines in bfd to write
> > > prpsinfo notes by
> > > > 556a562
> > >
> > > These were introduced by the PRPSINFO patches, but I don't agree with
> > > them (and don't see an elegant way to fix them). Is there any way to
> > > silent those warnings?
> > >
> > > --
> > > Sergio
>
--
Joel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [RFC] Remove ARI GNU/Linux rule (was: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt)
2013-02-06 10:04 ` [RFC] Remove ARI GNU/Linux rule (was: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt) Pierre Muller
2013-02-06 15:29 ` Joel Brobecker
@ 2013-02-14 13:56 ` Joel Brobecker
2013-02-14 21:09 ` Pierre Muller
1 sibling, 1 reply; 14+ messages in thread
From: Joel Brobecker @ 2013-02-14 13:56 UTC (permalink / raw)
To: Pierre Muller; +Cc: 'Sergio Durigan Junior', gdb-patches
> 2013-02-06 Pierre Muller <muller@sourceware.org>
>
> * contrib/ari/gdb_ari.sh (GNU/Linux rule): Remove.
Based on feedback from Mark, Tom, and myself, I think there is enough
support for me to approve. Please go ahead.
--
Joel
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [RFC] Remove ARI GNU/Linux rule (was: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt)
2013-02-14 13:56 ` Joel Brobecker
@ 2013-02-14 21:09 ` Pierre Muller
0 siblings, 0 replies; 14+ messages in thread
From: Pierre Muller @ 2013-02-14 21:09 UTC (permalink / raw)
To: 'Joel Brobecker'; +Cc: 'Sergio Durigan Junior', gdb-patches
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Joel Brobecker
> Envoyé : jeudi 14 février 2013 14:56
> À : Pierre Muller
> Cc : 'Sergio Durigan Junior'; gdb-patches@sourceware.org
> Objet : Re: [RFC] Remove ARI GNU/Linux rule (was: New ARI warning Tue Feb
5
> 02:01:10 UTC 2013 in -D 2013-02-05-gmt)
>
> > 2013-02-06 Pierre Muller <muller@sourceware.org>
> >
> > * contrib/ari/gdb_ari.sh (GNU/Linux rule): Remove.
>
> Based on feedback from Mark, Tom, and myself, I think there is enough
> support for me to approve. Please go ahead.
Thanks for the approval,
patch committed.
Pierre Muller
as ARI maintainer
^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <19773.0148713619$1360145095@news.gmane.org>]
[parent not found: <002001ce0450$9de57b00$d9b07100$%muller@ics-cnrs.unistra.fr>]
end of thread, other threads:[~2013-04-15 13:22 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-05 2:01 New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt GDB Administrator
2013-02-05 10:09 ` Pierre Muller
2013-02-14 9:44 ` [RFC/RFA] Remove ARI warning for set_gdbarch_write_pc use Pierre Muller
2013-04-15 17:33 ` Joel Brobecker
2013-02-06 2:05 ` New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt Sergio Durigan Junior
2013-02-06 9:59 ` Pierre Muller
2013-02-06 10:04 ` [RFC] Remove ARI GNU/Linux rule (was: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt) Pierre Muller
2013-02-06 15:29 ` Joel Brobecker
2013-02-14 13:56 ` Joel Brobecker
2013-02-14 21:09 ` Pierre Muller
[not found] ` <19773.0148713619$1360145095@news.gmane.org>
2013-02-06 16:08 ` [RFC] Remove ARI GNU/Linux rule Tom Tromey
[not found] ` <002001ce0450$9de57b00$d9b07100$%muller@ics-cnrs.unistra.fr>
[not found] ` <002301ce0451$4cbc6440$e6352cc0$%muller@ics-cnrs.unistra.fr>
2013-02-06 18:26 ` [RFC] Remove ARI GNU/Linux rule (was: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt) Eli Zaretskii
2013-02-06 19:19 ` Joel Brobecker
2013-02-06 19:39 ` Eli Zaretskii
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox