From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21305 invoked by alias); 6 Feb 2013 15:29:24 -0000 Received: (qmail 21294 invoked by uid 22791); 6 Feb 2013 15:29:24 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Feb 2013 15:29:17 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id CBC702E221; Wed, 6 Feb 2013 10:29:16 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id qGLN8m6ysxjt; Wed, 6 Feb 2013 10:29:16 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7E2B82E21D; Wed, 6 Feb 2013 10:29:16 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id BA9DEC7208; Wed, 6 Feb 2013 07:29:14 -0800 (PST) Date: Wed, 06 Feb 2013 15:29:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: 'Sergio Durigan Junior' , gdb-patches@sourceware.org Subject: Re: [RFC] Remove ARI GNU/Linux rule (was: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt) Message-ID: <20130206152914.GB1410@adacore.com> References: <20130205020110.GA5646@sourceware.org> <002001ce0450$9de57b00$d9b07100$@muller@ics-cnrs.unistra.fr> <002301ce0451$4cbc6440$e6352cc0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <002301ce0451$4cbc6440$e6352cc0$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00144.txt.bz2 > As announced in the previous email, > I would like to rediscuss the question > about removing the GNU/Linux rule. I cannot approve by myself, but I agree with removing the rule. This rule has caused way to much work already, and I do not think it helps anything. > 2013-02-06 Pierre Muller > > * contrib/ari/gdb_ari.sh (GNU/Linux rule): Remove. > > Index: contrib/ari/gdb_ari.sh > =================================================================== > RCS file: /cvs/src/src/gdb/contrib/ari/gdb_ari.sh,v > retrieving revision 1.7 > diff -u -p -r1.7 gdb_ari.sh > --- contrib/ari/gdb_ari.sh 1 Jan 2013 06:32:56 -0000 1.7 > +++ contrib/ari/gdb_ari.sh 6 Feb 2013 10:01:03 -0000 > @@ -257,21 +257,6 @@ BEGIN { > > # Things in comments > > -BEGIN { doc["GNU/Linux"] = "\ > -Do not use `Linux'\'', instead use `Linux kernel'\'' or `GNU/Linux > system'\'';\ > - comments should clearly differentiate between the two (this test assumes > that\ > - word `Linux'\'' appears on the same line as the word `GNU'\'' or > `kernel'\''\ > - or a kernel version" > - category["GNU/Linux"] = ari_comment > -} > -/(^|[^_[:alnum:]])Linux([^_[:alnum:]]|$)/ \ > -&& !/(^|[^_[:alnum:]])Linux\[sic\]([^_[:alnum:]]|$)/ \ > -&& !/(^|[^_[:alnum:]])GNU\/Linux([^_[:alnum:]]|$)/ \ > -&& !/(^|[^_[:alnum:]])Linux kernel([^_[:alnum:]]|$)/ \ > -&& !/(^|[^_[:alnum:]])Linux [[:digit:]]\.[[:digit:]]+)/ { > - fail("GNU/Linux") > -} > - > BEGIN { doc["ARGSUSED"] = "\ > Do not use ARGSUSED, unnecessary" > category["ARGSUSED"] = ari_regression > > > > -----Message d'origine----- > > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches- > > owner@sourceware.org] De la part de Pierre Muller > > Envoyé : mercredi 6 février 2013 10:59 > > À : 'Sergio Durigan Junior'; gdb-patches@sourceware.org > > Objet : RE: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D > 2013-02-05-gmt > > > > This issue has been discussed partly > > already in the thread: > > > > http://sourceware.org/ml/gdb-patches/2009-04/msg00286.html > > > > But I don't think that we really reached the point > > to agree that we should simply completely remove this > > rule. > > > > I will resubmit the removal as a separate email > > to see if we can agree on it. > > > > > > Pierre > > as ARI maintainer > > > > > > > -----Message d'origine----- > > > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches- > > > owner@sourceware.org] De la part de Sergio Durigan Junior > > > Envoyé : mercredi 6 février 2013 03:05 > > > À : gdb-patches@sourceware.org > > > Objet : Re: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D > > 2013-02-05-gmt > > > > > > On Tuesday, February 05 2013, GDB Administrator wrote: > > > > > > >> gdb/gdbarch.h:740: comment: GNU/Linux: Do not use 'Linux', instead > use > > > 'Linux kernel' or 'GNU/Linux system'; comments should clearly > > differentiate > > > between the two (this test assumes that word 'Linux' appears on the same > > > line as the word 'GNU' or 'kernel' or a kernel version > > > > gdb/gdbarch.h:740:/* The elfcore writer hook to use to write Linux > > > prpsinfo notes to core > > > >> gdb/gdbarch.h:741: comment: GNU/Linux: Do not use 'Linux', instead > use > > > 'Linux kernel' or 'GNU/Linux system'; comments should clearly > > differentiate > > > between the two (this test assumes that word 'Linux' appears on the same > > > line as the word 'GNU' or 'kernel' or a kernel version > > > > gdb/gdbarch.h:741: files. Most Linux architectures use the same > > > prpsinfo32 or > > > >> gdb/gdbarch.h:743: comment: GNU/Linux: Do not use 'Linux', instead > use > > > 'Linux kernel' or 'GNU/Linux system'; comments should clearly > > differentiate > > > between the two (this test assumes that word 'Linux' appears on the same > > > line as the word 'GNU' or 'kernel' or a kernel version > > > > gdb/gdbarch.h:743: call the Linux generic routines in bfd to write > > > prpsinfo notes by > > > > 556a562 > > > > > > These were introduced by the PRPSINFO patches, but I don't agree with > > > them (and don't see an elegant way to fix them). Is there any way to > > > silent those warnings? > > > > > > -- > > > Sergio > -- Joel