Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Sergio Durigan Junior'" <sergiodj@redhat.com>,
	       <gdb-patches@sourceware.org>
Subject: [RFC] Remove ARI GNU/Linux rule (was: New ARI warning Tue Feb  5 02:01:10 UTC 2013 in -D 2013-02-05-gmt)
Date: Wed, 06 Feb 2013 10:04:00 -0000	[thread overview]
Message-ID: <002301ce0451$4cbc6440$e6352cc0$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <002001ce0450$9de57b00$d9b07100$@muller@ics-cnrs.unistra.fr>

  As announced in the previous email,
I would like to rediscuss the question 
about removing the GNU/Linux rule.


Comments expected,

Pierre Muller
as ARI maintainer



2013-02-06  Pierre Muller  <muller@sourceware.org>

        * contrib/ari/gdb_ari.sh (GNU/Linux rule): Remove.

Index: contrib/ari/gdb_ari.sh
===================================================================
RCS file: /cvs/src/src/gdb/contrib/ari/gdb_ari.sh,v
retrieving revision 1.7
diff -u -p -r1.7 gdb_ari.sh
--- contrib/ari/gdb_ari.sh      1 Jan 2013 06:32:56 -0000       1.7
+++ contrib/ari/gdb_ari.sh      6 Feb 2013 10:01:03 -0000
@@ -257,21 +257,6 @@ BEGIN {

 # Things in comments

-BEGIN { doc["GNU/Linux"] = "\
-Do not use `Linux'\'', instead use `Linux kernel'\'' or `GNU/Linux
system'\'';\
- comments should clearly differentiate between the two (this test assumes
that\
- word `Linux'\'' appears on the same line as the word `GNU'\'' or
`kernel'\''\
- or a kernel version"
-    category["GNU/Linux"] = ari_comment
-}
-/(^|[^_[:alnum:]])Linux([^_[:alnum:]]|$)/ \
-&& !/(^|[^_[:alnum:]])Linux\[sic\]([^_[:alnum:]]|$)/ \
-&& !/(^|[^_[:alnum:]])GNU\/Linux([^_[:alnum:]]|$)/ \
-&& !/(^|[^_[:alnum:]])Linux kernel([^_[:alnum:]]|$)/ \
-&& !/(^|[^_[:alnum:]])Linux [[:digit:]]\.[[:digit:]]+)/ {
-    fail("GNU/Linux")
-}
-
 BEGIN { doc["ARGSUSED"] = "\
 Do not use ARGSUSED, unnecessary"
     category["ARGSUSED"] = ari_regression


> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pierre Muller
> Envoyé : mercredi 6 février 2013 10:59
> À : 'Sergio Durigan Junior'; gdb-patches@sourceware.org
> Objet : RE: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D
2013-02-05-gmt
> 
>   This issue has been discussed partly
> already in the thread:
> 
> http://sourceware.org/ml/gdb-patches/2009-04/msg00286.html
> 
> But I don't think that we really reached the point
> to agree that we should simply completely remove this
> rule.
> 
>   I will resubmit the removal as a separate email
> to see if we can agree on it.
> 
> 
> Pierre
> as ARI maintainer
> 
> 
> > -----Message d'origine-----
> > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> > owner@sourceware.org] De la part de Sergio Durigan Junior
> > Envoyé : mercredi 6 février 2013 03:05
> > À : gdb-patches@sourceware.org
> > Objet : Re: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D
> 2013-02-05-gmt
> >
> > On Tuesday, February 05 2013, GDB Administrator wrote:
> >
> > >> gdb/gdbarch.h:740: comment: GNU/Linux: Do not use 'Linux', instead
use
> > 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> differentiate
> > between the two (this test assumes that word 'Linux' appears on the same
> > line as the word 'GNU' or 'kernel' or a kernel version
> > > gdb/gdbarch.h:740:/* The elfcore writer hook to use to write Linux
> > prpsinfo notes to core
> > >> gdb/gdbarch.h:741: comment: GNU/Linux: Do not use 'Linux', instead
use
> > 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> differentiate
> > between the two (this test assumes that word 'Linux' appears on the same
> > line as the word 'GNU' or 'kernel' or a kernel version
> > > gdb/gdbarch.h:741:   files.  Most Linux architectures use the same
> > prpsinfo32 or
> > >> gdb/gdbarch.h:743: comment: GNU/Linux: Do not use 'Linux', instead
use
> > 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> differentiate
> > between the two (this test assumes that word 'Linux' appears on the same
> > line as the word 'GNU' or 'kernel' or a kernel version
> > > gdb/gdbarch.h:743:   call the Linux generic routines in bfd to write
> > prpsinfo notes by
> > > 556a562
> >
> > These were introduced by the PRPSINFO patches, but I don't agree with
> > them (and don't see an elegant way to fix them).  Is there any way to
> > silent those warnings?
> >
> > --
> > Sergio



  reply	other threads:[~2013-02-06 10:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-05  2:01 New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt GDB Administrator
2013-02-05 10:09 ` Pierre Muller
2013-02-14  9:44   ` [RFC/RFA] Remove ARI warning for set_gdbarch_write_pc use Pierre Muller
2013-04-15 17:33     ` Joel Brobecker
2013-02-06  2:05 ` New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt Sergio Durigan Junior
2013-02-06  9:59   ` Pierre Muller
2013-02-06 10:04     ` Pierre Muller [this message]
2013-02-06 15:29       ` [RFC] Remove ARI GNU/Linux rule (was: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt) Joel Brobecker
2013-02-14 13:56       ` Joel Brobecker
2013-02-14 21:09         ` Pierre Muller
     [not found]     ` <19773.0148713619$1360145095@news.gmane.org>
2013-02-06 16:08       ` [RFC] Remove ARI GNU/Linux rule Tom Tromey
     [not found]   ` <002001ce0450$9de57b00$d9b07100$%muller@ics-cnrs.unistra.fr>
     [not found]     ` <002301ce0451$4cbc6440$e6352cc0$%muller@ics-cnrs.unistra.fr>
2013-02-06 18:26       ` [RFC] Remove ARI GNU/Linux rule (was: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt) Eli Zaretskii
2013-02-06 19:19         ` Joel Brobecker
2013-02-06 19:39           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002301ce0451$4cbc6440$e6352cc0$@muller@ics-cnrs.unistra.fr' \
    --to=pierre.muller@ics-cnrs.unistra.fr \
    --cc=gdb-patches@sourceware.org \
    --cc=sergiodj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox