From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24187 invoked by alias); 14 Feb 2013 09:44:46 -0000 Received: (qmail 24178 invoked by uid 22791); 14 Feb 2013 09:44:45 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.156) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Feb 2013 09:44:39 +0000 Received: from md13.u-strasbg.fr (md13.u-strasbg.fr [130.79.200.248]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r1E9ibBM066368 for ; Thu, 14 Feb 2013 10:44:37 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms18.u-strasbg.fr [130.79.204.118]) by md13.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r1E9iaLp006664 for ; Thu, 14 Feb 2013 10:44:36 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r1E9iZEO003453 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Thu, 14 Feb 2013 10:44:36 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: References: <20130205020110.GA5646@sourceware.org> <001e01ce0388$e41155e0$ac3401a0$@muller@ics-cnrs.unistra.fr> In-Reply-To: <001e01ce0388$e41155e0$ac3401a0$@muller@ics-cnrs.unistra.fr> Subject: [RFC/RFA] Remove ARI warning for set_gdbarch_write_pc use Date: Thu, 14 Feb 2013 09:44:00 -0000 Message-ID: <000001ce0a97$e671cc00$b3556400$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00339.txt.bz2 I realized that the global maintainers might not have=20 seen this message, which is really=20 a request for comments or approval. Pierre Muller as ARI maintainer > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Pierre Muller > Envoy=E9=A0: mardi 5 f=E9vrier 2013 11:10 > =C0=A0: gdb-patches@sourceware.org > Objet=A0: RE: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt >=20 > Hi all, >=20 > As ARI maintainer, > I was wondering if the fact that > set_gdbarch_write_pc is treated as write_pc > inside the ARI script is really correct: >=20 > I was always considering that gdbarch specific method are > the right way to do things correctly in multi-target GDB. >=20 > Why is then set_gdbarch_write_pc also considered as deprecated? >=20 > If it should not be, the change below would take care of this: >=20 > Pierre Muller > as ARI maintainer. >=20 >=20 > 2013-02-05 Pierre Muller >=20 > * contrib/ari/gdb_ari.sh (write_pc rule): Do not consider > set_gdbarch_write_pc as deprecated anymore. >=20 > Index: gdb_ari.sh > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvs/src/src/gdb/contrib/ari/gdb_ari.sh,v > retrieving revision 1.7 > diff -u -p -r1.7 gdb_ari.sh > --- gdb_ari.sh 1 Jan 2013 06:32:56 -0000 1.7 > +++ gdb_ari.sh 5 Feb 2013 10:06:14 -0000 > @@ -1051,7 +1051,6 @@ a DECR_PC_AFTER_BREAK" > category["write_pc"] =3D ari_deprecate > } > /(^|[^_[:alnum:]])write_pc[[:space:]]*\(/ || \ > -/(^|[^_[:alnum:]])set_gdbarch_write_pc[[:space:]]*\(/ || \ > /(^|[^_[:alnum:]])TARGET_WRITE_PC[[:space:]]*\(/ { > fail("write_pc") > } >=20 > > > gdb/aarch64-tdep.c:2619: deprecate: write_pc: Replace write_pc() with > > get_frame_base_address or get_frame_id; at present the inferior function > > call code still uses this when doing a DECR_PC_AFTER_BREAK > > gdb/aarch64-tdep.c:2619: set_gdbarch_write_pc (gdbarch, > aarch64_write_pc); > > gdb/aarch64-tdep.c:2619: set_gdbarch_write_pc (gdbarch, > aarch64_write_pc); > > 274a277,279 > > > gdb/gdbarch.h:740: comment: GNU/Linux: Do not use 'Linux', instead use > > 'Linux kernel' or 'GNU/Linux system'; comments should clearly > differentiate > > between the two (this test assumes that word 'Linux' appears on the same > > line as the word 'GNU' or 'kernel' or a kernel version > > gdb/gdbarch.h:740:/* The elfcore writer hook to use to write Linux > prpsinfo > > notes to core > > > gdb/gdbarch.h:741: comment: GNU/Linux: Do not use 'Linux', instead use > > 'Linux kernel' or 'GNU/Linux system'; comments should clearly > differentiate > > between the two (this test assumes that word 'Linux' appears on the same > > line as the word 'GNU' or 'kernel' or a kernel version > > gdb/gdbarch.h:741: files. Most Linux architectures use the same > > prpsinfo32 or > > > gdb/gdbarch.h:743: comment: GNU/Linux: Do not use 'Linux', instead use > > 'Linux kernel' or 'GNU/Linux system'; comments should clearly > differentiate > > between the two (this test assumes that word 'Linux' appears on the same > > line as the word 'GNU' or 'kernel' or a kernel version > > gdb/gdbarch.h:743: call the Linux generic routines in bfd to write > > prpsinfo notes by > > 556a562 > > > gdb/ppc-linux-tdep.c:1451: comment: GNU/Linux: Do not use 'Linux', > instead > > use 'Linux kernel' or 'GNU/Linux system'; comments should clearly > > differentiate between the two (this test assumes that word 'Linux' appears > > on the same line as the word 'GNU' or 'kernel' or a kernel version > > gdb/ppc-linux-tdep.c:1451: /* Initialize the Linux target descriptions. > */