From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9055 invoked by alias); 5 Feb 2013 10:09:50 -0000 Received: (qmail 8968 invoked by uid 22791); 5 Feb 2013 10:09:48 -0000 X-SWARE-Spam-Status: No, hits=-0.8 required=5.0 tests=AWL,BAYES_40,KHOP_THREADED,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.158) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Feb 2013 10:09:39 +0000 Received: from md15.u-strasbg.fr (md15.u-strasbg.fr [130.79.200.204]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r15A9XlV056485 for ; Tue, 5 Feb 2013 11:09:33 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms15.u-strasbg.fr [130.79.204.115]) by md15.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r15A9UDs020669 for ; Tue, 5 Feb 2013 11:09:30 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r15A9TYe021829 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Tue, 5 Feb 2013 11:09:30 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: References: <20130205020110.GA5646@sourceware.org> In-Reply-To: <20130205020110.GA5646@sourceware.org> Subject: RE: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt Date: Tue, 05 Feb 2013 10:09:00 -0000 Message-ID: <001e01ce0388$e41155e0$ac3401a0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00111.txt.bz2 Hi all, As ARI maintainer, I was wondering if the fact that set_gdbarch_write_pc is treated as write_pc inside the ARI script is really correct: I was always considering that gdbarch specific method are the right way to do things correctly in multi-target GDB. Why is then set_gdbarch_write_pc also considered as deprecated? If it should not be, the change below would take care of this: Pierre Muller as ARI maintainer. 2013-02-05 Pierre Muller * contrib/ari/gdb_ari.sh (write_pc rule): Do not consider set_gdbarch_write_pc as deprecated anymore. Index: gdb_ari.sh =================================================================== RCS file: /cvs/src/src/gdb/contrib/ari/gdb_ari.sh,v retrieving revision 1.7 diff -u -p -r1.7 gdb_ari.sh --- gdb_ari.sh 1 Jan 2013 06:32:56 -0000 1.7 +++ gdb_ari.sh 5 Feb 2013 10:06:14 -0000 @@ -1051,7 +1051,6 @@ a DECR_PC_AFTER_BREAK" category["write_pc"] = ari_deprecate } /(^|[^_[:alnum:]])write_pc[[:space:]]*\(/ || \ -/(^|[^_[:alnum:]])set_gdbarch_write_pc[[:space:]]*\(/ || \ /(^|[^_[:alnum:]])TARGET_WRITE_PC[[:space:]]*\(/ { fail("write_pc") } > > gdb/aarch64-tdep.c:2619: deprecate: write_pc: Replace write_pc() with > get_frame_base_address or get_frame_id; at present the inferior function > call code still uses this when doing a DECR_PC_AFTER_BREAK > gdb/aarch64-tdep.c:2619: set_gdbarch_write_pc (gdbarch, aarch64_write_pc); > gdb/aarch64-tdep.c:2619: set_gdbarch_write_pc (gdbarch, aarch64_write_pc); > 274a277,279 > > gdb/gdbarch.h:740: comment: GNU/Linux: Do not use 'Linux', instead use > 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate > between the two (this test assumes that word 'Linux' appears on the same > line as the word 'GNU' or 'kernel' or a kernel version > gdb/gdbarch.h:740:/* The elfcore writer hook to use to write Linux prpsinfo > notes to core > > gdb/gdbarch.h:741: comment: GNU/Linux: Do not use 'Linux', instead use > 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate > between the two (this test assumes that word 'Linux' appears on the same > line as the word 'GNU' or 'kernel' or a kernel version > gdb/gdbarch.h:741: files. Most Linux architectures use the same > prpsinfo32 or > > gdb/gdbarch.h:743: comment: GNU/Linux: Do not use 'Linux', instead use > 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate > between the two (this test assumes that word 'Linux' appears on the same > line as the word 'GNU' or 'kernel' or a kernel version > gdb/gdbarch.h:743: call the Linux generic routines in bfd to write > prpsinfo notes by > 556a562 > > gdb/ppc-linux-tdep.c:1451: comment: GNU/Linux: Do not use 'Linux', instead > use 'Linux kernel' or 'GNU/Linux system'; comments should clearly > differentiate between the two (this test assumes that word 'Linux' appears > on the same line as the word 'GNU' or 'kernel' or a kernel version > gdb/ppc-linux-tdep.c:1451: /* Initialize the Linux target descriptions. */