* [PATCH] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA
@ 2025-09-09 7:16 Gopi Kumar Bulusu
2025-09-09 11:56 ` Michael Eager
2025-09-09 15:31 ` Simon Marchi
0 siblings, 2 replies; 15+ messages in thread
From: Gopi Kumar Bulusu @ 2025-09-09 7:16 UTC (permalink / raw)
To: gdb-patches; +Cc: Michael Eager
[-- Attachment #1.1: Type: text/plain, Size: 537 bytes --]
namaskaaram,
The macro MICROBLAZE_BREAKPOINT is set to an instruction opcode that does
not meet the criteria for software breakpoint instruction as set forth in
the AMD MicroBlaze ISA. This patch addresses the problem.
This simple patch concludes a series of patches that add AMD MicroBlaze
gdbserver target support for GNU/Linux.
Updated NEWS to include MicroBlaze gdbserver target.
Build/Test - tested by building microblazeel-linux-gdb and verifying that
software breakpoint works
using gdbserver as target.
dhanyavaadaaha
gopi
[-- Attachment #1.2: Type: text/html, Size: 910 bytes --]
[-- Attachment #2: 0001-MicroBlaze-Update-software-breakpoint-machine-code-a.patch --]
[-- Type: text/x-patch, Size: 1665 bytes --]
From a85980e98bf614fe7de60ddc8479d24f65009572 Mon Sep 17 00:00:00 2001
From: Gopi Kumar Bulusu <gopi@sankhya.com>
Date: Tue, 9 Sep 2025 12:00:11 +0530
Subject: [PATCH] MicroBlaze: Update software breakpoint machine code as per
MicroBlaze ISA
This patch updates breakpoint instruction machine code to be inline
with the specification in MicroBlaze ISA [1]
* gdb/microblaze-tdep.h : Update MICROBLAZE_BREAKPOINT
* gdb/NEWS : Add MicroBlaze gdbserver target
[1] https://docs.amd.com/r/en-US/ug984-vivado-microblaze-ref/brki
Signed-off-by: David Holsgrove <david.holsgrove@petalogix.com>
Signed-off-by: Nathan Rossi <nathan.rossi@petalogix.com>
Signed-off-by: Mahesh Bodapati <mbodapat@xilinx.com>
Signed-off-by: Gopi Kumar Bulusu <gopi@sankhya.com>
---
gdb/NEWS | 4 ++++
gdb/microblaze-tdep.h | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/gdb/NEWS b/gdb/NEWS
index 48f7bfabea7..36065ec1943 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -3,6 +3,10 @@
*** Changes since GDB 17
+* New targets
+
+GNU/Linux/MicroBlaze (gdbserver) microblazeel-*linux*
+
*** Changes in GDB 17
* Debugging Linux programs that use x86-64 or x86-64 with 32-bit pointer
diff --git a/gdb/microblaze-tdep.h b/gdb/microblaze-tdep.h
index b2fb5e7fcb9..852c9ebbafe 100644
--- a/gdb/microblaze-tdep.h
+++ b/gdb/microblaze-tdep.h
@@ -118,6 +118,6 @@ struct microblaze_frame_cache
/* MICROBLAZE_BREAKPOINT defines the breakpoint that should be used.
Only used for native debugging. */
-#define MICROBLAZE_BREAKPOINT {0xb9, 0xcc, 0x00, 0x60}
+#define MICROBLAZE_BREAKPOINT {0xba, 0x0c, 0x00, 0x18}
#endif /* GDB_MICROBLAZE_TDEP_H */
--
2.47.1
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA
2025-09-09 7:16 [PATCH] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA Gopi Kumar Bulusu
@ 2025-09-09 11:56 ` Michael Eager
2025-09-09 12:23 ` Gopi Kumar Bulusu
2025-09-09 15:31 ` Simon Marchi
1 sibling, 1 reply; 15+ messages in thread
From: Michael Eager @ 2025-09-09 11:56 UTC (permalink / raw)
To: Gopi Kumar Bulusu, gdb-patches
On 9/9/25 12:16 AM, Gopi Kumar Bulusu wrote:
> namaskaaram,
> The macro MICROBLAZE_BREAKPOINT is set to an instruction opcode that
> does not meet the criteria for software breakpoint instruction as set
> forth in the AMD MicroBlaze ISA. This patch addresses the problem.
>
> This simple patch concludes a series of patches that add AMD MicroBlaze
> gdbserver target support for GNU/Linux.
>
> Updated NEWS to include MicroBlaze gdbserver target.
>
> Build/Test - tested by building microblazeel-linux-gdb and verifying
> that software breakpoint works
> using gdbserver as target.
Has this patch been tested with bare metal targets?
--
Michael Eager
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA
2025-09-09 11:56 ` Michael Eager
@ 2025-09-09 12:23 ` Gopi Kumar Bulusu
2025-09-09 13:35 ` Michael Eager
0 siblings, 1 reply; 15+ messages in thread
From: Gopi Kumar Bulusu @ 2025-09-09 12:23 UTC (permalink / raw)
To: Michael Eager; +Cc: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 1450 bytes --]
namaskaaram
On Tue, Sep 9, 2025 at 5:26 PM Michael Eager <eager@eagercon.com> wrote:
> On 9/9/25 12:16 AM, Gopi Kumar Bulusu wrote:
> > namaskaaram,
> > The macro MICROBLAZE_BREAKPOINT is set to an instruction opcode that
> > does not meet the criteria for software breakpoint instruction as set
> > forth in the AMD MicroBlaze ISA. This patch addresses the problem.
> >
> > This simple patch concludes a series of patches that add AMD MicroBlaze
> > gdbserver target support for GNU/Linux.
> >
> > Updated NEWS to include MicroBlaze gdbserver target.
> >
> > Build/Test - tested by building microblazeel-linux-gdb and verifying
> > that software breakpoint works
> > using gdbserver as target.
>
>
> Has this patch been tested with bare metal targets?
>
>
1. Yes, This patch has been part of the AMD/Xilinx git sources (Yocto
builds) for many many years. Breakpoints
work with bare metal (qemu). From what I understand - the bare-metal case
when using QEMU does not use a
software breakpoint.
2. No, I have not checked Baremetal - real target, but when using BDM/JTAG
this may not matter. However I don't see
currently JTAG supported from gdb for MicroBlaze (does it ?).
3. I also don't see any indication that gdb for MicroBlaze includes support
for a remote debug monitor for bare metal targets
that may use software breakpoint.
Approved ?
dhanyavaadaaha
gopi
> --
> Michael Eager
>
>
[-- Attachment #2: Type: text/html, Size: 2214 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA
2025-09-09 12:23 ` Gopi Kumar Bulusu
@ 2025-09-09 13:35 ` Michael Eager
0 siblings, 0 replies; 15+ messages in thread
From: Michael Eager @ 2025-09-09 13:35 UTC (permalink / raw)
To: Gopi Kumar Bulusu; +Cc: gdb-patches
On 9/9/25 5:23 AM, Gopi Kumar Bulusu wrote:
> namaskaaram
>
> On Tue, Sep 9, 2025 at 5:26 PM Michael Eager <eager@eagercon.com
> <mailto:eager@eagercon.com>> wrote:
>
> On 9/9/25 12:16 AM, Gopi Kumar Bulusu wrote:
> > namaskaaram,
> > The macro MICROBLAZE_BREAKPOINT is set to an instruction opcode that
> > does not meet the criteria for software breakpoint instruction as
> set
> > forth in the AMD MicroBlaze ISA. This patch addresses the problem.
> >
> > This simple patch concludes a series of patches that add AMD
> MicroBlaze
> > gdbserver target support for GNU/Linux.
> >
> > Updated NEWS to include MicroBlaze gdbserver target.
> >
> > Build/Test - tested by building microblazeel-linux-gdb and verifying
> > that software breakpoint works
> > using gdbserver as target.
>
>
> Has this patch been tested with bare metal targets?
>
>
> 1. Yes, This patch has been part of the AMD/Xilinx git sources (Yocto
> builds) for many many years. Breakpoints
> work with bare metal (qemu). From what I understand - the bare-metal
> case when using QEMU does not use a
> software breakpoint.
>
> 2. No, I have not checked Baremetal - real target, but when using BDM/
> JTAG this may not matter. However I don't see
> currently JTAG supported from gdb for MicroBlaze (does it ?).
>
> 3. I also don't see any indication that gdb for MicroBlaze includes
> support for a remote debug monitor for bare metal targets
> that may use software breakpoint.
>
> Approved ?
Please apply.
--
Michael Eager
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA
2025-09-09 7:16 [PATCH] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA Gopi Kumar Bulusu
2025-09-09 11:56 ` Michael Eager
@ 2025-09-09 15:31 ` Simon Marchi
2025-09-09 15:34 ` Simon Marchi
2025-09-09 15:34 ` [PATCH] " Michael Eager
1 sibling, 2 replies; 15+ messages in thread
From: Simon Marchi @ 2025-09-09 15:31 UTC (permalink / raw)
To: Gopi Kumar Bulusu, gdb-patches; +Cc: Michael Eager
On 9/9/25 3:16 AM, Gopi Kumar Bulusu wrote:
> namaskaaram,
>
> The macro MICROBLAZE_BREAKPOINT is set to an instruction opcode that does not meet the criteria for software breakpoint instruction as set forth in the AMD MicroBlaze ISA. This patch addresses the problem.
>
> This simple patch concludes a series of patches that add AMD MicroBlaze gdbserver target support for GNU/Linux.
>
> Updated NEWS to include MicroBlaze gdbserver target.
>
> Build/Test - tested by building microblazeel-linux-gdb and verifying that software breakpoint works
> using gdbserver as target.
>
> dhanyavaadaaha
> gopi
>
Can you explain how the NEWS entry you add relates to the code change?
Simon
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA
2025-09-09 15:31 ` Simon Marchi
@ 2025-09-09 15:34 ` Simon Marchi
2025-09-09 16:05 ` Gopi Kumar Bulusu
2025-09-09 15:34 ` [PATCH] " Michael Eager
1 sibling, 1 reply; 15+ messages in thread
From: Simon Marchi @ 2025-09-09 15:34 UTC (permalink / raw)
To: Gopi Kumar Bulusu, gdb-patches; +Cc: Michael Eager
On 9/9/25 11:31 AM, Simon Marchi wrote:
> On 9/9/25 3:16 AM, Gopi Kumar Bulusu wrote:
>> namaskaaram,
>>
>> The macro MICROBLAZE_BREAKPOINT is set to an instruction opcode that does not meet the criteria for software breakpoint instruction as set forth in the AMD MicroBlaze ISA. This patch addresses the problem.
>>
>> This simple patch concludes a series of patches that add AMD MicroBlaze gdbserver target support for GNU/Linux.
>>
>> Updated NEWS to include MicroBlaze gdbserver target.
>>
>> Build/Test - tested by building microblazeel-linux-gdb and verifying that software breakpoint works
>> using gdbserver as target.
>>
>> dhanyavaadaaha
>> gopi
>>
>
> Can you explain how the NEWS entry you add relates to the code change?
>
> Simon
It sounds like it is related to this patch, merged back in March:
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f
If so, then the NEWS entry should be in the "Changes in GDB 17" section,
and cherry-picked to the gdb-17-branch branch (and it should not be added
in this particular patch).
Simon
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA
2025-09-09 15:34 ` Simon Marchi
@ 2025-09-09 16:05 ` Gopi Kumar Bulusu
2025-09-09 16:22 ` Simon Marchi
2025-09-09 16:29 ` Michael Eager
0 siblings, 2 replies; 15+ messages in thread
From: Gopi Kumar Bulusu @ 2025-09-09 16:05 UTC (permalink / raw)
To: Simon Marchi; +Cc: gdb-patches, Michael Eager
[-- Attachment #1: Type: text/plain, Size: 1613 bytes --]
On Tue, Sep 9, 2025, 9:04 PM Simon Marchi <simark@simark.ca> wrote:
> On 9/9/25 11:31 AM, Simon Marchi wrote:
> > On 9/9/25 3:16 AM, Gopi Kumar Bulusu wrote:
> >> namaskaaram,
> >>
> >> The macro MICROBLAZE_BREAKPOINT is set to an instruction opcode that
> does not meet the criteria for software breakpoint instruction as set forth
> in the AMD MicroBlaze ISA. This patch addresses the problem.
> >>
> >> This simple patch concludes a series of patches that add AMD MicroBlaze
> gdbserver target support for GNU/Linux.
> >>
> >> Updated NEWS to include MicroBlaze gdbserver target.
> >>
> >> Build/Test - tested by building microblazeel-linux-gdb and verifying
> that software breakpoint works
> >> using gdbserver as target.
> >>
> >> dhanyavaadaaha
> >> gopi
> >>
> >
> > Can you explain how the NEWS entry you add relates to the code change?
> >
> > Simon
>
> It sounds like it is related to this patch, merged back in March:
>
>
> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f
>
> If so, then the NEWS entry should be in the "Changes in GDB 17" section,
> and cherry-picked to the gdb-17-branch branch (and it should not be added
> in this particular patch).
>
All the patches in a series of changes ( bfd, gdb, gdbserver) are needed
for breakpoint to work from gdb for gdbserver target.
After a discussion at the beginning of this work (over a year ago) - I
followed the path of submitting patches as smaller logical units.
I can merge the last 2 (including this) MicroBlaze patches to the
gdb-17 branch as well.
dhanyavaadaaha
gopi
Simon
>
[-- Attachment #2: Type: text/html, Size: 2651 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA
2025-09-09 16:05 ` Gopi Kumar Bulusu
@ 2025-09-09 16:22 ` Simon Marchi
2025-09-09 16:39 ` Gopi Kumar Bulusu
2025-09-09 16:29 ` Michael Eager
1 sibling, 1 reply; 15+ messages in thread
From: Simon Marchi @ 2025-09-09 16:22 UTC (permalink / raw)
To: Gopi Kumar Bulusu; +Cc: gdb-patches, Michael Eager
On 9/9/25 12:05 PM, Gopi Kumar Bulusu wrote:
>
>
> On Tue, Sep 9, 2025, 9:04 PM Simon Marchi <simark@simark.ca <mailto:simark@simark.ca>> wrote:
>
> On 9/9/25 11:31 AM, Simon Marchi wrote:
> > On 9/9/25 3:16 AM, Gopi Kumar Bulusu wrote:
> >> namaskaaram,
> >>
> >> The macro MICROBLAZE_BREAKPOINT is set to an instruction opcode that does not meet the criteria for software breakpoint instruction as set forth in the AMD MicroBlaze ISA. This patch addresses the problem.
> >>
> >> This simple patch concludes a series of patches that add AMD MicroBlaze gdbserver target support for GNU/Linux.
> >>
> >> Updated NEWS to include MicroBlaze gdbserver target.
> >>
> >> Build/Test - tested by building microblazeel-linux-gdb and verifying that software breakpoint works
> >> using gdbserver as target.
> >>
> >> dhanyavaadaaha
> >> gopi
> >>
> >
> > Can you explain how the NEWS entry you add relates to the code change?
> >
> > Simon
>
> It sounds like it is related to this patch, merged back in March:
>
> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f <https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f>
>
> If so, then the NEWS entry should be in the "Changes in GDB 17" section,
> and cherry-picked to the gdb-17-branch branch (and it should not be added
> in this particular patch).
>
>
> All the patches in a series of changes ( bfd, gdb, gdbserver) are needed for breakpoint to work from gdb for gdbserver target.
>
> After a discussion at the beginning of this work (over a year ago) - I followed the path of submitting patches as smaller logical units.
>
> I can merge the last 2 (including this) MicroBlaze patches to the gdb-17 branch as well.
I'd be fine having this patch that changes the breakpoint instruction in
the gdb-17-branch. What is the other one?
Simon
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA
2025-09-09 16:22 ` Simon Marchi
@ 2025-09-09 16:39 ` Gopi Kumar Bulusu
0 siblings, 0 replies; 15+ messages in thread
From: Gopi Kumar Bulusu @ 2025-09-09 16:39 UTC (permalink / raw)
To: Simon Marchi; +Cc: gdb-patches, Michael Eager
[-- Attachment #1: Type: text/plain, Size: 2260 bytes --]
On Tue, Sep 9, 2025, 9:52 PM Simon Marchi <simark@simark.ca> wrote:
> On 9/9/25 12:05 PM, Gopi Kumar Bulusu wrote:
> >
> >
> > On Tue, Sep 9, 2025, 9:04 PM Simon Marchi <simark@simark.ca <mailto:
> simark@simark.ca>> wrote:
> >
> > On 9/9/25 11:31 AM, Simon Marchi wrote:
> > > On 9/9/25 3:16 AM, Gopi Kumar Bulusu wrote:
> > >> namaskaaram,
> > >>
> > >> The macro MICROBLAZE_BREAKPOINT is set to an instruction opcode
> that does not meet the criteria for software breakpoint instruction as set
> forth in the AMD MicroBlaze ISA. This patch addresses the problem.
> > >>
> > >> This simple patch concludes a series of patches that add AMD
> MicroBlaze gdbserver target support for GNU/Linux.
> > >>
> > >> Updated NEWS to include MicroBlaze gdbserver target.
> > >>
> > >> Build/Test - tested by building microblazeel-linux-gdb and
> verifying that software breakpoint works
> > >> using gdbserver as target.
> > >>
> > >> dhanyavaadaaha
> > >> gopi
> > >>
> > >
> > > Can you explain how the NEWS entry you add relates to the code
> change?
> > >
> > > Simon
> >
> > It sounds like it is related to this patch, merged back in March:
> >
> >
> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f
> <
> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f
> >
> >
> > If so, then the NEWS entry should be in the "Changes in GDB 17"
> section,
> > and cherry-picked to the gdb-17-branch branch (and it should not be
> added
> > in this particular patch).
> >
> >
> > All the patches in a series of changes ( bfd, gdb, gdbserver) are needed
> for breakpoint to work from gdb for gdbserver target.
> >
> > After a discussion at the beginning of this work (over a year ago) - I
> followed the path of submitting patches as smaller logical units.
> >
> > I can merge the last 2 (including this) MicroBlaze patches to the
> gdb-17 branch as well.
>
> I'd be fine having this patch that changes the breakpoint instruction in
> the gdb-17-branch. What is the other one?
Add microblaze_get_next_pcs
Commit 96b9a160734f34d6644cae7c2dec02a98e07f66e
gopi
>
> Simon
>
[-- Attachment #2: Type: text/html, Size: 3894 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA
2025-09-09 16:05 ` Gopi Kumar Bulusu
2025-09-09 16:22 ` Simon Marchi
@ 2025-09-09 16:29 ` Michael Eager
2025-09-09 16:41 ` Gopi Kumar Bulusu
1 sibling, 1 reply; 15+ messages in thread
From: Michael Eager @ 2025-09-09 16:29 UTC (permalink / raw)
To: Gopi Kumar Bulusu, Simon Marchi; +Cc: gdb-patches
On 9/9/25 9:05 AM, Gopi Kumar Bulusu wrote:
>
>
> On Tue, Sep 9, 2025, 9:04 PM Simon Marchi <simark@simark.ca
> <mailto:simark@simark.ca>> wrote:
>
> On 9/9/25 11:31 AM, Simon Marchi wrote:
> > On 9/9/25 3:16 AM, Gopi Kumar Bulusu wrote:
> >> namaskaaram,
> >>
> >> The macro MICROBLAZE_BREAKPOINT is set to an instruction opcode
> that does not meet the criteria for software breakpoint instruction
> as set forth in the AMD MicroBlaze ISA. This patch addresses the
> problem.
> >>
> >> This simple patch concludes a series of patches that add AMD
> MicroBlaze gdbserver target support for GNU/Linux.
> >>
> >> Updated NEWS to include MicroBlaze gdbserver target.
> >>
> >> Build/Test - tested by building microblazeel-linux-gdb and
> verifying that software breakpoint works
> >> using gdbserver as target.
> >>
> >> dhanyavaadaaha
> >> gopi
> >>
> >
> > Can you explain how the NEWS entry you add relates to the code
> change?
> >
> > Simon
>
> It sounds like it is related to this patch, merged back in March:
>
> https://sourceware.org/git/?p=binutils-
> gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f
> <https://sourceware.org/git/?p=binutils-
> gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f>
>
> If so, then the NEWS entry should be in the "Changes in GDB 17" section,
> and cherry-picked to the gdb-17-branch branch (and it should not be
> added
> in this particular patch).
>
>
> All the patches in a series of changes ( bfd, gdb, gdbserver) are needed
> for breakpoint to work from gdb for gdbserver target.
>
> After a discussion at the beginning of this work (over a year ago) - I
> followed the path of submitting patches as smaller logical units.
Neither of these points appear to be relevant to this patch.
> I can merge the last 2 (including this) MicroBlaze patches to the
> gdb-17 branch as well.
Let's work on one patch at a time and not confuse matters by referring
to other unrelated patches.
Please split this patch into two. One change to NEWS, the other
changing the breakpoint op code.
--
Michael Eager
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA
2025-09-09 16:29 ` Michael Eager
@ 2025-09-09 16:41 ` Gopi Kumar Bulusu
2025-09-10 5:14 ` [pushed] " Gopi Kumar Bulusu
0 siblings, 1 reply; 15+ messages in thread
From: Gopi Kumar Bulusu @ 2025-09-09 16:41 UTC (permalink / raw)
To: Michael Eager; +Cc: Simon Marchi, gdb-patches
[-- Attachment #1: Type: text/plain, Size: 2450 bytes --]
On Tue, Sep 9, 2025, 9:59 PM Michael Eager <eager@eagercon.com> wrote:
> On 9/9/25 9:05 AM, Gopi Kumar Bulusu wrote:
> >
> >
> > On Tue, Sep 9, 2025, 9:04 PM Simon Marchi <simark@simark.ca
> > <mailto:simark@simark.ca>> wrote:
> >
> > On 9/9/25 11:31 AM, Simon Marchi wrote:
> > > On 9/9/25 3:16 AM, Gopi Kumar Bulusu wrote:
> > >> namaskaaram,
> > >>
> > >> The macro MICROBLAZE_BREAKPOINT is set to an instruction opcode
> > that does not meet the criteria for software breakpoint instruction
> > as set forth in the AMD MicroBlaze ISA. This patch addresses the
> > problem.
> > >>
> > >> This simple patch concludes a series of patches that add AMD
> > MicroBlaze gdbserver target support for GNU/Linux.
> > >>
> > >> Updated NEWS to include MicroBlaze gdbserver target.
> > >>
> > >> Build/Test - tested by building microblazeel-linux-gdb and
> > verifying that software breakpoint works
> > >> using gdbserver as target.
> > >>
> > >> dhanyavaadaaha
> > >> gopi
> > >>
> > >
> > > Can you explain how the NEWS entry you add relates to the code
> > change?
> > >
> > > Simon
> >
> > It sounds like it is related to this patch, merged back in March:
> >
> > https://sourceware.org/git/?p=binutils-
> > gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f
> > <https://sourceware.org/git/?p=binutils-
> > gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f>
> >
> > If so, then the NEWS entry should be in the "Changes in GDB 17"
> section,
> > and cherry-picked to the gdb-17-branch branch (and it should not be
> > added
> > in this particular patch).
> >
> >
> > All the patches in a series of changes ( bfd, gdb, gdbserver) are needed
> > for breakpoint to work from gdb for gdbserver target.
> >
> > After a discussion at the beginning of this work (over a year ago) - I
> > followed the path of submitting patches as smaller logical units.
>
> Neither of these points appear to be relevant to this patch.
>
> > I can merge the last 2 (including this) MicroBlaze patches to the
> > gdb-17 branch as well.
>
> Let's work on one patch at a time and not confuse matters by referring
> to other unrelated patches.
>
> Please split this patch into two. One change to NEWS, the other
> changing the breakpoint op code.
>
Ok, I will do so.
dhanyavaadaaha
gopi
>
>
[-- Attachment #2: Type: text/html, Size: 3954 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [pushed] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA
2025-09-09 16:41 ` Gopi Kumar Bulusu
@ 2025-09-10 5:14 ` Gopi Kumar Bulusu
2025-09-10 13:27 ` Michael Eager
0 siblings, 1 reply; 15+ messages in thread
From: Gopi Kumar Bulusu @ 2025-09-10 5:14 UTC (permalink / raw)
To: Michael Eager; +Cc: Simon Marchi, gdb-patches
[-- Attachment #1: Type: text/plain, Size: 2860 bytes --]
On Tue, Sep 9, 2025 at 10:11 PM Gopi Kumar Bulusu <gopi@sankhya.com> wrote:
>
>
> On Tue, Sep 9, 2025, 9:59 PM Michael Eager <eager@eagercon.com> wrote:
>
>> On 9/9/25 9:05 AM, Gopi Kumar Bulusu wrote:
>> >
>> >
>> > On Tue, Sep 9, 2025, 9:04 PM Simon Marchi <simark@simark.ca
>> > <mailto:simark@simark.ca>> wrote:
>> >
>> > On 9/9/25 11:31 AM, Simon Marchi wrote:
>> > > On 9/9/25 3:16 AM, Gopi Kumar Bulusu wrote:
>> > >> namaskaaram,
>> > >>
>> > >> The macro MICROBLAZE_BREAKPOINT is set to an instruction opcode
>> > that does not meet the criteria for software breakpoint instruction
>> > as set forth in the AMD MicroBlaze ISA. This patch addresses the
>> > problem.
>> > >>
>> > >> This simple patch concludes a series of patches that add AMD
>> > MicroBlaze gdbserver target support for GNU/Linux.
>> > >>
>> > >> Updated NEWS to include MicroBlaze gdbserver target.
>> > >>
>> > >> Build/Test - tested by building microblazeel-linux-gdb and
>> > verifying that software breakpoint works
>> > >> using gdbserver as target.
>> > >>
>> > >> dhanyavaadaaha
>> > >> gopi
>> > >>
>> > >
>> > > Can you explain how the NEWS entry you add relates to the code
>> > change?
>> > >
>> > > Simon
>> >
>> > It sounds like it is related to this patch, merged back in March:
>> >
>> > https://sourceware.org/git/?p=binutils-
>> > gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f
>> > <https://sourceware.org/git/?p=binutils-
>> > gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f>
>> >
>> > If so, then the NEWS entry should be in the "Changes in GDB 17"
>> section,
>> > and cherry-picked to the gdb-17-branch branch (and it should not be
>> > added
>> > in this particular patch).
>> >
>> >
>> > All the patches in a series of changes ( bfd, gdb, gdbserver) are
>> needed
>> > for breakpoint to work from gdb for gdbserver target.
>> >
>> > After a discussion at the beginning of this work (over a year ago) - I
>> > followed the path of submitting patches as smaller logical units.
>>
>> Neither of these points appear to be relevant to this patch.
>>
>> > I can merge the last 2 (including this) MicroBlaze patches to the
>> > gdb-17 branch as well.
>>
>> Let's work on one patch at a time and not confuse matters by referring
>> to other unrelated patches.
>>
>> Please split this patch into two. One change to NEWS, the other
>> changing the breakpoint op code.
>>
>
> Ok, I will do so.
>
pushed 2dda928eb2f2764adaed515f513227cea8d16564
(microblaze-tdep.h)
pushed c8af46a9cc214f8ef70d189ead632419d5889c2f
(NEWS update)
dhanyavaadaaha
gopi
> dhanyavaadaaha
> gopi
>
>>
>>
[-- Attachment #2: Type: text/html, Size: 5200 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [pushed] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA
2025-09-10 5:14 ` [pushed] " Gopi Kumar Bulusu
@ 2025-09-10 13:27 ` Michael Eager
2025-09-10 15:09 ` Simon Marchi
0 siblings, 1 reply; 15+ messages in thread
From: Michael Eager @ 2025-09-10 13:27 UTC (permalink / raw)
To: Gopi Kumar Bulusu, Michael Eager; +Cc: Simon Marchi, gdb-patches
On 9/9/25 10:14 PM, Gopi Kumar Bulusu wrote:
>
>
> On Tue, Sep 9, 2025 at 10:11 PM Gopi Kumar Bulusu <gopi@sankhya.com
> <mailto:gopi@sankhya.com>> wrote:
>
>
>
> On Tue, Sep 9, 2025, 9:59 PM Michael Eager <eager@eagercon.com
> <mailto:eager@eagercon.com>> wrote:
>
> On 9/9/25 9:05 AM, Gopi Kumar Bulusu wrote:
> >
> >
> > On Tue, Sep 9, 2025, 9:04 PM Simon Marchi <simark@simark.ca
> <mailto:simark@simark.ca>
> > <mailto:simark@simark.ca <mailto:simark@simark.ca>>> wrote:
> >
> > On 9/9/25 11:31 AM, Simon Marchi wrote:
> > > On 9/9/25 3:16 AM, Gopi Kumar Bulusu wrote:
> > >> namaskaaram,
> > >>
> > >> The macro MICROBLAZE_BREAKPOINT is set to an
> instruction opcode
> > that does not meet the criteria for software breakpoint
> instruction
> > as set forth in the AMD MicroBlaze ISA. This patch
> addresses the
> > problem.
> > >>
> > >> This simple patch concludes a series of patches that
> add AMD
> > MicroBlaze gdbserver target support for GNU/Linux.
> > >>
> > >> Updated NEWS to include MicroBlaze gdbserver target.
> > >>
> > >> Build/Test - tested by building microblazeel-linux-
> gdb and
> > verifying that software breakpoint works
> > >> using gdbserver as target.
> > >>
> > >> dhanyavaadaaha
> > >> gopi
> > >>
> > >
> > > Can you explain how the NEWS entry you add relates to
> the code
> > change?
> > >
> > > Simon
> >
> > It sounds like it is related to this patch, merged back
> in March:
> >
> > https://sourceware.org/git/?p=binutils- <https://
> sourceware.org/git/?p=binutils->
> > gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f
> > <https://sourceware.org/git/?p=binutils- <https://
> sourceware.org/git/?p=binutils->
> > gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f>
> >
> > If so, then the NEWS entry should be in the "Changes in
> GDB 17" section,
> > and cherry-picked to the gdb-17-branch branch (and it
> should not be
> > added
> > in this particular patch).
> >
> >
> > All the patches in a series of changes ( bfd, gdb, gdbserver)
> are needed
> > for breakpoint to work from gdb for gdbserver target.
> >
> > After a discussion at the beginning of this work (over a year
> ago) - I
> > followed the path of submitting patches as smaller logical units.
>
> Neither of these points appear to be relevant to this patch.
>
> > I can merge the last 2 (including this) MicroBlaze
> patches to the
> > gdb-17 branch as well.
>
> Let's work on one patch at a time and not confuse matters by
> referring
> to other unrelated patches.
>
> Please split this patch into two. One change to NEWS, the other
> changing the breakpoint op code.
>
>
> Ok, I will do so.
>
>
> pushed 2dda928eb2f2764adaed515f513227cea8d16564
> (microblaze-tdep.h)
>
> pushed c8af46a9cc214f8ef70d189ead632419d5889c2f
> (NEWS update)
Please apply both to gdb-17-branch as well as trunk.
--
Michael Eager
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [pushed] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA
2025-09-10 13:27 ` Michael Eager
@ 2025-09-10 15:09 ` Simon Marchi
0 siblings, 0 replies; 15+ messages in thread
From: Simon Marchi @ 2025-09-10 15:09 UTC (permalink / raw)
To: Michael Eager, Gopi Kumar Bulusu; +Cc: gdb-patches
On 2025-09-10 09:27, Michael Eager wrote:
> On 9/9/25 10:14 PM, Gopi Kumar Bulusu wrote:
>>
>>
>> On Tue, Sep 9, 2025 at 10:11 PM Gopi Kumar Bulusu <gopi@sankhya.com <mailto:gopi@sankhya.com>> wrote:
>>
>>
>>
>> On Tue, Sep 9, 2025, 9:59 PM Michael Eager <eager@eagercon.com
>> <mailto:eager@eagercon.com>> wrote:
>>
>> On 9/9/25 9:05 AM, Gopi Kumar Bulusu wrote:
>> >
>> >
>> > On Tue, Sep 9, 2025, 9:04 PM Simon Marchi <simark@simark.ca
>> <mailto:simark@simark.ca>
>> > <mailto:simark@simark.ca <mailto:simark@simark.ca>>> wrote:
>> >
>> > On 9/9/25 11:31 AM, Simon Marchi wrote:
>> > > On 9/9/25 3:16 AM, Gopi Kumar Bulusu wrote:
>> > >> namaskaaram,
>> > >>
>> > >> The macro MICROBLAZE_BREAKPOINT is set to an
>> instruction opcode
>> > that does not meet the criteria for software breakpoint
>> instruction
>> > as set forth in the AMD MicroBlaze ISA. This patch addresses the
>> > problem.
>> > >>
>> > >> This simple patch concludes a series of patches that
>> add AMD
>> > MicroBlaze gdbserver target support for GNU/Linux.
>> > >>
>> > >> Updated NEWS to include MicroBlaze gdbserver target.
>> > >>
>> > >> Build/Test - tested by building microblazeel-linux-
>> gdb and
>> > verifying that software breakpoint works
>> > >> using gdbserver as target.
>> > >>
>> > >> dhanyavaadaaha
>> > >> gopi
>> > >>
>> > >
>> > > Can you explain how the NEWS entry you add relates to
>> the code
>> > change?
>> > >
>> > > Simon
>> >
>> > It sounds like it is related to this patch, merged back
>> in March:
>> >
>> > https://sourceware.org/git/?p=binutils- <https://
>> sourceware.org/git/?p=binutils->
>> > gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f
>> > <https://sourceware.org/git/?p=binutils- <https://
>> sourceware.org/git/?p=binutils->
>> > gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f>
>> >
>> > If so, then the NEWS entry should be in the "Changes in
>> GDB 17" section,
>> > and cherry-picked to the gdb-17-branch branch (and it
>> should not be
>> > added
>> > in this particular patch).
>> >
>> >
>> > All the patches in a series of changes ( bfd, gdb, gdbserver)
>> are needed
>> > for breakpoint to work from gdb for gdbserver target.
>> >
>> > After a discussion at the beginning of this work (over a year
>> ago) - I
>> > followed the path of submitting patches as smaller logical units.
>>
>> Neither of these points appear to be relevant to this patch.
>>
>> > I can merge the last 2 (including this) MicroBlaze patches to the
>> > gdb-17 branch as well.
>>
>> Let's work on one patch at a time and not confuse matters by
>> referring
>> to other unrelated patches.
>>
>> Please split this patch into two. One change to NEWS, the other
>> changing the breakpoint op code.
>>
>>
>> Ok, I will do so.
>>
>> pushed 2dda928eb2f2764adaed515f513227cea8d16564
>> (microblaze-tdep.h)
>>
>> pushed c8af46a9cc214f8ef70d189ead632419d5889c2f
>> (NEWS update)
>
> Please apply both to gdb-17-branch as well as trunk.
>
Note that if this ends up in GDB 17 branch, then the NEWS entry will
need to be moved to the "Changes in GDB 17" section.
Simon
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA
2025-09-09 15:31 ` Simon Marchi
2025-09-09 15:34 ` Simon Marchi
@ 2025-09-09 15:34 ` Michael Eager
1 sibling, 0 replies; 15+ messages in thread
From: Michael Eager @ 2025-09-09 15:34 UTC (permalink / raw)
To: Simon Marchi, Gopi Kumar Bulusu, gdb-patches
On 9/9/25 8:31 AM, Simon Marchi wrote:
> On 9/9/25 3:16 AM, Gopi Kumar Bulusu wrote:
>> namaskaaram,
>>
>> The macro MICROBLAZE_BREAKPOINT is set to an instruction opcode that does not meet the criteria for software breakpoint instruction as set forth in the AMD MicroBlaze ISA. This patch addresses the problem.
>>
>> This simple patch concludes a series of patches that add AMD MicroBlaze gdbserver target support for GNU/Linux.
>>
>> Updated NEWS to include MicroBlaze gdbserver target.
>>
>> Build/Test - tested by building microblazeel-linux-gdb and verifying that software breakpoint works
>> using gdbserver as target.
>>
>> dhanyavaadaaha
>> gopi
>>
>
> Can you explain how the NEWS entry you add relates to the code change?
>
> Simon
>
It would be better if these were separated into two independent patches.
--
Michael Eager
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2025-09-10 15:10 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-09 7:16 [PATCH] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA Gopi Kumar Bulusu
2025-09-09 11:56 ` Michael Eager
2025-09-09 12:23 ` Gopi Kumar Bulusu
2025-09-09 13:35 ` Michael Eager
2025-09-09 15:31 ` Simon Marchi
2025-09-09 15:34 ` Simon Marchi
2025-09-09 16:05 ` Gopi Kumar Bulusu
2025-09-09 16:22 ` Simon Marchi
2025-09-09 16:39 ` Gopi Kumar Bulusu
2025-09-09 16:29 ` Michael Eager
2025-09-09 16:41 ` Gopi Kumar Bulusu
2025-09-10 5:14 ` [pushed] " Gopi Kumar Bulusu
2025-09-10 13:27 ` Michael Eager
2025-09-10 15:09 ` Simon Marchi
2025-09-09 15:34 ` [PATCH] " Michael Eager
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox