From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MeCVO15YwGhP8T0AWB0awg (envelope-from ) for ; Tue, 09 Sep 2025 12:39:59 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=sankhya-com.20230601.gappssmtp.com header.i=@sankhya-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=iSI246AT; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id F01B01E0BA; Tue, 09 Sep 2025 12:39:58 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5CBE71E04C for ; Tue, 09 Sep 2025 12:39:58 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 017A03858406 for ; Tue, 9 Sep 2025 16:39:58 +0000 (GMT) Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id B271A3858C78 for ; Tue, 9 Sep 2025 16:39:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B271A3858C78 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sankhya.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=sankhya.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B271A3858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::532 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757435980; cv=none; b=FX0BI0DSfL0r/zb/K9CnY8Vxm3zmyI4rB9dCJC4sHjf+FTwMWSk7ZWC7jWPozdx8KvzoYV5aRm4iv6IoG+c+yAX3onAI6rU0qNkKFyuC5feEvumx+cWi1jNDFu3027QZHe6V3Mga713O8abm0o2sCVc7YtdIpwetBMcqTEusj/o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757435980; c=relaxed/simple; bh=yVN9GDNm7wjc4VDwkzE5DdR3iW9FCPfHO0u23s+3MlI=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=VFSfzso5gGH9yaSKNRm5YSSXpxo1X6jKWVETvfsLQqrmOYyW02wGQAwYjclYDK79dNnFc2+7A4iPDk+zKCKYx5eGfSUiFyrcfMrNozDDwCOdZEfG9MWSMZYEFWg6Hioqm1wGDtj/Cixfd2Co4w4eYlJ6TcqfMiajmyChGw9fZO8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B271A3858C78 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=sankhya-com.20230601.gappssmtp.com header.i=@sankhya-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=iSI246AT Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-61cb4374d2fso8833229a12.2 for ; Tue, 09 Sep 2025 09:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sankhya-com.20230601.gappssmtp.com; s=20230601; t=1757435978; x=1758040778; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=zxRU5p64nFjNuZr2iaT3B7aPsslBuWRFEMarEzKWcZ4=; b=iSI246AT1PTUO1peb2ELFaOaWTp81/h29KXapHXu0vr2PIfodyCYMAeyq+m7kYuDLW Iw3OZQFKVH7GCyp88jbBefR0pXSsWfZ7O/PB8iHiNPNwDmTtrUG+cpvQ7Q7EEReeIgUd Zzy6+6KVEt3ox0oLJEsm1VXJUHXScLaWxBrkGgMQhA/yBq+VW8ylJHT5FMWqade/DMxe ZEX3sr5UFq1oyl15mnkHENA8Wt70unIL5liyUENIIZKSWNDZefX4pTZEjhLce4Un7414 1u0QXqQyUN4RKUjHQbLfq60olxVg6oxkKgzg6nO/0+GeQfVthzNpUlmbCeHjKvQ+yxP2 RmMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757435978; x=1758040778; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zxRU5p64nFjNuZr2iaT3B7aPsslBuWRFEMarEzKWcZ4=; b=OJ9HytQkisdPijLl8tu/ZziWxf1avrxPLwDXMvlS0FZ11vP1FDVBMvxO6gRBKsyFf+ kILYGrZOw+lvT04odGBuHrGoXrKGQktIpPIueJ+Re7g8fDDqdqxxntOdmzVZDatmXSc5 1xGNrgURweDmOnPShf6RNncaFGdms8PvVDu0QkuA80IcAXIAYjetepbf5EEp3p/uEHkl wdIU8kpj52pmWm2/B1FeE07ZlwWxYmS6oP0SzBSmRHocFQZrQttR6xqbzDhUpw/hCRXy uHBWM230TR3XUEvfgYcKkzfAFaOBNtwnjnBZ4t2+Piu1oa/7QGg03GrB8iFI/Qrkxbxc C8hA== X-Gm-Message-State: AOJu0YxydwiWr7Rmg3DB0B/p5+i2eZfhixQf7lTiEECAByW1rSWbTyFe CaMnXn86fmOwifDt+OT0VwmAKmr405klz8GXt0je75cyEZJ/hd6dheOnx/1QHhkMEE3bltIM5k0 6AlMAhMqxtKTVipO03CwiYqCCEx/8Im+rYbJwUwXhCg== X-Gm-Gg: ASbGncs0iy1TyZNTCQO/mKImWJfei/UXeT2KII1K9pvsec0vL39wiCMRIhLd4+ke20G VAeJDXHTrUTbnyNvn7htbKhv0gXTMeqUCsseMVNOhLTE2YrO06OIpUU5sIdkmC4DTYMG5qZt/Wu fFpfjap1MfkduQkP81Gpi8GntBBAgkdSvVjXdjDEjx1SkxTTqSu1TPcx+aPf6EMTMRtclgPk2g6 fNwEUOSK8Sy5F30a69aopyoZ/Av792hbaSRUICgIEUUPF3/cMeLqg== X-Google-Smtp-Source: AGHT+IGiHP0AH9EWeyfYl+gn0pRjO9XMpSEyR+j6YprCzHiKe9T8YhXtgoCd97s3F8DD8c1F/NABiNQ6lwaAxLc+c9A= X-Received: by 2002:a05:6402:4607:b0:622:d2f3:ec04 with SMTP id 4fb4d7f45d1cf-6237b77e970mr10228413a12.9.1757435978121; Tue, 09 Sep 2025 09:39:38 -0700 (PDT) MIME-Version: 1.0 References: <4dfa7e96-c4c6-4f7e-8c0f-52aa2c851905@simark.ca> <88ee3799-12b0-48d5-afee-c43085675ed8@simark.ca> In-Reply-To: <88ee3799-12b0-48d5-afee-c43085675ed8@simark.ca> From: Gopi Kumar Bulusu Date: Tue, 9 Sep 2025 22:09:26 +0530 X-Gm-Features: AS18NWA_pSrBmEI2M9TcGfrTEqk_bxztlu3CKFAtDgUyGzDiMFAmsfSbl83VzyU Message-ID: Subject: Re: [PATCH] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA To: Simon Marchi Cc: gdb-patches@sourceware.org, Michael Eager Content-Type: multipart/alternative; boundary="000000000000311298063e60f3dd" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org --000000000000311298063e60f3dd Content-Type: text/plain; charset="UTF-8" On Tue, Sep 9, 2025, 9:52 PM Simon Marchi wrote: > On 9/9/25 12:05 PM, Gopi Kumar Bulusu wrote: > > > > > > On Tue, Sep 9, 2025, 9:04 PM Simon Marchi simark@simark.ca>> wrote: > > > > On 9/9/25 11:31 AM, Simon Marchi wrote: > > > On 9/9/25 3:16 AM, Gopi Kumar Bulusu wrote: > > >> namaskaaram, > > >> > > >> The macro MICROBLAZE_BREAKPOINT is set to an instruction opcode > that does not meet the criteria for software breakpoint instruction as set > forth in the AMD MicroBlaze ISA. This patch addresses the problem. > > >> > > >> This simple patch concludes a series of patches that add AMD > MicroBlaze gdbserver target support for GNU/Linux. > > >> > > >> Updated NEWS to include MicroBlaze gdbserver target. > > >> > > >> Build/Test - tested by building microblazeel-linux-gdb and > verifying that software breakpoint works > > >> using gdbserver as target. > > >> > > >> dhanyavaadaaha > > >> gopi > > >> > > > > > > Can you explain how the NEWS entry you add relates to the code > change? > > > > > > Simon > > > > It sounds like it is related to this patch, merged back in March: > > > > > https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f > < > https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f > > > > > > If so, then the NEWS entry should be in the "Changes in GDB 17" > section, > > and cherry-picked to the gdb-17-branch branch (and it should not be > added > > in this particular patch). > > > > > > All the patches in a series of changes ( bfd, gdb, gdbserver) are needed > for breakpoint to work from gdb for gdbserver target. > > > > After a discussion at the beginning of this work (over a year ago) - I > followed the path of submitting patches as smaller logical units. > > > > I can merge the last 2 (including this) MicroBlaze patches to the > gdb-17 branch as well. > > I'd be fine having this patch that changes the breakpoint instruction in > the gdb-17-branch. What is the other one? Add microblaze_get_next_pcs Commit 96b9a160734f34d6644cae7c2dec02a98e07f66e gopi > > Simon > --000000000000311298063e60f3dd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Sep 9, 2025, 9:52 PM Simon Marchi <simark@simark.ca> wrote:
On 9/9/25 12:05 PM, Gopi Kumar Bulusu wrote:
>
>
> On Tue, Sep 9, 2025, 9:04 PM Simon Marchi <simark@simark.ca <m= ailto:simark@simark.ca>> wrote:
>
>=C2=A0 =C2=A0 =C2=A0On 9/9/25 11:31 AM, Simon Marchi wrote:
>=C2=A0 =C2=A0 =C2=A0> On 9/9/25 3:16 AM, Gopi Kumar Bulusu wrote: >=C2=A0 =C2=A0 =C2=A0>> namaskaaram,
>=C2=A0 =C2=A0 =C2=A0>>
>=C2=A0 =C2=A0 =C2=A0>> The macro MICROBLAZE_BREAKPOINT is set to = an instruction opcode that does not meet the criteria for software breakpoi= nt instruction as set forth in the AMD MicroBlaze ISA. This patch=C2=A0 add= resses the problem.
>=C2=A0 =C2=A0 =C2=A0>>
>=C2=A0 =C2=A0 =C2=A0>> This simple patch concludes a series of pa= tches that add AMD MicroBlaze gdbserver target support for GNU/Linux.
>=C2=A0 =C2=A0 =C2=A0>>
>=C2=A0 =C2=A0 =C2=A0>> Updated NEWS to include MicroBlaze gdbserv= er target.
>=C2=A0 =C2=A0 =C2=A0>>
>=C2=A0 =C2=A0 =C2=A0>> Build/Test - tested by building microblaze= el-linux-gdb and verifying that software breakpoint works
>=C2=A0 =C2=A0 =C2=A0>> using gdbserver as target.
>=C2=A0 =C2=A0 =C2=A0>>
>=C2=A0 =C2=A0 =C2=A0>> dhanyavaadaaha
>=C2=A0 =C2=A0 =C2=A0>> gopi
>=C2=A0 =C2=A0 =C2=A0>>
>=C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0> Can you explain how the NEWS entry you add rel= ates to the code change?
>=C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0> Simon
>
>=C2=A0 =C2=A0 =C2=A0It sounds like it is related to this patch, merged = back in March:
>
>=C2=A0 =C2=A0 =C2=A0https://sourceware.org/git/?p=3Dbinu= tils-gdb.git;a=3Dcommit;h=3Da93f60043a26e0b8b0ea71a63201b9352ce52a6f &l= t;https://sourceware.org/git/?p=3Dbinutils-gdb.git;a=3Dcomm= it;h=3Da93f60043a26e0b8b0ea71a63201b9352ce52a6f>
>
>=C2=A0 =C2=A0 =C2=A0If so, then the NEWS entry should be in the "C= hanges in GDB 17" section,
>=C2=A0 =C2=A0 =C2=A0and cherry-picked to the gdb-17-branch branch (and = it should not be added
>=C2=A0 =C2=A0 =C2=A0in this particular patch).
>
>
> All the patches in a series of changes ( bfd, gdb, gdbserver) are need= ed for breakpoint to work from gdb for=C2=A0 gdbserver target.
>
> After a discussion at the beginning of this work (over a year ago) - I= followed the path of submitting patches as smaller logical units.
>
> I=C2=A0 can merge the last=C2=A0 2 (including this) MicroBlaze=C2=A0 p= atches=C2=A0 to the gdb-17 branch=C2=A0 as well.

I'd be fine having this patch that changes the breakpoint instruction i= n
the gdb-17-branch.=C2=A0 What is the other one?

Add microblaze_get_next_pcs
Commit=C2=A0 =C2=A096b9a160734f34d6644cae7c2dec02a98e07f66e

gopi=C2=A0
=

Simon
--000000000000311298063e60f3dd--