From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CaXHA8pUwGih7T0AWB0awg (envelope-from ) for ; Tue, 09 Sep 2025 12:24:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1757435081; bh=v0qrF1nf2rX3FHCeaAE0QiA5FG4BkxCM2k+gQK/MrZc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=V66WX9bzp/woy6KWJTNHeRWd+xwKBiJ0Dx2Sg7ZSVPMlqHcW4NVuaQESwXI5lxUj/ Eez5idmqSblYq0liQIhIy5d7OLcUBcqfbHDST5k0o6Iu7+9lfZaQ1sFIFEOWvOO+Zz riITyRnIsazXHLCxV75LNgFMow5JiTqMChUDZe88= Received: by simark.ca (Postfix, from userid 112) id F0DEC1E04C; Tue, 09 Sep 2025 12:24:41 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=WCgwb0he; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6642A1E04C for ; Tue, 09 Sep 2025 12:24:41 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EE3F63858407 for ; Tue, 9 Sep 2025 16:24:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EE3F63858407 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=WCgwb0he Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 97C673858C55 for ; Tue, 9 Sep 2025 16:22:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 97C673858C55 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 97C673858C55 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757434968; cv=none; b=reGAPPjU0ic8ChrjqrwU7VMyIhHMhHYM8JJvH2OFoppkUqGP5USIme4+D/4nZ/SWFMCQK5hGxSgI56bM1jWllSSDuNkjzkfmRhU3YWYaacswbELZgpmNJeljFk50Ca1d2sXhxqYG2veQMpEeppUuYyiFSAtag6KItWOIybFj9HQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757434968; c=relaxed/simple; bh=v0qrF1nf2rX3FHCeaAE0QiA5FG4BkxCM2k+gQK/MrZc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=KJpTtKPYho9gI10G0IPCqyQnukZZn6t6U5imZYqruOjL7fUsFsA4TToJk81vbueLxTpYMwlka2i3rESjKplURaNgOIfqI4OcELwz2pQxNxl8QzNyikNgQ0U9lUNoKVrYshfBfkKM5pm4ZTMwwdcxp2kQ1PpRvTq65IZmRNw3o1o= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1757434967; bh=v0qrF1nf2rX3FHCeaAE0QiA5FG4BkxCM2k+gQK/MrZc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=WCgwb0heWJk8CXix6wJJMH0xp8k38FZMlaqtkLAFjZLkcCwxZWwabGsi1vkKwgE6M L46GSQtL6ujDS+B1YUCfElFMFF+7TIeWdjB6SxkbggNQcf7a/M6M9EifrK9adbUYdZ sFmF0oCuPIgLKvoKvS4oS9U4x3yioqagX3W18Pgw= Received: by simark.ca (Postfix) id 010991E04C; Tue, 09 Sep 2025 12:22:46 -0400 (EDT) Message-ID: <88ee3799-12b0-48d5-afee-c43085675ed8@simark.ca> Date: Tue, 9 Sep 2025 12:22:46 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA To: Gopi Kumar Bulusu Cc: gdb-patches@sourceware.org, Michael Eager References: <4dfa7e96-c4c6-4f7e-8c0f-52aa2c851905@simark.ca> Content-Language: fr From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/9/25 12:05 PM, Gopi Kumar Bulusu wrote: > > > On Tue, Sep 9, 2025, 9:04 PM Simon Marchi > wrote: > > On 9/9/25 11:31 AM, Simon Marchi wrote: > > On 9/9/25 3:16 AM, Gopi Kumar Bulusu wrote: > >> namaskaaram, > >> > >> The macro MICROBLAZE_BREAKPOINT is set to an instruction opcode that does not meet the criteria for software breakpoint instruction as set forth in the AMD MicroBlaze ISA. This patch addresses the problem. > >> > >> This simple patch concludes a series of patches that add AMD MicroBlaze gdbserver target support for GNU/Linux. > >> > >> Updated NEWS to include MicroBlaze gdbserver target. > >> > >> Build/Test - tested by building microblazeel-linux-gdb and verifying that software breakpoint works > >> using gdbserver as target. > >> > >> dhanyavaadaaha > >> gopi > >> > > > > Can you explain how the NEWS entry you add relates to the code change? > > > > Simon > > It sounds like it is related to this patch, merged back in March: > > https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f > > If so, then the NEWS entry should be in the "Changes in GDB 17" section, > and cherry-picked to the gdb-17-branch branch (and it should not be added > in this particular patch). > > > All the patches in a series of changes ( bfd, gdb, gdbserver) are needed for breakpoint to work from gdb for gdbserver target. > > After a discussion at the beginning of this work (over a year ago) - I followed the path of submitting patches as smaller logical units. > > I can merge the last 2 (including this) MicroBlaze patches to the gdb-17 branch as well. I'd be fine having this patch that changes the breakpoint instruction in the gdb-17-branch. What is the other one? Simon