From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SQXnG1sQwWj+iT4AWB0awg (envelope-from ) for ; Wed, 10 Sep 2025 01:44:59 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=sankhya-com.20230601.gappssmtp.com header.i=@sankhya-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=zJazYtme; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6C9981E0BA; Wed, 10 Sep 2025 01:44:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C3D991E047 for ; Wed, 10 Sep 2025 01:44:58 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 304D03858C54 for ; Wed, 10 Sep 2025 05:44:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 304D03858C54 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=sankhya-com.20230601.gappssmtp.com header.i=@sankhya-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=zJazYtme Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id B918F3858D35 for ; Wed, 10 Sep 2025 05:44:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B918F3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sankhya.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=sankhya.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B918F3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::536 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757483067; cv=none; b=KB7vcqEwHVrnmHT62XONh70sopNqcrxd0DPGacNDsvEDExOteRT3RELMGBEAVaomWaKi8Cg/+O8H6/AfmcJEZtJPkLW1aB9RT3nAUcl3N3Rjtx7cPuoO+UjpCzlui8c59rM3hIEXgsu2E6RXU7/Jyv0NMFhTAei2F7hN1q5gTyA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757483067; c=relaxed/simple; bh=vc7Xw5NAS5iL2NRJLhQc6QjbSuSpN92u470gvQdqEJE=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=ClGulh/4dRLnDWwthb23XVGSifPNE5FSu/ShdVXnLjEBfEg34tYpuayO1JHjd2YHssBGSrOR9wdu9PRzb78Pcw3o8EfxKCSouMU7xyEGqYmFA+MQ81UAjie22KhnDRs+OL+PT6h3QPehfIcxvujp6wqNtXytPFSBdGZK8yD5hFA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B918F3858D35 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-6228de280ccso8494480a12.3 for ; Tue, 09 Sep 2025 22:44:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sankhya-com.20230601.gappssmtp.com; s=20230601; t=1757483065; x=1758087865; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nxUVzaKjYjtLb4XtQOUoh3951IAqZFq5F9WZ1XrPQyQ=; b=zJazYtmeWhkvI7cKzQPMNZ43V/+lsMVz6jHoMmHxMTxorbrzbgJA7reIDqWxcMLdsg ExfEwUOgdTmiHfO3LfSGi/NOzPz5ZTi0UeXTKCO1D06JpbSd19Aoe1ifLjOvj2K8aFi/ eWAyP+eODlvLfkyzBKGoHo3G15zt19VMokWZmxo1qsV3N/JZiL2Ra6DqrHTzqr7qQhFA u5/jLULmiIkW+knQ1ioXr3nDBr4FYNDkTBQ0lWh47f8vu1ft8mvHYxdDPe1Q1Yhs/cxK OVotvE2h7cE7qw4jYRg5/wTECgLTQwOo58hGzZTMfc9u5hH+6l3adg8vWuPCFY5xe41O Ezng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757483065; x=1758087865; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nxUVzaKjYjtLb4XtQOUoh3951IAqZFq5F9WZ1XrPQyQ=; b=IDIRQUuqy0Nouf22v6MtGZCq3bM9qaTQxYN76KXTMWS2xWnSHtVQx/WIcGeMF7sI7o JP0XaNa/k6GD/38i5hJlz6/tBpEbUfl1AoqbibboKmPrMJetPDtnxTByWwg0XJtJ8s4t y0lA8FXMkY0NgMQBNwvb5tLvcW3nKdylHjpOeUemPNI4vAAT2LOpEK7fHMT2abMDbRG8 LnJRzk51g6wP38X++s5Df04ZF4z65SJcteOL1i4yRIC7Vt9HQBjYXvGdd6PrmThjSegt HcUY60LP7JjFtufJvytyWPyHwhvWFkMbULiyTAGRUTmnYGzqDQ4BEGcmj90mgeLqo0L4 Vkng== X-Forwarded-Encrypted: i=1; AJvYcCV2J6Yzn4Gn/4HK40P5CHLaweGC9n4ANtLGAUdcqekf6wMsmH0w/HzIcjFq1pSvl2sRk1gGPMcIGGtpiw==@sourceware.org X-Gm-Message-State: AOJu0Ywv3CkgK6KBLWF1M/N7tM0wH0yBoIRPo20JpqSGJkFkQ6xGlbXt RhjISwUnX6O7gNIxIzsNjZ8Zj5C9HpDC+22BR0CFTaykX4qpcXS1NapfjeGpR3mI0Qvidw1EhvY ejV1zX8qhx7Q4roKy+TqcTvNBGuXXA1ak4m6MqHlGHQ== X-Gm-Gg: ASbGncu9PwlyWduIH8UgzXnHecT4vQx8ZrG4/RIrq6lrFq3X+GWISGyxbGODMy/lCOB e2JyNOIicXQ/5MzYc50Z1PtBM/8L7hImUHHnlMg8Z//NU1gNq4d3pPXsth43urPw6pQta1edfSo lKsdWG0AHPRzAnIosC2J4j9p+OvL7qMNiEJRM6hej66WlF+UZzKgvWp1F3hRIY0kUQky0My03MU E9C6/yS X-Google-Smtp-Source: AGHT+IG4fVU/xRZC9mFLolAHFvrAMeYioPh2JXM91vzdaIXooJo5R9KbaBwwDOVDzbZ3EgkFkVB7EVHGX9cofcX7sbQ= X-Received: by 2002:a17:907:fd17:b0:af9:414d:9c2 with SMTP id a640c23a62f3a-b04b1403616mr1317774366b.3.1757483065273; Tue, 09 Sep 2025 22:44:25 -0700 (PDT) MIME-Version: 1.0 References: <4dfa7e96-c4c6-4f7e-8c0f-52aa2c851905@simark.ca> <381d984b-4082-47f8-80d4-3338726c8cd9@eagercon.com> In-Reply-To: From: Gopi Kumar Bulusu Date: Wed, 10 Sep 2025 10:44:02 +0530 X-Gm-Features: AS18NWD422NJV3l5pDP9RCvz2B_nmWmN9Pi6urK0D-9XQBNIuLR9V3acvs2wd08 Message-ID: Subject: Re: [pushed] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA To: Michael Eager Cc: Simon Marchi , gdb-patches@sourceware.org Content-Type: multipart/alternative; boundary="000000000000ce037e063e6be9ed" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org --000000000000ce037e063e6be9ed Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Sep 9, 2025 at 10:11=E2=80=AFPM Gopi Kumar Bulusu wrote: > > > On Tue, Sep 9, 2025, 9:59 PM Michael Eager wrote: > >> On 9/9/25 9:05 AM, Gopi Kumar Bulusu wrote: >> > >> > >> > On Tue, Sep 9, 2025, 9:04 PM Simon Marchi > > > wrote: >> > >> > On 9/9/25 11:31 AM, Simon Marchi wrote: >> > > On 9/9/25 3:16 AM, Gopi Kumar Bulusu wrote: >> > >> namaskaaram, >> > >> >> > >> The macro MICROBLAZE_BREAKPOINT is set to an instruction opcod= e >> > that does not meet the criteria for software breakpoint instructio= n >> > as set forth in the AMD MicroBlaze ISA. This patch addresses the >> > problem. >> > >> >> > >> This simple patch concludes a series of patches that add AMD >> > MicroBlaze gdbserver target support for GNU/Linux. >> > >> >> > >> Updated NEWS to include MicroBlaze gdbserver target. >> > >> >> > >> Build/Test - tested by building microblazeel-linux-gdb and >> > verifying that software breakpoint works >> > >> using gdbserver as target. >> > >> >> > >> dhanyavaadaaha >> > >> gopi >> > >> >> > > >> > > Can you explain how the NEWS entry you add relates to the code >> > change? >> > > >> > > Simon >> > >> > It sounds like it is related to this patch, merged back in March: >> > >> > https://sourceware.org/git/?p=3Dbinutils- >> > gdb.git;a=3Dcommit;h=3Da93f60043a26e0b8b0ea71a63201b9352ce52a6f >> > > > gdb.git;a=3Dcommit;h=3Da93f60043a26e0b8b0ea71a63201b9352ce52a6f> >> > >> > If so, then the NEWS entry should be in the "Changes in GDB 17" >> section, >> > and cherry-picked to the gdb-17-branch branch (and it should not b= e >> > added >> > in this particular patch). >> > >> > >> > All the patches in a series of changes ( bfd, gdb, gdbserver) are >> needed >> > for breakpoint to work from gdb for gdbserver target. >> > >> > After a discussion at the beginning of this work (over a year ago) - I >> > followed the path of submitting patches as smaller logical units. >> >> Neither of these points appear to be relevant to this patch. >> >> > I can merge the last 2 (including this) MicroBlaze patches to the >> > gdb-17 branch as well. >> >> Let's work on one patch at a time and not confuse matters by referring >> to other unrelated patches. >> >> Please split this patch into two. One change to NEWS, the other >> changing the breakpoint op code. >> > > Ok, I will do so. > pushed 2dda928eb2f2764adaed515f513227cea8d16564 (microblaze-tdep.h) pushed c8af46a9cc214f8ef70d189ead632419d5889c2f (NEWS update) dhanyavaadaaha gopi > dhanyavaadaaha > gopi > >> >> --000000000000ce037e063e6be9ed Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Sep 9, 2025 at 10:11=E2=80=AFPM Gopi Kumar Bulusu <gopi@sankhya.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">

On Tu= e, Sep 9, 2025, 9:59 PM Michael Eager <eager@eagercon.com> wrote:
On 9/9/25 9:05 AM, Gopi Kumar Bulu= su wrote:
>
>
> On Tue, Sep 9, 2025, 9:04 PM Simon Marchi <simark@simark.ca
> <mailto:simark@simark.ca>> wrote:
>
>=C2=A0 =C2=A0 =C2=A0On 9/9/25 11:31 AM, Simon Marchi wrote:
>=C2=A0 =C2=A0 =C2=A0 > On 9/9/25 3:16 AM, Gopi Kumar Bulusu wrote: >=C2=A0 =C2=A0 =C2=A0 >> namaskaaram,
>=C2=A0 =C2=A0 =C2=A0 >>
>=C2=A0 =C2=A0 =C2=A0 >> The macro MICROBLAZE_BREAKPOINT is set to= an instruction opcode
>=C2=A0 =C2=A0 =C2=A0that does not meet the criteria for software breakp= oint instruction
>=C2=A0 =C2=A0 =C2=A0as set forth in the AMD MicroBlaze ISA. This patch= =C2=A0 addresses the
>=C2=A0 =C2=A0 =C2=A0problem.
>=C2=A0 =C2=A0 =C2=A0 >>
>=C2=A0 =C2=A0 =C2=A0 >> This simple patch concludes a series of p= atches that add AMD
>=C2=A0 =C2=A0 =C2=A0MicroBlaze gdbserver target support for GNU/Linux.<= br> >=C2=A0 =C2=A0 =C2=A0 >>
>=C2=A0 =C2=A0 =C2=A0 >> Updated NEWS to include MicroBlaze gdbser= ver target.
>=C2=A0 =C2=A0 =C2=A0 >>
>=C2=A0 =C2=A0 =C2=A0 >> Build/Test - tested by building microblaz= eel-linux-gdb and
>=C2=A0 =C2=A0 =C2=A0verifying that software breakpoint works
>=C2=A0 =C2=A0 =C2=A0 >> using gdbserver as target.
>=C2=A0 =C2=A0 =C2=A0 >>
>=C2=A0 =C2=A0 =C2=A0 >> dhanyavaadaaha
>=C2=A0 =C2=A0 =C2=A0 >> gopi
>=C2=A0 =C2=A0 =C2=A0 >>
>=C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 > Can you explain how the NEWS entry you add re= lates to the code
>=C2=A0 =C2=A0 =C2=A0change?
>=C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 > Simon
>
>=C2=A0 =C2=A0 =C2=A0It sounds like it is related to this patch, merged = back in March:
>
>=C2=A0 =C2=A0 =C2=A0https://sourceware.org/g= it/?p=3Dbinutils-
>=C2=A0 =C2=A0 =C2=A0gdb.git;a=3Dcommit;h=3Da93f60043a26e0b8b0ea71a63201= b9352ce52a6f
>=C2=A0 =C2=A0 =C2=A0<https://sourceware.o= rg/git/?p=3Dbinutils-
>=C2=A0 =C2=A0 =C2=A0gdb.git;a=3Dcommit;h=3Da93f60043a26e0b8b0ea71a63201= b9352ce52a6f>
>
>=C2=A0 =C2=A0 =C2=A0If so, then the NEWS entry should be in the "C= hanges in GDB 17" section,
>=C2=A0 =C2=A0 =C2=A0and cherry-picked to the gdb-17-branch branch (and = it should not be
>=C2=A0 =C2=A0 =C2=A0added
>=C2=A0 =C2=A0 =C2=A0in this particular patch).
>
>
> All the patches in a series of changes ( bfd, gdb, gdbserver) are need= ed
> for breakpoint to work from gdb for=C2=A0 gdbserver target.
>
> After a discussion at the beginning of this work (over a year ago) - I=
> followed the path of submitting patches as smaller logical units.

Neither of these points appear to be relevant to this patch.

> I=C2=A0 can merge the last=C2=A0 2 (including this) MicroBlaze=C2=A0 p= atches=C2=A0 to the
> gdb-17 branch=C2=A0 as well.

Let's work on one patch at a time and not confuse matters by referring =
to other unrelated patches.

Please split this patch into two.=C2=A0 One change to NEWS, the other
changing the breakpoint op code.
<= div>

Ok, I will do so.=C2=A0

pushe= d=C2=A0 2dda928eb2f2764adaed515f513227cea8d16564
(microblaze-tdep= .h)

pushed c8af46a9cc214f8ef70d189ead632419d5889c2= f
(NEWS update)

dhanyavaadaaha
=
gopi


dhanya= vaadaaha=C2=A0
gopi=C2=A0

--000000000000ce037e063e6be9ed--