From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OY9JJvhYwGi98T0AWB0awg (envelope-from ) for ; Tue, 09 Sep 2025 12:42:32 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=sankhya-com.20230601.gappssmtp.com header.i=@sankhya-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=qarE0exx; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 961891E0BA; Tue, 09 Sep 2025 12:42:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E225A1E04C for ; Tue, 09 Sep 2025 12:42:31 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 704BD3858C52 for ; Tue, 9 Sep 2025 16:42:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 704BD3858C52 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=sankhya-com.20230601.gappssmtp.com header.i=@sankhya-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=qarE0exx Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by sourceware.org (Postfix) with ESMTPS id 9F70F3858D35 for ; Tue, 9 Sep 2025 16:41:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9F70F3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sankhya.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=sankhya.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9F70F3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::531 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757436119; cv=none; b=SyN2snCZ6QpwQovYho2oXVieUBj3kcvDuBm6igLm+HT4uPLXmSVKD3iSgiQOvOhsAWv+CNTCuxgdzEX8rKum0JlXkqhNAhFC2UJqhdPlWwC/mkgll8lekHVZBquJPXPZZ+vLMzbzSghsp/D6y5EtExfT+UYON0yj8T9O6/vPl04= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757436119; c=relaxed/simple; bh=Xjj8K3uQtu9jlhTiYj67FarM8IvKwrl1Fq2HG8YmY/0=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=KrCXkw/1WXGboVuDQfS0u9lw0IMykecvtyrLYjatI0XUNVbrhZDa+6j1QrYXzsiFD5kaotrH65dfZBQi+wa5CBHZCUbK6Ogsq03LIxeCFmK+OldABCmr5OV9csnWD26RGFTKX4djxQYG2oS306dK+JUP6iQSmBRzOjZzEGNyCzQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9F70F3858D35 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-6188b5b113eso2962628a12.0 for ; Tue, 09 Sep 2025 09:41:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sankhya-com.20230601.gappssmtp.com; s=20230601; t=1757436118; x=1758040918; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1SySnk8iTu8YNO0rFG1OzyXr8IymBnQjZWerav8bzks=; b=qarE0exxYipt6+77/eB4hULigA7VQn0KkAZZon3ZwAefi4FHoN6WUBFeX17dFiYgG7 weWYSZaKz4AKMozNiofPMx08aXTLUwmJbz9hQzggD2B85ZBUzgDtm+mNQ0xPhZrybco5 ZYrKALF3Y3FxrZu1zD3CxAKvgjgNGg1gLquEvjuRSykKjUH5i1ceILUhU/9dsrNYmuKF n1mkiCAFavD92Xqo4CbgmTZa9lcWXgfUMAr4crVqBq0SJJPJBHLbUcJ0SKF75XN8FagN ofaVPvEhQD3Uhok6xbBK7XFCTzW6yytLo/+6t0WJII89d6Puok/HTZNuI5EYaIXo8oKm b/og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757436118; x=1758040918; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1SySnk8iTu8YNO0rFG1OzyXr8IymBnQjZWerav8bzks=; b=ibTDzs3wmXrQ9pKXzoaMno+pqPiffJwHF/m0VRoJdL8AJiO2EstEg/w/nITDHzEDu/ qyIbMiLxcuh8rup26DluBJrZt9MpRnbKpt6PGtD96GCpWNC4Vs+FXrf8ZT9+HoqIVWe9 XMPc4E0i3oERfYMHoBmRiRm2qT1raUG8VCfSOg10vyH35EMj5BFe7PY7LNb0BEmFfojH UZFq5ZYP5irCb8bmuN8a+OtURZoulaRq1D2lk8qT+6KOEq34849fOPjCZ6HVudS0fzjR 62JjSSxSxcEcMZ7fwbfsbrXQbMT+1/5w6RQmydrNU2Gin/wcBxuSzTBUCwwvDEU/2zze HGNQ== X-Forwarded-Encrypted: i=1; AJvYcCXlmDu6lYhpBZLjXTlHjSGS3mL0dHLT0UzbcgnFQjRNQVChWT06YakFdY4oE7DaFj4zMfrg5fC8+5FKmg==@sourceware.org X-Gm-Message-State: AOJu0YzQJ/6rSkht3lxnuTh8O7AvZCoWpWZs+vdOP5L45ZMylATRMDFy EgBEcwByHG8b8qeTPKexFjWkUVMMYng5nBl3M31ZI1NxsE54ujq6RtLD7DMlPowtaU4j+cIPQcK du5g/mIIoTpIcq1xEocmLsvWhVU8SkUYhnpQqsZgkgQ== X-Gm-Gg: ASbGncsBEH5Q+nzKI9oR9Gk2O8uK3db+NytY5PwrigjYh8xJeXZw8ptoaHUqlzKtB9i rj/J04AQmmNblksIWqFGpenkBdne/2tiA3pSFoKHPsJlQTTfCdHG6HwTUFemKy/dCO+4ZlsBRak ATiMHRqkhOvXCR2uGR4ysyuGfn5RQLJ5+1v1ve1cnjg2kwHHcTqTdJpJLJs6dByL6oLLgGkG78X BdvaLD6rq0NkjWiwm7MzXbQZfuXjARorYdTSFuEQrXvpdQEPZdu+g== X-Google-Smtp-Source: AGHT+IHg9tAVOUGc5Ff/SHHEoWWUKnt8q9QpTUMNHr4w61rW2UX92RyWB51b9Nl4E4a1cJ/7fvqqg5qnPpR7Aew6OGk= X-Received: by 2002:a05:6402:3484:b0:617:d024:9e75 with SMTP id 4fb4d7f45d1cf-62374d59503mr11768094a12.0.1757436118203; Tue, 09 Sep 2025 09:41:58 -0700 (PDT) MIME-Version: 1.0 References: <4dfa7e96-c4c6-4f7e-8c0f-52aa2c851905@simark.ca> <381d984b-4082-47f8-80d4-3338726c8cd9@eagercon.com> In-Reply-To: <381d984b-4082-47f8-80d4-3338726c8cd9@eagercon.com> From: Gopi Kumar Bulusu Date: Tue, 9 Sep 2025 22:11:46 +0530 X-Gm-Features: AS18NWA9DV8J8ss-lO8SRuFXTy7pA0WeSeYcPBTxuZfzBNBvHBXnoZaZLZmOS_A Message-ID: Subject: Re: [PATCH] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA To: Michael Eager Cc: Simon Marchi , gdb-patches@sourceware.org Content-Type: multipart/alternative; boundary="0000000000008a97f9063e60fb12" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org --0000000000008a97f9063e60fb12 Content-Type: text/plain; charset="UTF-8" On Tue, Sep 9, 2025, 9:59 PM Michael Eager wrote: > On 9/9/25 9:05 AM, Gopi Kumar Bulusu wrote: > > > > > > On Tue, Sep 9, 2025, 9:04 PM Simon Marchi > > wrote: > > > > On 9/9/25 11:31 AM, Simon Marchi wrote: > > > On 9/9/25 3:16 AM, Gopi Kumar Bulusu wrote: > > >> namaskaaram, > > >> > > >> The macro MICROBLAZE_BREAKPOINT is set to an instruction opcode > > that does not meet the criteria for software breakpoint instruction > > as set forth in the AMD MicroBlaze ISA. This patch addresses the > > problem. > > >> > > >> This simple patch concludes a series of patches that add AMD > > MicroBlaze gdbserver target support for GNU/Linux. > > >> > > >> Updated NEWS to include MicroBlaze gdbserver target. > > >> > > >> Build/Test - tested by building microblazeel-linux-gdb and > > verifying that software breakpoint works > > >> using gdbserver as target. > > >> > > >> dhanyavaadaaha > > >> gopi > > >> > > > > > > Can you explain how the NEWS entry you add relates to the code > > change? > > > > > > Simon > > > > It sounds like it is related to this patch, merged back in March: > > > > https://sourceware.org/git/?p=binutils- > > gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f > > > gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f> > > > > If so, then the NEWS entry should be in the "Changes in GDB 17" > section, > > and cherry-picked to the gdb-17-branch branch (and it should not be > > added > > in this particular patch). > > > > > > All the patches in a series of changes ( bfd, gdb, gdbserver) are needed > > for breakpoint to work from gdb for gdbserver target. > > > > After a discussion at the beginning of this work (over a year ago) - I > > followed the path of submitting patches as smaller logical units. > > Neither of these points appear to be relevant to this patch. > > > I can merge the last 2 (including this) MicroBlaze patches to the > > gdb-17 branch as well. > > Let's work on one patch at a time and not confuse matters by referring > to other unrelated patches. > > Please split this patch into two. One change to NEWS, the other > changing the breakpoint op code. > Ok, I will do so. dhanyavaadaaha gopi > > --0000000000008a97f9063e60fb12 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Sep 9, 2025, 9:59 PM Michael Eager <eager@eagercon.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">On 9/9/25 9:05 AM, Gopi Kumar Bulusu wrote: >
>
> On Tue, Sep 9, 2025, 9:04 PM Simon Marchi <simark@simark.ca
> <mailto:simark@simark.ca>> wrote:
>
>=C2=A0 =C2=A0 =C2=A0On 9/9/25 11:31 AM, Simon Marchi wrote:
>=C2=A0 =C2=A0 =C2=A0 > On 9/9/25 3:16 AM, Gopi Kumar Bulusu wrote: >=C2=A0 =C2=A0 =C2=A0 >> namaskaaram,
>=C2=A0 =C2=A0 =C2=A0 >>
>=C2=A0 =C2=A0 =C2=A0 >> The macro MICROBLAZE_BREAKPOINT is set to= an instruction opcode
>=C2=A0 =C2=A0 =C2=A0that does not meet the criteria for software breakp= oint instruction
>=C2=A0 =C2=A0 =C2=A0as set forth in the AMD MicroBlaze ISA. This patch= =C2=A0 addresses the
>=C2=A0 =C2=A0 =C2=A0problem.
>=C2=A0 =C2=A0 =C2=A0 >>
>=C2=A0 =C2=A0 =C2=A0 >> This simple patch concludes a series of p= atches that add AMD
>=C2=A0 =C2=A0 =C2=A0MicroBlaze gdbserver target support for GNU/Linux.<= br> >=C2=A0 =C2=A0 =C2=A0 >>
>=C2=A0 =C2=A0 =C2=A0 >> Updated NEWS to include MicroBlaze gdbser= ver target.
>=C2=A0 =C2=A0 =C2=A0 >>
>=C2=A0 =C2=A0 =C2=A0 >> Build/Test - tested by building microblaz= eel-linux-gdb and
>=C2=A0 =C2=A0 =C2=A0verifying that software breakpoint works
>=C2=A0 =C2=A0 =C2=A0 >> using gdbserver as target.
>=C2=A0 =C2=A0 =C2=A0 >>
>=C2=A0 =C2=A0 =C2=A0 >> dhanyavaadaaha
>=C2=A0 =C2=A0 =C2=A0 >> gopi
>=C2=A0 =C2=A0 =C2=A0 >>
>=C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 > Can you explain how the NEWS entry you add re= lates to the code
>=C2=A0 =C2=A0 =C2=A0change?
>=C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 > Simon
>
>=C2=A0 =C2=A0 =C2=A0It sounds like it is related to this patch, merged = back in March:
>
>=C2=A0 =C2=A0 =C2=A0https://sourceware.org/g= it/?p=3Dbinutils-
>=C2=A0 =C2=A0 =C2=A0gdb.git;a=3Dcommit;h=3Da93f60043a26e0b8b0ea71a63201= b9352ce52a6f
>=C2=A0 =C2=A0 =C2=A0<https://sourceware.o= rg/git/?p=3Dbinutils-
>=C2=A0 =C2=A0 =C2=A0gdb.git;a=3Dcommit;h=3Da93f60043a26e0b8b0ea71a63201= b9352ce52a6f>
>
>=C2=A0 =C2=A0 =C2=A0If so, then the NEWS entry should be in the "C= hanges in GDB 17" section,
>=C2=A0 =C2=A0 =C2=A0and cherry-picked to the gdb-17-branch branch (and = it should not be
>=C2=A0 =C2=A0 =C2=A0added
>=C2=A0 =C2=A0 =C2=A0in this particular patch).
>
>
> All the patches in a series of changes ( bfd, gdb, gdbserver) are need= ed
> for breakpoint to work from gdb for=C2=A0 gdbserver target.
>
> After a discussion at the beginning of this work (over a year ago) - I=
> followed the path of submitting patches as smaller logical units.

Neither of these points appear to be relevant to this patch.

> I=C2=A0 can merge the last=C2=A0 2 (including this) MicroBlaze=C2=A0 p= atches=C2=A0 to the
> gdb-17 branch=C2=A0 as well.

Let's work on one patch at a time and not confuse matters by referring =
to other unrelated patches.

Please split this patch into two.=C2=A0 One change to NEWS, the other
changing the breakpoint op code.

Ok, I will do so.=C2=A0

dhanyavaadaaha=C2=A0
gopi=C2=A0

--0000000000008a97f9063e60fb12--