From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Gb2/AYhQwGjr6D0AWB0awg (envelope-from ) for ; Tue, 09 Sep 2025 12:06:32 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=sankhya-com.20230601.gappssmtp.com header.i=@sankhya-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=HbxXNN0f; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 033121E04C; Tue, 09 Sep 2025 12:06:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6AB8E1E04C for ; Tue, 09 Sep 2025 12:06:31 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3085D385840F for ; Tue, 9 Sep 2025 16:06:31 +0000 (GMT) Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by sourceware.org (Postfix) with ESMTPS id B4BEC385840C for ; Tue, 9 Sep 2025 16:06:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B4BEC385840C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sankhya.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=sankhya.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B4BEC385840C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757433964; cv=none; b=X24GKhl+Ug5sQbQ8qs5QD0XEq0iX4mfUgre3RMtjHd8+WKd5Tw1gY/FfruIdd5Ululua9qkzhroDQu48MypK67oiCpQsqo3Da11yMfqD1IhoneqQ6/G+OGNK4eox5ZFz97KYfr6I0eQz0rWg6yWvvJYj5aJ0rO6hosryjb3Z878= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757433964; c=relaxed/simple; bh=MaHUc2JpbWyODnKD0kPifCgiSpoRsAwqOd2Uy4vFnRw=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=OnwYoSGBMY91R+zMcdvfnbNPJT6XikqhxFR94RnrjAZjz2+fAcPkP2SUBbz2p8RWJSbJy1uuTFqScEQII0fdWUAsJRbjxH1SrCLoBhUVEL23CvIFZxZFfExBnei8CaIWAjdjYw/m2yI8c2P4OY8GDD4Ld9fRXk51LKCh8wvyVsQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-b04b55d5a2cso616563966b.2 for ; Tue, 09 Sep 2025 09:06:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sankhya-com.20230601.gappssmtp.com; s=20230601; t=1757433962; x=1758038762; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nn4ljOLr7bP9tAeKhI18wEHBrDRfh+GRXf0ZXJf2m6I=; b=HbxXNN0fAAbgJ7U60U27DzMQxlY9SHq2KYfeA8KWJW0zc7QV4Ssm3lHTMKFj/uEMDj ewYy5I3wgQH5YoMlUOSZf7pBp0WLZZB+J6yalqsuqqE6SIGw+M1HUQfUvdfrJ/vo+wnS 8IeGfeWJmHbg+cbCBKsAj2ceVXpT39x6KIyjiIwEgrIH/rS6ooyTnpFU9G7Rwjw+aQCB amUl94iLhXCfMYAZpxRgCkXR/qUC8xIEcb+2RLcvr6GnrQIrQ9+JD/25D8JNHEaDgs94 8ek7iZTygOM/WAn4YWF34XSS4mTJE1ZQx+y+PyzDP6DKtVvb7fViTXHWdtUIgRYpay7L LLxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757433962; x=1758038762; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nn4ljOLr7bP9tAeKhI18wEHBrDRfh+GRXf0ZXJf2m6I=; b=DG3Yli4026yKYxvKoelBcyyQzDb4RtO4WjcCXuN0IBq4YwYAoiov1OBle60Nh8xTGt alXHCDmvgI9Rntn9Mz28yQV0pHoXWaz94ZUkRNAbz/AIM06pRMouiQaCtJo45NagCMbn nwBpQkt3SZPgidFy5rEfOaEv7vopYFGpuZ06YxTjUAT+aqFiACrpgTUJ1oh7aZOP8zAs hLrs0/D1iiT5E+OhX4RtbOfMr3XrAhY2/mM9qITEeCCRDQuoDSB8d3OBZKV/uo+rHbuN 4PKZDSReEq86rDc/v3duyvCpUol3Ztwcfj3ZuXBT/gAdJN3fXyQkt3I0vbpLjcsn0ZFm O5rg== X-Gm-Message-State: AOJu0YwPKtUojYxmqITKXPI+/y4wPJTVAP1pUk4PD38kVD2SDcIwpJ1s iG5iXdC6hh/OmFKADxaOYuPnjZvgSURmsXeWT0zAVjdSgmOoNwX8C3BLPpW/IcFeelOxEl0Noxc yDPos2QZN34CzOt4hmbjJK5J7cFXQ4Il+CJiyDfkpM6mELRiF74q5 X-Gm-Gg: ASbGnct3sjSIFN/Cr7dbtU/Vee1bAOPq3yXYjtXCRmWcOWmVTT1FCyuA3MIxlFF2Qz+ QTvlbfq+VYt461B7gF1N06IP7/CHQdXWDEn03AjovUl1jv3TMIuRIym8lC9hsN87OENWWL9yMra d93OHGa8PVfi6UeobP5dFcibYmijnd+vv2+SDSyVtypF+de9OCjcuzLAP5TByHqVRYaxQjfu+Et 8Ta8II0FETh70H/LCz17kPBJJhs+4Fd X-Google-Smtp-Source: AGHT+IEK9fYe6xYYrZ5Ig2LFYLJb5i0TN/aXR9vSdK92Nx+qxSpBPcRAzTwiawOhnLNKUYFjMcDb8VJjZxR5HqN+1BQ= X-Received: by 2002:a17:907:7ea7:b0:afe:b311:a274 with SMTP id a640c23a62f3a-b04b16dc5f0mr1252265366b.46.1757433961891; Tue, 09 Sep 2025 09:06:01 -0700 (PDT) MIME-Version: 1.0 References: <4dfa7e96-c4c6-4f7e-8c0f-52aa2c851905@simark.ca> In-Reply-To: From: Gopi Kumar Bulusu Date: Tue, 9 Sep 2025 21:35:47 +0530 X-Gm-Features: AS18NWD24QuaXr8Vol0ThlE21A0SswNYoE9GsMqwn-6V48qQPqQOpxtyVvv93tM Message-ID: Subject: Re: [PATCH] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA To: Simon Marchi Cc: gdb-patches@sourceware.org, Michael Eager Content-Type: multipart/alternative; boundary="00000000000003ecd1063e607bd9" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org --00000000000003ecd1063e607bd9 Content-Type: text/plain; charset="UTF-8" On Tue, Sep 9, 2025, 9:04 PM Simon Marchi wrote: > On 9/9/25 11:31 AM, Simon Marchi wrote: > > On 9/9/25 3:16 AM, Gopi Kumar Bulusu wrote: > >> namaskaaram, > >> > >> The macro MICROBLAZE_BREAKPOINT is set to an instruction opcode that > does not meet the criteria for software breakpoint instruction as set forth > in the AMD MicroBlaze ISA. This patch addresses the problem. > >> > >> This simple patch concludes a series of patches that add AMD MicroBlaze > gdbserver target support for GNU/Linux. > >> > >> Updated NEWS to include MicroBlaze gdbserver target. > >> > >> Build/Test - tested by building microblazeel-linux-gdb and verifying > that software breakpoint works > >> using gdbserver as target. > >> > >> dhanyavaadaaha > >> gopi > >> > > > > Can you explain how the NEWS entry you add relates to the code change? > > > > Simon > > It sounds like it is related to this patch, merged back in March: > > > https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f > > If so, then the NEWS entry should be in the "Changes in GDB 17" section, > and cherry-picked to the gdb-17-branch branch (and it should not be added > in this particular patch). > All the patches in a series of changes ( bfd, gdb, gdbserver) are needed for breakpoint to work from gdb for gdbserver target. After a discussion at the beginning of this work (over a year ago) - I followed the path of submitting patches as smaller logical units. I can merge the last 2 (including this) MicroBlaze patches to the gdb-17 branch as well. dhanyavaadaaha gopi Simon > --00000000000003ecd1063e607bd9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Sep 9, 2025, 9:04 PM Simon Marchi <simark@simark.ca> wrote:
On 9/9/25 11:31 AM, Simon Marchi wrote:
> On 9/9/25 3:16 AM, Gopi Kumar Bulusu wrote:
>> namaskaaram,
>>=C2=A0
>> The macro MICROBLAZE_BREAKPOINT is set to an instruction opcode th= at does not meet the criteria for software breakpoint instruction as set fo= rth in the AMD MicroBlaze ISA. This patch=C2=A0 addresses the problem.
>>
>> This simple patch concludes a series of patches that add AMD Micro= Blaze gdbserver target support for GNU/Linux.
>>
>> Updated NEWS to include MicroBlaze gdbserver target.
>>
>> Build/Test - tested by building microblazeel-linux-gdb and verifyi= ng that software breakpoint works
>> using gdbserver as target.
>>
>> dhanyavaadaaha
>> gopi
>>=C2=A0
>
> Can you explain how the NEWS entry you add relates to the code change?=
>
> Simon

It sounds like it is related to this patch, merged back in March:

https://sourceware.org/git/?p=3Dbinutils-gdb.git;a=3Dcommit;= h=3Da93f60043a26e0b8b0ea71a63201b9352ce52a6f

If so, then the NEWS entry should be in the "Changes in GDB 17" s= ection,
and cherry-picked to the gdb-17-branch branch (and it should not be added in this particular patch).
All the patches in a series of changes ( bfd, gdb= , gdbserver) are needed for breakpoint to work from gdb for=C2=A0 gdbserver= target.

After a discuss= ion at the beginning of this work (over a year ago) - I followed the path o= f submitting patches as smaller logical units.

<= /div>
I=C2=A0 can merge the last=C2=A0 2 (including this) = MicroBlaze=C2=A0 patches=C2=A0 to the gdb-17 branch=C2=A0 as well.=C2=A0

dhanyavaadaaha=C2=A0
=
gopi=C2=A0

Simon
--00000000000003ecd1063e607bd9--