From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Yap5OsyUwWjI/T4AWB0awg (envelope-from ) for ; Wed, 10 Sep 2025 11:10:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1757517004; bh=OJesHK5bHSXPDT1mzfZj40NcRAwCAn8ZYeMzbQHCrEA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=c/sz2bQXj6bZ4OyWl6nn4JTua5Dp047NhyJrsuEQEOwEnyfis6F7h6IQwNoIymSpv DcLWTxtFLafRRqazRPSXU/FTOH7HpNN3GqZXZsrkSHu3zxbJxmwQtR3WhZzQxzC4vW 4FYzTDaE3gSbuOSqMcRBzLfZkW4/oXWIou8o+m0M= Received: by simark.ca (Postfix, from userid 112) id E09321E0BA; Wed, 10 Sep 2025 11:10:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=HlgGx+M5; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 103AB1E04C for ; Wed, 10 Sep 2025 11:10:03 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8F54F3858C54 for ; Wed, 10 Sep 2025 15:10:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8F54F3858C54 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=HlgGx+M5 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 0A7D33858D35 for ; Wed, 10 Sep 2025 15:09:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0A7D33858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0A7D33858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757516965; cv=none; b=M0WsY1virtxvpW+0V6VWgRXYJKAOP08NyfSZHhY8t3eQZ58DcqwJEDPvrUzm1WEcn6BFKqv2wmfNoaP8nBK3/t4/ZVo/8lGykYbCYdwcOsqoeA9P2MEZsnBz4a2JI7361J6OSEtmJBXe5/OObFwqiTh2JROd+D3P9JdfTJTy0Pk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757516965; c=relaxed/simple; bh=OJesHK5bHSXPDT1mzfZj40NcRAwCAn8ZYeMzbQHCrEA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=dpt4KUxin3IO7r6aMRZ8+B4SpIHJQ7jpiVlKLje62SmvZMKFrfa8yde3lJlQn1NDDSQxQgEzwefhiVlai4gN+x6YvWYxHcmvVAfQIJL6mSqq+Pzm0f29dWPAP0CpJ36Lwf3b09fu4hiB5XUEh0dKUDPgtGh8MKyJ2V/Qn2izzNI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0A7D33858D35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1757516964; bh=OJesHK5bHSXPDT1mzfZj40NcRAwCAn8ZYeMzbQHCrEA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HlgGx+M5Md38YhdzWe8LUqnWCavDxVKhuxE0nAslJjNQ2wvEpQRCcpTuA9wIdrOIu c6RU/SXrPAAEvQg9xpgdTwT1LEwB3y3l3zKOb0ILe7CMkuCKshoRMTpRElJ5bIBGAn LSoRrCMDkSCmN+pIqm1lrVgYimWd4h4ouAXTZYSE= Received: by simark.ca (Postfix) id 8829D1E04C; Wed, 10 Sep 2025 11:09:24 -0400 (EDT) Message-ID: <8561464e-e520-4401-8747-8eb5a908641a@simark.ca> Date: Wed, 10 Sep 2025 11:09:24 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [pushed] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA To: Michael Eager , Gopi Kumar Bulusu Cc: gdb-patches@sourceware.org References: <4dfa7e96-c4c6-4f7e-8c0f-52aa2c851905@simark.ca> <381d984b-4082-47f8-80d4-3338726c8cd9@eagercon.com> <54494909-20ca-4b36-ae92-7defa0dbe961@eagercon.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <54494909-20ca-4b36-ae92-7defa0dbe961@eagercon.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-09-10 09:27, Michael Eager wrote: > On 9/9/25 10:14 PM, Gopi Kumar Bulusu wrote: >> >> >> On Tue, Sep 9, 2025 at 10:11 PM Gopi Kumar Bulusu > wrote: >> >> >> >> On Tue, Sep 9, 2025, 9:59 PM Michael Eager > > wrote: >> >> On 9/9/25 9:05 AM, Gopi Kumar Bulusu wrote: >> > >> > >> > On Tue, Sep 9, 2025, 9:04 PM Simon Marchi > >> > >> wrote: >> > >> > On 9/9/25 11:31 AM, Simon Marchi wrote: >> > > On 9/9/25 3:16 AM, Gopi Kumar Bulusu wrote: >> > >> namaskaaram, >> > >> >> > >> The macro MICROBLAZE_BREAKPOINT is set to an >> instruction opcode >> > that does not meet the criteria for software breakpoint >> instruction >> > as set forth in the AMD MicroBlaze ISA. This patch addresses the >> > problem. >> > >> >> > >> This simple patch concludes a series of patches that >> add AMD >> > MicroBlaze gdbserver target support for GNU/Linux. >> > >> >> > >> Updated NEWS to include MicroBlaze gdbserver target. >> > >> >> > >> Build/Test - tested by building microblazeel-linux- >> gdb and >> > verifying that software breakpoint works >> > >> using gdbserver as target. >> > >> >> > >> dhanyavaadaaha >> > >> gopi >> > >> >> > > >> > > Can you explain how the NEWS entry you add relates to >> the code >> > change? >> > > >> > > Simon >> > >> > It sounds like it is related to this patch, merged back >> in March: >> > >> > https://sourceware.org/git/?p=binutils- > sourceware.org/git/?p=binutils-> >> > gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f >> > > sourceware.org/git/?p=binutils-> >> > gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f> >> > >> > If so, then the NEWS entry should be in the "Changes in >> GDB 17" section, >> > and cherry-picked to the gdb-17-branch branch (and it >> should not be >> > added >> > in this particular patch). >> > >> > >> > All the patches in a series of changes ( bfd, gdb, gdbserver) >> are needed >> > for breakpoint to work from gdb for gdbserver target. >> > >> > After a discussion at the beginning of this work (over a year >> ago) - I >> > followed the path of submitting patches as smaller logical units. >> >> Neither of these points appear to be relevant to this patch. >> >> > I can merge the last 2 (including this) MicroBlaze patches to the >> > gdb-17 branch as well. >> >> Let's work on one patch at a time and not confuse matters by >> referring >> to other unrelated patches. >> >> Please split this patch into two. One change to NEWS, the other >> changing the breakpoint op code. >> >> >> Ok, I will do so. >> >> pushed 2dda928eb2f2764adaed515f513227cea8d16564 >> (microblaze-tdep.h) >> >> pushed c8af46a9cc214f8ef70d189ead632419d5889c2f >> (NEWS update) > > Please apply both to gdb-17-branch as well as trunk. > Note that if this ends up in GDB 17 branch, then the NEWS entry will need to be moved to the "Changes in GDB 17" section. Simon