From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AYcQBCJWwGjs7j0AWB0awg (envelope-from ) for ; Tue, 09 Sep 2025 12:30:26 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=eagercon.com header.i=@eagercon.com header.a=rsa-sha256 header.s=dreamhost header.b=anrg1rFh; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0A2101E04C; Tue, 09 Sep 2025 12:30:26 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 50BE31E04C for ; Tue, 09 Sep 2025 12:30:25 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CD80A3858D35 for ; Tue, 9 Sep 2025 16:30:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CD80A3858D35 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=eagercon.com header.i=@eagercon.com header.a=rsa-sha256 header.s=dreamhost header.b=anrg1rFh Received: from toucan.tulip.relay.mailchannels.net (toucan.tulip.relay.mailchannels.net [23.83.218.254]) by sourceware.org (Postfix) with ESMTPS id 5DD0E3858D35 for ; Tue, 9 Sep 2025 16:29:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5DD0E3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=eagercon.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eagercon.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5DD0E3858D35 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=23.83.218.254 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1757435384; cv=pass; b=afPLlORwMh12Hnuhzl/35IDn8kXrPbcrC42ucCA3jodJdLjkpBdjrTkx/gE4VWmaiFL5fDKwLDoZMY95kJb+g0CPfqcKNnudYEW84dcW/9YMMAlC201GwskCcmH6kgtSL9ovY/k++aHm25gms0GcLyMArDkNwo5STzeAELaJYYg= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1757435384; c=relaxed/simple; bh=iNB+FWGe+H3rToKMSpJibSBvxXGz8qnfX6ThH6p+EAA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=c+MsIHvnPkyrJqKM4I0x0HWUHwy0OXF631i+eHd8ZfF3Hu7XKO13MMJlHsc3h8TPiTgBHGNHlCw8Kyhe7fR6cjC5VKzuXoDaer7oVLyTKVJQKJ9jDad3nsvnx0pzd2W7tJEGAdyKTxlOl/Dtf0qxO07ieGlMLrfp118+Fj4SI9c= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5DD0E3858D35 X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 6E1DB781ACA; Tue, 9 Sep 2025 16:29:43 +0000 (UTC) Received: from pdx1-sub0-mail-a231.dreamhost.com (100-107-19-249.trex-nlb.outbound.svc.cluster.local [100.107.19.249]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id DA5C0782671; Tue, 9 Sep 2025 16:29:42 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1757435382; a=rsa-sha256; cv=none; b=lsB/9Jy4bJqiz2jQwL8dTUlVjTMfgv/1edrnxiy4ACA1MAIU2cNiollkcJFnL9D/BRnkYu VVvO685HlcgJxcYYCJtBMXHA4x9+uMQXMGbwYTiWO2QdZrckvtnUGPt1zEAOV9fH9tsyI3 9v2NUxQEpZ7IGLlgtXpi3+az9i9Gdgz2ejQbpCfryl/aY57uX45Tp02R27l472VlnTmewb zznVakisy3XQoW50sF44nRGcrW+MefJTdThbci4Lbu4rUhlmJbvCtyDgRAqFkK8hpZW+5z 40aIugjOSNflFyFh3un9U9+z4p1XIPCjZAHqdZuDRvnX9XsDbe1J1Pf8ebsFNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1757435382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KPO8PvU0+Wix1Jiwy472Z1lfMogpTIlBA7WVo6TCheg=; b=gdSXDI5diDxZzY/afoXCRA2d8BJDHYJHkSQg1uc7U52M7XTimyFthTgKilNEqBdlpDQfuB JhLRl7FF3xlMXj/4F4fWbuotPKXHMxYRlT0fN8Q7hsKP003/gqOe8V2QP8gUF0z5pTcV01 QAhEC5PTp1paTe7L1hRwmkyCiKsl9rXlv5uEQoK4wHW+HDr8Y8f5CYBzRZAI5jJLL+4rfN 95TdWuC8ERWmh+qQUKdMB9ZI6zDeSUzBKnH0gNsmS9fYaVaeh/EaWDhlUSFLsJTtlsuiFy O4UMtXiJrRXaspoaBIhfgGKKv9MqtmFs+5xnrc4dpKVzzy7wE9iajoVcBPszQw== ARC-Authentication-Results: i=1; rspamd-54bcd779b6-j4b9r; auth=pass smtp.auth=dreamhost smtp.mailfrom=eager@eagercon.com X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|eager@eagerm.com X-MailChannels-Auth-Id: dreamhost X-Arch-Gusty: 5cfa0145058f1994_1757435383124_2815861839 X-MC-Loop-Signature: 1757435383124:1192562645 X-MC-Ingress-Time: 1757435383124 Received: from pdx1-sub0-mail-a231.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.107.19.249 (trex/7.1.3); Tue, 09 Sep 2025 16:29:43 +0000 Received: from [192.168.20.10] (99-119-193-198.lightspeed.sntcca.sbcglobal.net [99.119.193.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by pdx1-sub0-mail-a231.dreamhost.com (Postfix) with ESMTPSA id 4cLq6G41TWz9y; Tue, 9 Sep 2025 09:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eagercon.com; s=dreamhost; t=1757435382; bh=KPO8PvU0+Wix1Jiwy472Z1lfMogpTIlBA7WVo6TCheg=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=anrg1rFhvF6hSbQztTb4+fs/qdofTrEeW/Il3ghsx0mZVxbXcjca92+RGQNw/B1UF Qowyi3mFHTWoGOQb7oCb7sSPEjeeeJf4krG2UWMEZowbWdVUsaKJJ2xDFxW4CEDx0T vNifnmYH66PJdFtx4lyCTo+83LnpYs5xzGA/n2FrgVibap3iFHnawMq4nTw+obe6iY e00tkLz8SeoRD1vQpu3z6KUZ/eZte8sC1lRs74mN2fN7kzDivbziSofWy9CAdf6yQO AXtx4MH36ZbDJM7M1qA1KYxg1fWCraZZS2vYa2OsWxHIct3QMiyz4hGXW1rawhSJWZ KgEOM2M45hWRQ== Message-ID: <381d984b-4082-47f8-80d4-3338726c8cd9@eagercon.com> Date: Tue, 9 Sep 2025 09:29:41 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] MicroBlaze: Update software breakpoint machine code as per MicroBlaze ISA To: Gopi Kumar Bulusu , Simon Marchi Cc: gdb-patches@sourceware.org References: <4dfa7e96-c4c6-4f7e-8c0f-52aa2c851905@simark.ca> Content-Language: en-US From: Michael Eager In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/9/25 9:05 AM, Gopi Kumar Bulusu wrote: > > > On Tue, Sep 9, 2025, 9:04 PM Simon Marchi > wrote: > > On 9/9/25 11:31 AM, Simon Marchi wrote: > > On 9/9/25 3:16 AM, Gopi Kumar Bulusu wrote: > >> namaskaaram, > >> > >> The macro MICROBLAZE_BREAKPOINT is set to an instruction opcode > that does not meet the criteria for software breakpoint instruction > as set forth in the AMD MicroBlaze ISA. This patch  addresses the > problem. > >> > >> This simple patch concludes a series of patches that add AMD > MicroBlaze gdbserver target support for GNU/Linux. > >> > >> Updated NEWS to include MicroBlaze gdbserver target. > >> > >> Build/Test - tested by building microblazeel-linux-gdb and > verifying that software breakpoint works > >> using gdbserver as target. > >> > >> dhanyavaadaaha > >> gopi > >> > > > > Can you explain how the NEWS entry you add relates to the code > change? > > > > Simon > > It sounds like it is related to this patch, merged back in March: > > https://sourceware.org/git/?p=binutils- > gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f > gdb.git;a=commit;h=a93f60043a26e0b8b0ea71a63201b9352ce52a6f> > > If so, then the NEWS entry should be in the "Changes in GDB 17" section, > and cherry-picked to the gdb-17-branch branch (and it should not be > added > in this particular patch). > > > All the patches in a series of changes ( bfd, gdb, gdbserver) are needed > for breakpoint to work from gdb for  gdbserver target. > > After a discussion at the beginning of this work (over a year ago) - I > followed the path of submitting patches as smaller logical units. Neither of these points appear to be relevant to this patch. > I  can merge the last  2 (including this) MicroBlaze  patches  to the > gdb-17 branch  as well. Let's work on one patch at a time and not confuse matters by referring to other unrelated patches. Please split this patch into two. One change to NEWS, the other changing the breakpoint op code. -- Michael Eager