* Build failure: src/gdb ChangeLog record.c gcore.c gcore.h
[not found] <20091022193607.13598.qmail@sourceware.org>
@ 2009-10-23 7:49 ` Pierre Muller
2009-10-23 15:38 ` Michael Snyder
0 siblings, 1 reply; 17+ messages in thread
From: Pierre Muller @ 2009-10-23 7:49 UTC (permalink / raw)
To: msnyder; +Cc: gdb-patches
This patch to record.c
causes compilation failure on
OpenSolaris 2009/06
The reason is that byteswap.h
is not found.
The strange thing is that apparently this
is already known in gnulib,
http://www.gnu.org/software/hello/manual/gnulib/byteswap_002eh.html#byteswap
_002eh
Is it that the gdb/gnulib is only a
small part of the complete gnulib?
Could someone fix this please?
Pierre Muller
Pascal language support maintainer for GDB
> -----Message d'origine-----
> De : gdb-cvs-owner@sourceware.org [mailto:gdb-cvs-owner@sourceware.org]
> De la part de msnyder@sourceware.org
> Envoyé : Thursday, October 22, 2009 9:36 PM
> À : gdb-cvs@sourceware.org
> Objet : src/gdb ChangeLog record.c gcore.c gcore.h
>
> CVSROOT: /cvs/src
> Module name: src
> Changes by: msnyder@sourceware.org 2009-10-22 19:36:07
>
> Modified files:
> gdb : ChangeLog record.c gcore.c
> Added files:
> gdb : gcore.h
>
> Log message:
> 2009-10-16 Hui Zhu <teawater@gmail.com>
> Michael Snyder <msnyder@msnyder-server.eng.vmware.com>
>
> * record.c (RECORD_FILE_MAGIC): New constant.
> (record_arch_list_cleanups): Renamed from
> record_message_cleanups.
> (bfdcore_read): New function.
> (netorder64): New function.
> (netorder32): New function.
> (netorder16): New function.
> (record_restore): New function. Restore a saved record log.
> (bfdcore_write): New function.
> (cmd_record_restore): New function.
> (cmd_record_save): New function. Save a record log to a file.
> (_initialize_record): Set up commands for save and restore.
>
> 2009-10-17 Michael Snyder <msnyder@vmware.com>
>
> * gcore.h: New file.
> * gcore.c (create_gcore_bfd): New function.
> (write_gcore_file): New function.
> (call_target_sbrk): New function. Abstracted from gcore_command.
> (gcore_command): Call call_target_sbrk.
>
> Patches:
> http://sources.redhat.com/cgi-
> bin/cvsweb.cgi/src/gdb/gcore.h.diff?cvsroot=src&r1=NONE&r2=1.1
> http://sources.redhat.com/cgi-
> bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.10988&r2=1.10989
> http://sources.redhat.com/cgi-
> bin/cvsweb.cgi/src/gdb/record.c.diff?cvsroot=src&r1=1.29&r2=1.30
> http://sources.redhat.com/cgi-
> bin/cvsweb.cgi/src/gdb/gcore.c.diff?cvsroot=src&r1=1.34&r2=1.35
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h
2009-10-23 7:49 ` Build failure: src/gdb ChangeLog record.c gcore.c gcore.h Pierre Muller
@ 2009-10-23 15:38 ` Michael Snyder
2009-10-24 22:18 ` Michael Eager
0 siblings, 1 reply; 17+ messages in thread
From: Michael Snyder @ 2009-10-23 15:38 UTC (permalink / raw)
To: Pierre Muller; +Cc: msnyder, gdb-patches
Pierre Muller wrote:
> This patch to record.c
> causes compilation failure on
> OpenSolaris 2009/06
>
> The reason is that byteswap.h
> is not found.
>
> The strange thing is that apparently this
> is already known in gnulib,
> http://www.gnu.org/software/hello/manual/gnulib/byteswap_002eh.html#byteswap
> _002eh
> Is it that the gdb/gnulib is only a
> small part of the complete gnulib?
>
> Could someone fix this please?
Folks, really sorry about all the build failures.
Just getting up, give me a few minutes to have coffee.
I have an idea that I think will clear this up quickly.
If not, then we can revert.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h
2009-10-23 15:38 ` Michael Snyder
@ 2009-10-24 22:18 ` Michael Eager
2009-10-24 23:07 ` Michael Snyder
0 siblings, 1 reply; 17+ messages in thread
From: Michael Eager @ 2009-10-24 22:18 UTC (permalink / raw)
To: Michael Snyder; +Cc: Pierre Muller, msnyder, gdb-patches
Michael Snyder wrote:
> Pierre Muller wrote:
>> This patch to record.c causes compilation failure on OpenSolaris
>> 2009/06
>>
>> The reason is that byteswap.h
>> is not found.
>>
>> The strange thing is that apparently this
>> is already known in gnulib,
>> http://www.gnu.org/software/hello/manual/gnulib/byteswap_002eh.html#byteswap
>>
>> _002eh
>> Is it that the gdb/gnulib is only a small part of the complete gnulib?
>>
>> Could someone fix this please?
>
> Folks, really sorry about all the build failures.
> Just getting up, give me a few minutes to have coffee.
> I have an idea that I think will clear this up quickly.
Looks like gcore.o is not linked in.
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.1103
diff -u -p -r1.1103 Makefile.in
--- Makefile.in 21 Oct 2009 14:14:56 -0000 1.1103
+++ Makefile.in 24 Oct 2009 22:16:44 -0000
@@ -834,7 +834,7 @@ COMMON_OBS = $(DEPFILES) $(CONFIG_OBS) $
solib.o solib-null.o \
prologue-value.o memory-map.o xml-support.o xml-syscall.o \
target-descriptions.o target-memory.o xml-tdesc.o xml-builtin.o \
- inferior.o osdata.o gdb_usleep.o record.o \
+ inferior.o osdata.o gdb_usleep.o record.o gcore.o \
jit.o progspace.o
# Definitions for the syscall's XML files and dir
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h
2009-10-24 22:18 ` Michael Eager
@ 2009-10-24 23:07 ` Michael Snyder
2009-10-25 0:26 ` Hui Zhu
0 siblings, 1 reply; 17+ messages in thread
From: Michael Snyder @ 2009-10-24 23:07 UTC (permalink / raw)
To: Michael Eager; +Cc: Pierre Muller, msnyder, gdb-patches
Michael Eager wrote:
> Michael Snyder wrote:
>> Pierre Muller wrote:
>>> This patch to record.c causes compilation failure on OpenSolaris
>>> 2009/06
>>>
>>> The reason is that byteswap.h
>>> is not found.
>>>
>>> The strange thing is that apparently this
>>> is already known in gnulib,
>>> http://www.gnu.org/software/hello/manual/gnulib/byteswap_002eh.html#byteswap
>>>
>>> _002eh
>>> Is it that the gdb/gnulib is only a small part of the complete gnulib?
>>>
>>> Could someone fix this please?
>> Folks, really sorry about all the build failures.
>> Just getting up, give me a few minutes to have coffee.
>> I have an idea that I think will clear this up quickly.
>
> Looks like gcore.o is not linked in.
Can't do it that way -- gcore.o is included (or not)
via the host makefile fragment in NATDEPFILES.
It doesn't work for some hosts, that's why it isn't included for all.
>
> Index: Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/gdb/Makefile.in,v
> retrieving revision 1.1103
> diff -u -p -r1.1103 Makefile.in
> --- Makefile.in 21 Oct 2009 14:14:56 -0000 1.1103
> +++ Makefile.in 24 Oct 2009 22:16:44 -0000
> @@ -834,7 +834,7 @@ COMMON_OBS = $(DEPFILES) $(CONFIG_OBS) $
> solib.o solib-null.o \
> prologue-value.o memory-map.o xml-support.o xml-syscall.o \
> target-descriptions.o target-memory.o xml-tdesc.o xml-builtin.o \
> - inferior.o osdata.o gdb_usleep.o record.o \
> + inferior.o osdata.o gdb_usleep.o record.o gcore.o \
> jit.o progspace.o
>
> # Definitions for the syscall's XML files and dir
>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h
2009-10-24 23:07 ` Michael Snyder
@ 2009-10-25 0:26 ` Hui Zhu
2009-10-25 0:56 ` Hui Zhu
0 siblings, 1 reply; 17+ messages in thread
From: Hui Zhu @ 2009-10-25 0:26 UTC (permalink / raw)
To: Michael Snyder; +Cc: Michael Eager, Pierre Muller, msnyder, gdb-patches
I try to link gcore.o together with record.o in cygwin. It looks OK.
Maybe it's a way to handle this issue.
Thanks,
Hui
On Sun, Oct 25, 2009 at 06:59, Michael Snyder <msnyder@vmware.com> wrote:
> Michael Eager wrote:
>>
>> Michael Snyder wrote:
>>>
>>> Pierre Muller wrote:
>>>>
>>>> This patch to record.c causes compilation failure on OpenSolaris
>>>> 2009/06
>>>>
>>>> The reason is that byteswap.h
>>>> is not found.
>>>>
>>>> The strange thing is that apparently this
>>>> is already known in gnulib,
>>>> http://www.gnu.org/software/hello/manual/gnulib/byteswap_002eh.html#byteswap
>>>> _002eh
>>>> Is it that the gdb/gnulib is only a small part of the complete gnulib?
>>>>
>>>> Could someone fix this please?
>>>
>>> Folks, really sorry about all the build failures.
>>> Just getting up, give me a few minutes to have coffee.
>>> I have an idea that I think will clear this up quickly.
>>
>> Looks like gcore.o is not linked in.
>
> Can't do it that way -- gcore.o is included (or not)
> via the host makefile fragment in NATDEPFILES.
>
> It doesn't work for some hosts, that's why it isn't included for all.
>
>>
>> Index: Makefile.in
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/Makefile.in,v
>> retrieving revision 1.1103
>> diff -u -p -r1.1103 Makefile.in
>> --- Makefile.in 21 Oct 2009 14:14:56 -0000 1.1103
>> +++ Makefile.in 24 Oct 2009 22:16:44 -0000
>> @@ -834,7 +834,7 @@ COMMON_OBS = $(DEPFILES) $(CONFIG_OBS) $
>> solib.o solib-null.o \
>> prologue-value.o memory-map.o xml-support.o xml-syscall.o \
>> target-descriptions.o target-memory.o xml-tdesc.o xml-builtin.o \
>> - inferior.o osdata.o gdb_usleep.o record.o \
>> + inferior.o osdata.o gdb_usleep.o record.o gcore.o \
>> jit.o progspace.o
>>
>> # Definitions for the syscall's XML files and dir
>>
>>
>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h
2009-10-25 0:26 ` Hui Zhu
@ 2009-10-25 0:56 ` Hui Zhu
2009-10-25 1:26 ` Michael Snyder
0 siblings, 1 reply; 17+ messages in thread
From: Hui Zhu @ 2009-10-25 0:56 UTC (permalink / raw)
To: Michael Snyder; +Cc: Michael Eager, Pierre Muller, msnyder, gdb-patches
I try in cygwin with:
configure --disable-sid --disable-rda --disable-binutils --disable-gas
--disable-ld --disable-gprof --enable-targets=all --enable-64-bits-bfd
CFLAGS=-g
configure --disable-sid --disable-rda --disable-binutils --disable-gas
--disable-ld --disable-gprof
Build is OK.
$ ./gdb
GNU gdb (GDB) 7.0.50.20091025-cvs
Copyright (C) 2009 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law. Type "show copying"
and "show warranty" for details.
This GDB was configured as "i686-pc-cygwin".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Setting up the environment for debugging gdb.
No symbol table is loaded. Use the "file" command.
Make breakpoint pending on future shared library load? (y or [n])
[answered N; input not from terminal]
No symbol table is loaded. Use the "file" command.
Make breakpoint pending on future shared library load? (y or [n])
[answered N; input not from terminal]
/home/hzhu/gdb/bgdbcygwin/gdb/.gdbinit:8: Error in sourced command file:
No breakpoint number 0.
(gdb)
I think in gcore.o, there is not some host-special code. Just some target hook.
I suggest mv gcore.o to makefile.in and add code to check return value
in record.o when call gcore function.
What do you think about it?
Thanks,
Hui
On Sun, Oct 25, 2009 at 08:25, Hui Zhu <teawater@gmail.com> wrote:
> I try to link gcore.o together with record.o in cygwin. It looks OK.
> Maybe it's a way to handle this issue.
>
> Thanks,
> Hui
>
> On Sun, Oct 25, 2009 at 06:59, Michael Snyder <msnyder@vmware.com> wrote:
>> Michael Eager wrote:
>>>
>>> Michael Snyder wrote:
>>>>
>>>> Pierre Muller wrote:
>>>>>
>>>>> This patch to record.c causes compilation failure on OpenSolaris
>>>>> 2009/06
>>>>>
>>>>> The reason is that byteswap.h
>>>>> is not found.
>>>>>
>>>>> The strange thing is that apparently this
>>>>> is already known in gnulib,
>>>>> http://www.gnu.org/software/hello/manual/gnulib/byteswap_002eh.html#byteswap
>>>>> _002eh
>>>>> Is it that the gdb/gnulib is only a small part of the complete gnulib?
>>>>>
>>>>> Could someone fix this please?
>>>>
>>>> Folks, really sorry about all the build failures.
>>>> Just getting up, give me a few minutes to have coffee.
>>>> I have an idea that I think will clear this up quickly.
>>>
>>> Looks like gcore.o is not linked in.
>>
>> Can't do it that way -- gcore.o is included (or not)
>> via the host makefile fragment in NATDEPFILES.
>>
>> It doesn't work for some hosts, that's why it isn't included for all.
>>
>>>
>>> Index: Makefile.in
>>> ===================================================================
>>> RCS file: /cvs/src/src/gdb/Makefile.in,v
>>> retrieving revision 1.1103
>>> diff -u -p -r1.1103 Makefile.in
>>> --- Makefile.in 21 Oct 2009 14:14:56 -0000 1.1103
>>> +++ Makefile.in 24 Oct 2009 22:16:44 -0000
>>> @@ -834,7 +834,7 @@ COMMON_OBS = $(DEPFILES) $(CONFIG_OBS) $
>>> solib.o solib-null.o \
>>> prologue-value.o memory-map.o xml-support.o xml-syscall.o \
>>> target-descriptions.o target-memory.o xml-tdesc.o xml-builtin.o \
>>> - inferior.o osdata.o gdb_usleep.o record.o \
>>> + inferior.o osdata.o gdb_usleep.o record.o gcore.o \
>>> jit.o progspace.o
>>>
>>> # Definitions for the syscall's XML files and dir
>>>
>>>
>>
>>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h
2009-10-25 0:56 ` Hui Zhu
@ 2009-10-25 1:26 ` Michael Snyder
2009-10-25 8:41 ` Hui Zhu
0 siblings, 1 reply; 17+ messages in thread
From: Michael Snyder @ 2009-10-25 1:26 UTC (permalink / raw)
To: Hui Zhu; +Cc: Michael Eager, Pierre Muller, msnyder, gdb-patches
Hui Zhu wrote:
> I try in cygwin with:
> configure --disable-sid --disable-rda --disable-binutils --disable-gas
> --disable-ld --disable-gprof --enable-targets=all --enable-64-bits-bfd
> CFLAGS=-g
> configure --disable-sid --disable-rda --disable-binutils --disable-gas
> --disable-ld --disable-gprof
>
> Build is OK.
>
> $ ./gdb
> GNU gdb (GDB) 7.0.50.20091025-cvs
> Copyright (C) 2009 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law. Type "show copying"
> and "show warranty" for details.
> This GDB was configured as "i686-pc-cygwin".
> For bug reporting instructions, please see:
> <http://www.gnu.org/software/gdb/bugs/>.
> Setting up the environment for debugging gdb.
> No symbol table is loaded. Use the "file" command.
> Make breakpoint pending on future shared library load? (y or [n])
> [answered N; input not from terminal]
> No symbol table is loaded. Use the "file" command.
> Make breakpoint pending on future shared library load? (y or [n])
> [answered N; input not from terminal]
> /home/hzhu/gdb/bgdbcygwin/gdb/.gdbinit:8: Error in sourced command file:
> No breakpoint number 0.
> (gdb)
>
> I think in gcore.o, there is not some host-special code. Just some target hook.
> I suggest mv gcore.o to makefile.in and add code to check return value
> in record.o when call gcore function.
> What do you think about it?
Can't be done. gcore depends on some callbacks that
are not implemented for cygwin.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h
2009-10-25 1:26 ` Michael Snyder
@ 2009-10-25 8:41 ` Hui Zhu
2009-10-25 13:53 ` Hui Zhu
2009-10-25 18:42 ` Michael Snyder
0 siblings, 2 replies; 17+ messages in thread
From: Hui Zhu @ 2009-10-25 8:41 UTC (permalink / raw)
To: Michael Snyder; +Cc: Michael Eager, Pierre Muller, msnyder, gdb-patches
$ ./gdb ./a.exe
GNU gdb (GDB) 7.0.50.20091025-cvs
Copyright (C) 2009 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law. Type "show copying"
and "show warranty" for details.
This GDB was configured as "i686-pc-cygwin".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>...
Reading symbols from /home/hzhu/gdb/bgdbcygwin/gdb/a.exe...done.
Setting up the environment for debugging gdb.
Function "internal_error" not defined.
Make breakpoint pending on future shared library load? (y or [n])
[answered N; input not from terminal]
Function "info_command" not defined.
Make breakpoint pending on future shared library load? (y or [n])
[answered N; input not from terminal]
/home/hzhu/gdb/bgdbcygwin/gdb/.gdbinit:8: Error in sourced command file:
No breakpoint number 0.
(gdb) start
Temporary breakpoint 1 at 0x4010b0: file
/cygdrive/c/study/gcc/gdb/rec/1.c, line 20.
Starting program: /home/hzhu/gdb/bgdbcygwin/gdb/a.exe
[New Thread 3820.0x600]
[New Thread 3820.0x14c]
[New Thread 3820.0xf94]
Temporary breakpoint 1, main () at /cygdrive/c/study/gcc/gdb/rec/1.c:20
20 int b = 0;
(gdb) gcore
Can't create a corefile
(gdb)
/* An external target method must build the notes section. */
note_data = target_make_corefile_notes (obfd, ¬e_size);
It's target depend.
It just a error output, better than build error.
Thanks,
Hui
On Sun, Oct 25, 2009 at 09:19, Michael Snyder <msnyder@vmware.com> wrote:
> Hui Zhu wrote:
>>
>> I try in cygwin with:
>> configure --disable-sid --disable-rda --disable-binutils --disable-gas
>> --disable-ld --disable-gprof --enable-targets=all --enable-64-bits-bfd
>> CFLAGS=-g
>> configure --disable-sid --disable-rda --disable-binutils --disable-gas
>> --disable-ld --disable-gprof
>>
>> Build is OK.
>>
>> $ ./gdb
>> GNU gdb (GDB) 7.0.50.20091025-cvs
>> Copyright (C) 2009 Free Software Foundation, Inc.
>> License GPLv3+: GNU GPL version 3 or later
>> <http://gnu.org/licenses/gpl.html>
>> This is free software: you are free to change and redistribute it.
>> There is NO WARRANTY, to the extent permitted by law. Type "show copying"
>> and "show warranty" for details.
>> This GDB was configured as "i686-pc-cygwin".
>> For bug reporting instructions, please see:
>> <http://www.gnu.org/software/gdb/bugs/>.
>> Setting up the environment for debugging gdb.
>> No symbol table is loaded. Use the "file" command.
>> Make breakpoint pending on future shared library load? (y or [n])
>> [answered N; input not from terminal]
>> No symbol table is loaded. Use the "file" command.
>> Make breakpoint pending on future shared library load? (y or [n])
>> [answered N; input not from terminal]
>> /home/hzhu/gdb/bgdbcygwin/gdb/.gdbinit:8: Error in sourced command file:
>> No breakpoint number 0.
>> (gdb)
>>
>> I think in gcore.o, there is not some host-special code. Just some target
>> hook.
>> I suggest mv gcore.o to makefile.in and add code to check return value
>> in record.o when call gcore function.
>> What do you think about it?
>
> Can't be done. gcore depends on some callbacks that
> are not implemented for cygwin.
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h
2009-10-25 8:41 ` Hui Zhu
@ 2009-10-25 13:53 ` Hui Zhu
2009-10-25 18:43 ` Michael Snyder
2009-10-25 18:42 ` Michael Snyder
1 sibling, 1 reply; 17+ messages in thread
From: Hui Zhu @ 2009-10-25 13:53 UTC (permalink / raw)
To: Michael Snyder; +Cc: Michael Eager, Pierre Muller, msnyder, gdb-patches
Hi Michael,
If you this way will change the GDB too much. I think move the
"record save" cmd together with gcore. I think it can handle this
issue too.
What do you think?
Thanks,
Hui
On Sun, Oct 25, 2009 at 16:41, Hui Zhu <teawater@gmail.com> wrote:
> $ ./gdb ./a.exe
> GNU gdb (GDB) 7.0.50.20091025-cvs
> Copyright (C) 2009 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law. Type "show copying"
> and "show warranty" for details.
> This GDB was configured as "i686-pc-cygwin".
> For bug reporting instructions, please see:
> <http://www.gnu.org/software/gdb/bugs/>...
> Reading symbols from /home/hzhu/gdb/bgdbcygwin/gdb/a.exe...done.
> Setting up the environment for debugging gdb.
> Function "internal_error" not defined.
> Make breakpoint pending on future shared library load? (y or [n])
> [answered N; input not from terminal]
> Function "info_command" not defined.
> Make breakpoint pending on future shared library load? (y or [n])
> [answered N; input not from terminal]
> /home/hzhu/gdb/bgdbcygwin/gdb/.gdbinit:8: Error in sourced command file:
> No breakpoint number 0.
> (gdb) start
> Temporary breakpoint 1 at 0x4010b0: file
> /cygdrive/c/study/gcc/gdb/rec/1.c, line 20.
> Starting program: /home/hzhu/gdb/bgdbcygwin/gdb/a.exe
> [New Thread 3820.0x600]
> [New Thread 3820.0x14c]
> [New Thread 3820.0xf94]
>
> Temporary breakpoint 1, main () at /cygdrive/c/study/gcc/gdb/rec/1.c:20
> 20 int b = 0;
> (gdb) gcore
> Can't create a corefile
> (gdb)
>
> /* An external target method must build the notes section. */
> note_data = target_make_corefile_notes (obfd, ¬e_size);
>
> It's target depend.
>
> It just a error output, better than build error.
>
> Thanks,
> Hui
>
>
>
> On Sun, Oct 25, 2009 at 09:19, Michael Snyder <msnyder@vmware.com> wrote:
>> Hui Zhu wrote:
>>>
>>> I try in cygwin with:
>>> configure --disable-sid --disable-rda --disable-binutils --disable-gas
>>> --disable-ld --disable-gprof --enable-targets=all --enable-64-bits-bfd
>>> CFLAGS=-g
>>> configure --disable-sid --disable-rda --disable-binutils --disable-gas
>>> --disable-ld --disable-gprof
>>>
>>> Build is OK.
>>>
>>> $ ./gdb
>>> GNU gdb (GDB) 7.0.50.20091025-cvs
>>> Copyright (C) 2009 Free Software Foundation, Inc.
>>> License GPLv3+: GNU GPL version 3 or later
>>> <http://gnu.org/licenses/gpl.html>
>>> This is free software: you are free to change and redistribute it.
>>> There is NO WARRANTY, to the extent permitted by law. Type "show copying"
>>> and "show warranty" for details.
>>> This GDB was configured as "i686-pc-cygwin".
>>> For bug reporting instructions, please see:
>>> <http://www.gnu.org/software/gdb/bugs/>.
>>> Setting up the environment for debugging gdb.
>>> No symbol table is loaded. Use the "file" command.
>>> Make breakpoint pending on future shared library load? (y or [n])
>>> [answered N; input not from terminal]
>>> No symbol table is loaded. Use the "file" command.
>>> Make breakpoint pending on future shared library load? (y or [n])
>>> [answered N; input not from terminal]
>>> /home/hzhu/gdb/bgdbcygwin/gdb/.gdbinit:8: Error in sourced command file:
>>> No breakpoint number 0.
>>> (gdb)
>>>
>>> I think in gcore.o, there is not some host-special code. Just some target
>>> hook.
>>> I suggest mv gcore.o to makefile.in and add code to check return value
>>> in record.o when call gcore function.
>>> What do you think about it?
>>
>> Can't be done. gcore depends on some callbacks that
>> are not implemented for cygwin.
>>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h
2009-10-25 8:41 ` Hui Zhu
2009-10-25 13:53 ` Hui Zhu
@ 2009-10-25 18:42 ` Michael Snyder
2009-10-26 2:05 ` Hui Zhu
1 sibling, 1 reply; 17+ messages in thread
From: Michael Snyder @ 2009-10-25 18:42 UTC (permalink / raw)
To: Hui Zhu; +Cc: Michael Eager, Pierre Muller, msnyder, gdb-patches
Hui Zhu wrote:
> $ ./gdb ./a.exe
> GNU gdb (GDB) 7.0.50.20091025-cvs
> Copyright (C) 2009 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law. Type "show copying"
> and "show warranty" for details.
> This GDB was configured as "i686-pc-cygwin".
> For bug reporting instructions, please see:
> <http://www.gnu.org/software/gdb/bugs/>...
> Reading symbols from /home/hzhu/gdb/bgdbcygwin/gdb/a.exe...done.
> Setting up the environment for debugging gdb.
> Function "internal_error" not defined.
> Make breakpoint pending on future shared library load? (y or [n])
> [answered N; input not from terminal]
> Function "info_command" not defined.
> Make breakpoint pending on future shared library load? (y or [n])
> [answered N; input not from terminal]
> /home/hzhu/gdb/bgdbcygwin/gdb/.gdbinit:8: Error in sourced command file:
> No breakpoint number 0.
> (gdb) start
> Temporary breakpoint 1 at 0x4010b0: file
> /cygdrive/c/study/gcc/gdb/rec/1.c, line 20.
> Starting program: /home/hzhu/gdb/bgdbcygwin/gdb/a.exe
> [New Thread 3820.0x600]
> [New Thread 3820.0x14c]
> [New Thread 3820.0xf94]
>
> Temporary breakpoint 1, main () at /cygdrive/c/study/gcc/gdb/rec/1.c:20
> 20 int b = 0;
> (gdb) gcore
> Can't create a corefile
> (gdb)
>
> /* An external target method must build the notes section. */
> note_data = target_make_corefile_notes (obfd, ¬e_size);
>
> It's target depend.
>
> It just a error output, better than build error.
>
> Thanks,
> Hui
Fine, if you can make it work.
I'll be happy to look at a patch.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h
2009-10-25 13:53 ` Hui Zhu
@ 2009-10-25 18:43 ` Michael Snyder
0 siblings, 0 replies; 17+ messages in thread
From: Michael Snyder @ 2009-10-25 18:43 UTC (permalink / raw)
To: Hui Zhu; +Cc: gdb-patches
Hui Zhu wrote:
> Hi Michael,
>
> If you this way will change the GDB too much. I think move the
> "record save" cmd together with gcore. I think it can handle this
> issue too.
>
> What do you think?
I think I'll be happy to look at a patch.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h
2009-10-25 18:42 ` Michael Snyder
@ 2009-10-26 2:05 ` Hui Zhu
2009-10-26 3:41 ` Michael Snyder
0 siblings, 1 reply; 17+ messages in thread
From: Hui Zhu @ 2009-10-26 2:05 UTC (permalink / raw)
To: Michael Snyder; +Cc: Michael Eager, Pierre Muller, msnyder, gdb-patches
[-- Attachment #1: Type: text/plain, Size: 12881 bytes --]
Hi Michael,
I make a patch that move gcore.o to makefile.in.
It will make record save build OK in cygwin.
And cygwin "gcore" will get:
>> (gdb) start
>> Temporary breakpoint 1 at 0x4010b0: file
>> /cygdrive/c/study/gcc/gdb/rec/1.c, line 20.
>> Starting program: /home/hzhu/gdb/bgdbcygwin/gdb/a.exe
>> [New Thread 3820.0x600]
>> [New Thread 3820.0x14c]
>> [New Thread 3820.0xf94]
>>
>> Temporary breakpoint 1, main () at /cygdrive/c/study/gcc/gdb/rec/1.c:20
>> 20 int b = 0;
>> (gdb) gcore
>> Can't create a corefile
>> (gdb)
Please help me review it.
Thanks,
Hui
2009-10-26 Hui Zhu <teawater@gmail.com>
* Makefile.in (SFILES): Add gcore.c.
(COMMON_OBS): Add gcore.o.
* config/alpha/alpha-linux.mh (NATDEPFILES): Delete gcore.o.
* config/alpha/fbsd.mh (NATDEPFILES): Ditto.
* config/arm/linux.mh (NATDEPFILES): Ditto.
* config/i386/fbsd.mh (NATDEPFILES): Ditto.
* config/i386/fbsd64.mh (NATDEPFILES): Ditto.
* config/i386/i386sol2.mh (NATDEPFILES): Ditto.
* config/i386/linux.mh (NATDEPFILES): Ditto.
* config/i386/linux64.mh (NATDEPFILES): Ditto.
* config/i386/sol2-64.mh (NATDEPFILES): Ditto.
* config/ia64/linux.mh (NATDEPFILES): Ditto.
* config/m32r/linux.mh (NATDEPFILES): Ditto.
* config/m68k/linux.mh (NATDEPFILES): Ditto.
* config/mips/linux.mh (NATDEPFILES): Ditto.
* config/pa/linux.mh (NATDEPFILES): Ditto.
* config/powerpc/linux.mh (NATDEPFILES): Ditto.
* config/powerpc/ppc64-linux.mh (NATDEPFILES): Ditto.
* config/s390/s390.mh (NATDEPFILES): Ditto.
* config/sparc/fbsd.mh (NATDEPFILES): Ditto.
* config/sparc/linux.mh (NATDEPFILES): Ditto.
* config/sparc/linux64.mh (NATDEPFILES): Ditto.
* config/sparc/sol2.mh (NATDEPFILES): Ditto.
* config/xtensa/linux.mh (NATDEPFILES): Ditto.
---
Makefile.in | 4 ++--
config/alpha/alpha-linux.mh | 2 +-
config/alpha/fbsd.mh | 2 +-
config/arm/linux.mh | 2 +-
config/i386/fbsd.mh | 2 +-
config/i386/fbsd64.mh | 2 +-
config/i386/i386sol2.mh | 2 +-
config/i386/linux.mh | 2 +-
config/i386/linux64.mh | 2 +-
config/i386/sol2-64.mh | 2 +-
config/ia64/linux.mh | 2 +-
config/m32r/linux.mh | 2 +-
config/m68k/linux.mh | 2 +-
config/mips/linux.mh | 2 +-
config/pa/linux.mh | 2 +-
config/powerpc/linux.mh | 2 +-
config/powerpc/ppc64-linux.mh | 2 +-
config/s390/s390.mh | 2 +-
config/sparc/fbsd.mh | 2 +-
config/sparc/linux.mh | 2 +-
config/sparc/linux64.mh | 2 +-
config/sparc/sol2.mh | 2 +-
config/xtensa/linux.mh | 2 +-
23 files changed, 24 insertions(+), 24 deletions(-)
--- a/Makefile.in
+++ b/Makefile.in
@@ -681,7 +681,7 @@ SFILES = ada-exp.y ada-lang.c ada-typepr
wrapper.c \
xml-tdesc.c xml-support.c \
inferior.c gdb_usleep.c \
- record.c \
+ record.c gcore.c\
jit.c \
xml-syscall.c \
@@ -834,7 +834,7 @@ COMMON_OBS = $(DEPFILES) $(CONFIG_OBS) $
solib.o solib-null.o \
prologue-value.o memory-map.o xml-support.o xml-syscall.o \
target-descriptions.o target-memory.o xml-tdesc.o xml-builtin.o \
- inferior.o osdata.o gdb_usleep.o record.o \
+ inferior.o osdata.o gdb_usleep.o record.o gcore.o \
jit.o progspace.o
# Definitions for the syscall's XML files and dir
--- a/config/alpha/alpha-linux.mh
+++ b/config/alpha/alpha-linux.mh
@@ -1,7 +1,7 @@
# Host: Little-endian Alpha running Linux
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o corelow.o alpha-linux-nat.o \
- fork-child.o proc-service.o linux-thread-db.o gcore.o \
+ fork-child.o proc-service.o linux-thread-db.o \
linux-nat.o linux-fork.o
# The dynamically loaded libthread_db needs access to symbols in the
--- a/config/alpha/fbsd.mh
+++ b/config/alpha/fbsd.mh
@@ -1,6 +1,6 @@
# Host: FreeBSD/alpha
NATDEPFILES= fork-child.o inf-ptrace.o \
fbsd-nat.o alphabsd-nat.o bsd-kvm.o \
- gcore.o corelow.o core-regset.o
+ corelow.o core-regset.o
LOADLIBES= -lkvm
--- a/config/arm/linux.mh
+++ b/config/arm/linux.mh
@@ -1,7 +1,7 @@
# Host: ARM based machine running GNU/Linux
NAT_FILE= config/nm-linux.h
-NATDEPFILES= inf-ptrace.o fork-child.o arm-linux-nat.o gcore.o \
+NATDEPFILES= inf-ptrace.o fork-child.o arm-linux-nat.o \
proc-service.o linux-thread-db.o linux-nat.o linux-fork.o
LOADLIBES= -ldl -rdynamic
--- a/config/i386/fbsd.mh
+++ b/config/i386/fbsd.mh
@@ -1,7 +1,7 @@
# Host: FreeBSD/i386
NATDEPFILES= fork-child.o inf-ptrace.o \
fbsd-nat.o i386-nat.o i386bsd-nat.o i386fbsd-nat.o \
- gcore.o bsd-kvm.o
+ bsd-kvm.o
NAT_FILE= nm-fbsd.h
LOADLIBES= -lkvm
--- a/config/i386/fbsd64.mh
+++ b/config/i386/fbsd64.mh
@@ -1,6 +1,6 @@
# Host: FreeBSD/amd64
NATDEPFILES= fork-child.o inf-ptrace.o \
fbsd-nat.o amd64-nat.o amd64bsd-nat.o amd64fbsd-nat.o \
- gcore.o bsd-kvm.o
+ bsd-kvm.o
LOADLIBES= -lkvm
--- a/config/i386/i386sol2.mh
+++ b/config/i386/i386sol2.mh
@@ -1,4 +1,4 @@
# Host: Solaris x86
NATDEPFILES= fork-child.o i386v4-nat.o i386-sol2-nat.o \
- procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o gcore.o
+ procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o
NAT_FILE= nm-i386sol2.h
--- a/config/i386/linux.mh
+++ b/config/i386/linux.mh
@@ -3,7 +3,7 @@
NAT_FILE= nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o \
i386-nat.o i386-linux-nat.o \
- proc-service.o linux-thread-db.o gcore.o \
+ proc-service.o linux-thread-db.o \
linux-nat.o linux-fork.o
# The dynamically loaded libthread_db needs access to symbols in the
--- a/config/i386/linux64.mh
+++ b/config/i386/linux64.mh
@@ -1,7 +1,7 @@
# Host: GNU/Linux x86-64
NATDEPFILES= inf-ptrace.o fork-child.o \
i386-nat.o amd64-nat.o amd64-linux-nat.o linux-nat.o \
- proc-service.o linux-thread-db.o gcore.o linux-fork.o
+ proc-service.o linux-thread-db.o linux-fork.o
NAT_FILE= config/nm-linux.h
# The dynamically loaded libthread_db needs access to symbols in the
--- a/config/i386/sol2-64.mh
+++ b/config/i386/sol2-64.mh
@@ -1,4 +1,4 @@
# Host: Solaris x86_64
NATDEPFILES= fork-child.o amd64-nat.o i386v4-nat.o i386-sol2-nat.o \
- procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o gcore.o
+ procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o
NAT_FILE= nm-i386sol2.h
--- a/config/ia64/linux.mh
+++ b/config/ia64/linux.mh
@@ -1,7 +1,7 @@
# Host: Intel IA-64 running GNU/Linux
NAT_FILE= config/nm-linux.h
-NATDEPFILES= inf-ptrace.o fork-child.o corelow.o gcore.o \
+NATDEPFILES= inf-ptrace.o fork-child.o corelow.o \
core-regset.o ia64-linux-nat.o \
proc-service.o linux-thread-db.o linux-nat.o linux-fork.o
--- a/config/m32r/linux.mh
+++ b/config/m32r/linux.mh
@@ -2,7 +2,7 @@
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o corelow.o \
- m32r-linux-nat.o gcore.o proc-service.o linux-thread-db.o \
+ m32r-linux-nat.o proc-service.o linux-thread-db.o \
linux-nat.o linux-fork.o
LOADLIBES= -ldl -rdynamic
--- a/config/m68k/linux.mh
+++ b/config/m68k/linux.mh
@@ -2,7 +2,7 @@
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o \
- corelow.o m68klinux-nat.o gcore.o \
+ corelow.o m68klinux-nat.o \
proc-service.o linux-thread-db.o linux-nat.o linux-fork.o
# The dynamically loaded libthread_db needs access to symbols in the
--- a/config/mips/linux.mh
+++ b/config/mips/linux.mh
@@ -1,7 +1,7 @@
# Host: Linux/MIPS
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o mips-linux-nat.o \
- linux-thread-db.o proc-service.o gcore.o \
+ linux-thread-db.o proc-service.o \
linux-nat.o linux-fork.o
LOADLIBES = -ldl -rdynamic
--- a/config/pa/linux.mh
+++ b/config/pa/linux.mh
@@ -1,6 +1,6 @@
# Host: Hewlett-Packard PA-RISC machine, running Linux
NAT_FILE= config/nm-linux.h
-NATDEPFILES= inf-ptrace.o fork-child.o corelow.o gcore.o \
+NATDEPFILES= inf-ptrace.o fork-child.o corelow.o \
hppa-linux-nat.o proc-service.o linux-thread-db.o linux-nat.o \
linux-fork.o
--- a/config/powerpc/linux.mh
+++ b/config/powerpc/linux.mh
@@ -5,6 +5,6 @@ XM_CLIBS=
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o \
ppc-linux-nat.o proc-service.o linux-thread-db.o \
- gcore.o linux-nat.o linux-fork.o
+ linux-nat.o linux-fork.o
LOADLIBES = -ldl -rdynamic
--- a/config/powerpc/ppc64-linux.mh
+++ b/config/powerpc/ppc64-linux.mh
@@ -5,7 +5,7 @@ XM_CLIBS=
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o \
ppc-linux-nat.o proc-service.o linux-thread-db.o \
- gcore.o linux-nat.o linux-fork.o
+ linux-nat.o linux-fork.o
# The PowerPC has severe limitations on TOC size, and uses them even
# for non-PIC code. GDB overflows those tables when compiling with
--- a/config/s390/s390.mh
+++ b/config/s390/s390.mh
@@ -1,5 +1,5 @@
# Host: S390, running Linux
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o corelow.o s390-nat.o \
- gcore.o linux-thread-db.o proc-service.o linux-nat.o linux-fork.o
+ linux-thread-db.o proc-service.o linux-nat.o linux-fork.o
LOADLIBES = -ldl -rdynamic
--- a/config/sparc/fbsd.mh
+++ b/config/sparc/fbsd.mh
@@ -1,6 +1,6 @@
# Host: FreeBSD/sparc64
NATDEPFILES= fork-child.o inf-ptrace.o \
fbsd-nat.o sparc-nat.o sparc64-nat.o sparc64fbsd-nat.o \
- gcore.o bsd-kvm.o
+ bsd-kvm.o
LOADLIBES= -lkvm
--- a/config/sparc/linux.mh
+++ b/config/sparc/linux.mh
@@ -3,7 +3,7 @@ NAT_FILE= config/nm-linux.h
NATDEPFILES= sparc-nat.o sparc-linux-nat.o \
corelow.o core-regset.o fork-child.o inf-ptrace.o \
proc-service.o linux-thread-db.o \
- gcore.o linux-nat.o linux-fork.o
+ linux-nat.o linux-fork.o
# The dynamically loaded libthread_db needs access to symbols in the
# gdb executable.
--- a/config/sparc/linux64.mh
+++ b/config/sparc/linux64.mh
@@ -4,7 +4,7 @@ NATDEPFILES= sparc-nat.o sparc64-nat.o s
corelow.o core-regset.o \
fork-child.o inf-ptrace.o \
proc-service.o linux-thread-db.o \
- gcore.o linux-nat.o linux-fork.o
+ linux-nat.o linux-fork.o
# The dynamically loaded libthread_db needs access to symbols in the
# gdb executable.
--- a/config/sparc/sol2.mh
+++ b/config/sparc/sol2.mh
@@ -1,5 +1,5 @@
# Host: Solaris SPARC & UltraSPARC
NAT_FILE= nm-sol2.h
NATDEPFILES= sparc-sol2-nat.o \
- corelow.o core-regset.o fork-child.o gcore.o \
+ corelow.o core-regset.o fork-child.o \
procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o
--- a/config/xtensa/linux.mh
+++ b/config/xtensa/linux.mh
@@ -2,7 +2,7 @@
NAT_FILE= config/nm-linux.h
-NATDEPFILES= inf-ptrace.o fork-child.o xtensa-linux-nat.o gcore.o \
+NATDEPFILES= inf-ptrace.o fork-child.o xtensa-linux-nat.o \
linux-thread-db.o proc-service.o linux-nat.o linux-fork.o
LOADLIBES = -ldl -rdynamic
On Mon, Oct 26, 2009 at 02:35, Michael Snyder <msnyder@vmware.com> wrote:
> Hui Zhu wrote:
>>
>> $ ./gdb ./a.exe
>> GNU gdb (GDB) 7.0.50.20091025-cvs
>> Copyright (C) 2009 Free Software Foundation, Inc.
>> License GPLv3+: GNU GPL version 3 or later
>> <http://gnu.org/licenses/gpl.html>
>> This is free software: you are free to change and redistribute it.
>> There is NO WARRANTY, to the extent permitted by law. Type "show copying"
>> and "show warranty" for details.
>> This GDB was configured as "i686-pc-cygwin".
>> For bug reporting instructions, please see:
>> <http://www.gnu.org/software/gdb/bugs/>...
>> Reading symbols from /home/hzhu/gdb/bgdbcygwin/gdb/a.exe...done.
>> Setting up the environment for debugging gdb.
>> Function "internal_error" not defined.
>> Make breakpoint pending on future shared library load? (y or [n])
>> [answered N; input not from terminal]
>> Function "info_command" not defined.
>> Make breakpoint pending on future shared library load? (y or [n])
>> [answered N; input not from terminal]
>> /home/hzhu/gdb/bgdbcygwin/gdb/.gdbinit:8: Error in sourced command file:
>> No breakpoint number 0.
>> (gdb) start
>> Temporary breakpoint 1 at 0x4010b0: file
>> /cygdrive/c/study/gcc/gdb/rec/1.c, line 20.
>> Starting program: /home/hzhu/gdb/bgdbcygwin/gdb/a.exe
>> [New Thread 3820.0x600]
>> [New Thread 3820.0x14c]
>> [New Thread 3820.0xf94]
>>
>> Temporary breakpoint 1, main () at /cygdrive/c/study/gcc/gdb/rec/1.c:20
>> 20 int b = 0;
>> (gdb) gcore
>> Can't create a corefile
>> (gdb)
>>
>> /* An external target method must build the notes section. */
>> note_data = target_make_corefile_notes (obfd, ¬e_size);
>>
>> It's target depend.
>>
>> It just a error output, better than build error.
>>
>> Thanks,
>> Hui
>
> Fine, if you can make it work.
> I'll be happy to look at a patch.
>
[-- Attachment #2: mv_gcore.txt --]
[-- Type: text/plain, Size: 8936 bytes --]
---
Makefile.in | 4 ++--
config/alpha/alpha-linux.mh | 2 +-
config/alpha/fbsd.mh | 2 +-
config/arm/linux.mh | 2 +-
config/i386/fbsd.mh | 2 +-
config/i386/fbsd64.mh | 2 +-
config/i386/i386sol2.mh | 2 +-
config/i386/linux.mh | 2 +-
config/i386/linux64.mh | 2 +-
config/i386/sol2-64.mh | 2 +-
config/ia64/linux.mh | 2 +-
config/m32r/linux.mh | 2 +-
config/m68k/linux.mh | 2 +-
config/mips/linux.mh | 2 +-
config/pa/linux.mh | 2 +-
config/powerpc/linux.mh | 2 +-
config/powerpc/ppc64-linux.mh | 2 +-
config/s390/s390.mh | 2 +-
config/sparc/fbsd.mh | 2 +-
config/sparc/linux.mh | 2 +-
config/sparc/linux64.mh | 2 +-
config/sparc/sol2.mh | 2 +-
config/xtensa/linux.mh | 2 +-
23 files changed, 24 insertions(+), 24 deletions(-)
--- a/Makefile.in
+++ b/Makefile.in
@@ -681,7 +681,7 @@ SFILES = ada-exp.y ada-lang.c ada-typepr
wrapper.c \
xml-tdesc.c xml-support.c \
inferior.c gdb_usleep.c \
- record.c \
+ record.c gcore.c\
jit.c \
xml-syscall.c \
@@ -834,7 +834,7 @@ COMMON_OBS = $(DEPFILES) $(CONFIG_OBS) $
solib.o solib-null.o \
prologue-value.o memory-map.o xml-support.o xml-syscall.o \
target-descriptions.o target-memory.o xml-tdesc.o xml-builtin.o \
- inferior.o osdata.o gdb_usleep.o record.o \
+ inferior.o osdata.o gdb_usleep.o record.o gcore.o \
jit.o progspace.o
# Definitions for the syscall's XML files and dir
--- a/config/alpha/alpha-linux.mh
+++ b/config/alpha/alpha-linux.mh
@@ -1,7 +1,7 @@
# Host: Little-endian Alpha running Linux
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o corelow.o alpha-linux-nat.o \
- fork-child.o proc-service.o linux-thread-db.o gcore.o \
+ fork-child.o proc-service.o linux-thread-db.o \
linux-nat.o linux-fork.o
# The dynamically loaded libthread_db needs access to symbols in the
--- a/config/alpha/fbsd.mh
+++ b/config/alpha/fbsd.mh
@@ -1,6 +1,6 @@
# Host: FreeBSD/alpha
NATDEPFILES= fork-child.o inf-ptrace.o \
fbsd-nat.o alphabsd-nat.o bsd-kvm.o \
- gcore.o corelow.o core-regset.o
+ corelow.o core-regset.o
LOADLIBES= -lkvm
--- a/config/arm/linux.mh
+++ b/config/arm/linux.mh
@@ -1,7 +1,7 @@
# Host: ARM based machine running GNU/Linux
NAT_FILE= config/nm-linux.h
-NATDEPFILES= inf-ptrace.o fork-child.o arm-linux-nat.o gcore.o \
+NATDEPFILES= inf-ptrace.o fork-child.o arm-linux-nat.o \
proc-service.o linux-thread-db.o linux-nat.o linux-fork.o
LOADLIBES= -ldl -rdynamic
--- a/config/i386/fbsd.mh
+++ b/config/i386/fbsd.mh
@@ -1,7 +1,7 @@
# Host: FreeBSD/i386
NATDEPFILES= fork-child.o inf-ptrace.o \
fbsd-nat.o i386-nat.o i386bsd-nat.o i386fbsd-nat.o \
- gcore.o bsd-kvm.o
+ bsd-kvm.o
NAT_FILE= nm-fbsd.h
LOADLIBES= -lkvm
--- a/config/i386/fbsd64.mh
+++ b/config/i386/fbsd64.mh
@@ -1,6 +1,6 @@
# Host: FreeBSD/amd64
NATDEPFILES= fork-child.o inf-ptrace.o \
fbsd-nat.o amd64-nat.o amd64bsd-nat.o amd64fbsd-nat.o \
- gcore.o bsd-kvm.o
+ bsd-kvm.o
LOADLIBES= -lkvm
--- a/config/i386/i386sol2.mh
+++ b/config/i386/i386sol2.mh
@@ -1,4 +1,4 @@
# Host: Solaris x86
NATDEPFILES= fork-child.o i386v4-nat.o i386-sol2-nat.o \
- procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o gcore.o
+ procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o
NAT_FILE= nm-i386sol2.h
--- a/config/i386/linux.mh
+++ b/config/i386/linux.mh
@@ -3,7 +3,7 @@
NAT_FILE= nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o \
i386-nat.o i386-linux-nat.o \
- proc-service.o linux-thread-db.o gcore.o \
+ proc-service.o linux-thread-db.o \
linux-nat.o linux-fork.o
# The dynamically loaded libthread_db needs access to symbols in the
--- a/config/i386/linux64.mh
+++ b/config/i386/linux64.mh
@@ -1,7 +1,7 @@
# Host: GNU/Linux x86-64
NATDEPFILES= inf-ptrace.o fork-child.o \
i386-nat.o amd64-nat.o amd64-linux-nat.o linux-nat.o \
- proc-service.o linux-thread-db.o gcore.o linux-fork.o
+ proc-service.o linux-thread-db.o linux-fork.o
NAT_FILE= config/nm-linux.h
# The dynamically loaded libthread_db needs access to symbols in the
--- a/config/i386/sol2-64.mh
+++ b/config/i386/sol2-64.mh
@@ -1,4 +1,4 @@
# Host: Solaris x86_64
NATDEPFILES= fork-child.o amd64-nat.o i386v4-nat.o i386-sol2-nat.o \
- procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o gcore.o
+ procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o
NAT_FILE= nm-i386sol2.h
--- a/config/ia64/linux.mh
+++ b/config/ia64/linux.mh
@@ -1,7 +1,7 @@
# Host: Intel IA-64 running GNU/Linux
NAT_FILE= config/nm-linux.h
-NATDEPFILES= inf-ptrace.o fork-child.o corelow.o gcore.o \
+NATDEPFILES= inf-ptrace.o fork-child.o corelow.o \
core-regset.o ia64-linux-nat.o \
proc-service.o linux-thread-db.o linux-nat.o linux-fork.o
--- a/config/m32r/linux.mh
+++ b/config/m32r/linux.mh
@@ -2,7 +2,7 @@
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o corelow.o \
- m32r-linux-nat.o gcore.o proc-service.o linux-thread-db.o \
+ m32r-linux-nat.o proc-service.o linux-thread-db.o \
linux-nat.o linux-fork.o
LOADLIBES= -ldl -rdynamic
--- a/config/m68k/linux.mh
+++ b/config/m68k/linux.mh
@@ -2,7 +2,7 @@
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o \
- corelow.o m68klinux-nat.o gcore.o \
+ corelow.o m68klinux-nat.o \
proc-service.o linux-thread-db.o linux-nat.o linux-fork.o
# The dynamically loaded libthread_db needs access to symbols in the
--- a/config/mips/linux.mh
+++ b/config/mips/linux.mh
@@ -1,7 +1,7 @@
# Host: Linux/MIPS
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o mips-linux-nat.o \
- linux-thread-db.o proc-service.o gcore.o \
+ linux-thread-db.o proc-service.o \
linux-nat.o linux-fork.o
LOADLIBES = -ldl -rdynamic
--- a/config/pa/linux.mh
+++ b/config/pa/linux.mh
@@ -1,6 +1,6 @@
# Host: Hewlett-Packard PA-RISC machine, running Linux
NAT_FILE= config/nm-linux.h
-NATDEPFILES= inf-ptrace.o fork-child.o corelow.o gcore.o \
+NATDEPFILES= inf-ptrace.o fork-child.o corelow.o \
hppa-linux-nat.o proc-service.o linux-thread-db.o linux-nat.o \
linux-fork.o
--- a/config/powerpc/linux.mh
+++ b/config/powerpc/linux.mh
@@ -5,6 +5,6 @@ XM_CLIBS=
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o \
ppc-linux-nat.o proc-service.o linux-thread-db.o \
- gcore.o linux-nat.o linux-fork.o
+ linux-nat.o linux-fork.o
LOADLIBES = -ldl -rdynamic
--- a/config/powerpc/ppc64-linux.mh
+++ b/config/powerpc/ppc64-linux.mh
@@ -5,7 +5,7 @@ XM_CLIBS=
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o \
ppc-linux-nat.o proc-service.o linux-thread-db.o \
- gcore.o linux-nat.o linux-fork.o
+ linux-nat.o linux-fork.o
# The PowerPC has severe limitations on TOC size, and uses them even
# for non-PIC code. GDB overflows those tables when compiling with
--- a/config/s390/s390.mh
+++ b/config/s390/s390.mh
@@ -1,5 +1,5 @@
# Host: S390, running Linux
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o corelow.o s390-nat.o \
- gcore.o linux-thread-db.o proc-service.o linux-nat.o linux-fork.o
+ linux-thread-db.o proc-service.o linux-nat.o linux-fork.o
LOADLIBES = -ldl -rdynamic
--- a/config/sparc/fbsd.mh
+++ b/config/sparc/fbsd.mh
@@ -1,6 +1,6 @@
# Host: FreeBSD/sparc64
NATDEPFILES= fork-child.o inf-ptrace.o \
fbsd-nat.o sparc-nat.o sparc64-nat.o sparc64fbsd-nat.o \
- gcore.o bsd-kvm.o
+ bsd-kvm.o
LOADLIBES= -lkvm
--- a/config/sparc/linux.mh
+++ b/config/sparc/linux.mh
@@ -3,7 +3,7 @@ NAT_FILE= config/nm-linux.h
NATDEPFILES= sparc-nat.o sparc-linux-nat.o \
corelow.o core-regset.o fork-child.o inf-ptrace.o \
proc-service.o linux-thread-db.o \
- gcore.o linux-nat.o linux-fork.o
+ linux-nat.o linux-fork.o
# The dynamically loaded libthread_db needs access to symbols in the
# gdb executable.
--- a/config/sparc/linux64.mh
+++ b/config/sparc/linux64.mh
@@ -4,7 +4,7 @@ NATDEPFILES= sparc-nat.o sparc64-nat.o s
corelow.o core-regset.o \
fork-child.o inf-ptrace.o \
proc-service.o linux-thread-db.o \
- gcore.o linux-nat.o linux-fork.o
+ linux-nat.o linux-fork.o
# The dynamically loaded libthread_db needs access to symbols in the
# gdb executable.
--- a/config/sparc/sol2.mh
+++ b/config/sparc/sol2.mh
@@ -1,5 +1,5 @@
# Host: Solaris SPARC & UltraSPARC
NAT_FILE= nm-sol2.h
NATDEPFILES= sparc-sol2-nat.o \
- corelow.o core-regset.o fork-child.o gcore.o \
+ corelow.o core-regset.o fork-child.o \
procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o
--- a/config/xtensa/linux.mh
+++ b/config/xtensa/linux.mh
@@ -2,7 +2,7 @@
NAT_FILE= config/nm-linux.h
-NATDEPFILES= inf-ptrace.o fork-child.o xtensa-linux-nat.o gcore.o \
+NATDEPFILES= inf-ptrace.o fork-child.o xtensa-linux-nat.o \
linux-thread-db.o proc-service.o linux-nat.o linux-fork.o
LOADLIBES = -ldl -rdynamic
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h
2009-10-26 2:05 ` Hui Zhu
@ 2009-10-26 3:41 ` Michael Snyder
2009-10-26 7:03 ` Hui Zhu
0 siblings, 1 reply; 17+ messages in thread
From: Michael Snyder @ 2009-10-26 3:41 UTC (permalink / raw)
To: Hui Zhu; +Cc: Michael Eager, Pierre Muller, msnyder, gdb-patches
[-- Attachment #1: Type: text/plain, Size: 306 bytes --]
Hui Zhu wrote:
> Hi Michael,
>
> I make a patch that move gcore.o to makefile.in.
> It will make record save build OK in cygwin.
Not quite good for targets that don't use "exec" (such as
remote or sim). We'll expose an error message that isn't
very informative.
Could you add this diff to your patch?
[-- Attachment #2: gcore.txt --]
[-- Type: text/plain, Size: 1085 bytes --]
Index: target.c
===================================================================
RCS file: /cvs/src/src/gdb/target.c,v
retrieving revision 1.229
diff -u -p -r1.229 target.c
--- target.c 20 Oct 2009 11:09:01 -0000 1.229
+++ target.c 26 Oct 2009 03:39:36 -0000
@@ -2751,17 +2751,19 @@ dummy_pid_to_str (struct target_ops *ops
return normal_pid_to_str (ptid);
}
-/* Error-catcher for target_find_memory_regions */
-static int dummy_find_memory_regions (int (*ignore1) (), void *ignore2)
+/* Error-catcher for target_find_memory_regions. */
+static int
+dummy_find_memory_regions (int (*ignore1) (), void *ignore2)
{
- error (_("No target."));
+ error (_("Command not implemented for this target."));
return 0;
}
-/* Error-catcher for target_make_corefile_notes */
-static char * dummy_make_corefile_notes (bfd *ignore1, int *ignore2)
+/* Error-catcher for target_make_corefile_notes. */
+static char *
+dummy_make_corefile_notes (bfd *ignore1, int *ignore2)
{
- error (_("No target."));
+ error (_("Command not implemented for this target."));
return NULL;
}
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h
2009-10-26 3:41 ` Michael Snyder
@ 2009-10-26 7:03 ` Hui Zhu
2009-10-26 15:51 ` Michael Snyder
0 siblings, 1 reply; 17+ messages in thread
From: Hui Zhu @ 2009-10-26 7:03 UTC (permalink / raw)
To: Michael Snyder; +Cc: Michael Eager, Pierre Muller, msnyder, gdb-patches
[-- Attachment #1: Type: text/plain, Size: 13125 bytes --]
OK. I make a new patch for it.
Please help me review it.
Thanks,
Hui
2009-10-26 Michael Snyder <msnyder@vmware.com>
Hui Zhu <teawater@gmail.com>
* Makefile.in (SFILES): Add gcore.c.
(COMMON_OBS): Add gcore.o.
* config/alpha/alpha-linux.mh (NATDEPFILES): Delete gcore.o.
* config/alpha/fbsd.mh (NATDEPFILES): Ditto.
* config/arm/linux.mh (NATDEPFILES): Ditto.
* config/i386/fbsd.mh (NATDEPFILES): Ditto.
* config/i386/fbsd64.mh (NATDEPFILES): Ditto.
* config/i386/i386sol2.mh (NATDEPFILES): Ditto.
* config/i386/linux.mh (NATDEPFILES): Ditto.
* config/i386/linux64.mh (NATDEPFILES): Ditto.
* config/i386/sol2-64.mh (NATDEPFILES): Ditto.
* config/ia64/linux.mh (NATDEPFILES): Ditto.
* config/m32r/linux.mh (NATDEPFILES): Ditto.
* config/m68k/linux.mh (NATDEPFILES): Ditto.
* config/mips/linux.mh (NATDEPFILES): Ditto.
* config/pa/linux.mh (NATDEPFILES): Ditto.
* config/powerpc/linux.mh (NATDEPFILES): Ditto.
* config/powerpc/ppc64-linux.mh (NATDEPFILES): Ditto.
* config/s390/s390.mh (NATDEPFILES): Ditto.
* config/sparc/fbsd.mh (NATDEPFILES): Ditto.
* config/sparc/linux.mh (NATDEPFILES): Ditto.
* config/sparc/linux64.mh (NATDEPFILES): Ditto.
* config/sparc/sol2.mh (NATDEPFILES): Ditto.
* config/xtensa/linux.mh (NATDEPFILES): Ditto.
* target.c (dummy_find_memory_regions): Change output.
(dummy_make_corefile_notes): Ditto.
---
Makefile.in | 4 ++--
config/alpha/alpha-linux.mh | 2 +-
config/alpha/fbsd.mh | 2 +-
config/arm/linux.mh | 2 +-
config/i386/fbsd.mh | 2 +-
config/i386/fbsd64.mh | 2 +-
config/i386/i386sol2.mh | 2 +-
config/i386/linux.mh | 2 +-
config/i386/linux64.mh | 2 +-
config/i386/sol2-64.mh | 2 +-
config/ia64/linux.mh | 2 +-
config/m32r/linux.mh | 2 +-
config/m68k/linux.mh | 2 +-
config/mips/linux.mh | 2 +-
config/pa/linux.mh | 2 +-
config/powerpc/linux.mh | 2 +-
config/powerpc/ppc64-linux.mh | 2 +-
config/s390/s390.mh | 2 +-
config/sparc/fbsd.mh | 2 +-
config/sparc/linux.mh | 2 +-
config/sparc/linux64.mh | 2 +-
config/sparc/sol2.mh | 2 +-
config/xtensa/linux.mh | 2 +-
target.c | 14 ++++++++------
24 files changed, 32 insertions(+), 30 deletions(-)
--- a/Makefile.in
+++ b/Makefile.in
@@ -681,7 +681,7 @@ SFILES = ada-exp.y ada-lang.c ada-typepr
wrapper.c \
xml-tdesc.c xml-support.c \
inferior.c gdb_usleep.c \
- record.c \
+ record.c gcore.c\
jit.c \
xml-syscall.c \
@@ -834,7 +834,7 @@ COMMON_OBS = $(DEPFILES) $(CONFIG_OBS) $
solib.o solib-null.o \
prologue-value.o memory-map.o xml-support.o xml-syscall.o \
target-descriptions.o target-memory.o xml-tdesc.o xml-builtin.o \
- inferior.o osdata.o gdb_usleep.o record.o \
+ inferior.o osdata.o gdb_usleep.o record.o gcore.o \
jit.o progspace.o
# Definitions for the syscall's XML files and dir
--- a/config/alpha/alpha-linux.mh
+++ b/config/alpha/alpha-linux.mh
@@ -1,7 +1,7 @@
# Host: Little-endian Alpha running Linux
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o corelow.o alpha-linux-nat.o \
- fork-child.o proc-service.o linux-thread-db.o gcore.o \
+ fork-child.o proc-service.o linux-thread-db.o \
linux-nat.o linux-fork.o
# The dynamically loaded libthread_db needs access to symbols in the
--- a/config/alpha/fbsd.mh
+++ b/config/alpha/fbsd.mh
@@ -1,6 +1,6 @@
# Host: FreeBSD/alpha
NATDEPFILES= fork-child.o inf-ptrace.o \
fbsd-nat.o alphabsd-nat.o bsd-kvm.o \
- gcore.o corelow.o core-regset.o
+ corelow.o core-regset.o
LOADLIBES= -lkvm
--- a/config/arm/linux.mh
+++ b/config/arm/linux.mh
@@ -1,7 +1,7 @@
# Host: ARM based machine running GNU/Linux
NAT_FILE= config/nm-linux.h
-NATDEPFILES= inf-ptrace.o fork-child.o arm-linux-nat.o gcore.o \
+NATDEPFILES= inf-ptrace.o fork-child.o arm-linux-nat.o \
proc-service.o linux-thread-db.o linux-nat.o linux-fork.o
LOADLIBES= -ldl -rdynamic
--- a/config/i386/fbsd.mh
+++ b/config/i386/fbsd.mh
@@ -1,7 +1,7 @@
# Host: FreeBSD/i386
NATDEPFILES= fork-child.o inf-ptrace.o \
fbsd-nat.o i386-nat.o i386bsd-nat.o i386fbsd-nat.o \
- gcore.o bsd-kvm.o
+ bsd-kvm.o
NAT_FILE= nm-fbsd.h
LOADLIBES= -lkvm
--- a/config/i386/fbsd64.mh
+++ b/config/i386/fbsd64.mh
@@ -1,6 +1,6 @@
# Host: FreeBSD/amd64
NATDEPFILES= fork-child.o inf-ptrace.o \
fbsd-nat.o amd64-nat.o amd64bsd-nat.o amd64fbsd-nat.o \
- gcore.o bsd-kvm.o
+ bsd-kvm.o
LOADLIBES= -lkvm
--- a/config/i386/i386sol2.mh
+++ b/config/i386/i386sol2.mh
@@ -1,4 +1,4 @@
# Host: Solaris x86
NATDEPFILES= fork-child.o i386v4-nat.o i386-sol2-nat.o \
- procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o gcore.o
+ procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o
NAT_FILE= nm-i386sol2.h
--- a/config/i386/linux.mh
+++ b/config/i386/linux.mh
@@ -3,7 +3,7 @@
NAT_FILE= nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o \
i386-nat.o i386-linux-nat.o \
- proc-service.o linux-thread-db.o gcore.o \
+ proc-service.o linux-thread-db.o \
linux-nat.o linux-fork.o
# The dynamically loaded libthread_db needs access to symbols in the
--- a/config/i386/linux64.mh
+++ b/config/i386/linux64.mh
@@ -1,7 +1,7 @@
# Host: GNU/Linux x86-64
NATDEPFILES= inf-ptrace.o fork-child.o \
i386-nat.o amd64-nat.o amd64-linux-nat.o linux-nat.o \
- proc-service.o linux-thread-db.o gcore.o linux-fork.o
+ proc-service.o linux-thread-db.o linux-fork.o
NAT_FILE= config/nm-linux.h
# The dynamically loaded libthread_db needs access to symbols in the
--- a/config/i386/sol2-64.mh
+++ b/config/i386/sol2-64.mh
@@ -1,4 +1,4 @@
# Host: Solaris x86_64
NATDEPFILES= fork-child.o amd64-nat.o i386v4-nat.o i386-sol2-nat.o \
- procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o gcore.o
+ procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o
NAT_FILE= nm-i386sol2.h
--- a/config/ia64/linux.mh
+++ b/config/ia64/linux.mh
@@ -1,7 +1,7 @@
# Host: Intel IA-64 running GNU/Linux
NAT_FILE= config/nm-linux.h
-NATDEPFILES= inf-ptrace.o fork-child.o corelow.o gcore.o \
+NATDEPFILES= inf-ptrace.o fork-child.o corelow.o \
core-regset.o ia64-linux-nat.o \
proc-service.o linux-thread-db.o linux-nat.o linux-fork.o
--- a/config/m32r/linux.mh
+++ b/config/m32r/linux.mh
@@ -2,7 +2,7 @@
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o corelow.o \
- m32r-linux-nat.o gcore.o proc-service.o linux-thread-db.o \
+ m32r-linux-nat.o proc-service.o linux-thread-db.o \
linux-nat.o linux-fork.o
LOADLIBES= -ldl -rdynamic
--- a/config/m68k/linux.mh
+++ b/config/m68k/linux.mh
@@ -2,7 +2,7 @@
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o \
- corelow.o m68klinux-nat.o gcore.o \
+ corelow.o m68klinux-nat.o \
proc-service.o linux-thread-db.o linux-nat.o linux-fork.o
# The dynamically loaded libthread_db needs access to symbols in the
--- a/config/mips/linux.mh
+++ b/config/mips/linux.mh
@@ -1,7 +1,7 @@
# Host: Linux/MIPS
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o mips-linux-nat.o \
- linux-thread-db.o proc-service.o gcore.o \
+ linux-thread-db.o proc-service.o \
linux-nat.o linux-fork.o
LOADLIBES = -ldl -rdynamic
--- a/config/pa/linux.mh
+++ b/config/pa/linux.mh
@@ -1,6 +1,6 @@
# Host: Hewlett-Packard PA-RISC machine, running Linux
NAT_FILE= config/nm-linux.h
-NATDEPFILES= inf-ptrace.o fork-child.o corelow.o gcore.o \
+NATDEPFILES= inf-ptrace.o fork-child.o corelow.o \
hppa-linux-nat.o proc-service.o linux-thread-db.o linux-nat.o \
linux-fork.o
--- a/config/powerpc/linux.mh
+++ b/config/powerpc/linux.mh
@@ -5,6 +5,6 @@ XM_CLIBS=
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o \
ppc-linux-nat.o proc-service.o linux-thread-db.o \
- gcore.o linux-nat.o linux-fork.o
+ linux-nat.o linux-fork.o
LOADLIBES = -ldl -rdynamic
--- a/config/powerpc/ppc64-linux.mh
+++ b/config/powerpc/ppc64-linux.mh
@@ -5,7 +5,7 @@ XM_CLIBS=
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o \
ppc-linux-nat.o proc-service.o linux-thread-db.o \
- gcore.o linux-nat.o linux-fork.o
+ linux-nat.o linux-fork.o
# The PowerPC has severe limitations on TOC size, and uses them even
# for non-PIC code. GDB overflows those tables when compiling with
--- a/config/s390/s390.mh
+++ b/config/s390/s390.mh
@@ -1,5 +1,5 @@
# Host: S390, running Linux
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o corelow.o s390-nat.o \
- gcore.o linux-thread-db.o proc-service.o linux-nat.o linux-fork.o
+ linux-thread-db.o proc-service.o linux-nat.o linux-fork.o
LOADLIBES = -ldl -rdynamic
--- a/config/sparc/fbsd.mh
+++ b/config/sparc/fbsd.mh
@@ -1,6 +1,6 @@
# Host: FreeBSD/sparc64
NATDEPFILES= fork-child.o inf-ptrace.o \
fbsd-nat.o sparc-nat.o sparc64-nat.o sparc64fbsd-nat.o \
- gcore.o bsd-kvm.o
+ bsd-kvm.o
LOADLIBES= -lkvm
--- a/config/sparc/linux.mh
+++ b/config/sparc/linux.mh
@@ -3,7 +3,7 @@ NAT_FILE= config/nm-linux.h
NATDEPFILES= sparc-nat.o sparc-linux-nat.o \
corelow.o core-regset.o fork-child.o inf-ptrace.o \
proc-service.o linux-thread-db.o \
- gcore.o linux-nat.o linux-fork.o
+ linux-nat.o linux-fork.o
# The dynamically loaded libthread_db needs access to symbols in the
# gdb executable.
--- a/config/sparc/linux64.mh
+++ b/config/sparc/linux64.mh
@@ -4,7 +4,7 @@ NATDEPFILES= sparc-nat.o sparc64-nat.o s
corelow.o core-regset.o \
fork-child.o inf-ptrace.o \
proc-service.o linux-thread-db.o \
- gcore.o linux-nat.o linux-fork.o
+ linux-nat.o linux-fork.o
# The dynamically loaded libthread_db needs access to symbols in the
# gdb executable.
--- a/config/sparc/sol2.mh
+++ b/config/sparc/sol2.mh
@@ -1,5 +1,5 @@
# Host: Solaris SPARC & UltraSPARC
NAT_FILE= nm-sol2.h
NATDEPFILES= sparc-sol2-nat.o \
- corelow.o core-regset.o fork-child.o gcore.o \
+ corelow.o core-regset.o fork-child.o \
procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o
--- a/config/xtensa/linux.mh
+++ b/config/xtensa/linux.mh
@@ -2,7 +2,7 @@
NAT_FILE= config/nm-linux.h
-NATDEPFILES= inf-ptrace.o fork-child.o xtensa-linux-nat.o gcore.o \
+NATDEPFILES= inf-ptrace.o fork-child.o xtensa-linux-nat.o \
linux-thread-db.o proc-service.o linux-nat.o linux-fork.o
LOADLIBES = -ldl -rdynamic
--- a/target.c
+++ b/target.c
@@ -2751,17 +2751,19 @@ dummy_pid_to_str (struct target_ops *ops
return normal_pid_to_str (ptid);
}
-/* Error-catcher for target_find_memory_regions */
-static int dummy_find_memory_regions (int (*ignore1) (), void *ignore2)
+/* Error-catcher for target_find_memory_regions. */
+static int
+dummy_find_memory_regions (int (*ignore1) (), void *ignore2)
{
- error (_("No target."));
+ error (_("Command not implemented for this target."));
return 0;
}
-/* Error-catcher for target_make_corefile_notes */
-static char * dummy_make_corefile_notes (bfd *ignore1, int *ignore2)
+/* Error-catcher for target_make_corefile_notes. */
+static char *
+dummy_make_corefile_notes (bfd *ignore1, int *ignore2)
{
- error (_("No target."));
+ error (_("Command not implemented for this target."));
return NULL;
}
On Mon, Oct 26, 2009 at 11:34, Michael Snyder <msnyder@vmware.com> wrote:
> Hui Zhu wrote:
>>
>> Hi Michael,
>>
>> I make a patch that move gcore.o to makefile.in.
>> It will make record save build OK in cygwin.
>
> Not quite good for targets that don't use "exec" (such as
> remote or sim). We'll expose an error message that isn't
> very informative.
>
> Could you add this diff to your patch?
>
>
> Index: target.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/target.c,v
> retrieving revision 1.229
> diff -u -p -r1.229 target.c
> --- target.c 20 Oct 2009 11:09:01 -0000 1.229
> +++ target.c 26 Oct 2009 03:39:36 -0000
> @@ -2751,17 +2751,19 @@ dummy_pid_to_str (struct target_ops *ops
> return normal_pid_to_str (ptid);
> }
>
> -/* Error-catcher for target_find_memory_regions */
> -static int dummy_find_memory_regions (int (*ignore1) (), void *ignore2)
> +/* Error-catcher for target_find_memory_regions. */
> +static int
> +dummy_find_memory_regions (int (*ignore1) (), void *ignore2)
> {
> - error (_("No target."));
> + error (_("Command not implemented for this target."));
> return 0;
> }
>
> -/* Error-catcher for target_make_corefile_notes */
> -static char * dummy_make_corefile_notes (bfd *ignore1, int *ignore2)
> +/* Error-catcher for target_make_corefile_notes. */
> +static char *
> +dummy_make_corefile_notes (bfd *ignore1, int *ignore2)
> {
> - error (_("No target."));
> + error (_("Command not implemented for this target."));
> return NULL;
> }
>
>
>
[-- Attachment #2: mv_gcore.txt --]
[-- Type: text/plain, Size: 9842 bytes --]
---
Makefile.in | 4 ++--
config/alpha/alpha-linux.mh | 2 +-
config/alpha/fbsd.mh | 2 +-
config/arm/linux.mh | 2 +-
config/i386/fbsd.mh | 2 +-
config/i386/fbsd64.mh | 2 +-
config/i386/i386sol2.mh | 2 +-
config/i386/linux.mh | 2 +-
config/i386/linux64.mh | 2 +-
config/i386/sol2-64.mh | 2 +-
config/ia64/linux.mh | 2 +-
config/m32r/linux.mh | 2 +-
config/m68k/linux.mh | 2 +-
config/mips/linux.mh | 2 +-
config/pa/linux.mh | 2 +-
config/powerpc/linux.mh | 2 +-
config/powerpc/ppc64-linux.mh | 2 +-
config/s390/s390.mh | 2 +-
config/sparc/fbsd.mh | 2 +-
config/sparc/linux.mh | 2 +-
config/sparc/linux64.mh | 2 +-
config/sparc/sol2.mh | 2 +-
config/xtensa/linux.mh | 2 +-
target.c | 14 ++++++++------
24 files changed, 32 insertions(+), 30 deletions(-)
--- a/Makefile.in
+++ b/Makefile.in
@@ -681,7 +681,7 @@ SFILES = ada-exp.y ada-lang.c ada-typepr
wrapper.c \
xml-tdesc.c xml-support.c \
inferior.c gdb_usleep.c \
- record.c \
+ record.c gcore.c\
jit.c \
xml-syscall.c \
@@ -834,7 +834,7 @@ COMMON_OBS = $(DEPFILES) $(CONFIG_OBS) $
solib.o solib-null.o \
prologue-value.o memory-map.o xml-support.o xml-syscall.o \
target-descriptions.o target-memory.o xml-tdesc.o xml-builtin.o \
- inferior.o osdata.o gdb_usleep.o record.o \
+ inferior.o osdata.o gdb_usleep.o record.o gcore.o \
jit.o progspace.o
# Definitions for the syscall's XML files and dir
--- a/config/alpha/alpha-linux.mh
+++ b/config/alpha/alpha-linux.mh
@@ -1,7 +1,7 @@
# Host: Little-endian Alpha running Linux
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o corelow.o alpha-linux-nat.o \
- fork-child.o proc-service.o linux-thread-db.o gcore.o \
+ fork-child.o proc-service.o linux-thread-db.o \
linux-nat.o linux-fork.o
# The dynamically loaded libthread_db needs access to symbols in the
--- a/config/alpha/fbsd.mh
+++ b/config/alpha/fbsd.mh
@@ -1,6 +1,6 @@
# Host: FreeBSD/alpha
NATDEPFILES= fork-child.o inf-ptrace.o \
fbsd-nat.o alphabsd-nat.o bsd-kvm.o \
- gcore.o corelow.o core-regset.o
+ corelow.o core-regset.o
LOADLIBES= -lkvm
--- a/config/arm/linux.mh
+++ b/config/arm/linux.mh
@@ -1,7 +1,7 @@
# Host: ARM based machine running GNU/Linux
NAT_FILE= config/nm-linux.h
-NATDEPFILES= inf-ptrace.o fork-child.o arm-linux-nat.o gcore.o \
+NATDEPFILES= inf-ptrace.o fork-child.o arm-linux-nat.o \
proc-service.o linux-thread-db.o linux-nat.o linux-fork.o
LOADLIBES= -ldl -rdynamic
--- a/config/i386/fbsd.mh
+++ b/config/i386/fbsd.mh
@@ -1,7 +1,7 @@
# Host: FreeBSD/i386
NATDEPFILES= fork-child.o inf-ptrace.o \
fbsd-nat.o i386-nat.o i386bsd-nat.o i386fbsd-nat.o \
- gcore.o bsd-kvm.o
+ bsd-kvm.o
NAT_FILE= nm-fbsd.h
LOADLIBES= -lkvm
--- a/config/i386/fbsd64.mh
+++ b/config/i386/fbsd64.mh
@@ -1,6 +1,6 @@
# Host: FreeBSD/amd64
NATDEPFILES= fork-child.o inf-ptrace.o \
fbsd-nat.o amd64-nat.o amd64bsd-nat.o amd64fbsd-nat.o \
- gcore.o bsd-kvm.o
+ bsd-kvm.o
LOADLIBES= -lkvm
--- a/config/i386/i386sol2.mh
+++ b/config/i386/i386sol2.mh
@@ -1,4 +1,4 @@
# Host: Solaris x86
NATDEPFILES= fork-child.o i386v4-nat.o i386-sol2-nat.o \
- procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o gcore.o
+ procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o
NAT_FILE= nm-i386sol2.h
--- a/config/i386/linux.mh
+++ b/config/i386/linux.mh
@@ -3,7 +3,7 @@
NAT_FILE= nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o \
i386-nat.o i386-linux-nat.o \
- proc-service.o linux-thread-db.o gcore.o \
+ proc-service.o linux-thread-db.o \
linux-nat.o linux-fork.o
# The dynamically loaded libthread_db needs access to symbols in the
--- a/config/i386/linux64.mh
+++ b/config/i386/linux64.mh
@@ -1,7 +1,7 @@
# Host: GNU/Linux x86-64
NATDEPFILES= inf-ptrace.o fork-child.o \
i386-nat.o amd64-nat.o amd64-linux-nat.o linux-nat.o \
- proc-service.o linux-thread-db.o gcore.o linux-fork.o
+ proc-service.o linux-thread-db.o linux-fork.o
NAT_FILE= config/nm-linux.h
# The dynamically loaded libthread_db needs access to symbols in the
--- a/config/i386/sol2-64.mh
+++ b/config/i386/sol2-64.mh
@@ -1,4 +1,4 @@
# Host: Solaris x86_64
NATDEPFILES= fork-child.o amd64-nat.o i386v4-nat.o i386-sol2-nat.o \
- procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o gcore.o
+ procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o
NAT_FILE= nm-i386sol2.h
--- a/config/ia64/linux.mh
+++ b/config/ia64/linux.mh
@@ -1,7 +1,7 @@
# Host: Intel IA-64 running GNU/Linux
NAT_FILE= config/nm-linux.h
-NATDEPFILES= inf-ptrace.o fork-child.o corelow.o gcore.o \
+NATDEPFILES= inf-ptrace.o fork-child.o corelow.o \
core-regset.o ia64-linux-nat.o \
proc-service.o linux-thread-db.o linux-nat.o linux-fork.o
--- a/config/m32r/linux.mh
+++ b/config/m32r/linux.mh
@@ -2,7 +2,7 @@
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o corelow.o \
- m32r-linux-nat.o gcore.o proc-service.o linux-thread-db.o \
+ m32r-linux-nat.o proc-service.o linux-thread-db.o \
linux-nat.o linux-fork.o
LOADLIBES= -ldl -rdynamic
--- a/config/m68k/linux.mh
+++ b/config/m68k/linux.mh
@@ -2,7 +2,7 @@
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o \
- corelow.o m68klinux-nat.o gcore.o \
+ corelow.o m68klinux-nat.o \
proc-service.o linux-thread-db.o linux-nat.o linux-fork.o
# The dynamically loaded libthread_db needs access to symbols in the
--- a/config/mips/linux.mh
+++ b/config/mips/linux.mh
@@ -1,7 +1,7 @@
# Host: Linux/MIPS
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o mips-linux-nat.o \
- linux-thread-db.o proc-service.o gcore.o \
+ linux-thread-db.o proc-service.o \
linux-nat.o linux-fork.o
LOADLIBES = -ldl -rdynamic
--- a/config/pa/linux.mh
+++ b/config/pa/linux.mh
@@ -1,6 +1,6 @@
# Host: Hewlett-Packard PA-RISC machine, running Linux
NAT_FILE= config/nm-linux.h
-NATDEPFILES= inf-ptrace.o fork-child.o corelow.o gcore.o \
+NATDEPFILES= inf-ptrace.o fork-child.o corelow.o \
hppa-linux-nat.o proc-service.o linux-thread-db.o linux-nat.o \
linux-fork.o
--- a/config/powerpc/linux.mh
+++ b/config/powerpc/linux.mh
@@ -5,6 +5,6 @@ XM_CLIBS=
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o \
ppc-linux-nat.o proc-service.o linux-thread-db.o \
- gcore.o linux-nat.o linux-fork.o
+ linux-nat.o linux-fork.o
LOADLIBES = -ldl -rdynamic
--- a/config/powerpc/ppc64-linux.mh
+++ b/config/powerpc/ppc64-linux.mh
@@ -5,7 +5,7 @@ XM_CLIBS=
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o \
ppc-linux-nat.o proc-service.o linux-thread-db.o \
- gcore.o linux-nat.o linux-fork.o
+ linux-nat.o linux-fork.o
# The PowerPC has severe limitations on TOC size, and uses them even
# for non-PIC code. GDB overflows those tables when compiling with
--- a/config/s390/s390.mh
+++ b/config/s390/s390.mh
@@ -1,5 +1,5 @@
# Host: S390, running Linux
NAT_FILE= config/nm-linux.h
NATDEPFILES= inf-ptrace.o fork-child.o corelow.o s390-nat.o \
- gcore.o linux-thread-db.o proc-service.o linux-nat.o linux-fork.o
+ linux-thread-db.o proc-service.o linux-nat.o linux-fork.o
LOADLIBES = -ldl -rdynamic
--- a/config/sparc/fbsd.mh
+++ b/config/sparc/fbsd.mh
@@ -1,6 +1,6 @@
# Host: FreeBSD/sparc64
NATDEPFILES= fork-child.o inf-ptrace.o \
fbsd-nat.o sparc-nat.o sparc64-nat.o sparc64fbsd-nat.o \
- gcore.o bsd-kvm.o
+ bsd-kvm.o
LOADLIBES= -lkvm
--- a/config/sparc/linux.mh
+++ b/config/sparc/linux.mh
@@ -3,7 +3,7 @@ NAT_FILE= config/nm-linux.h
NATDEPFILES= sparc-nat.o sparc-linux-nat.o \
corelow.o core-regset.o fork-child.o inf-ptrace.o \
proc-service.o linux-thread-db.o \
- gcore.o linux-nat.o linux-fork.o
+ linux-nat.o linux-fork.o
# The dynamically loaded libthread_db needs access to symbols in the
# gdb executable.
--- a/config/sparc/linux64.mh
+++ b/config/sparc/linux64.mh
@@ -4,7 +4,7 @@ NATDEPFILES= sparc-nat.o sparc64-nat.o s
corelow.o core-regset.o \
fork-child.o inf-ptrace.o \
proc-service.o linux-thread-db.o \
- gcore.o linux-nat.o linux-fork.o
+ linux-nat.o linux-fork.o
# The dynamically loaded libthread_db needs access to symbols in the
# gdb executable.
--- a/config/sparc/sol2.mh
+++ b/config/sparc/sol2.mh
@@ -1,5 +1,5 @@
# Host: Solaris SPARC & UltraSPARC
NAT_FILE= nm-sol2.h
NATDEPFILES= sparc-sol2-nat.o \
- corelow.o core-regset.o fork-child.o gcore.o \
+ corelow.o core-regset.o fork-child.o \
procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o
--- a/config/xtensa/linux.mh
+++ b/config/xtensa/linux.mh
@@ -2,7 +2,7 @@
NAT_FILE= config/nm-linux.h
-NATDEPFILES= inf-ptrace.o fork-child.o xtensa-linux-nat.o gcore.o \
+NATDEPFILES= inf-ptrace.o fork-child.o xtensa-linux-nat.o \
linux-thread-db.o proc-service.o linux-nat.o linux-fork.o
LOADLIBES = -ldl -rdynamic
--- a/target.c
+++ b/target.c
@@ -2751,17 +2751,19 @@ dummy_pid_to_str (struct target_ops *ops
return normal_pid_to_str (ptid);
}
-/* Error-catcher for target_find_memory_regions */
-static int dummy_find_memory_regions (int (*ignore1) (), void *ignore2)
+/* Error-catcher for target_find_memory_regions. */
+static int
+dummy_find_memory_regions (int (*ignore1) (), void *ignore2)
{
- error (_("No target."));
+ error (_("Command not implemented for this target."));
return 0;
}
-/* Error-catcher for target_make_corefile_notes */
-static char * dummy_make_corefile_notes (bfd *ignore1, int *ignore2)
+/* Error-catcher for target_make_corefile_notes. */
+static char *
+dummy_make_corefile_notes (bfd *ignore1, int *ignore2)
{
- error (_("No target."));
+ error (_("Command not implemented for this target."));
return NULL;
}
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h
2009-10-26 7:03 ` Hui Zhu
@ 2009-10-26 15:51 ` Michael Snyder
2009-10-26 17:20 ` Pedro Alves
0 siblings, 1 reply; 17+ messages in thread
From: Michael Snyder @ 2009-10-26 15:51 UTC (permalink / raw)
To: Hui Zhu; +Cc: Pedro Alves, Pierre Muller, gdb-patches
Hui Zhu wrote:
> OK. I make a new patch for it.
> Please help me review it.
It looks ok to me, but I have only linux systems on which to
evaluate it. I'd like a 2nd opinion. Pedro?
> 2009-10-26 Michael Snyder <msnyder@vmware.com>
> Hui Zhu <teawater@gmail.com>
>
> * Makefile.in (SFILES): Add gcore.c.
> (COMMON_OBS): Add gcore.o.
> * config/alpha/alpha-linux.mh (NATDEPFILES): Delete gcore.o.
> * config/alpha/fbsd.mh (NATDEPFILES): Ditto.
> * config/arm/linux.mh (NATDEPFILES): Ditto.
> * config/i386/fbsd.mh (NATDEPFILES): Ditto.
> * config/i386/fbsd64.mh (NATDEPFILES): Ditto.
> * config/i386/i386sol2.mh (NATDEPFILES): Ditto.
> * config/i386/linux.mh (NATDEPFILES): Ditto.
> * config/i386/linux64.mh (NATDEPFILES): Ditto.
> * config/i386/sol2-64.mh (NATDEPFILES): Ditto.
> * config/ia64/linux.mh (NATDEPFILES): Ditto.
> * config/m32r/linux.mh (NATDEPFILES): Ditto.
> * config/m68k/linux.mh (NATDEPFILES): Ditto.
> * config/mips/linux.mh (NATDEPFILES): Ditto.
> * config/pa/linux.mh (NATDEPFILES): Ditto.
> * config/powerpc/linux.mh (NATDEPFILES): Ditto.
> * config/powerpc/ppc64-linux.mh (NATDEPFILES): Ditto.
> * config/s390/s390.mh (NATDEPFILES): Ditto.
> * config/sparc/fbsd.mh (NATDEPFILES): Ditto.
> * config/sparc/linux.mh (NATDEPFILES): Ditto.
> * config/sparc/linux64.mh (NATDEPFILES): Ditto.
> * config/sparc/sol2.mh (NATDEPFILES): Ditto.
> * config/xtensa/linux.mh (NATDEPFILES): Ditto.
> * target.c (dummy_find_memory_regions): Change output.
> (dummy_make_corefile_notes): Ditto.
>
> ---
> Makefile.in | 4 ++--
> config/alpha/alpha-linux.mh | 2 +-
> config/alpha/fbsd.mh | 2 +-
> config/arm/linux.mh | 2 +-
> config/i386/fbsd.mh | 2 +-
> config/i386/fbsd64.mh | 2 +-
> config/i386/i386sol2.mh | 2 +-
> config/i386/linux.mh | 2 +-
> config/i386/linux64.mh | 2 +-
> config/i386/sol2-64.mh | 2 +-
> config/ia64/linux.mh | 2 +-
> config/m32r/linux.mh | 2 +-
> config/m68k/linux.mh | 2 +-
> config/mips/linux.mh | 2 +-
> config/pa/linux.mh | 2 +-
> config/powerpc/linux.mh | 2 +-
> config/powerpc/ppc64-linux.mh | 2 +-
> config/s390/s390.mh | 2 +-
> config/sparc/fbsd.mh | 2 +-
> config/sparc/linux.mh | 2 +-
> config/sparc/linux64.mh | 2 +-
> config/sparc/sol2.mh | 2 +-
> config/xtensa/linux.mh | 2 +-
> target.c | 14 ++++++++------
> 24 files changed, 32 insertions(+), 30 deletions(-)
>
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -681,7 +681,7 @@ SFILES = ada-exp.y ada-lang.c ada-typepr
> wrapper.c \
> xml-tdesc.c xml-support.c \
> inferior.c gdb_usleep.c \
> - record.c \
> + record.c gcore.c\
> jit.c \
> xml-syscall.c \
>
> @@ -834,7 +834,7 @@ COMMON_OBS = $(DEPFILES) $(CONFIG_OBS) $
> solib.o solib-null.o \
> prologue-value.o memory-map.o xml-support.o xml-syscall.o \
> target-descriptions.o target-memory.o xml-tdesc.o xml-builtin.o \
> - inferior.o osdata.o gdb_usleep.o record.o \
> + inferior.o osdata.o gdb_usleep.o record.o gcore.o \
> jit.o progspace.o
>
> # Definitions for the syscall's XML files and dir
> --- a/config/alpha/alpha-linux.mh
> +++ b/config/alpha/alpha-linux.mh
> @@ -1,7 +1,7 @@
> # Host: Little-endian Alpha running Linux
> NAT_FILE= config/nm-linux.h
> NATDEPFILES= inf-ptrace.o corelow.o alpha-linux-nat.o \
> - fork-child.o proc-service.o linux-thread-db.o gcore.o \
> + fork-child.o proc-service.o linux-thread-db.o \
> linux-nat.o linux-fork.o
>
> # The dynamically loaded libthread_db needs access to symbols in the
> --- a/config/alpha/fbsd.mh
> +++ b/config/alpha/fbsd.mh
> @@ -1,6 +1,6 @@
> # Host: FreeBSD/alpha
> NATDEPFILES= fork-child.o inf-ptrace.o \
> fbsd-nat.o alphabsd-nat.o bsd-kvm.o \
> - gcore.o corelow.o core-regset.o
> + corelow.o core-regset.o
>
> LOADLIBES= -lkvm
> --- a/config/arm/linux.mh
> +++ b/config/arm/linux.mh
> @@ -1,7 +1,7 @@
> # Host: ARM based machine running GNU/Linux
>
> NAT_FILE= config/nm-linux.h
> -NATDEPFILES= inf-ptrace.o fork-child.o arm-linux-nat.o gcore.o \
> +NATDEPFILES= inf-ptrace.o fork-child.o arm-linux-nat.o \
> proc-service.o linux-thread-db.o linux-nat.o linux-fork.o
>
> LOADLIBES= -ldl -rdynamic
> --- a/config/i386/fbsd.mh
> +++ b/config/i386/fbsd.mh
> @@ -1,7 +1,7 @@
> # Host: FreeBSD/i386
> NATDEPFILES= fork-child.o inf-ptrace.o \
> fbsd-nat.o i386-nat.o i386bsd-nat.o i386fbsd-nat.o \
> - gcore.o bsd-kvm.o
> + bsd-kvm.o
> NAT_FILE= nm-fbsd.h
>
> LOADLIBES= -lkvm
> --- a/config/i386/fbsd64.mh
> +++ b/config/i386/fbsd64.mh
> @@ -1,6 +1,6 @@
> # Host: FreeBSD/amd64
> NATDEPFILES= fork-child.o inf-ptrace.o \
> fbsd-nat.o amd64-nat.o amd64bsd-nat.o amd64fbsd-nat.o \
> - gcore.o bsd-kvm.o
> + bsd-kvm.o
>
> LOADLIBES= -lkvm
> --- a/config/i386/i386sol2.mh
> +++ b/config/i386/i386sol2.mh
> @@ -1,4 +1,4 @@
> # Host: Solaris x86
> NATDEPFILES= fork-child.o i386v4-nat.o i386-sol2-nat.o \
> - procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o gcore.o
> + procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o
> NAT_FILE= nm-i386sol2.h
> --- a/config/i386/linux.mh
> +++ b/config/i386/linux.mh
> @@ -3,7 +3,7 @@
> NAT_FILE= nm-linux.h
> NATDEPFILES= inf-ptrace.o fork-child.o \
> i386-nat.o i386-linux-nat.o \
> - proc-service.o linux-thread-db.o gcore.o \
> + proc-service.o linux-thread-db.o \
> linux-nat.o linux-fork.o
>
> # The dynamically loaded libthread_db needs access to symbols in the
> --- a/config/i386/linux64.mh
> +++ b/config/i386/linux64.mh
> @@ -1,7 +1,7 @@
> # Host: GNU/Linux x86-64
> NATDEPFILES= inf-ptrace.o fork-child.o \
> i386-nat.o amd64-nat.o amd64-linux-nat.o linux-nat.o \
> - proc-service.o linux-thread-db.o gcore.o linux-fork.o
> + proc-service.o linux-thread-db.o linux-fork.o
> NAT_FILE= config/nm-linux.h
>
> # The dynamically loaded libthread_db needs access to symbols in the
> --- a/config/i386/sol2-64.mh
> +++ b/config/i386/sol2-64.mh
> @@ -1,4 +1,4 @@
> # Host: Solaris x86_64
> NATDEPFILES= fork-child.o amd64-nat.o i386v4-nat.o i386-sol2-nat.o \
> - procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o gcore.o
> + procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o
> NAT_FILE= nm-i386sol2.h
> --- a/config/ia64/linux.mh
> +++ b/config/ia64/linux.mh
> @@ -1,7 +1,7 @@
> # Host: Intel IA-64 running GNU/Linux
>
> NAT_FILE= config/nm-linux.h
> -NATDEPFILES= inf-ptrace.o fork-child.o corelow.o gcore.o \
> +NATDEPFILES= inf-ptrace.o fork-child.o corelow.o \
> core-regset.o ia64-linux-nat.o \
> proc-service.o linux-thread-db.o linux-nat.o linux-fork.o
>
> --- a/config/m32r/linux.mh
> +++ b/config/m32r/linux.mh
> @@ -2,7 +2,7 @@
>
> NAT_FILE= config/nm-linux.h
> NATDEPFILES= inf-ptrace.o fork-child.o corelow.o \
> - m32r-linux-nat.o gcore.o proc-service.o linux-thread-db.o \
> + m32r-linux-nat.o proc-service.o linux-thread-db.o \
> linux-nat.o linux-fork.o
>
> LOADLIBES= -ldl -rdynamic
> --- a/config/m68k/linux.mh
> +++ b/config/m68k/linux.mh
> @@ -2,7 +2,7 @@
>
> NAT_FILE= config/nm-linux.h
> NATDEPFILES= inf-ptrace.o fork-child.o \
> - corelow.o m68klinux-nat.o gcore.o \
> + corelow.o m68klinux-nat.o \
> proc-service.o linux-thread-db.o linux-nat.o linux-fork.o
>
> # The dynamically loaded libthread_db needs access to symbols in the
> --- a/config/mips/linux.mh
> +++ b/config/mips/linux.mh
> @@ -1,7 +1,7 @@
> # Host: Linux/MIPS
> NAT_FILE= config/nm-linux.h
> NATDEPFILES= inf-ptrace.o fork-child.o mips-linux-nat.o \
> - linux-thread-db.o proc-service.o gcore.o \
> + linux-thread-db.o proc-service.o \
> linux-nat.o linux-fork.o
>
> LOADLIBES = -ldl -rdynamic
> --- a/config/pa/linux.mh
> +++ b/config/pa/linux.mh
> @@ -1,6 +1,6 @@
> # Host: Hewlett-Packard PA-RISC machine, running Linux
> NAT_FILE= config/nm-linux.h
> -NATDEPFILES= inf-ptrace.o fork-child.o corelow.o gcore.o \
> +NATDEPFILES= inf-ptrace.o fork-child.o corelow.o \
> hppa-linux-nat.o proc-service.o linux-thread-db.o linux-nat.o \
> linux-fork.o
>
> --- a/config/powerpc/linux.mh
> +++ b/config/powerpc/linux.mh
> @@ -5,6 +5,6 @@ XM_CLIBS=
> NAT_FILE= config/nm-linux.h
> NATDEPFILES= inf-ptrace.o fork-child.o \
> ppc-linux-nat.o proc-service.o linux-thread-db.o \
> - gcore.o linux-nat.o linux-fork.o
> + linux-nat.o linux-fork.o
>
> LOADLIBES = -ldl -rdynamic
> --- a/config/powerpc/ppc64-linux.mh
> +++ b/config/powerpc/ppc64-linux.mh
> @@ -5,7 +5,7 @@ XM_CLIBS=
> NAT_FILE= config/nm-linux.h
> NATDEPFILES= inf-ptrace.o fork-child.o \
> ppc-linux-nat.o proc-service.o linux-thread-db.o \
> - gcore.o linux-nat.o linux-fork.o
> + linux-nat.o linux-fork.o
>
> # The PowerPC has severe limitations on TOC size, and uses them even
> # for non-PIC code. GDB overflows those tables when compiling with
> --- a/config/s390/s390.mh
> +++ b/config/s390/s390.mh
> @@ -1,5 +1,5 @@
> # Host: S390, running Linux
> NAT_FILE= config/nm-linux.h
> NATDEPFILES= inf-ptrace.o fork-child.o corelow.o s390-nat.o \
> - gcore.o linux-thread-db.o proc-service.o linux-nat.o linux-fork.o
> + linux-thread-db.o proc-service.o linux-nat.o linux-fork.o
> LOADLIBES = -ldl -rdynamic
> --- a/config/sparc/fbsd.mh
> +++ b/config/sparc/fbsd.mh
> @@ -1,6 +1,6 @@
> # Host: FreeBSD/sparc64
> NATDEPFILES= fork-child.o inf-ptrace.o \
> fbsd-nat.o sparc-nat.o sparc64-nat.o sparc64fbsd-nat.o \
> - gcore.o bsd-kvm.o
> + bsd-kvm.o
>
> LOADLIBES= -lkvm
> --- a/config/sparc/linux.mh
> +++ b/config/sparc/linux.mh
> @@ -3,7 +3,7 @@ NAT_FILE= config/nm-linux.h
> NATDEPFILES= sparc-nat.o sparc-linux-nat.o \
> corelow.o core-regset.o fork-child.o inf-ptrace.o \
> proc-service.o linux-thread-db.o \
> - gcore.o linux-nat.o linux-fork.o
> + linux-nat.o linux-fork.o
>
> # The dynamically loaded libthread_db needs access to symbols in the
> # gdb executable.
> --- a/config/sparc/linux64.mh
> +++ b/config/sparc/linux64.mh
> @@ -4,7 +4,7 @@ NATDEPFILES= sparc-nat.o sparc64-nat.o s
> corelow.o core-regset.o \
> fork-child.o inf-ptrace.o \
> proc-service.o linux-thread-db.o \
> - gcore.o linux-nat.o linux-fork.o
> + linux-nat.o linux-fork.o
>
> # The dynamically loaded libthread_db needs access to symbols in the
> # gdb executable.
> --- a/config/sparc/sol2.mh
> +++ b/config/sparc/sol2.mh
> @@ -1,5 +1,5 @@
> # Host: Solaris SPARC & UltraSPARC
> NAT_FILE= nm-sol2.h
> NATDEPFILES= sparc-sol2-nat.o \
> - corelow.o core-regset.o fork-child.o gcore.o \
> + corelow.o core-regset.o fork-child.o \
> procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o
> --- a/config/xtensa/linux.mh
> +++ b/config/xtensa/linux.mh
> @@ -2,7 +2,7 @@
>
> NAT_FILE= config/nm-linux.h
>
> -NATDEPFILES= inf-ptrace.o fork-child.o xtensa-linux-nat.o gcore.o \
> +NATDEPFILES= inf-ptrace.o fork-child.o xtensa-linux-nat.o \
> linux-thread-db.o proc-service.o linux-nat.o linux-fork.o
>
> LOADLIBES = -ldl -rdynamic
> --- a/target.c
> +++ b/target.c
> @@ -2751,17 +2751,19 @@ dummy_pid_to_str (struct target_ops *ops
> return normal_pid_to_str (ptid);
> }
>
> -/* Error-catcher for target_find_memory_regions */
> -static int dummy_find_memory_regions (int (*ignore1) (), void *ignore2)
> +/* Error-catcher for target_find_memory_regions. */
> +static int
> +dummy_find_memory_regions (int (*ignore1) (), void *ignore2)
> {
> - error (_("No target."));
> + error (_("Command not implemented for this target."));
> return 0;
> }
>
> -/* Error-catcher for target_make_corefile_notes */
> -static char * dummy_make_corefile_notes (bfd *ignore1, int *ignore2)
> +/* Error-catcher for target_make_corefile_notes. */
> +static char *
> +dummy_make_corefile_notes (bfd *ignore1, int *ignore2)
> {
> - error (_("No target."));
> + error (_("Command not implemented for this target."));
> return NULL;
> }
>
> On Mon, Oct 26, 2009 at 11:34, Michael Snyder <msnyder@vmware.com> wrote:
>> Hui Zhu wrote:
>>> Hi Michael,
>>>
>>> I make a patch that move gcore.o to makefile.in.
>>> It will make record save build OK in cygwin.
>> Not quite good for targets that don't use "exec" (such as
>> remote or sim). We'll expose an error message that isn't
>> very informative.
>>
>> Could you add this diff to your patch?
>>
>>
>> Index: target.c
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/target.c,v
>> retrieving revision 1.229
>> diff -u -p -r1.229 target.c
>> --- target.c 20 Oct 2009 11:09:01 -0000 1.229
>> +++ target.c 26 Oct 2009 03:39:36 -0000
>> @@ -2751,17 +2751,19 @@ dummy_pid_to_str (struct target_ops *ops
>> return normal_pid_to_str (ptid);
>> }
>>
>> -/* Error-catcher for target_find_memory_regions */
>> -static int dummy_find_memory_regions (int (*ignore1) (), void *ignore2)
>> +/* Error-catcher for target_find_memory_regions. */
>> +static int
>> +dummy_find_memory_regions (int (*ignore1) (), void *ignore2)
>> {
>> - error (_("No target."));
>> + error (_("Command not implemented for this target."));
>> return 0;
>> }
>>
>> -/* Error-catcher for target_make_corefile_notes */
>> -static char * dummy_make_corefile_notes (bfd *ignore1, int *ignore2)
>> +/* Error-catcher for target_make_corefile_notes. */
>> +static char *
>> +dummy_make_corefile_notes (bfd *ignore1, int *ignore2)
>> {
>> - error (_("No target."));
>> + error (_("Command not implemented for this target."));
>> return NULL;
>> }
>>
>>
>>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h
2009-10-26 15:51 ` Michael Snyder
@ 2009-10-26 17:20 ` Pedro Alves
2009-10-26 18:33 ` Hui Zhu
0 siblings, 1 reply; 17+ messages in thread
From: Pedro Alves @ 2009-10-26 17:20 UTC (permalink / raw)
To: Michael Snyder; +Cc: Hui Zhu, Pierre Muller, gdb-patches
On Monday 26 October 2009 15:43:59, Michael Snyder wrote:
> Hui Zhu wrote:
> > OK. I make a new patch for it.
> > Please help me review it.
>
> It looks ok to me, but I have only linux systems on which to
> evaluate it. I'd like a 2nd opinion. Pedro?
Looks good to me. Thanks.
Tiny consistency issue:
> - record.c \
> + record.c gcore.c\
All other lines have a space before '\'. Write as:
> - record.c \
> + record.c gcore.c \
--
Pedro Alves
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h
2009-10-26 17:20 ` Pedro Alves
@ 2009-10-26 18:33 ` Hui Zhu
0 siblings, 0 replies; 17+ messages in thread
From: Hui Zhu @ 2009-10-26 18:33 UTC (permalink / raw)
To: Pedro Alves; +Cc: Michael Snyder, Pierre Muller, gdb-patches
On Tue, Oct 27, 2009 at 01:20, Pedro Alves <pedro@codesourcery.com> wrote:
> On Monday 26 October 2009 15:43:59, Michael Snyder wrote:
>> Hui Zhu wrote:
>> > OK. I make a new patch for it.
>> > Please help me review it.
>>
>> It looks ok to me, but I have only linux systems on which to
>> evaluate it. I'd like a 2nd opinion. Pedro?
>
> Looks good to me. Thanks.
>
> Tiny consistency issue:
>
>> - record.c \
>> + record.c gcore.c\
>
> All other lines have a space before '\'. Write as:
>
>> - record.c \
>> + record.c gcore.c \
>
> --
Fixed and checked in.
Thanks Pedro and Michael.
Hui
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2009-10-26 18:33 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20091022193607.13598.qmail@sourceware.org>
2009-10-23 7:49 ` Build failure: src/gdb ChangeLog record.c gcore.c gcore.h Pierre Muller
2009-10-23 15:38 ` Michael Snyder
2009-10-24 22:18 ` Michael Eager
2009-10-24 23:07 ` Michael Snyder
2009-10-25 0:26 ` Hui Zhu
2009-10-25 0:56 ` Hui Zhu
2009-10-25 1:26 ` Michael Snyder
2009-10-25 8:41 ` Hui Zhu
2009-10-25 13:53 ` Hui Zhu
2009-10-25 18:43 ` Michael Snyder
2009-10-25 18:42 ` Michael Snyder
2009-10-26 2:05 ` Hui Zhu
2009-10-26 3:41 ` Michael Snyder
2009-10-26 7:03 ` Hui Zhu
2009-10-26 15:51 ` Michael Snyder
2009-10-26 17:20 ` Pedro Alves
2009-10-26 18:33 ` Hui Zhu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox