From: Pedro Alves <pedro@codesourcery.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: Hui Zhu <teawater@gmail.com>,
Pierre Muller <muller@ics.u-strasbg.fr>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h
Date: Mon, 26 Oct 2009 17:20:00 -0000 [thread overview]
Message-ID: <200910261720.37279.pedro@codesourcery.com> (raw)
In-Reply-To: <4AE5C3BF.4010007@vmware.com>
On Monday 26 October 2009 15:43:59, Michael Snyder wrote:
> Hui Zhu wrote:
> > OK. I make a new patch for it.
> > Please help me review it.
>
> It looks ok to me, but I have only linux systems on which to
> evaluate it. I'd like a 2nd opinion. Pedro?
Looks good to me. Thanks.
Tiny consistency issue:
> - record.c \
> + record.c gcore.c\
All other lines have a space before '\'. Write as:
> - record.c \
> + record.c gcore.c \
--
Pedro Alves
next prev parent reply other threads:[~2009-10-26 17:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091022193607.13598.qmail@sourceware.org>
2009-10-23 7:49 ` Pierre Muller
2009-10-23 15:38 ` Michael Snyder
2009-10-24 22:18 ` Michael Eager
2009-10-24 23:07 ` Michael Snyder
2009-10-25 0:26 ` Hui Zhu
2009-10-25 0:56 ` Hui Zhu
2009-10-25 1:26 ` Michael Snyder
2009-10-25 8:41 ` Hui Zhu
2009-10-25 13:53 ` Hui Zhu
2009-10-25 18:43 ` Michael Snyder
2009-10-25 18:42 ` Michael Snyder
2009-10-26 2:05 ` Hui Zhu
2009-10-26 3:41 ` Michael Snyder
2009-10-26 7:03 ` Hui Zhu
2009-10-26 15:51 ` Michael Snyder
2009-10-26 17:20 ` Pedro Alves [this message]
2009-10-26 18:33 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910261720.37279.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
--cc=muller@ics.u-strasbg.fr \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox