Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h

[Michael Snyder <msnyder@vmware.com>]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

Hui Zhu wrote:
> Hi Michael,
> 
> I make a patch that move gcore.o to makefile.in.
> It will make record save build OK in cygwin.

Not quite good for targets that don't use "exec" (such as
remote or sim).  We'll expose an error message that isn't
very informative.

Could you add this diff to your patch?


[-- Attachment #2: gcore.txt --]
[-- Type: text/plain, Size: 1085 bytes --]

Index: target.c
===================================================================
RCS file: /cvs/src/src/gdb/target.c,v
retrieving revision 1.229
diff -u -p -r1.229 target.c
--- target.c	20 Oct 2009 11:09:01 -0000	1.229
+++ target.c	26 Oct 2009 03:39:36 -0000
@@ -2751,17 +2751,19 @@ dummy_pid_to_str (struct target_ops *ops
   return normal_pid_to_str (ptid);
 }
 
-/* Error-catcher for target_find_memory_regions */
-static int dummy_find_memory_regions (int (*ignore1) (), void *ignore2)
+/* Error-catcher for target_find_memory_regions.  */
+static int
+dummy_find_memory_regions (int (*ignore1) (), void *ignore2)
 {
-  error (_("No target."));
+  error (_("Command not implemented for this target."));
   return 0;
 }
 
-/* Error-catcher for target_make_corefile_notes */
-static char * dummy_make_corefile_notes (bfd *ignore1, int *ignore2)
+/* Error-catcher for target_make_corefile_notes.  */
+static char *
+dummy_make_corefile_notes (bfd *ignore1, int *ignore2)
 {
-  error (_("No target."));
+  error (_("Command not implemented for this target."));
   return NULL;
 }