Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h

[Hui Zhu <teawater@gmail.com>]

I try in cygwin with:
configure --disable-sid --disable-rda --disable-binutils --disable-gas
--disable-ld --disable-gprof --enable-targets=all --enable-64-bits-bfd
CFLAGS=-g
configure --disable-sid --disable-rda --disable-binutils --disable-gas
--disable-ld --disable-gprof

 Build is OK.

$ ./gdb
GNU gdb (GDB) 7.0.50.20091025-cvs
Copyright (C) 2009 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "i686-pc-cygwin".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Setting up the environment for debugging gdb.
No symbol table is loaded.  Use the "file" command.
Make breakpoint pending on future shared library load? (y or [n])
[answered N; input not from terminal]
No symbol table is loaded.  Use the "file" command.
Make breakpoint pending on future shared library load? (y or [n])
[answered N; input not from terminal]
/home/hzhu/gdb/bgdbcygwin/gdb/.gdbinit:8: Error in sourced command file:
No breakpoint number 0.
(gdb)

I think in gcore.o, there is not some host-special code.  Just some target hook.
I suggest mv gcore.o to makefile.in and add code to check return value
in record.o when call gcore function.
What do you think about it?

Thanks,
Hui


On Sun, Oct 25, 2009 at 08:25, Hui Zhu <teawater@gmail.com> wrote:
> I try to link gcore.o together with record.o in cygwin.  It looks OK.
> Maybe it's a way to handle this issue.
>
> Thanks,
> Hui
>
> On Sun, Oct 25, 2009 at 06:59, Michael Snyder <msnyder@vmware.com> wrote:
>> Michael Eager wrote:
>>>
>>> Michael Snyder wrote:
>>>>
>>>> Pierre Muller wrote:
>>>>>
>>>>>  This patch to record.c causes compilation failure on OpenSolaris
>>>>> 2009/06
>>>>>
>>>>>  The reason is that byteswap.h
>>>>> is not found.
>>>>>
>>>>> The strange thing is that apparently this
>>>>> is already known in gnulib,
>>>>> http://www.gnu.org/software/hello/manual/gnulib/byteswap_002eh.html#byteswap
>>>>> _002eh
>>>>> Is it that the gdb/gnulib is only a small part of the complete gnulib?
>>>>>
>>>>>  Could someone fix this please?
>>>>
>>>> Folks, really sorry about all the build failures.
>>>> Just getting up, give me a few minutes to have coffee.
>>>> I have an idea that I think will clear this up quickly.
>>>
>>> Looks like gcore.o is not linked in.
>>
>> Can't do it that way -- gcore.o is included (or not)
>> via the host makefile fragment in NATDEPFILES.
>>
>> It doesn't work for some hosts, that's why it isn't included for all.
>>
>>>
>>> Index: Makefile.in
>>> ===================================================================
>>> RCS file: /cvs/src/src/gdb/Makefile.in,v
>>> retrieving revision 1.1103
>>> diff -u -p -r1.1103 Makefile.in
>>> --- Makefile.in 21 Oct 2009 14:14:56 -0000      1.1103
>>> +++ Makefile.in 24 Oct 2009 22:16:44 -0000
>>> @@ -834,7 +834,7 @@ COMMON_OBS = $(DEPFILES) $(CONFIG_OBS) $
>>>         solib.o solib-null.o \
>>>         prologue-value.o memory-map.o xml-support.o xml-syscall.o \
>>>         target-descriptions.o target-memory.o xml-tdesc.o xml-builtin.o \
>>> -       inferior.o osdata.o gdb_usleep.o record.o \
>>> +       inferior.o osdata.o gdb_usleep.o record.o gcore.o \
>>>         jit.o progspace.o
>>>
>>>  # Definitions for the syscall's XML files and dir
>>>
>>>
>>
>>
>