From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14429 invoked by alias); 26 Oct 2009 03:41:56 -0000 Received: (qmail 14417 invoked by uid 22791); 26 Oct 2009 03:41:55 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Oct 2009 03:41:51 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 9BEC61307D; Sun, 25 Oct 2009 20:41:47 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by mailhost4.vmware.com (Postfix) with ESMTP id 91118C9C00; Sun, 25 Oct 2009 20:41:47 -0700 (PDT) Message-ID: <4AE518C6.2000701@vmware.com> Date: Mon, 26 Oct 2009 03:41:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Hui Zhu CC: Michael Eager , Pierre Muller , "msnyder@sourceware.org" , "gdb-patches@sourceware.org" Subject: Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h References: <20091022193607.13598.qmail@sourceware.org> <004e01ca53b5$5f9bc330$1ed34990$@u-strasbg.fr> <4AE1CC6E.1070604@vmware.com> <4AE37D44.10905@eagercon.com> <4AE386EF.60809@vmware.com> <4AE3A79A.6060600@vmware.com> <4AE49A75.9030007@vmware.com> In-Reply-To: Content-Type: multipart/mixed; boundary="------------080507070702060304030104" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00638.txt.bz2 This is a multi-part message in MIME format. --------------080507070702060304030104 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 306 Hui Zhu wrote: > Hi Michael, > > I make a patch that move gcore.o to makefile.in. > It will make record save build OK in cygwin. Not quite good for targets that don't use "exec" (such as remote or sim). We'll expose an error message that isn't very informative. Could you add this diff to your patch? --------------080507070702060304030104 Content-Type: text/plain; name="gcore.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="gcore.txt" Content-length: 1085 Index: target.c =================================================================== RCS file: /cvs/src/src/gdb/target.c,v retrieving revision 1.229 diff -u -p -r1.229 target.c --- target.c 20 Oct 2009 11:09:01 -0000 1.229 +++ target.c 26 Oct 2009 03:39:36 -0000 @@ -2751,17 +2751,19 @@ dummy_pid_to_str (struct target_ops *ops return normal_pid_to_str (ptid); } -/* Error-catcher for target_find_memory_regions */ -static int dummy_find_memory_regions (int (*ignore1) (), void *ignore2) +/* Error-catcher for target_find_memory_regions. */ +static int +dummy_find_memory_regions (int (*ignore1) (), void *ignore2) { - error (_("No target.")); + error (_("Command not implemented for this target.")); return 0; } -/* Error-catcher for target_make_corefile_notes */ -static char * dummy_make_corefile_notes (bfd *ignore1, int *ignore2) +/* Error-catcher for target_make_corefile_notes. */ +static char * +dummy_make_corefile_notes (bfd *ignore1, int *ignore2) { - error (_("No target.")); + error (_("Command not implemented for this target.")); return NULL; } --------------080507070702060304030104--