From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19999 invoked by alias); 26 Oct 2009 17:20:23 -0000 Received: (qmail 19988 invoked by uid 22791); 26 Oct 2009 17:20:23 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Oct 2009 17:20:18 +0000 Received: (qmail 18110 invoked from network); 26 Oct 2009 17:20:16 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 26 Oct 2009 17:20:16 -0000 From: Pedro Alves To: Michael Snyder Subject: Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h Date: Mon, 26 Oct 2009 17:20:00 -0000 User-Agent: KMail/1.9.10 Cc: Hui Zhu , Pierre Muller , "gdb-patches@sourceware.org" References: <20091022193607.13598.qmail@sourceware.org> <4AE5C3BF.4010007@vmware.com> In-Reply-To: <4AE5C3BF.4010007@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200910261720.37279.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00647.txt.bz2 On Monday 26 October 2009 15:43:59, Michael Snyder wrote: > Hui Zhu wrote: > > OK. I make a new patch for it. > > Please help me review it. > > It looks ok to me, but I have only linux systems on which to > evaluate it. I'd like a 2nd opinion. Pedro? Looks good to me. Thanks. Tiny consistency issue: > - record.c \ > + record.c gcore.c\ All other lines have a space before '\'. Write as: > - record.c \ > + record.c gcore.c \ -- Pedro Alves