From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17961 invoked by alias); 26 Oct 2009 18:33:44 -0000 Received: (qmail 17952 invoked by uid 22791); 26 Oct 2009 18:33:43 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-pw0-f49.google.com (HELO mail-pw0-f49.google.com) (209.85.160.49) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Oct 2009 18:33:37 +0000 Received: by pwj3 with SMTP id 3so3584510pwj.8 for ; Mon, 26 Oct 2009 11:33:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.248.38 with SMTP id v38mr1163455wfh.280.1256582016314; Mon, 26 Oct 2009 11:33:36 -0700 (PDT) In-Reply-To: <200910261720.37279.pedro@codesourcery.com> References: <20091022193607.13598.qmail@sourceware.org> <4AE5C3BF.4010007@vmware.com> <200910261720.37279.pedro@codesourcery.com> From: Hui Zhu Date: Mon, 26 Oct 2009 18:33:00 -0000 Message-ID: Subject: Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h To: Pedro Alves Cc: Michael Snyder , Pierre Muller , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00649.txt.bz2 On Tue, Oct 27, 2009 at 01:20, Pedro Alves wrote: > On Monday 26 October 2009 15:43:59, Michael Snyder wrote: >> Hui Zhu wrote: >> > OK. =A0I make a new patch for it. >> > Please help me review it. >> >> It looks ok to me, but I have only linux systems on which to >> evaluate it. =A0I'd like a 2nd opinion. =A0Pedro? > > Looks good to me. =A0Thanks. > > Tiny consistency issue: > >> - =A0 =A0 =A0 record.c \ >> + =A0 =A0 =A0 record.c gcore.c\ > > All other lines have a space before '\'. =A0Write as: > >> - =A0 =A0 =A0 record.c \ >> + =A0 =A0 =A0 record.c gcore.c \ > > -- Fixed and checked in. Thanks Pedro and Michael. Hui