From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20310 invoked by alias); 24 Oct 2009 23:07:10 -0000 Received: (qmail 20296 invoked by uid 22791); 24 Oct 2009 23:07:10 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,HK_OBFDOM X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 24 Oct 2009 23:07:04 +0000 Received: from jupiter.vmware.com (mailhost5.vmware.com [10.16.68.131]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id AD8C113627; Sat, 24 Oct 2009 16:07:03 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by jupiter.vmware.com (Postfix) with ESMTP id 9C57BDC058; Sat, 24 Oct 2009 16:07:03 -0700 (PDT) Message-ID: <4AE386EF.60809@vmware.com> Date: Sat, 24 Oct 2009 23:07:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Michael Eager CC: Pierre Muller , "msnyder@sourceware.org" , "gdb-patches@sourceware.org" Subject: Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h References: <20091022193607.13598.qmail@sourceware.org> <004e01ca53b5$5f9bc330$1ed34990$@u-strasbg.fr> <4AE1CC6E.1070604@vmware.com> <4AE37D44.10905@eagercon.com> In-Reply-To: <4AE37D44.10905@eagercon.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00614.txt.bz2 Michael Eager wrote: > Michael Snyder wrote: >> Pierre Muller wrote: >>> This patch to record.c causes compilation failure on OpenSolaris >>> 2009/06 >>> >>> The reason is that byteswap.h >>> is not found. >>> >>> The strange thing is that apparently this >>> is already known in gnulib, >>> http://www.gnu.org/software/hello/manual/gnulib/byteswap_002eh.html#byteswap >>> >>> _002eh >>> Is it that the gdb/gnulib is only a small part of the complete gnulib? >>> >>> Could someone fix this please? >> Folks, really sorry about all the build failures. >> Just getting up, give me a few minutes to have coffee. >> I have an idea that I think will clear this up quickly. > > Looks like gcore.o is not linked in. Can't do it that way -- gcore.o is included (or not) via the host makefile fragment in NATDEPFILES. It doesn't work for some hosts, that's why it isn't included for all. > > Index: Makefile.in > =================================================================== > RCS file: /cvs/src/src/gdb/Makefile.in,v > retrieving revision 1.1103 > diff -u -p -r1.1103 Makefile.in > --- Makefile.in 21 Oct 2009 14:14:56 -0000 1.1103 > +++ Makefile.in 24 Oct 2009 22:16:44 -0000 > @@ -834,7 +834,7 @@ COMMON_OBS = $(DEPFILES) $(CONFIG_OBS) $ > solib.o solib-null.o \ > prologue-value.o memory-map.o xml-support.o xml-syscall.o \ > target-descriptions.o target-memory.o xml-tdesc.o xml-builtin.o \ > - inferior.o osdata.o gdb_usleep.o record.o \ > + inferior.o osdata.o gdb_usleep.o record.o gcore.o \ > jit.o progspace.o > > # Definitions for the syscall's XML files and dir > >