* [PATCH] gdb/testsuite: Updated includes @ 2020-01-02 14:47 Lukas Durfina 2020-01-05 6:25 ` Joel Brobecker 0 siblings, 1 reply; 10+ messages in thread From: Lukas Durfina @ 2020-01-02 14:47 UTC (permalink / raw) To: gdb-patches Fixed compilation error with musl. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/gdb.base/fileio.c | 3 +-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index f7835f35f7..89d403897c 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2020-01-02 Lukas Durfina <ldurfina@tachyum.com> + + * gdb.base/fileio.c: Updated includes to be more generic. + 2019-12-29 Bernd Edlinger <bernd.edlinger@hotmail.de> * gdb.base/line65535.exp: New file. diff --git a/gdb/testsuite/gdb.base/fileio.c b/gdb/testsuite/gdb.base/fileio.c index 7f482a34d3..0f201518b7 100644 --- a/gdb/testsuite/gdb.base/fileio.c +++ b/gdb/testsuite/gdb.base/fileio.c @@ -1,13 +1,12 @@ #include <stdio.h> #include <stdlib.h> #include <string.h> -#include <sys/errno.h> #include <sys/types.h> -#include <sys/fcntl.h> #include <sys/stat.h> #include <sys/time.h> #include <errno.h> #include <sys/wait.h> +#include <fcntl.h> #include <unistd.h> #include <time.h> /* TESTS : -- 2.17.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gdb/testsuite: Updated includes 2020-01-02 14:47 [PATCH] gdb/testsuite: Updated includes Lukas Durfina @ 2020-01-05 6:25 ` Joel Brobecker 2020-01-07 13:48 ` Lukas Durfina 0 siblings, 1 reply; 10+ messages in thread From: Joel Brobecker @ 2020-01-05 6:25 UTC (permalink / raw) To: Lukas Durfina; +Cc: gdb-patches Hi Lukas, > Fixed compilation error with musl. Thanks for the patch! > --- > gdb/testsuite/ChangeLog | 4 ++++ > gdb/testsuite/gdb.base/fileio.c | 3 +-- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog > index f7835f35f7..89d403897c 100644 > --- a/gdb/testsuite/ChangeLog > +++ b/gdb/testsuite/ChangeLog > @@ -1,3 +1,7 @@ > +2020-01-02 Lukas Durfina <ldurfina@tachyum.com> > + > + * gdb.base/fileio.c: Updated includes to be more generic. For the revision log, I think it's import to be a bit more specific when explaining what changes you made and why. I see you removed the <sys/errno.h> #include without replacing it by a #include of <errno.h>. However, this file does make references to errno, so I think there is an oversight there. Also, I see you not only replace <sys/fcntl.h> by <fcntl.h>, but you also move its include further down. Any reason for that. Was it to move that include outside of the range of #include-s that include files in "sys"? For the ChangeLog, I think it is worth being a little more specific. For instance, I would have written the ChangeLog as follow: * gdb.base/fileio.c: Remove #include of <sys/errno.h>. Replace #include of <sys/fcntl.h> by <fcntl.h>. I'm usually the first in line to take shortcuts with ChangeLog files, but I try to be more informative when the cost of being so is so small... > + > 2019-12-29 Bernd Edlinger <bernd.edlinger@hotmail.de> > > * gdb.base/line65535.exp: New file. > diff --git a/gdb/testsuite/gdb.base/fileio.c b/gdb/testsuite/gdb.base/fileio.c > index 7f482a34d3..0f201518b7 100644 > --- a/gdb/testsuite/gdb.base/fileio.c > +++ b/gdb/testsuite/gdb.base/fileio.c > @@ -1,13 +1,12 @@ > #include <stdio.h> > #include <stdlib.h> > #include <string.h> > -#include <sys/errno.h> > #include <sys/types.h> > -#include <sys/fcntl.h> > #include <sys/stat.h> > #include <sys/time.h> > #include <errno.h> > #include <sys/wait.h> > +#include <fcntl.h> > #include <unistd.h> > #include <time.h> > /* TESTS : > -- > 2.17.1 -- Joel ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] gdb/testsuite: Updated includes 2020-01-05 6:25 ` Joel Brobecker @ 2020-01-07 13:48 ` Lukas Durfina 2020-01-07 17:55 ` Joel Brobecker 0 siblings, 1 reply; 10+ messages in thread From: Lukas Durfina @ 2020-01-07 13:48 UTC (permalink / raw) To: Joel Brobecker; +Cc: gdb-patches Hi Joel, Thanks for review. > -----Original Message----- > From: Joel Brobecker <brobecker@adacore.com> > Sent: Sunday, January 5, 2020 7:26 AM > To: Lukas Durfina <ldurfina@tachyum.com> > Cc: gdb-patches@sourceware.org > Subject: Re: [PATCH] gdb/testsuite: Updated includes > > Hi Lukas, > > > Fixed compilation error with musl. > > Thanks for the patch! > > > --- > > gdb/testsuite/ChangeLog | 4 ++++ > > gdb/testsuite/gdb.base/fileio.c | 3 +-- > > 2 files changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index > > f7835f35f7..89d403897c 100644 > > --- a/gdb/testsuite/ChangeLog > > +++ b/gdb/testsuite/ChangeLog > > @@ -1,3 +1,7 @@ > > +2020-01-02 Lukas Durfina <ldurfina@tachyum.com> > > + > > + * gdb.base/fileio.c: Updated includes to be more generic. > > For the revision log, I think it's import to be a bit more specific when > explaining what changes you made and why. > > I see you removed the <sys/errno.h> #include without replacing it by a > #include of <errno.h>. However, this file does make references to errno, so I > think there is an oversight there. There is already #include <errno.h> a few lines below, so I skipped it. > > Also, I see you not only replace <sys/fcntl.h> by <fcntl.h>, but you also move > its include further down. Any reason for that. > Was it to move that include outside of the range of #include-s that include > files in "sys"? Exactly. My intention was to move it out of <sys/...> includes. No other reason. > > For the ChangeLog, I think it is worth being a little more specific. > For instance, I would have written the ChangeLog as follow: > > * gdb.base/fileio.c: Remove #include of <sys/errno.h>. > Replace #include of <sys/fcntl.h> by <fcntl.h>. > > I'm usually the first in line to take shortcuts with ChangeLog files, but I try to > be more informative when the cost of being so is so small... I see your point. Is it fine to send the patch with updated Changelog? Lukas > > > + > > 2019-12-29 Bernd Edlinger <bernd.edlinger@hotmail.de> > > > > * gdb.base/line65535.exp: New file. > > diff --git a/gdb/testsuite/gdb.base/fileio.c > > b/gdb/testsuite/gdb.base/fileio.c index 7f482a34d3..0f201518b7 100644 > > --- a/gdb/testsuite/gdb.base/fileio.c > > +++ b/gdb/testsuite/gdb.base/fileio.c > > @@ -1,13 +1,12 @@ > > #include <stdio.h> > > #include <stdlib.h> > > #include <string.h> > > -#include <sys/errno.h> > > #include <sys/types.h> > > -#include <sys/fcntl.h> > > #include <sys/stat.h> > > #include <sys/time.h> > > #include <errno.h> > > #include <sys/wait.h> > > +#include <fcntl.h> > > #include <unistd.h> > > #include <time.h> > > /* TESTS : > > -- > > 2.17.1 > > -- > Joel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gdb/testsuite: Updated includes 2020-01-07 13:48 ` Lukas Durfina @ 2020-01-07 17:55 ` Joel Brobecker 2020-01-09 8:17 ` Lukas Durfina 0 siblings, 1 reply; 10+ messages in thread From: Joel Brobecker @ 2020-01-07 17:55 UTC (permalink / raw) To: Lukas Durfina; +Cc: gdb-patches > > I see you removed the <sys/errno.h> #include without replacing it by a > > #include of <errno.h>. However, this file does make references to errno, so I > > think there is an oversight there. > > There is already #include <errno.h> a few lines below, so I skipped it. Duh (head slap). <accent=french>but of course</accent>. Sorry. > > Also, I see you not only replace <sys/fcntl.h> by <fcntl.h>, but you also move > > its include further down. Any reason for that. > > Was it to move that include outside of the range of #include-s that include > > files in "sys"? > > Exactly. My intention was to move it out of <sys/...> includes. No > other reason. > > > > > For the ChangeLog, I think it is worth being a little more specific. > > For instance, I would have written the ChangeLog as follow: > > > > * gdb.base/fileio.c: Remove #include of <sys/errno.h>. > > Replace #include of <sys/fcntl.h> by <fcntl.h>. > > > > I'm usually the first in line to take shortcuts with ChangeLog > > files, but I try to be more informative when the cost of being so is > > so small... > > I see your point. Is it fine to send the patch with updated Changelog? That would be fine. On the other hand, if you want, you can push the patch with the ChangeLog above, since the change itself looks good to me, now. Thank you! > > Lukas > > > > > > + > > > 2019-12-29 Bernd Edlinger <bernd.edlinger@hotmail.de> > > > > > > * gdb.base/line65535.exp: New file. > > > diff --git a/gdb/testsuite/gdb.base/fileio.c > > > b/gdb/testsuite/gdb.base/fileio.c index 7f482a34d3..0f201518b7 100644 > > > --- a/gdb/testsuite/gdb.base/fileio.c > > > +++ b/gdb/testsuite/gdb.base/fileio.c > > > @@ -1,13 +1,12 @@ > > > #include <stdio.h> > > > #include <stdlib.h> > > > #include <string.h> > > > -#include <sys/errno.h> > > > #include <sys/types.h> > > > -#include <sys/fcntl.h> > > > #include <sys/stat.h> > > > #include <sys/time.h> > > > #include <errno.h> > > > #include <sys/wait.h> > > > +#include <fcntl.h> > > > #include <unistd.h> > > > #include <time.h> > > > /* TESTS : > > > -- > > > 2.17.1 > > > > -- > > Joel -- Joel ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] gdb/testsuite: Updated includes 2020-01-07 17:55 ` Joel Brobecker @ 2020-01-09 8:17 ` Lukas Durfina 2020-02-01 10:15 ` Joel Brobecker 0 siblings, 1 reply; 10+ messages in thread From: Lukas Durfina @ 2020-01-09 8:17 UTC (permalink / raw) To: gdb-patches Fixed compilation with musl. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.base/fileio.c | 3 +-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 3f243641b8..243721f6cb 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2020-01-09 Lukas Durfina <ldurfina@tachyum.com> + + * gdb.base/fileio.c: Remove #include of <sys/errno.h>. + Replace #include of <sys/fcntl.h> by <fcntl.h>. + 2020-01-06 Andrew Burgess <andrew.burgess@embecosm.com> * gdb.base/backtrace.c: New file. diff --git a/gdb/testsuite/gdb.base/fileio.c b/gdb/testsuite/gdb.base/fileio.c index 7f482a34d3..0f201518b7 100644 --- a/gdb/testsuite/gdb.base/fileio.c +++ b/gdb/testsuite/gdb.base/fileio.c @@ -1,13 +1,12 @@ #include <stdio.h> #include <stdlib.h> #include <string.h> -#include <sys/errno.h> #include <sys/types.h> -#include <sys/fcntl.h> #include <sys/stat.h> #include <sys/time.h> #include <errno.h> #include <sys/wait.h> +#include <fcntl.h> #include <unistd.h> #include <time.h> /* TESTS : -- 2.17.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gdb/testsuite: Updated includes 2020-01-09 8:17 ` Lukas Durfina @ 2020-02-01 10:15 ` Joel Brobecker 2020-02-03 10:00 ` Lukas Durfina 2020-02-03 10:10 ` [PATCH] [gdb/testsuite] Fix compilation error with musl in gdb/testsuite/gdb.base/fileio.c Lukas Durfina 0 siblings, 2 replies; 10+ messages in thread From: Joel Brobecker @ 2020-02-01 10:15 UTC (permalink / raw) To: Lukas Durfina; +Cc: gdb-patches Hello, I had assumed you pushed the patch, but in double-checking, it does not seem that way. Apologies for the confusion. The patch is OK to wait, but can you include the ChangeLog entry in the revision log? It's been pretty traditional in the GDB project to have the revision log of the commit be the same as what's sent by email. I'll take this opportunity to make some suggestions on how to make the revision log a little more useful to those who use "git log" (I do it a lot myself). Typically, it looks like this: | Fix compilation error with musl in gdb/testsuite/gdb.base/fileio.c | | <in most cases, a short description of the problem to better | understand the circumstances of the change should be provided here> | | gdb/ChangeLog: | | * gdb.base/fileio.c: Remove #include of <sys/errno.h>. | Replace #include of <sys/fcntl.h> by <fcntl.h>. Thank you! On Thu, Jan 09, 2020 at 09:17:31AM +0100, Lukas Durfina wrote: > Fixed compilation with musl. > --- > gdb/testsuite/ChangeLog | 5 +++++ > gdb/testsuite/gdb.base/fileio.c | 3 +-- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog > index 3f243641b8..243721f6cb 100644 > --- a/gdb/testsuite/ChangeLog > +++ b/gdb/testsuite/ChangeLog > @@ -1,3 +1,8 @@ > +2020-01-09 Lukas Durfina <ldurfina@tachyum.com> > + > + * gdb.base/fileio.c: Remove #include of <sys/errno.h>. > + Replace #include of <sys/fcntl.h> by <fcntl.h>. > + > 2020-01-06 Andrew Burgess <andrew.burgess@embecosm.com> > > * gdb.base/backtrace.c: New file. > diff --git a/gdb/testsuite/gdb.base/fileio.c b/gdb/testsuite/gdb.base/fileio.c > index 7f482a34d3..0f201518b7 100644 > --- a/gdb/testsuite/gdb.base/fileio.c > +++ b/gdb/testsuite/gdb.base/fileio.c > @@ -1,13 +1,12 @@ > #include <stdio.h> > #include <stdlib.h> > #include <string.h> > -#include <sys/errno.h> > #include <sys/types.h> > -#include <sys/fcntl.h> > #include <sys/stat.h> > #include <sys/time.h> > #include <errno.h> > #include <sys/wait.h> > +#include <fcntl.h> > #include <unistd.h> > #include <time.h> > /* TESTS : > -- > 2.17.1 -- Joel ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] gdb/testsuite: Updated includes 2020-02-01 10:15 ` Joel Brobecker @ 2020-02-03 10:00 ` Lukas Durfina 2020-02-03 10:25 ` Joel Brobecker 2020-02-03 10:10 ` [PATCH] [gdb/testsuite] Fix compilation error with musl in gdb/testsuite/gdb.base/fileio.c Lukas Durfina 1 sibling, 1 reply; 10+ messages in thread From: Lukas Durfina @ 2020-02-03 10:00 UTC (permalink / raw) To: Joel Brobecker; +Cc: gdb-patches > > Hello, > > I had assumed you pushed the patch, but in double-checking, it does not > seem that way. Apologies for the confusion. Hi Joel, Sorry, I was not sure what you mean by pushing. I assume I cannot push directly to repo, so I sent a patch. Thanks for a hint. I am going to send an updated patch in the following email. Best regards, Lukas > > The patch is OK to wait, but can you include the ChangeLog entry in the > revision log? It's been pretty traditional in the GDB project to have the > revision log of the commit be the same as what's sent by email. I'll take this > opportunity to make some suggestions on how to make the revision log a > little more useful to those who use "git log" (I do it a lot myself). Typically, it > looks like this: > > | Fix compilation error with musl in gdb/testsuite/gdb.base/fileio.c > | > | <in most cases, a short description of the problem to better > | understand the circumstances of the change should be provided here> > | > | gdb/ChangeLog: > | > | * gdb.base/fileio.c: Remove #include of <sys/errno.h>. > | Replace #include of <sys/fcntl.h> by <fcntl.h>. > > Thank you! > > On Thu, Jan 09, 2020 at 09:17:31AM +0100, Lukas Durfina wrote: > > Fixed compilation with musl. > > --- > > gdb/testsuite/ChangeLog | 5 +++++ > > gdb/testsuite/gdb.base/fileio.c | 3 +-- > > 2 files changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index > > 3f243641b8..243721f6cb 100644 > > --- a/gdb/testsuite/ChangeLog > > +++ b/gdb/testsuite/ChangeLog > > @@ -1,3 +1,8 @@ > > +2020-01-09 Lukas Durfina <ldurfina@tachyum.com> > > + > > + * gdb.base/fileio.c: Remove #include of <sys/errno.h>. > > + Replace #include of <sys/fcntl.h> by <fcntl.h>. > > + > > 2020-01-06 Andrew Burgess <andrew.burgess@embecosm.com> > > > > * gdb.base/backtrace.c: New file. > > diff --git a/gdb/testsuite/gdb.base/fileio.c > > b/gdb/testsuite/gdb.base/fileio.c index 7f482a34d3..0f201518b7 100644 > > --- a/gdb/testsuite/gdb.base/fileio.c > > +++ b/gdb/testsuite/gdb.base/fileio.c > > @@ -1,13 +1,12 @@ > > #include <stdio.h> > > #include <stdlib.h> > > #include <string.h> > > -#include <sys/errno.h> > > #include <sys/types.h> > > -#include <sys/fcntl.h> > > #include <sys/stat.h> > > #include <sys/time.h> > > #include <errno.h> > > #include <sys/wait.h> > > +#include <fcntl.h> > > #include <unistd.h> > > #include <time.h> > > /* TESTS : > > -- > > 2.17.1 > > -- > Joel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] gdb/testsuite: Updated includes 2020-02-03 10:00 ` Lukas Durfina @ 2020-02-03 10:25 ` Joel Brobecker 0 siblings, 0 replies; 10+ messages in thread From: Joel Brobecker @ 2020-02-03 10:25 UTC (permalink / raw) To: Lukas Durfina; +Cc: gdb-patches > Sorry, I was not sure what you mean by pushing. > I assume I cannot push directly to repo, so I sent a patch. > Thanks for a hint. I am going to send an updated patch in the following email. I see. I had assumed that you have "Write After Approval" privileges, which gives you privileges to push after your patch has been reviewed by a maintainer and approved. The requirements for you to be given write privileges are that you have a GDB Copyright Assignment on file with the FSF and that you submit at least one good patch (this patch qualifies). For this patch, I will simply push it for you, once you send the updated version. Normally, we require that all patches are covered by a copyright assignment (mentioned above), but since your patch is small, we can include it under the "tiny change" rule. For the future, if you think you'll be sending further contributions to GDB, you should start the copyright assignment process. I can send you the initial paperwork if interested -- just let me know in private. Thanks -- Joel > > Best regards, > Lukas > > > > > The patch is OK to wait, but can you include the ChangeLog entry in the > > revision log? It's been pretty traditional in the GDB project to have the > > revision log of the commit be the same as what's sent by email. I'll take this > > opportunity to make some suggestions on how to make the revision log a > > little more useful to those who use "git log" (I do it a lot myself). Typically, it > > looks like this: > > > > | Fix compilation error with musl in gdb/testsuite/gdb.base/fileio.c > > | > > | <in most cases, a short description of the problem to better > > | understand the circumstances of the change should be provided here> > > | > > | gdb/ChangeLog: > > | > > | * gdb.base/fileio.c: Remove #include of <sys/errno.h>. > > | Replace #include of <sys/fcntl.h> by <fcntl.h>. > > > > Thank you! > > > > On Thu, Jan 09, 2020 at 09:17:31AM +0100, Lukas Durfina wrote: > > > Fixed compilation with musl. > > > --- > > > gdb/testsuite/ChangeLog | 5 +++++ > > > gdb/testsuite/gdb.base/fileio.c | 3 +-- > > > 2 files changed, 6 insertions(+), 2 deletions(-) > > > > > > diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index > > > 3f243641b8..243721f6cb 100644 > > > --- a/gdb/testsuite/ChangeLog > > > +++ b/gdb/testsuite/ChangeLog > > > @@ -1,3 +1,8 @@ > > > +2020-01-09 Lukas Durfina <ldurfina@tachyum.com> > > > + > > > + * gdb.base/fileio.c: Remove #include of <sys/errno.h>. > > > + Replace #include of <sys/fcntl.h> by <fcntl.h>. > > > + > > > 2020-01-06 Andrew Burgess <andrew.burgess@embecosm.com> > > > > > > * gdb.base/backtrace.c: New file. > > > diff --git a/gdb/testsuite/gdb.base/fileio.c > > > b/gdb/testsuite/gdb.base/fileio.c index 7f482a34d3..0f201518b7 100644 > > > --- a/gdb/testsuite/gdb.base/fileio.c > > > +++ b/gdb/testsuite/gdb.base/fileio.c > > > @@ -1,13 +1,12 @@ > > > #include <stdio.h> > > > #include <stdlib.h> > > > #include <string.h> > > > -#include <sys/errno.h> > > > #include <sys/types.h> > > > -#include <sys/fcntl.h> > > > #include <sys/stat.h> > > > #include <sys/time.h> > > > #include <errno.h> > > > #include <sys/wait.h> > > > +#include <fcntl.h> > > > #include <unistd.h> > > > #include <time.h> > > > /* TESTS : > > > -- > > > 2.17.1 > > > > -- > > Joel -- Joel ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] [gdb/testsuite] Fix compilation error with musl in gdb/testsuite/gdb.base/fileio.c 2020-02-01 10:15 ` Joel Brobecker 2020-02-03 10:00 ` Lukas Durfina @ 2020-02-03 10:10 ` Lukas Durfina 2020-02-03 10:37 ` Joel Brobecker 1 sibling, 1 reply; 10+ messages in thread From: Lukas Durfina @ 2020-02-03 10:10 UTC (permalink / raw) To: gdb-patches Musl is giving warnings about these includes in this way: warning: #warning redirecting incorrect #include <sys/errno.h> to <errno.h> warning: #warning redirecting incorrect #include <sys/fcntl.h> to <fcntl.h> gdb/testsuite/Changelog: * gdb.base/fileio.c: Remove #include of <sys/errno.h>. Replace #include of <sys/fcntl.h> by <fcntl.h>. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.base/fileio.c | 3 +-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index b5ba5ba59d..9fd6cea172 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2020-02-03 Lukas Durfina <ldurfina@tachyum.com> + + * gdb.base/fileio.c: Remove #include of <sys/errno.h>. + Replace #include of <sys/fcntl.h> by <fcntl.h>. + 2020-02-01 Tom de Vries <tdevries@suse.de> * gdb.server/server-kill-python.exp: Fix $gdb_tst_name typo. diff --git a/gdb/testsuite/gdb.base/fileio.c b/gdb/testsuite/gdb.base/fileio.c index 7f482a34d3..0f201518b7 100644 --- a/gdb/testsuite/gdb.base/fileio.c +++ b/gdb/testsuite/gdb.base/fileio.c @@ -1,13 +1,12 @@ #include <stdio.h> #include <stdlib.h> #include <string.h> -#include <sys/errno.h> #include <sys/types.h> -#include <sys/fcntl.h> #include <sys/stat.h> #include <sys/time.h> #include <errno.h> #include <sys/wait.h> +#include <fcntl.h> #include <unistd.h> #include <time.h> /* TESTS : -- 2.17.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] [gdb/testsuite] Fix compilation error with musl in gdb/testsuite/gdb.base/fileio.c 2020-02-03 10:10 ` [PATCH] [gdb/testsuite] Fix compilation error with musl in gdb/testsuite/gdb.base/fileio.c Lukas Durfina @ 2020-02-03 10:37 ` Joel Brobecker 0 siblings, 0 replies; 10+ messages in thread From: Joel Brobecker @ 2020-02-03 10:37 UTC (permalink / raw) To: Lukas Durfina; +Cc: gdb-patches > Musl is giving warnings about these includes in this way: > warning: #warning redirecting incorrect #include <sys/errno.h> to <errno.h> > warning: #warning redirecting incorrect #include <sys/fcntl.h> to <fcntl.h> > > gdb/testsuite/Changelog: > > * gdb.base/fileio.c: Remove #include of <sys/errno.h>. > Replace #include of <sys/fcntl.h> by <fcntl.h>. Thank you; pushed to master, under the "tiny change" rule. > --- > gdb/testsuite/ChangeLog | 5 +++++ > gdb/testsuite/gdb.base/fileio.c | 3 +-- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog > index b5ba5ba59d..9fd6cea172 100644 > --- a/gdb/testsuite/ChangeLog > +++ b/gdb/testsuite/ChangeLog > @@ -1,3 +1,8 @@ > +2020-02-03 Lukas Durfina <ldurfina@tachyum.com> > + > + * gdb.base/fileio.c: Remove #include of <sys/errno.h>. > + Replace #include of <sys/fcntl.h> by <fcntl.h>. > + > 2020-02-01 Tom de Vries <tdevries@suse.de> > > * gdb.server/server-kill-python.exp: Fix $gdb_tst_name typo. > diff --git a/gdb/testsuite/gdb.base/fileio.c b/gdb/testsuite/gdb.base/fileio.c > index 7f482a34d3..0f201518b7 100644 > --- a/gdb/testsuite/gdb.base/fileio.c > +++ b/gdb/testsuite/gdb.base/fileio.c > @@ -1,13 +1,12 @@ > #include <stdio.h> > #include <stdlib.h> > #include <string.h> > -#include <sys/errno.h> > #include <sys/types.h> > -#include <sys/fcntl.h> > #include <sys/stat.h> > #include <sys/time.h> > #include <errno.h> > #include <sys/wait.h> > +#include <fcntl.h> > #include <unistd.h> > #include <time.h> > /* TESTS : > -- > 2.17.1 -- Joel ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-02-03 10:37 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-01-02 14:47 [PATCH] gdb/testsuite: Updated includes Lukas Durfina 2020-01-05 6:25 ` Joel Brobecker 2020-01-07 13:48 ` Lukas Durfina 2020-01-07 17:55 ` Joel Brobecker 2020-01-09 8:17 ` Lukas Durfina 2020-02-01 10:15 ` Joel Brobecker 2020-02-03 10:00 ` Lukas Durfina 2020-02-03 10:25 ` Joel Brobecker 2020-02-03 10:10 ` [PATCH] [gdb/testsuite] Fix compilation error with musl in gdb/testsuite/gdb.base/fileio.c Lukas Durfina 2020-02-03 10:37 ` Joel Brobecker
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox